summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorom <om@e03df62e-2008-0410-955e-edbf42e46eb7>2006-03-09 23:04:01 +0000
committerom <om@e03df62e-2008-0410-955e-edbf42e46eb7>2006-03-09 23:04:01 +0000
commit98ebe62da8fa6377863bc771a22a5d0cdce49348 (patch)
tree95e373f5bb0d1859e473e3364bf64d61244a04c0
parent0e8a357147848b2643f41eb2c2a1ee331fea0880 (diff)
More const references, this is nearly it apart from the module API..
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@3608 e03df62e-2008-0410-955e-edbf42e46eb7
-rw-r--r--include/base.h7
-rw-r--r--src/base.cpp6
2 files changed, 6 insertions, 7 deletions
diff --git a/include/base.h b/include/base.h
index 5f7ac0ffb..43a3101bd 100644
--- a/include/base.h
+++ b/include/base.h
@@ -67,7 +67,7 @@ public:
*
* @return Returns true on success, false if otherwise
*/
- bool Extend(std::string key, char* p);
+ bool Extend(const std::string &key, char* p);
/** Shrink an Extensible class.
*
@@ -78,7 +78,7 @@ public:
*
* @return Returns true on success.
*/
- bool Shrink(std::string key);
+ bool Shrink(const std::string &key);
/** Get an extension item.
*
@@ -86,7 +86,7 @@ public:
*
* @return If you provide a non-existent key name, the function returns NULL, otherwise a pointer to the item referenced by the key is returned.
*/
- char* GetExt(std::string key);
+ char* GetExt(const std::string &key);
/** Get a list of all extension items names.
*
@@ -160,4 +160,3 @@ class BoolSet
#endif
-
diff --git a/src/base.cpp b/src/base.cpp
index fc6e6583b..53ebda798 100644
--- a/src/base.cpp
+++ b/src/base.cpp
@@ -29,7 +29,7 @@ const int inverted_bitfields[] = {~1,~2,~4,~8,~16,~32,~64,~128};
extern time_t TIME;
-bool Extensible::Extend(std::string key, char* p)
+bool Extensible::Extend(const std::string &key, char* p)
{
// only add an item if it doesnt already exist
if (this->Extension_Items.find(key) == this->Extension_Items.end())
@@ -42,7 +42,7 @@ bool Extensible::Extend(std::string key, char* p)
return false;
}
-bool Extensible::Shrink(std::string key)
+bool Extensible::Shrink(const std::string &key)
{
// only attempt to remove a map item that exists
if (this->Extension_Items.find(key) != this->Extension_Items.end())
@@ -54,7 +54,7 @@ bool Extensible::Shrink(std::string key)
return false;
}
-char* Extensible::GetExt(std::string key)
+char* Extensible::GetExt(const std::string &key)
{
if (this->Extension_Items.find(key) != this->Extension_Items.end())
{