Remove strnewdup(), it is a good source of possible memory leaks

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11622 e03df62e-2008-0410-955e-edbf42e46eb7

2 files changed, 4 insertions, 18 deletions

diff --git a/include/configreader.h b/include/configreader.h
index e70a1478a..c8cd13081 100644
--- a/include/configreader.h
+++ b/include/configreader.h
@@ -46,19 +46,19 @@ struct operclass_data : public classbase
 {
 	/** Command list for the class
 	 */
-	char *commandlist;
+	std::string commandlist;
 
 	/** Channel mode list for the class
 	 */
-	char *cmodelist;
+	std::string cmodelist;
 
 	/** User mode list for the class
 	 */
-	char *umodelist;
+	std::string umodelist;
 
 	/** Priviledges given by this class
 	 */
-	char *privs;
+	std::string privs;
 };
 
 /** A Set of oper classes
diff --git a/include/inspstring.h b/include/inspstring.h
index 54bb1c8bd..4a7fa6271 100644
--- a/include/inspstring.h
+++ b/include/inspstring.h
@@ -39,19 +39,5 @@ CoreExport int charlcat(char* x,char y,int z);
  */
 CoreExport bool charremove(char* mp, char remove);
 
-/** strnewdup() is an implemenetation of strdup() which calls operator new
- * rather than malloc to allocate the new string, therefore allowing it to
- * be hooked into the C++ memory manager, and freed with operator delete.
- * This is required for windows, where we override operators new and delete
- * to allow for global allocation between modules and the core.
- */
-inline char * strnewdup(const char * s1)
-{
-	size_t len = strlen(s1) + 1;
-	char * p = new char[len];
-	memcpy(p, s1, len);
-	return p;
-}
-
 #endif