diff options
| author | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
|---|---|---|
| committer | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
| commit | 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f (patch) | |
| tree | 8a780298dbc1311024047a2587fddcd0beafd2ca /src/modules/m_cban.cpp | |
| parent | de87dec941cbf1eb6950a508876d654e2a3b63e4 (diff) | |
Change allocation of commands/modes
API change: Commands passed to AddCommand are no longer deleted automatically
This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'src/modules/m_cban.cpp')
| -rw-r--r-- | src/modules/m_cban.cpp | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/src/modules/m_cban.cpp b/src/modules/m_cban.cpp index 39e956272..4b0319d87 100644 --- a/src/modules/m_cban.cpp +++ b/src/modules/m_cban.cpp @@ -156,17 +156,15 @@ class CommandCBan : public Command class ModuleCBan : public Module { - CommandCBan* mycommand; - CBanFactory *f; + CommandCBan mycommand; + CBanFactory f; public: - ModuleCBan(InspIRCd* Me) : Module(Me) + ModuleCBan(InspIRCd* Me) : Module(Me), mycommand(Me), f(Me) { - f = new CBanFactory(ServerInstance); - ServerInstance->XLines->RegisterFactory(f); + ServerInstance->XLines->RegisterFactory(&f); - mycommand = new CommandCBan(Me); - ServerInstance->AddCommand(mycommand); + ServerInstance->AddCommand(&mycommand); Implementation eventlist[] = { I_OnUserPreJoin, I_OnSyncOtherMetaData, I_OnDecodeMetaData, I_OnStats }; ServerInstance->Modules->Attach(eventlist, this, 4); } @@ -174,7 +172,7 @@ class ModuleCBan : public Module virtual ~ModuleCBan() { ServerInstance->XLines->DelAll("CBAN"); - ServerInstance->XLines->UnregisterFactory(f); + ServerInstance->XLines->UnregisterFactory(&f); } virtual int OnStats(char symbol, User* user, string_list &out) |