Fix more undefined behavior caused by referencing the returned buffer by std::string::c_str() when the object is temporary

See 83c7cc45daf6fb1f8c36f15297a4657e45a34e88

1 files changed, 5 insertions, 3 deletions

diff --git a/src/modules/m_connectban.cpp b/src/modules/m_connectban.cpp
index 00452a8f2..aebe9a4ca 100644
--- a/src/modules/m_connectban.cpp
+++ b/src/modules/m_connectban.cpp
@@ -103,9 +103,11 @@ class ModuleConnectBan : public Module
 				else
 					delete zl;
 
-				ServerInstance->SNO->WriteGlobalSno('x',"Module m_connectban added Z:line on *@%s to expire on %s: Connect flooding", 
-					mask.str().c_str(), ServerInstance->TimeString(zl->expiry).c_str());
-				ServerInstance->SNO->WriteGlobalSno('a', "Connect flooding from IP range %s (%d)", mask.str().c_str(), threshold);
+				std::string maskstr = mask.str();
+				std::string timestr = ServerInstance->TimeString(zl->expiry);
+				ServerInstance->SNO->WriteGlobalSno('x',"Module m_connectban added Z:line on *@%s to expire on %s: Connect flooding",
+					maskstr.c_str(), timestr.c_str());
+				ServerInstance->SNO->WriteGlobalSno('a', "Connect flooding from IP range %s (%d)", maskstr.c_str(), threshold);
 				connects.erase(i);
 			}
 		}