Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 8 insertions, 12 deletions

diff --git a/src/modules/m_globalload.cpp b/src/modules/m_globalload.cpp
index 22035178c..a3e314846 100644
--- a/src/modules/m_globalload.cpp
+++ b/src/modules/m_globalload.cpp
@@ -125,21 +125,17 @@ class CommandGreloadmodule : public Command
 
 class ModuleGlobalLoad : public Module
 {
-	CommandGloadmodule *mycommand;
-	CommandGunloadmodule *mycommand2;
-	CommandGreloadmodule *mycommand3;
+	CommandGloadmodule cmd1;
+	CommandGunloadmodule cmd2;
+	CommandGreloadmodule cmd3;
 
  public:
-	ModuleGlobalLoad(InspIRCd* Me) : Module(Me)
+	ModuleGlobalLoad(InspIRCd* Me)
+		: Module(Me), cmd1(Me), cmd2(Me), cmd3(Me)
 	{
-
-		mycommand = new CommandGloadmodule(ServerInstance);
-		mycommand2 = new CommandGunloadmodule(ServerInstance);
-		mycommand3 = new CommandGreloadmodule(ServerInstance);
-		ServerInstance->AddCommand(mycommand);
-		ServerInstance->AddCommand(mycommand2);
-		ServerInstance->AddCommand(mycommand3);
-
+		ServerInstance->AddCommand(&cmd1);
+		ServerInstance->AddCommand(&cmd2);
+		ServerInstance->AddCommand(&cmd3);
 	}
 
 	virtual ~ModuleGlobalLoad()