diff options
| author | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
|---|---|---|
| committer | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
| commit | 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f (patch) | |
| tree | 8a780298dbc1311024047a2587fddcd0beafd2ca /src/modules/m_hideoper.cpp | |
| parent | de87dec941cbf1eb6950a508876d654e2a3b63e4 (diff) | |
Change allocation of commands/modes
API change: Commands passed to AddCommand are no longer deleted automatically
This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'src/modules/m_hideoper.cpp')
| -rw-r--r-- | src/modules/m_hideoper.cpp | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/src/modules/m_hideoper.cpp b/src/modules/m_hideoper.cpp index c08a42860..c204d51e9 100644 --- a/src/modules/m_hideoper.cpp +++ b/src/modules/m_hideoper.cpp @@ -47,15 +47,13 @@ class HideOper : public ModeHandler class ModuleHideOper : public Module { - - HideOper* hm; + HideOper hm; public: ModuleHideOper(InspIRCd* Me) - : Module(Me) + : Module(Me), hm(Me) { - hm = new HideOper(ServerInstance); - if (!ServerInstance->Modes->AddMode(hm)) + if (!ServerInstance->Modes->AddMode(&hm)) throw ModuleException("Could not add new modes!"); Implementation eventlist[] = { I_OnWhoisLine }; ServerInstance->Modules->Attach(eventlist, this, 1); @@ -64,8 +62,7 @@ class ModuleHideOper : public Module virtual ~ModuleHideOper() { - ServerInstance->Modes->DelMode(hm); - delete hm; + ServerInstance->Modes->DelMode(&hm); } virtual Version GetVersion() |