Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 5 insertions, 8 deletions

diff --git a/src/modules/m_nicklock.cpp b/src/modules/m_nicklock.cpp
index fe669fdcb..cc6691717 100644
--- a/src/modules/m_nicklock.cpp
+++ b/src/modules/m_nicklock.cpp
@@ -145,18 +145,15 @@ class CommandNickunlock : public Command
 
 class ModuleNickLock : public Module
 {
-	CommandNicklock*	cmd1;
-	CommandNickunlock*	cmd2;
+	CommandNicklock	cmd1;
+	CommandNickunlock	cmd2;
 	char* n;
  public:
 	ModuleNickLock(InspIRCd* Me)
-		: Module(Me)
+		: Module(Me), cmd1(Me), cmd2(Me)
 	{
-
-		cmd1 = new CommandNicklock(ServerInstance);
-		cmd2 = new CommandNickunlock(ServerInstance);
-		ServerInstance->AddCommand(cmd1);
-		ServerInstance->AddCommand(cmd2);
+		ServerInstance->AddCommand(&cmd1);
+		ServerInstance->AddCommand(&cmd2);
 		Implementation eventlist[] = { I_OnUserPreNick, I_OnUserQuit, I_OnCleanup };
 		ServerInstance->Modules->Attach(eventlist, this, 3);
 	}