diff options
| author | w00t <w00t@e03df62e-2008-0410-955e-edbf42e46eb7> | 2006-02-15 02:19:16 +0000 |
|---|---|---|
| committer | w00t <w00t@e03df62e-2008-0410-955e-edbf42e46eb7> | 2006-02-15 02:19:16 +0000 |
| commit | 56aea01ab7e6d4ab2ac904615a5d5c4a376bb2d6 (patch) | |
| tree | 6365aef8c6566fc392042cfd3feb9b57806aa298 /src/modules/m_park.cpp | |
| parent | 3cc3b745418494a654bedf38098c6aed54c2449b (diff) | |
- Made note of some potential improvements in m_part. Brain, please review when you get a chance.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@3203 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'src/modules/m_park.cpp')
| -rw-r--r-- | src/modules/m_park.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/modules/m_park.cpp b/src/modules/m_park.cpp index 5ac07839e..8c529ba97 100644 --- a/src/modules/m_park.cpp +++ b/src/modules/m_park.cpp @@ -67,6 +67,7 @@ class cmd_park : public command_t * We then disconnect the real user leaving a controlled ghost in their place :) */ int othersessions = 0; + /* XXX - why can't just use pinfo.size() like we do below, rather than iterating over the whole vector? -- w00t */ if (pinfo.size()) for (parkinfo::iterator j = pinfo.begin(); j != pinfo.end(); j++) if (j->host == std::string(user->host)) @@ -284,6 +285,7 @@ class ModulePark : public Module { // track nickchanges in our parked user list // (this isnt too efficient, i'll tidy it up some time) + /* XXX - perhaps extend the user record, or, that wouldn't work - perhaps use a map? -- w00t */ for (parkinfo::iterator j = pinfo.begin(); j != pinfo.end(); j++) { if (j->nick == std::string(user->nick)) @@ -322,6 +324,7 @@ class ModulePark : public Module } } + /* XXX - why is OnPrePrivmsg seperated here, I assume there is reason for the extra function call? --w00t */ virtual int OnUserPreMessage(userrec* user,void* dest,int target_type, std::string &text, char status) { if (target_type == TYPE_USER) |