Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 4 insertions, 9 deletions

diff --git a/src/modules/m_permchannels.cpp b/src/modules/m_permchannels.cpp
index ff269934e..08a48443e 100644
--- a/src/modules/m_permchannels.cpp
+++ b/src/modules/m_permchannels.cpp
@@ -77,17 +77,13 @@ class PermChannel : public ModeHandler
 
 class ModulePermanentChannels : public Module
 {
-	PermChannel *p;
+	PermChannel p;
 public:
 
-	ModulePermanentChannels(InspIRCd* Me) : Module(Me)
+	ModulePermanentChannels(InspIRCd* Me) : Module(Me), p(Me)
 	{
-		p = new PermChannel(ServerInstance);
-		if (!ServerInstance->Modes->AddMode(p))
-		{
-			delete p;
+		if (!ServerInstance->Modes->AddMode(&p))
 			throw ModuleException("Could not add new modes!");
-		}
 		Implementation eventlist[] = { I_OnChannelPreDelete };
 		ServerInstance->Modules->Attach(eventlist, this, 1);
 
@@ -96,8 +92,7 @@ public:
 
 	virtual ~ModulePermanentChannels()
 	{
-		ServerInstance->Modes->DelMode(p);
-		delete p;
+		ServerInstance->Modes->DelMode(&p);
 	}
 
 	virtual void OnRehash(User *user)