diff options
| author | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
|---|---|---|
| committer | danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7> | 2009-09-02 00:43:04 +0000 |
| commit | 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f (patch) | |
| tree | 8a780298dbc1311024047a2587fddcd0beafd2ca /src/modules/m_randquote.cpp | |
| parent | de87dec941cbf1eb6950a508876d654e2a3b63e4 (diff) | |
Change allocation of commands/modes
API change: Commands passed to AddCommand are no longer deleted automatically
This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7
Diffstat (limited to 'src/modules/m_randquote.cpp')
| -rw-r--r-- | src/modules/m_randquote.cpp | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/modules/m_randquote.cpp b/src/modules/m_randquote.cpp index 988d82a85..21cb2257d 100644 --- a/src/modules/m_randquote.cpp +++ b/src/modules/m_randquote.cpp @@ -55,11 +55,11 @@ class CommandRandquote : public Command class ModuleRandQuote : public Module { private: - CommandRandquote* mycommand; + CommandRandquote cmd; ConfigReader *conf; public: ModuleRandQuote(InspIRCd* Me) - : Module(Me) + : Module(Me), cmd(Me) { conf = new ConfigReader(ServerInstance); @@ -70,8 +70,6 @@ class ModuleRandQuote : public Module prefix = conf->ReadValue("randquote","prefix",0); suffix = conf->ReadValue("randquote","suffix",0); - mycommand = NULL; - if (q_file.empty()) { throw ModuleException("m_randquote: Quotefile not specified - Please check your config."); @@ -85,8 +83,7 @@ class ModuleRandQuote : public Module else { /* Hidden Command -- Mode clients assume /quote sends raw data to an IRCd >:D */ - mycommand = new CommandRandquote(ServerInstance); - ServerInstance->AddCommand(mycommand); + ServerInstance->AddCommand(&cmd); } Implementation eventlist[] = { I_OnUserConnect }; ServerInstance->Modules->Attach(eventlist, this, 1); @@ -106,8 +103,7 @@ class ModuleRandQuote : public Module virtual void OnUserConnect(User* user) { - if (mycommand) - mycommand->Handle(std::vector<std::string>(), user); + cmd.Handle(std::vector<std::string>(), user); } }; |