Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 5 insertions, 7 deletions

diff --git a/src/modules/m_remove.cpp b/src/modules/m_remove.cpp
index 6e5eaae46..c86565b5f 100644
--- a/src/modules/m_remove.cpp
+++ b/src/modules/m_remove.cpp
@@ -238,19 +238,17 @@ class CommandFpart : public Command, public RemoveBase
 
 class ModuleRemove : public Module
 {
-	CommandRemove* mycommand;
-	CommandFpart* mycommand2;
+	CommandRemove cmd1;
+	CommandFpart cmd2;
 	bool supportnokicks;
 
 
  public:
 	ModuleRemove(InspIRCd* Me)
-	: Module(Me)
+	: Module(Me), cmd1(Me, supportnokicks), cmd2(Me, supportnokicks)
 	{
-		mycommand = new CommandRemove(ServerInstance, supportnokicks);
-		mycommand2 = new CommandFpart(ServerInstance, supportnokicks);
-		ServerInstance->AddCommand(mycommand);
-		ServerInstance->AddCommand(mycommand2);
+		ServerInstance->AddCommand(&cmd1);
+		ServerInstance->AddCommand(&cmd2);
 		OnRehash(NULL);
 		Implementation eventlist[] = { I_On005Numeric, I_OnRehash };
 		ServerInstance->Modules->Attach(eventlist, this, 2);