Change allocation of commands/modes

API change: Commands passed to AddCommand are no longer deleted automatically

This removes lots of needless heap allocation and fixes a few memory leaks by
allocating commands and modes as part of the Module rather than creating them
separately in the module constructor.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7

1 files changed, 5 insertions, 7 deletions

diff --git a/src/modules/m_silence.cpp b/src/modules/m_silence.cpp
index 9b5f393e5..0786c4da4 100644
--- a/src/modules/m_silence.cpp
+++ b/src/modules/m_silence.cpp
@@ -266,19 +266,17 @@ class CommandSilence : public Command
 
 class ModuleSilence : public Module
 {
-	CommandSilence* cmdsilence;
-	CommandSVSSilence *cmdsvssilence;
 	unsigned int maxsilence;
+	CommandSilence cmdsilence;
+	CommandSVSSilence cmdsvssilence;
  public:
 
 	ModuleSilence(InspIRCd* Me)
-		: Module(Me), maxsilence(32)
+		: Module(Me), maxsilence(32), cmdsilence(Me, maxsilence), cmdsvssilence(Me)
 	{
 		OnRehash(NULL);
-		cmdsilence = new CommandSilence(ServerInstance,maxsilence);
-		cmdsvssilence = new CommandSVSSilence(ServerInstance);
-		ServerInstance->AddCommand(cmdsilence);
-		ServerInstance->AddCommand(cmdsvssilence);
+		ServerInstance->AddCommand(&cmdsilence);
+		ServerInstance->AddCommand(&cmdsvssilence);
 
 		Implementation eventlist[] = { I_OnRehash, I_OnBuildExemptList, I_OnUserQuit, I_On005Numeric, I_OnUserPreNotice, I_OnUserPreMessage, I_OnUserPreInvite };
 		ServerInstance->Modules->Attach(eventlist, this, 7);