From 5a8d1f3298512a37e0b5e628da9113ba9bc8ab63 Mon Sep 17 00:00:00 2001
From: danieldg <danieldg@e03df62e-2008-0410-955e-edbf42e46eb7>
Date: Tue, 23 Mar 2010 14:51:36 +0000
Subject: Fail config parse if duplicate keys are found

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@12658 e03df62e-2008-0410-955e-edbf42e46eb7
---
 src/configparser.cpp | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/configparser.cpp b/src/configparser.cpp
index 6b1b47e6d..2e84b1736 100644
--- a/src/configparser.cpp
+++ b/src/configparser.cpp
@@ -84,7 +84,7 @@ struct Parser
 		unget(ch);
 	}
 
-	bool kv(std::vector<KeyVal>* items)
+	bool kv(std::vector<KeyVal>* items, std::set<std::string>& seen)
 	{
 		std::string key;
 		nextword(key);
@@ -149,6 +149,10 @@ struct Parser
 			else
 				value.push_back(ch);
 		}
+
+		if (!seen.insert(key).second)
+			throw CoreException("Duplicate key '" + key + "' found");
+
 		items->push_back(KeyVal(key, value));
 		return true;
 	}
@@ -169,9 +173,10 @@ struct Parser
 			throw CoreException("Empty tag name");
 
 		std::vector<KeyVal>* items;
+		std::set<std::string> seen;
 		tag = ConfigTag::create(name, current.filename, current.line, items);
 
-		while (kv(items));
+		while (kv(items, seen));
 
 		if (name == "include")
 		{
-- 
cgit v1.2.3