From 7ba299a6c42a95fbbd913c2a5910b370cf9e2cc1 Mon Sep 17 00:00:00 2001 From: w00t Date: Thu, 17 Apr 2008 12:10:59 +0000 Subject: Remove completed XXX: override is now only checked locally, snotices are automatically broadcast globally, and all is well in the universe once more. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@9528 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_override.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/modules/m_override.cpp b/src/modules/m_override.cpp index 3fabd193b..a879515f2 100644 --- a/src/modules/m_override.cpp +++ b/src/modules/m_override.cpp @@ -230,13 +230,7 @@ class ModuleOverride : public Module virtual int OnUserPreJoin(User* user, Channel* chan, const char* cname, std::string &privs, const std::string &keygiven) { - /* - * XXX: this is potentially prone to desyncs (though unlikely). - * Really, now we have a protocol interface, we should only do - * this for *local* users and just broadcast out a SNONOTICE if - * an override is perpetrated. -- w00t - */ - if (IS_OPER(user)) + if (IS_LOCAL(user) && IS_OPER(user)) { if (chan) { -- cgit v1.2.3