From e8c617b7749a18b353290471491e23b0573ebd7c Mon Sep 17 00:00:00 2001 From: danieldg Date: Sat, 16 Jan 2010 19:45:16 +0000 Subject: Fix signdedness error in LoopCall git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@12268 e03df62e-2008-0410-955e-edbf42e46eb7 --- include/command_parse.h | 2 +- src/command_parse.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/command_parse.h b/include/command_parse.h index ac401ff67..2b03ec9bd 100644 --- a/include/command_parse.h +++ b/include/command_parse.h @@ -105,7 +105,7 @@ class CoreExport CommandParser * @return This function will return 1 when there are no more parameters to process. When this occurs, its * caller should return without doing anything, otherwise it should continue into its main section of code. */ - int LoopCall(User* user, Command* CommandObj, const std::vector& parameters, unsigned int splithere, unsigned int extra = -1, bool usemax = true); + int LoopCall(User* user, Command* CommandObj, const std::vector& parameters, unsigned int splithere, int extra = -1, bool usemax = true); /** Take a raw input buffer from a recvq, and process it on behalf of a user. * @param buffer The buffer line to process diff --git a/src/command_parse.cpp b/src/command_parse.cpp index 216981773..8d5bcbee4 100644 --- a/src/command_parse.cpp +++ b/src/command_parse.cpp @@ -55,12 +55,12 @@ int InspIRCd::PassCompare(Extensible* ex, const std::string &data, const std::st * The second version is much simpler and just has the one stream to read, and is used in NAMES, WHOIS, PRIVMSG etc. * Both will only parse until they reach ServerInstance->Config->MaxTargets number of targets, to stop abuse via spam. */ -int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vector& parameters, unsigned int splithere, unsigned int extra, bool usemax) +int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vector& parameters, unsigned int splithere, int extra, bool usemax) { if (splithere >= parameters.size()) return 0; - if (extra >= parameters.size()) + if (extra >= (signed)parameters.size()) extra = -1; /* First check if we have more than one item in the list, if we don't we return zero here and the handler -- cgit v1.2.3