From 2dfc384cde46ba63ed7c2f4420712596096123ca Mon Sep 17 00:00:00 2001 From: danieldg Date: Fri, 17 Apr 2009 13:54:53 +0000 Subject: Fix SetModeParam to use std::string and handle edge cases. Previously, changing the vaule of a mode could require 3 calls to SetMode and SetModeParam. This also fixes memory leaks caused by the strdup() not always being paired with a free(). git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11307 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modes/cmode_l.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/modes/cmode_l.cpp') diff --git a/src/modes/cmode_l.cpp b/src/modes/cmode_l.cpp index e87a524b2..3d37fc900 100644 --- a/src/modes/cmode_l.cpp +++ b/src/modes/cmode_l.cpp @@ -54,8 +54,7 @@ ModeAction ModeChannelLimit::OnModeChange(User*, User*, Channel* channel, std::s parameter = ConvToStr(limit); /* Set new limit */ - channel->SetModeParam('l', parameter.c_str(), true); - channel->modes[CM_LIMIT] = 1; + channel->SetMode('l', parameter); return MODEACTION_ALLOW; } @@ -71,9 +70,7 @@ ModeAction ModeChannelLimit::OnModeChange(User*, User*, Channel* channel, std::s } /* Removing old limit, no checks here */ - channel->SetModeParam('l', "", false); - channel->modes[CM_LIMIT] = 0; - + channel->SetMode('l', ""); return MODEACTION_ALLOW; } } -- cgit v1.2.3