From 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f Mon Sep 17 00:00:00 2001 From: danieldg Date: Wed, 2 Sep 2009 00:43:04 +0000 Subject: Change allocation of commands/modes API change: Commands passed to AddCommand are no longer deleted automatically This removes lots of needless heap allocation and fixes a few memory leaks by allocating commands and modes as part of the Module rather than creating them separately in the module constructor. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_allowinvite.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'src/modules/m_allowinvite.cpp') diff --git a/src/modules/m_allowinvite.cpp b/src/modules/m_allowinvite.cpp index 4805e1ac6..e177f8ee6 100644 --- a/src/modules/m_allowinvite.cpp +++ b/src/modules/m_allowinvite.cpp @@ -23,13 +23,12 @@ class AllowInvite : public SimpleChannelModeHandler class ModuleAllowInvite : public Module { - AllowInvite *ni; + AllowInvite ni; public: - ModuleAllowInvite(InspIRCd* Me) : Module(Me) + ModuleAllowInvite(InspIRCd* Me) : Module(Me), ni(Me) { - ni = new AllowInvite(ServerInstance); - if (!ServerInstance->Modes->AddMode(ni)) + if (!ServerInstance->Modes->AddMode(&ni)) throw ModuleException("Could not add new modes!"); Implementation eventlist[] = { I_OnUserPreInvite, I_On005Numeric }; ServerInstance->Modules->Attach(eventlist, this, 2); @@ -62,8 +61,7 @@ class ModuleAllowInvite : public Module virtual ~ModuleAllowInvite() { - ServerInstance->Modes->DelMode(ni); - delete ni; + ServerInstance->Modes->DelMode(&ni); } virtual Version GetVersion() -- cgit v1.2.3