From 2630a87bb13b089e6d0fdcff4bcd0f3a9612e52f Mon Sep 17 00:00:00 2001 From: danieldg Date: Wed, 2 Sep 2009 00:43:04 +0000 Subject: Change allocation of commands/modes API change: Commands passed to AddCommand are no longer deleted automatically This removes lots of needless heap allocation and fixes a few memory leaks by allocating commands and modes as part of the Module rather than creating them separately in the module constructor. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11592 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_botmode.cpp | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) (limited to 'src/modules/m_botmode.cpp') diff --git a/src/modules/m_botmode.cpp b/src/modules/m_botmode.cpp index 7e8993cb3..01bc46357 100644 --- a/src/modules/m_botmode.cpp +++ b/src/modules/m_botmode.cpp @@ -25,15 +25,12 @@ class BotMode : public SimpleUserModeHandler class ModuleBotMode : public Module { - - BotMode* bm; + BotMode bm; public: ModuleBotMode(InspIRCd* Me) - : Module(Me) + : Module(Me), bm(Me) { - - bm = new BotMode(ServerInstance); - if (!ServerInstance->Modes->AddMode(bm)) + if (!ServerInstance->Modes->AddMode(&bm)) throw ModuleException("Could not add new modes!"); Implementation eventlist[] = { I_OnWhois }; ServerInstance->Modules->Attach(eventlist, this, 1); @@ -42,8 +39,7 @@ class ModuleBotMode : public Module virtual ~ModuleBotMode() { - ServerInstance->Modes->DelMode(bm); - delete bm; + ServerInstance->Modes->DelMode(&bm); } virtual Version GetVersion() -- cgit v1.2.3