From 0023d21ce23812ad59aefc0b62aac37bd09d182e Mon Sep 17 00:00:00 2001
From: attilamolnar <attilamolnar@hush.com>
Date: Sun, 17 Jun 2012 18:37:06 +0200
Subject: m_cap Use an enum to specify cap event type instead of a string,
 assign CapEvent data in the constructor

---
 src/modules/m_cap.h | 27 +++++++++++++++++----------
 1 file changed, 17 insertions(+), 10 deletions(-)

(limited to 'src/modules/m_cap.h')

diff --git a/src/modules/m_cap.h b/src/modules/m_cap.h
index 604fdb0ef..9ce7f9501 100644
--- a/src/modules/m_cap.h
+++ b/src/modules/m_cap.h
@@ -21,18 +21,22 @@
 #ifndef M_CAP_H
 #define M_CAP_H
 
-#include <map>
-#include <string>
-
 class CapEvent : public Event
 {
  public:
-	irc::string type;
+	enum CapEventType
+	{
+		CAPEVENT_REQ,
+		CAPEVENT_LS,
+		CAPEVENT_LIST,
+		CAPEVENT_CLEAR
+	};
+
+	CapEventType type;
 	std::vector<std::string> wanted;
 	std::vector<std::string> ack;
 	User* user;
-	Module* creator;
-	CapEvent(Module* sender, const std::string& t) : Event(sender, t) {}
+	CapEvent(Module* sender, User* u, CapEventType capevtype) : Event(sender, "cap_request"), type(capevtype), user(u) {}
 };
 
 class GenericCap
@@ -47,8 +51,11 @@ class GenericCap
 
 	void HandleEvent(Event& ev)
 	{
+		if (ev.id != "cap_request")
+			return;
+
 		CapEvent *data = static_cast<CapEvent*>(&ev);
-		if (ev.id == "cap_req")
+		if (data->type == CapEvent::CAPEVENT_REQ)
 		{
 			std::vector<std::string>::iterator it;
 			if ((it = std::find(data->wanted.begin(), data->wanted.end(), cap)) != data->wanted.end())
@@ -59,16 +66,16 @@ class GenericCap
 				ext.set(data->user, 1);
 			}
 		}
-		else if (ev.id == "cap_ls")
+		else if (data->type == CapEvent::CAPEVENT_LS)
 		{
 			data->wanted.push_back(cap);
 		}
-		else if (ev.id == "cap_list")
+		else if (data->type == CapEvent::CAPEVENT_LIST)
 		{
 			if (ext.get(data->user))
 				data->wanted.push_back(cap);
 		}
-		else if (ev.id == "cap_clear")
+		else if (data->type == CapEvent::CAPEVENT_CLEAR)
 		{
 			data->ack.push_back("-" + cap);
 			ext.set(data->user, 0);
-- 
cgit v1.2.3


From ba55ac6a72aae178b14b49b121a5f3bd1a738917 Mon Sep 17 00:00:00 2001
From: attilamolnar <attilamolnar@hush.com>
Date: Sun, 17 Jun 2012 18:37:47 +0200
Subject: m_cap Allow clients to disable specific capabilities by prefixing
 them with a dash (-) to be compliant with the specification

---
 src/modules/m_cap.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

(limited to 'src/modules/m_cap.h')

diff --git a/src/modules/m_cap.h b/src/modules/m_cap.h
index 9ce7f9501..ce7e7f394 100644
--- a/src/modules/m_cap.h
+++ b/src/modules/m_cap.h
@@ -57,13 +57,19 @@ class GenericCap
 		CapEvent *data = static_cast<CapEvent*>(&ev);
 		if (data->type == CapEvent::CAPEVENT_REQ)
 		{
-			std::vector<std::string>::iterator it;
-			if ((it = std::find(data->wanted.begin(), data->wanted.end(), cap)) != data->wanted.end())
+			for (std::vector<std::string>::iterator it = data->wanted.begin(); it != data->wanted.end(); ++it)
 			{
-				// we can handle this, so ACK it, and remove it from the wanted list
-				data->ack.push_back(*it);
-				data->wanted.erase(it);
-				ext.set(data->user, 1);
+				if (it->empty())
+					continue;
+				bool enablecap = ((*it)[0] != '-');
+				if (((enablecap) && (*it == cap)) || (*it == "-" + cap))
+				{
+					// we can handle this, so ACK it, and remove it from the wanted list
+					data->ack.push_back(*it);
+					data->wanted.erase(it);
+					ext.set(data->user, enablecap ? 1 : 0);
+					break;
+				}
 			}
 		}
 		else if (data->type == CapEvent::CAPEVENT_LS)
-- 
cgit v1.2.3