From b2159a9e4f40fcbe755f8c0d2e6a7cbfcfd09f4f Mon Sep 17 00:00:00 2001 From: danieldg Date: Thu, 7 May 2009 14:51:10 +0000 Subject: Remove handshake timer on server sockets that die before completing handshake This fixes some very subtle and hard-to-trace bugs that are triggered when a file descriptor and memory address of an EventHandler* are reused after being deallocated. Impossible to trigger in valgrind; has been seen in live networks. git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@11369 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_spanningtree/handshaketimer.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/modules/m_spanningtree/handshaketimer.h') diff --git a/src/modules/m_spanningtree/handshaketimer.h b/src/modules/m_spanningtree/handshaketimer.h index 26379c8a6..0a60c78fc 100644 --- a/src/modules/m_spanningtree/handshaketimer.h +++ b/src/modules/m_spanningtree/handshaketimer.h @@ -31,6 +31,7 @@ class HandshakeTimer : public Timer int thefd; public: HandshakeTimer(InspIRCd* Inst, TreeSocket* s, Link* l, SpanningTreeUtilities* u, int delay); + ~HandshakeTimer(); virtual void Tick(time_t TIME); }; -- cgit v1.2.3