From 82fdc01e33aa5e5bfb1315e811d9465f85241248 Mon Sep 17 00:00:00 2001 From: brain Date: Sun, 21 Sep 2008 10:55:18 +0000 Subject: Fix the 'i/o error on connection (no error)' stuff, by displaying 'connected closed unexpectedly' when errno == 0. Also trigger failover whenever a connection times out in the new authentication timeout code (the connection isnt properly established so the failover should trigger) git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10575 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/modules/m_spanningtree/main.cpp | 11 ++++++++++- src/modules/m_spanningtree/treesocket1.cpp | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) (limited to 'src/modules/m_spanningtree') diff --git a/src/modules/m_spanningtree/main.cpp b/src/modules/m_spanningtree/main.cpp index 264ee1078..86d511a2a 100644 --- a/src/modules/m_spanningtree/main.cpp +++ b/src/modules/m_spanningtree/main.cpp @@ -335,6 +335,7 @@ void ModuleSpanningTree::AutoConnectServers(time_t curtime) void ModuleSpanningTree::DoConnectTimeout(time_t curtime) { + std::vector failovers; for (std::map >::iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); i++) { TreeSocket* s = i->first; @@ -344,8 +345,16 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime) ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %d seconds)",p.first.c_str(),p.second); ServerInstance->SE->DelFd(s); s->Close(); + Link* MyLink = Utils->FindLink(p.first); + if (MyLink) + failovers.push_back(MyLink); } - } + } + /* Trigger failover for each timed out socket */ + for (std::vector::const_iterator n = failovers.begin(); n != failovers.end(); ++n) + { + Utils->DoFailOver(*n); + } } int ModuleSpanningTree::HandleVersion(const std::vector& parameters, User* user) diff --git a/src/modules/m_spanningtree/treesocket1.cpp b/src/modules/m_spanningtree/treesocket1.cpp index 0687aa06b..a89bd2574 100644 --- a/src/modules/m_spanningtree/treesocket1.cpp +++ b/src/modules/m_spanningtree/treesocket1.cpp @@ -151,7 +151,7 @@ void TreeSocket::OnError(BufferedSocketError e) Utils->Creator->RemoteMessage(NULL,"Connection failed: Error binding socket to address or port (%s)", strerror(errno)); break; case I_ERR_WRITE: - Utils->Creator->RemoteMessage(NULL,"Connection failed: I/O error on connection (%s)", strerror(errno)); + Utils->Creator->RemoteMessage(NULL,"Connection failed: I/O error on connection (%s)", errno ? strerror(errno) : "Connection closed unexpectedly"); break; case I_ERR_NOMOREFDS: Utils->Creator->RemoteMessage(NULL,"Connection failed: Operating system is out of file descriptors!"); -- cgit v1.2.3