From d0dac3a2751e5b5edadf3befa8259f9902b9450b Mon Sep 17 00:00:00 2001 From: Peter Powell Date: Sun, 15 Jul 2018 14:11:04 +0100 Subject: Use mysql_real_escape_string instead of mysql_escape string. This is not exploitable as far as I know but it is probably best that we use the newer function just in case. Closes #649 (although the attack mentioned in that issue was not feasible). --- src/modules/extra/m_mysql.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/modules') diff --git a/src/modules/extra/m_mysql.cpp b/src/modules/extra/m_mysql.cpp index 0a7d4d993..9f17c1426 100644 --- a/src/modules/extra/m_mysql.cpp +++ b/src/modules/extra/m_mysql.cpp @@ -356,10 +356,9 @@ class SQLConnection : public SQL::Provider // and one byte is the terminating null std::vector buffer(parm.length() * 2 + 1); - // The return value of mysql_escape_string() is the length of the encoded string, + // The return value of mysql_real_escape_string() is the length of the encoded string, // not including the terminating null - unsigned long escapedsize = mysql_escape_string(&buffer[0], parm.c_str(), parm.length()); -// mysql_real_escape_string(connection, queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length()); + unsigned long escapedsize = mysql_real_escape_string(connection, &buffer[0], parm.c_str(), parm.length()); res.append(&buffer[0], escapedsize); } } -- cgit v1.2.3