From 4bf95512bc85eb8bdcbf48a00a52a23bf50b296b Mon Sep 17 00:00:00 2001 From: brain Date: Thu, 17 Aug 2006 14:16:15 +0000 Subject: userrec::AddBuffer and userrec::Write end up copying the const std::string& into a non-const to make use of it, why not just pass std::string and let the compiler do the copy when passing it? git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@4933 e03df62e-2008-0410-955e-edbf42e46eb7 --- src/users.cpp | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) (limited to 'src/users.cpp') diff --git a/src/users.cpp b/src/users.cpp index aab40aa1d..9d7e8dc28 100644 --- a/src/users.cpp +++ b/src/users.cpp @@ -478,19 +478,18 @@ bool userrec::HasPermission(const std::string &command) } -bool userrec::AddBuffer(const std::string &a) +bool userrec::AddBuffer(std::string a) { - std::string b(a); - std::string::size_type i = b.rfind('\r'); + std::string::size_type i = a.rfind('\r'); while (i != std::string::npos) { b.erase(i, 1); - i = b.rfind('\r'); + i = a.rfind('\r'); } - if (b.length()) - recvq.append(b); + if (a.length()) + recvq.append(a); if (recvq.length() > (unsigned)this->recvqmax) { @@ -1271,19 +1270,18 @@ const char* userrec::GetIPString(char* buf) } -void userrec::Write(const std::string &text) +void userrec::Write(std::string text) { if ((this->fd < 0) || (this->fd > MAX_DESCRIPTORS)) return; - std::string crlf = text; - crlf.append("\r\n"); + text.append("\r\n"); if (ServerInstance->Config->GetIOHook(this->GetPort())) { try { - ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, crlf.data(), crlf.length()); + ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length()); } catch (ModuleException& modexcept) { @@ -1292,9 +1290,9 @@ void userrec::Write(const std::string &text) } else { - this->AddWriteBuf(crlf); + this->AddWriteBuf(text); } - ServerInstance->stats->statsSent += crlf.length(); + ServerInstance->stats->statsSent += text.length(); } /** Write() -- cgit v1.2.3