From 52e4d9c96c83ca4bbbeb487966ac2897a384907d Mon Sep 17 00:00:00 2001 From: attilamolnar Date: Mon, 2 Sep 2013 12:25:54 +0200 Subject: Add ModeHandler::IsListModeBase() and MC_LIST --- src/listmode.cpp | 2 +- src/modules/m_rmode.cpp | 13 ++++--------- 2 files changed, 5 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/listmode.cpp b/src/listmode.cpp index f7890f9ad..4ab15b2dc 100644 --- a/src/listmode.cpp +++ b/src/listmode.cpp @@ -20,7 +20,7 @@ #include "listmode.h" ListModeBase::ListModeBase(Module* Creator, const std::string& Name, char modechar, const std::string &eolstr, unsigned int lnum, unsigned int eolnum, bool autotidy, const std::string &ctag) - : ModeHandler(Creator, Name, modechar, PARAM_ALWAYS, MODETYPE_CHANNEL), + : ModeHandler(Creator, Name, modechar, PARAM_ALWAYS, MODETYPE_CHANNEL, MC_LIST), listnumeric(lnum), endoflistnumeric(eolnum), endofliststring(eolstr), tidy(autotidy), configtag(ctag), extItem("listbase_mode_" + name + "_list", Creator) { diff --git a/src/modules/m_rmode.cpp b/src/modules/m_rmode.cpp index 6d17820a5..dde9f496e 100644 --- a/src/modules/m_rmode.cpp +++ b/src/modules/m_rmode.cpp @@ -62,12 +62,7 @@ class CommandRMode : public Command ListModeBase::ModeList* ml; irc::modestacker modestack(false); - if (!mh->IsListMode()) - { - if (chan->IsModeSet(mh)) - modestack.Push(modeletter); - } - else if ((pm = mh->IsPrefixMode())) + if ((pm = mh->IsPrefixMode())) { // As user prefix modes don't have a GetList() method, let's iterate through the channel's users. for (UserMembIter it = chan->userlist.begin(); it != chan->userlist.end(); ++it) @@ -78,7 +73,7 @@ class CommandRMode : public Command modestack.Push(modeletter, it->first->nick); } } - else if (((lm = dynamic_cast(mh)) != NULL) && ((ml = lm->GetList(chan)) != NULL)) + else if ((lm = mh->IsListModeBase()) && ((ml = lm->GetList(chan)) != NULL)) { for (ListModeBase::ModeList::iterator it = ml->begin(); it != ml->end(); ++it) { @@ -89,8 +84,8 @@ class CommandRMode : public Command } else { - user->WriteNotice("Could not remove channel mode " + ConvToStr(modeletter)); - return CMD_FAILURE; + if (chan->IsModeSet(mh)) + modestack.Push(modeletter); } parameterlist stackresult; -- cgit v1.2.3