From bebde5f254e40c7cce6c068a17e7f2c575611db0 Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Mon, 17 Mar 2008 18:50:31 +0100 Subject: rss plugin: make_stream final Hash should be optional --- data/rbot/plugins/rss.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'data') diff --git a/data/rbot/plugins/rss.rb b/data/rbot/plugins/rss.rb index 3b790bac..3fa38008 100644 --- a/data/rbot/plugins/rss.rb +++ b/data/rbot/plugins/rss.rb @@ -287,7 +287,7 @@ class RSSFeedsPlugin < Plugin # Auxiliary method used to collect two lines for rss output filters, # running substitutions against DataStream _s_ optionally joined # with hash _h_ - def make_stream(line1, line2, s, h) + def make_stream(line1, line2, s, h={}) DataStream.new([line1, line2].compact.join("\n") % s.merge(h)) end -- cgit v1.2.3 From 901d14ffa819d069730a64d99a90a1e282656119 Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Mon, 17 Mar 2008 19:00:26 +0100 Subject: rss plugin: there are feeds with items without content --- data/rbot/plugins/rss.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'data') diff --git a/data/rbot/plugins/rss.rb b/data/rbot/plugins/rss.rb index 3fa38008..0cf8f129 100644 --- a/data/rbot/plugins/rss.rb +++ b/data/rbot/plugins/rss.rb @@ -977,7 +977,7 @@ class RSSFeedsPlugin < Plugin desc = item.content_encoded.ircify_html(desc_opt) elsif item.respond_to?(:description) && item.description desc = item.description.ircify_html(desc_opt) - else + elsif item.respond_to?(:content) && item.content if item.content.type == "html" desc = item.content.content.ircify_html(desc_opt) else @@ -986,6 +986,8 @@ class RSSFeedsPlugin < Plugin desc = desc.slice(0, desc_opt[:limit]) + "#{Reverse}...#{Reverse}" end end + else + desc = "(?)" end link = item.link.href rescue item.link.chomp rescue nil -- cgit v1.2.3 From 726b5c7b4973a9e1ab478b7a3ef1bed084749bf8 Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Mon, 17 Mar 2008 19:13:27 +0100 Subject: rss plugin: use (?) for missing item and channel titles too --- data/rbot/plugins/rss.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'data') diff --git a/data/rbot/plugins/rss.rb b/data/rbot/plugins/rss.rb index 0cf8f129..dd359781 100644 --- a/data/rbot/plugins/rss.rb +++ b/data/rbot/plugins/rss.rb @@ -1080,13 +1080,13 @@ class RSSFeedsPlugin < Plugin return nil end if rss.respond_to? :channel - rss.channel.title ||= "Unknown" + rss.channel.title ||= "(?)" title = rss.channel.title else title = rss.title.content end rss.items.each do |item| - item.title ||= "Unknown" + item.title ||= "(?)" items << item end end -- cgit v1.2.3 From 73f25ad4578a7fffc1608099d15a479f0af6b215 Mon Sep 17 00:00:00 2001 From: Giuseppe Bilotta Date: Mon, 17 Mar 2008 19:14:28 +0100 Subject: rss plugin: provide htmlinfo filter --- data/rbot/plugins/rss.rb | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) (limited to 'data') diff --git a/data/rbot/plugins/rss.rb b/data/rbot/plugins/rss.rb index dd359781..8f16509e 100644 --- a/data/rbot/plugins/rss.rb +++ b/data/rbot/plugins/rss.rb @@ -288,7 +288,8 @@ class RSSFeedsPlugin < Plugin # running substitutions against DataStream _s_ optionally joined # with hash _h_ def make_stream(line1, line2, s, h={}) - DataStream.new([line1, line2].compact.join("\n") % s.merge(h)) + ss = s.merge(h) + DataStream.new([line1, line2].compact.join("\n") % ss, ss) end # Define default RSS filters @@ -354,6 +355,27 @@ class RSSFeedsPlugin < Plugin line1 << " (by %{author})" if s[:author] make_stream(line1, nil, s) } + + # Define an HTML info filter too + @bot.register_filter(:rss, :htmlinfo) { |s| htmlinfo_filter(s) } + + # This is the output format used by the input filter + @bot.register_filter(:htmlinfo, @outkey) { |s| + line1 = "%{title}%{at}%{link}" + make_stream(line1, nil, s) + } + end + + def htmlinfo_filter(s) + return nil unless s[:headers] and s[:headers]['x-rbot-location'] + blob = RssBlob.new(s[:headers]['x-rbot-location'],"", :htmlinfo) + return nil unless fetchRss(blob, nil) + return nil unless parseRss(blob, nil) + output = [] + blob.items.each { |it| + output << printFormattedRss(blob, it)[:text] + } + return {:title => blob.title, :content => output.join(" | ")} end # Display the known rss types @@ -916,7 +938,7 @@ class RSSFeedsPlugin < Plugin def printFormattedRss(feed, item, opts=nil) debug item places = feed.watchers - handle = "::#{feed.handle}:: " + handle = feed.handle.empty? ? "" : "::#{feed.handle}:: " date = String.new if opts places = opts[:places] if opts.key?(:places) @@ -1007,6 +1029,8 @@ class RSSFeedsPlugin < Plugin :title => title, :desc => desc, :link => link, :category => category, :author => author, :at => at) + return output if places.empty? + places.each { |loc| output.to_s.each_line { |line| @bot.say loc, line, :overlong => :truncate -- cgit v1.2.3