]> git.netwichtig.de Git - user/henk/code/inspircd.git/blob - src/modules/m_spanningtree/treesocket2.cpp
341c6c473e86f4f47826cf1d8a4861406ed8e838
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / treesocket2.cpp
1 /*       +------------------------------------+
2  *       | Inspire Internet Relay Chat Daemon |
3  *       +------------------------------------+
4  *
5  *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
6  * See: http://www.inspircd.org/wiki/index.php/Credits
7  *
8  * This program is free but copyrighted software; see
9  *            the file COPYING for details.
10  *
11  * ---------------------------------------------------
12  */
13
14 #include "inspircd.h"
15 #include "commands/cmd_whois.h"
16 #include "commands/cmd_stats.h"
17 #include "socket.h"
18 #include "wildcard.h"
19 #include "xline.h"
20 #include "transport.h"
21 #include "socketengine.h"
22
23 #include "m_spanningtree/main.h"
24 #include "m_spanningtree/utils.h"
25 #include "m_spanningtree/treeserver.h"
26 #include "m_spanningtree/link.h"
27 #include "m_spanningtree/treesocket.h"
28 #include "m_spanningtree/resolvers.h"
29 #include "m_spanningtree/handshaketimer.h"
30
31 /* $ModDep: m_spanningtree/timesynctimer.h m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h */
32
33 static std::map<std::string, std::string> warned;       /* Server names that have had protocol violation warnings displayed for them */
34
35 int TreeSocket::WriteLine(std::string line)
36 {
37         Instance->Logs->Log("m_spanningtree",DEBUG, "S[%d] O %s", this->GetFd(), line.c_str());
38         line.append("\r\n");
39         return this->Write(line);
40 }
41
42
43 /* Handle ERROR command */
44 bool TreeSocket::Error(std::deque<std::string> &params)
45 {
46         if (params.size() < 1)
47                 return false;
48         this->Instance->SNO->WriteToSnoMask('l',"ERROR from %s: %s",(!InboundServerName.empty() ? InboundServerName.c_str() : myhost.c_str()),params[0].c_str());
49         /* we will return false to cause the socket to close. */
50         return false;
51 }
52
53 void TreeSocket::Split(const std::string &line, std::deque<std::string> &n)
54 {
55         n.clear();
56         irc::tokenstream tokens(line);
57         std::string param;
58         while (tokens.GetToken(param))
59         {
60                 n.push_back(param);
61         }
62         return;
63 }
64
65 bool TreeSocket::ProcessLine(std::string &line)
66 {
67         std::deque<std::string> params;
68         irc::string command;
69         std::string prefix;
70
71         line = line.substr(0, line.find_first_of("\r\n"));
72
73         if (line.empty())
74                 return true;
75
76         Instance->Logs->Log("m_spanningtree",DEBUG, "S[%d] I %s", this->GetFd(), line.c_str());
77
78         this->Split(line.c_str(),params);
79         
80         if (params.empty())
81                 return true;
82         
83         if ((params[0][0] == ':') && (params.size() > 1))
84         {
85                 prefix = params[0].substr(1);
86                 params.pop_front();
87                 
88                 if (prefix.empty())
89                 {
90                         this->SendError("BUG (?) Empty prefix recieved.");
91                         return false;
92                 }
93         }
94         
95         command = params[0].c_str();
96         params.pop_front();
97
98         switch (this->LinkState)
99         {
100                 TreeServer* Node;
101
102                 case WAIT_AUTH_1:
103                         /*
104                          * State WAIT_AUTH_1:
105                          *  Waiting for SERVER command from remote server. Server initiating
106                          *  the connection sends the first SERVER command, listening server
107                          *  replies with theirs if its happy, then if the initiator is happy,
108                          *  it starts to send its net sync, which starts the merge, otherwise
109                          *  it sends an ERROR.
110                          */
111                         if (command == "PASS")
112                         {
113                                 /*
114                                  * Ignore this silently. Some services packages insist on sending PASS, even
115                                  * when it is not required (i.e. by us). We have to ignore this here, otherwise
116                                  * as it's an unknown command (effectively), it will cause the connection to be
117                                  * closed, which probably isn't what people want. -- w00t
118                                  */
119                         }
120                         else if (command == "SERVER")
121                         {
122                                 return this->Inbound_Server(params);
123                         }
124                         else if (command == "ERROR")
125                         {
126                                 return this->Error(params);
127                         }
128                         else if (command == "USER")
129                         {
130                                 this->SendError("Client connections to this port are prohibited.");
131                                 return false;
132                         }
133                         else if (command == "CAPAB")
134                         {
135                                 return this->Capab(params);
136                         }
137                         else
138                         {
139                                 // XXX ...wtf.
140                                 irc::string error = "Invalid command in negotiation phase: " + command;
141                                 this->SendError(assign(error));
142                                 return false;
143                         }
144                 break;
145                 case WAIT_AUTH_2:
146                         /*
147                          * State WAIT_AUTH_2:
148                          *  We have sent SERVER to the other side of the connection. Now we're waiting for them to start BURST.
149                          *  The other option at this stage of things, of course, is for them to close our connection thanks
150                          *  to invalid credentials.. -- w
151                          */
152                         if (command == "SERVER")
153                         {
154                                 /*
155                                  * Connection is either attempting to re-auth itself (stupid) or sending netburst without sending BURST.
156                                  * Both of these aren't allowable, so block them here. -- w
157                                  */
158                                 this->SendError("You may not re-authenticate or commence netburst without sending BURST.");
159                                 return true;
160                         }
161                         else if (command == "BURST")
162                         {
163                                 if (params.size())
164                                 {
165                                         time_t them = atoi(params[0].c_str());
166                                         time_t delta = them - Instance->Time();
167                                         if ((delta < -600) || (delta > 600))
168                                         {
169                                                 Instance->SNO->WriteToSnoMask('l',"\2ERROR\2: Your clocks are out by %d seconds (this is more than five minutes). Link aborted, \2PLEASE SYNC YOUR CLOCKS!\2",abs(delta));
170                                                 SendError("Your clocks are out by "+ConvToStr(abs(delta))+" seconds (this is more than five minutes). Link aborted, PLEASE SYNC YOUR CLOCKS!");
171                                                 return false;
172                                         }
173                                         else if ((delta < -30) || (delta > 30))
174                                         {
175                                                 Instance->SNO->WriteToSnoMask('l',"\2WARNING\2: Your clocks are out by %d seconds. Please consider synching your clocks.", abs(delta));
176                                         }
177                                 }
178                                 this->LinkState = CONNECTED;
179                                 Link* lnk = Utils->FindLink(InboundServerName);
180
181                                 Node = new TreeServer(this->Utils, this->Instance, InboundServerName, InboundDescription, InboundSID, Utils->TreeRoot, this, lnk ? lnk->Hidden : false);
182
183                                 if (Node->DuplicateID())
184                                 {
185                                         this->SendError("Server ID "+InboundSID+" already exists on the network!");
186                                         this->Instance->SNO->WriteToSnoMask('l',"Server \2"+InboundServerName+"\2 being introduced from \2" + prefix + "\2 denied, server ID already exists on the network. Closing link.");
187                                         return false;
188                                 }
189
190                                 Utils->TreeRoot->AddChild(Node);
191                                 params.clear();
192                                 params.push_back(InboundServerName);
193                                 params.push_back("*");
194                                 params.push_back("1");
195                                 params.push_back(InboundSID);
196                                 params.push_back(":"+InboundDescription);
197                                 Utils->DoOneToAllButSender(Instance->Config->GetSID(),"SERVER",params,InboundServerName);
198                                 Node->bursting = true;
199                                 this->DoBurst(Node);
200                         }
201                         else if (command == "ERROR")
202                         {
203                                 return this->Error(params);
204                         }
205                         else if (command == "CAPAB")
206                         {
207                                 return this->Capab(params);
208                         }
209
210                 break;
211                 case LISTENER:
212                         /*
213                          * This really shouldn't happen.
214                          */
215                         this->SendError("Internal error -- listening socket accepted its own descriptor!!!");
216                         return false;
217                 break;
218                 case CONNECTING:
219                         /*
220                          * State CONNECTING:
221                          *  We're connecting (OUTGOING) to another server. They are in state WAIT_AUTH_1 until they verify
222                          *  our credentials, when they proceed into WAIT_AUTH_2 and send SERVER to us. We then send BURST
223                          *  + our netburst, which will put them into CONNECTED state. -- w
224                          */
225                         if (command == "SERVER")
226                         {
227                                 // Our credentials have been accepted, send netburst. (this puts US into the CONNECTED state)
228                                 return this->Outbound_Reply_Server(params);
229                         }
230                         else if (command == "ERROR")
231                         {
232                                 return this->Error(params);
233                         }
234                         else if (command == "CAPAB")
235                         {
236                                 return this->Capab(params);
237                         }
238                 break;
239                 case CONNECTED:
240                         /*
241                         * State CONNECTED:
242                          *  Credentials have been exchanged, we've gotten their 'BURST' (or sent ours).
243                          *  Anything from here on should be accepted a little more reasonably.
244                          */
245                         if (!prefix.empty())
246                         {
247                                 /*
248                                  * Check for fake direction here, and drop any instances that are found.
249                                  * What is fake direction? Imagine the following server setup:
250                                  *    0AA <-> 0AB <-> 0AC
251                                  * Fake direction would be 0AC sending a message to 0AB claiming to be from
252                                  * 0AA, or something similar. Basically, a message taking a path that *cannot*
253                                  * be correct.
254                                  *
255                                  * When would this be seen?
256                                  * Well, hopefully never. It could be caused by race conditions, bugs, or
257                                  * "miscreant" servers, though, so let's check anyway. -- w
258                                  */
259                                 std::string direction = prefix;
260
261                                 User *t = this->Instance->FindUUID(prefix);
262                                 if (t)
263                                 {
264                                         direction = t->server;
265                                 }
266
267                                 TreeServer* route_back_again = Utils->BestRouteTo(direction);
268                                 if ((!route_back_again) || (route_back_again->GetSocket() != this))
269                                 {
270                                         if (route_back_again)
271                                                 Instance->Logs->Log("m_spanningtree",DEBUG,"Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
272                                         return true;
273                                 }
274                                 /* Fix by brain:
275                                  * When there is activity on the socket, reset the ping counter so
276                                  * that we're not wasting bandwidth pinging an active server.
277                                  */
278                                 route_back_again->SetNextPingTime(Instance->Time() + Utils->PingFreq);
279                                 route_back_again->SetPingFlag();
280                         }
281                         else
282                         {
283                                 /*
284                                  * Empty prefix from a server to server link:
285                                  *  This is somewhat bad/naughty, so let's set the prefix
286                                  *  to be the link that we got it from, so we don't break anything. -- w
287                                  */
288                                 TreeServer* n = Utils->FindServer(GetName());
289                                 if (n)
290                                         prefix = n->GetID();
291                                 else
292                                         prefix = GetName();
293                         }
294
295                         /*
296                          * First up, check for any malformed commands (e.g. MODE without a timestamp)
297                          * and rewrite commands where necessary (SVSMODE -> MODE for services). -- w
298                          */
299                         if (command == "MODE")
300                         {
301                                 if (params.size() >= 2)
302                                 {
303                                         Channel* channel = Instance->FindChan(params[0]);
304                                         if (channel)
305                                         {
306                                                 User* x = Instance->FindNick(prefix);
307                                                 if (x)
308                                                 {
309                                                         if (warned.find(x->server) == warned.end())
310                                                         {
311                                                                 Instance->Logs->Log("m_spanningtree",DEFAULT,"WARNING: I revceived modes '%s' from another server '%s'. This is not compliant with InspIRCd. Please check that server for bugs.", params[1].c_str(), x->server);
312                                                                 Instance->SNO->WriteToSnoMask('d', "WARNING: The server %s is sending nonstandard modes: '%s MODE %s' where FMODE should be used, and may cause desyncs.", x->server, x->nick, params[1].c_str());
313                                                                 warned[x->server] = x->nick;
314                                                         }
315                                                 }
316                                         }
317                                 }
318                         }
319                         else if (command == "SVSMODE")
320                         {
321                                 command = "MODE";
322                         }
323
324
325                         /*
326                          * Now, check for (and parse) commands as appropriate. -- w
327                          */     
328                 
329                         /* Find the server that this command originated from, used in the handlers below */
330                         TreeServer *ServerSource = Utils->FindServer(prefix);
331
332                         /* Find the link we just got this from so we don't bounce it back incorrectly */
333                         std::string sourceserv = this->myhost;
334                         if (!this->InboundServerName.empty())
335                         {
336                                 sourceserv = this->InboundServerName;
337                         }
338
339                         /*
340                          * XXX one of these days, this needs to be moved into class Commands.
341                          */
342                         if (command == "UID")
343                         {
344                                 return this->ParseUID(prefix, params);
345                         }
346                         else if (command == "FJOIN")
347                         {
348                                 return this->ForceJoin(prefix,params);
349                         }
350                         else if (command == "STATS")
351                         {
352                                 return this->Stats(prefix, params);
353                         }
354                         else if (command == "MOTD")
355                         {
356                                 return this->Motd(prefix, params);
357                         }
358                         else if (command == "KILL" && ServerSource)
359                         {
360                                 // Kill from a server
361                                 return this->RemoteKill(prefix,params);
362                         }
363                         else if (command == "MODULES")
364                         {
365                                 return this->Modules(prefix, params);
366                         }
367                         else if (command == "ADMIN")
368                         {
369                                 return this->Admin(prefix, params);
370                         }
371                         else if (command == "SERVER")
372                         {
373                                 return this->RemoteServer(prefix,params);
374                         }
375                         else if (command == "ERROR")
376                         {
377                                 return this->Error(params);
378                         }
379                         else if (command == "OPERTYPE")
380                         {
381                                 return this->OperType(prefix,params);
382                         }
383                         else if (command == "FMODE")
384                         {
385                                 return this->ForceMode(prefix,params);
386                         }
387                         else if (command == "FTOPIC")
388                         {
389                                 return this->ForceTopic(prefix,params);
390                         }
391                         else if (command == "REHASH")
392                         {
393                                 return this->RemoteRehash(prefix,params);
394                         }
395                         else if (command == "METADATA")
396                         {
397                                 return this->MetaData(prefix,params);
398                         }
399                         else if (command == "PING")
400                         {
401                                 return this->LocalPing(prefix,params);
402                         }
403                         else if (command == "PONG")
404                         {
405                                 return this->LocalPong(prefix,params);
406                         }
407                         else if (command == "VERSION")
408                         {
409                                 return this->ServerVersion(prefix,params);
410                         }
411                         else if (command == "FHOST")
412                         {
413                                 return this->ChangeHost(prefix,params);
414                         }
415                         else if (command == "FNAME")
416                         {
417                                 return this->ChangeName(prefix,params);
418                         }
419                         else if (command == "ADDLINE")
420                         {
421                                 return this->AddLine(prefix,params);
422                         }
423                         else if (command == "DELLINE")
424                         {
425                                 return this->DelLine(prefix,params);
426                         }
427                         else if (command == "SVSNICK")
428                         {
429                                 return this->ForceNick(prefix,params);
430                         }
431                         else if (command == "OPERQUIT")
432                         {
433                                 return this->OperQuit(prefix,params);
434                         }
435                         else if (command == "IDLE")
436                         {
437                                 return this->Whois(prefix,params);
438                         }
439                         else if (command == "PUSH")
440                         {
441                                 return this->Push(prefix,params);
442                         }
443                         else if (command == "TIME")
444                         {
445                                 return this->Time(prefix,params);
446                         }
447                         else if ((command == "KICK") && (Utils->IsServer(prefix)))
448                         {
449                                 if (params.size() == 3)
450                                 {
451                                         User* user = this->Instance->FindNick(params[1]);
452                                         Channel* chan = this->Instance->FindChan(params[0]);
453                                         if (user && chan)
454                                         {
455                                                 if (!chan->ServerKickUser(user, params[2].c_str(), false))
456                                                         /* Yikes, the channels gone! */
457                                                         delete chan;
458                                         }
459                                 }
460
461                                 return Utils->DoOneToAllButSenderRaw(line,sourceserv,prefix,command,params);
462                         }
463                         else if (command == "SVSJOIN")
464                         {
465                                 return this->ServiceJoin(prefix,params);
466                         }
467                         else if (command == "SVSPART")
468                         {
469                                 return this->ServicePart(prefix,params);
470                         }
471                         else if (command == "SQUIT")
472                         {
473                                 if (params.size() == 2)
474                                 {
475                                         this->Squit(Utils->FindServer(params[0]),params[1]);
476                                 }
477                                 return true;
478                         }
479                         else if (command == "OPERNOTICE")
480                         {
481                                 if (params.size() >= 1)
482                                         Instance->SNO->WriteToSnoMask('A', "From " + prefix + ": " + params[0]);
483                                 return Utils->DoOneToAllButSenderRaw(line, sourceserv, prefix, command, params);
484                         }
485                         else if (command == "MODENOTICE")
486                         {
487                                 if (params.size() >= 2)
488                                 {
489                                         Instance->Users->WriteMode(params[0].c_str(), WM_AND, "*** From %s: %s", prefix.c_str(), params[1].c_str());
490                                 }
491                                 return Utils->DoOneToAllButSenderRaw(line, sourceserv, prefix, command, params);
492                         }
493                         else if (command == "SNONOTICE")
494                         {
495                                 if (params.size() >= 2)
496                                 {
497                                         Instance->SNO->WriteToSnoMask(*(params[0].c_str()), "From " + prefix + ": "+ params[1]);
498                                 }
499                                 return Utils->DoOneToAllButSenderRaw(line, sourceserv, prefix, command, params);
500                         }
501                         else if (command == "BURST")
502                         {
503                                 // Set prefix server as bursting
504                                 if (!ServerSource)
505                                 {
506                                         this->Instance->SNO->WriteToSnoMask('l', "WTF: Got BURST from a nonexistant server(?): %s", prefix.c_str());
507                                         return false;
508                                 }
509                                 
510                                 ServerSource->bursting = true;
511                                 return Utils->DoOneToAllButSenderRaw(line, sourceserv, prefix, command, params);
512                         }
513                         else if (command == "ENDBURST")
514                         {
515                                 if (!ServerSource)
516                                 {
517                                         this->Instance->SNO->WriteToSnoMask('l', "WTF: Got ENDBURST from a nonexistant server(?): %s", prefix.c_str());
518                                         return false;
519                                 }
520                                 
521                                 ServerSource->FinishBurst();
522                                 return Utils->DoOneToAllButSenderRaw(line, sourceserv, prefix, command, params);
523                         }
524                         else if (command == "MODE")
525                         {
526                                 // Server-prefix MODE.
527                                 const char* modelist[MAXPARAMETERS];
528                                 for (size_t i = 0; i < params.size(); i++)
529                                         modelist[i] = params[i].c_str();
530                                         
531                                 // Insert into the parser
532                                 this->Instance->SendMode(modelist, params.size(), this->Instance->FakeClient);
533                                 
534                                 // Pass out to the network
535                                 return Utils->DoOneToAllButSenderRaw(line,sourceserv,prefix,command,params);
536                         }
537                         else
538                         {
539                                 /*
540                                  * Not a special s2s command. Emulate the user doing it.
541                                  * This saves us having a huge ugly command parser again.
542                                  */
543                                 User *who = this->Instance->FindUUID(prefix);
544
545                                 if (!who)
546                                 {
547                                         // this looks ugly because command is an irc::string
548                                         this->SendError("Command (" + std::string(command.c_str()) + ") from unknown prefix (" + prefix + ")! Dropping link.");
549                                         return false;
550                                 }
551
552                                 if (command == "NICK")
553                                 {
554                                         if (params.size() != 2)
555                                         {
556                                                 SendError("Protocol violation: NICK message without TS - :"+std::string(who->uuid)+" NICK "+params[0]);
557                                                 return false;
558                                         }
559                                         /* Update timestamp on user when they change nicks */
560                                         who->age = atoi(params[1].c_str());
561
562                                         /*
563                                          * On nick messages, check that the nick doesnt already exist here.
564                                          * If it does, perform collision logic.
565                                          */
566                                         User* x = this->Instance->FindNickOnly(params[0]);
567                                         if ((x) && (x != who))
568                                         {
569                                                 int collideret = 0;
570                                                 /* x is local, who is remote */
571                                                 collideret = this->DoCollision(x, who->age, who->ident, who->GetIPString(), who->uuid);
572                                                 if (collideret != 1)
573                                                 {
574                                                         /*
575                                                          * Remote client lost, or both lost, parsing this nickchange would be
576                                                          * pointless, as the incoming client's server will soon recieve SVSNICK to
577                                                          * change its nick to its UID. :) -- w00t
578                                                          */
579                                                         return true;
580                                                 }
581                                         }
582                                 }
583                                         
584                                 // its a user
585                                 const char* strparams[127];
586                                 for (unsigned int q = 0; q < params.size(); q++)
587                                 {
588                                         strparams[q] = params[q].c_str();
589                                 }
590
591                                 switch (this->Instance->CallCommandHandler(command.c_str(), strparams, params.size(), who))
592                                 {
593                                         case CMD_INVALID:
594                                                 // command is irc::string, hence ugliness
595                                                 this->SendError("Unrecognised or malformed command '" + std::string(command.c_str()) + "' -- possibly loaded mismatched modules");
596                                                 return false;
597                                                 break;
598                                         /*
599                                          * CMD_LOCALONLY is aliased to CMD_FAILURE, so this won't go out onto the network.
600                                          */
601                                         case CMD_FAILURE:
602                                                 return true;
603                                                 break;
604                                         default:
605                                                 /* CMD_SUCCESS and CMD_USER_DELETED fall through here */
606                                                 break;
607                                 }
608
609                                 return Utils->DoOneToAllButSenderRaw(line,sourceserv,prefix,command,params);
610
611                         }
612                         return true;
613                         break; // end of state CONNECTED (phew).
614         }
615         return true;
616 }
617
618 std::string TreeSocket::GetName()
619 {
620         std::string sourceserv = this->myhost;
621         if (!this->InboundServerName.empty())
622         {
623                 sourceserv = this->InboundServerName;
624         }
625         return sourceserv;
626 }
627
628 void TreeSocket::OnTimeout()
629 {
630         if (this->LinkState == CONNECTING)
631         {
632                 Utils->Creator->RemoteMessage(NULL, "CONNECT: Connection to \002%s\002 timed out.", myhost.c_str());
633                 Link* MyLink = Utils->FindLink(myhost);
634                 if (MyLink)
635                         Utils->DoFailOver(MyLink);
636         }
637 }
638
639 void TreeSocket::OnClose()
640 {
641         // Test fix for big fuckup
642         if (this->LinkState != CONNECTED)
643                 return;
644
645         // Connection closed.
646         // If the connection is fully up (state CONNECTED)
647         // then propogate a netsplit to all peers.
648         std::string quitserver = this->myhost;
649         if (!this->InboundServerName.empty())
650         {
651                 quitserver = this->InboundServerName;
652         }
653         TreeServer* s = Utils->FindServer(quitserver);
654         if (s)
655         {
656                 Squit(s,"Remote host closed the connection");
657         }
658
659         if (!quitserver.empty())
660         {
661                 Utils->Creator->RemoteMessage(NULL,"Connection to '\2%s\2' failed.",quitserver.c_str());
662                 time_t server_uptime = Instance->Time() - this->age;    
663                 if (server_uptime)
664                         Utils->Creator->RemoteMessage(NULL,"Connection to '\2%s\2' was established for %s", quitserver.c_str(), Utils->Creator->TimeToStr(server_uptime).c_str());
665         }
666 }
667
668 int TreeSocket::OnIncomingConnection(int newsock, char* ip)
669 {
670         /* To prevent anyone from attempting to flood opers/DDoS by connecting to the server port,
671          * or discovering if this port is the server port, we don't allow connections from any
672          * IPs for which we don't have a link block.
673          */
674         bool found = false;
675
676         found = (std::find(Utils->ValidIPs.begin(), Utils->ValidIPs.end(), ip) != Utils->ValidIPs.end());
677         if (!found)
678         {
679                 for (std::vector<std::string>::iterator i = Utils->ValidIPs.begin(); i != Utils->ValidIPs.end(); i++)
680                         if (irc::sockets::MatchCIDR(ip, (*i).c_str()))
681                                 found = true;
682
683                 if (!found)
684                 {
685                         Utils->Creator->RemoteMessage(NULL,"Server connection from %s denied (no link blocks with that IP address)", ip);
686                         Instance->SE->Close(newsock);
687                         return false;
688                 }
689         }
690
691         TreeSocket* s = new TreeSocket(this->Utils, this->Instance, newsock, ip, this->Hook);
692         s = s; /* Whinge whinge whinge, thats all GCC ever does. */
693         return true;
694 }