imdb plugin: imdb.popular and imdb.exact config options to determine which results...

[user/henk/code/ruby/rbot.git] / data / rbot / plugins / imdb.rb

diff --git a/data/rbot/plugins/imdb.rb b/data/rbot/plugins/imdb.rb
index f00b4e53bf7b36c3a6a59ebfcfd1563437c5e1d6..3f750793cc1969a86e38a34ce0ebdb679e5b4163 100644 (file)
--- a/data/rbot/plugins/imdb.rb
+++ b/data/rbot/plugins/imdb.rb
@@ -41,13 +41,11 @@ class Imdb
 
     if resp.code == "200"
       m = []
-      m << TITLE_OR_NAME_MATCH.match(resp.body)
-      if resp.body.match(/\(Exact Matches\)<\/b>/)
+      m << TITLE_OR_NAME_MATCH.match(resp.body) if @bot.config['imdb.popular']
+      if resp.body.match(/\(Exact Matches\)<\/b>/) and @bot.config['imdb.exact']
         m << TITLE_OR_NAME_MATCH.match($')
       end
-      debug m.inspect
       m.compact!
-      debug m.inspect
       unless m.empty?
         return m.map { |mm|
           mm[1]
@@ -101,29 +99,50 @@ class Imdb
       return nil
     end
 
+    info = []
+
     if resp.code == "200"
       m = /<title>([^<]*)<\/title>/.match(resp.body)
       return nil if !m
-      title = Utils.decode_html_entities(m[1])
+      title_date = m[1]
+      title, date, extra = title_date.scan(/^(.*)\((\d\d\d\d(?:[IV]+)?)\)\s*(.+)?$/).first
+      title.strip!
 
-      m = /<b>([0-9.]+)\/10<\/b>\n?\r?\s+<small>\(<a href="ratings">([0-9,]+) votes?<\/a>\)<\/small>/.match(resp.body)
-      return nil if !m
-      score = m[1]
-      votes = m[2]
+      dir = nil
+      data = grab_info(/Directors?/, resp.body)
+      if data
+        dir = data.scan(NAME_MATCH).map { |url, name|
+          name
+        }.join(', ')
+      end
 
-      plot = nil
-      data = grab_info(/Plot (?:Outline|Summary)/, resp.body)
+      country = nil
+      data = grab_info(/Country/, resp.body)
       if data
-        plot = "Plot: #{data.ircify_html.gsub(/\s+more$/,'')}"
+        country = data.ircify_html
+      end
+
+      info << [title, "(#{country}, #{date})", extra, dir ? "[#{dir}]" : nil, ": http://us.imdb.com#{sr}"].compact.join(" ")
+
+      ratings = "no votes"
+      m = /<b>([0-9.]+)\/10<\/b>\n?\r?\s+<small>\(<a href="ratings">([0-9,]+) votes?<\/a>\)<\/small>/.match(resp.body)
+      if m
+        ratings = "#{m[1]}/10 (#{m[2]} voters)"
       end
 
       genre = Array.new
       resp.body.scan(/<a href="\/Sections\/Genres\/[^\/]+\/">([^<]+)<\/a>/) do |gnr|
         genre << gnr
       end
-      info = "#{title} : http://us.imdb.com#{sr}\n"
-      info << "Ratings: #{score}/10 (#{votes} voters). Genre: #{genre.join('/')}\n"
-      info << plot if plot
+
+      plot = nil
+      data = grab_info(/Plot (?:Outline|Summary)/, resp.body)
+      if data
+        plot = "Plot: " + data.ircify_html.gsub(/\s+more$/,'')
+      end
+
+      info << ["Ratings: " << ratings, "Genre: " << genre.join('/') , plot].compact.join(". ")
+
       return info
     end
     return nil
@@ -139,10 +158,14 @@ class Imdb
       return nil
     end
 
+    info = []
+
     if resp.code == "200"
       m = /<title>([^<]*)<\/title>/.match(resp.body)
       return nil if !m
-      name = Utils.decode_html_entities(m[1])
+      name = m[1]
+
+      info << "#{name} : http://us.imdb.com#{sr}"
 
       birth = nil
       data = grab_info("Date of Birth", resp.body)
@@ -156,6 +179,8 @@ class Imdb
         death = "Death: #{data.ircify_html.gsub(/\s+more$/,'')}"
       end
 
+      info << [birth, death].compact.join('. ') if birth or death
+
       movies = {}
 
       filmorate = nil
@@ -167,23 +192,33 @@ class Imdb
       if filmorate
         filmorate.scan(/<div class="filmo">.*?<a href="\/title.*?<\/div>/m) { |str|
           what = str.match(/<a name="[^"]+">([^<]+)<\/a>/)[1] rescue nil
-          # next unless what
-          next unless ['Actor', 'Director'].include?(what)
+          next unless what
           movies[what] = str.scan(TITLE_MATCH)[0..2].map { |url, tit|
-            Utils.decode_html_entities(tit)
+            tit
           }
         }
       end
-      debug movies.inspect
 
-      info = "#{name} : http://us.imdb.com#{sr}\n"
-      info << [birth, death].compact.join('. ') << "\n"
+      preferred = ['Actor', 'Director']
+      if resp.body.match(/Jump to filmography as:&nbsp;(.*?)<\/div>/)
+        txt = $1
+        preferred = txt.scan(/<a[^>]+>([^<]+)<\/a>/)[0..2].map { |pref|
+          pref.first
+        }
+      end
+
       unless movies.empty?
-        info << "Top Movies:: "
+        all_keys = movies.keys.sort
+        debug all_keys.inspect
+        keys = []
+        preferred.each { |key|
+          keys << key if all_keys.include? key
+        }
+        keys = all_keys if keys.empty?
         ar = []
-        movies.keys.sort.each { |key|
+        keys.each { |key|
           ar << key.dup
-          ar.last << ": " + movies[key].join(', ')
+          ar.last << ": " + movies[key].join('; ')
         }
         info << ar.join('. ')
       end
@@ -195,6 +230,13 @@ class Imdb
 end
 
 class ImdbPlugin < Plugin
+  BotConfig.register BotConfigBooleanValue.new('imdb.popular',
+    :default => true,
+    :desc => "Display info on popular IMDB entries matching the request closely")
+  BotConfig.register BotConfigBooleanValue.new('imdb.exact',
+    :default => true,
+    :desc => "Display info on IMDB entries matching the request exactly")
+
   def help(plugin, topic="")
     "imdb <string> => search http://www.imdb.org for <string>"
   end
@@ -208,10 +250,10 @@ class ImdbPlugin < Plugin
       return nil
     end
     if info.length == 1
-      m.reply info
+      m.reply Utils.decode_html_entities info.first.join("\n")
     else
       m.reply info.map { |i|
-        i.gsub(/\n+/, " | ")
+        Utils.decode_html_entities i.join(" | ")
       }.join("\n")
     end
   end