]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/channels.cpp
Add ModeHandler* versions of channel mode access
[user/henk/code/inspircd.git] / src / channels.cpp
index 0a4ef993daa792aec81efd7a8ae26e0db8359571..31038484eb14baedf93858253908b0af711295da 100644 (file)
 #include <cstdarg>
 #include "mode.h"
 
-Channel::Channel(InspIRCd* Instance, const std::string &cname, time_t ts) : ServerInstance(Instance)
+Channel::Channel(const std::string &cname, time_t ts)
 {
        chan_hash::iterator findchan = ServerInstance->chanlist->find(cname);
-       if (findchan != Instance->chanlist->end())
+       if (findchan != ServerInstance->chanlist->end())
                throw CoreException("Cannot create duplicate channel " + cname);
 
        (*(ServerInstance->chanlist))[cname.c_str()] = this;
@@ -36,7 +36,12 @@ void Channel::SetMode(char mode,bool mode_on)
        modes[mode-65] = mode_on;
 }
 
-void Channel::SetModeParam(char mode, std::string parameter)
+void Channel::SetMode(ModeHandler* mh, bool on)
+{
+       modes[mh->GetModeChar() - 65] = on;
+}
+
+void Channel::SetModeParam(char mode, const std::string& parameter)
 {
        CustomModeList::iterator n = custom_mode_params.find(mode);
        // always erase, even if changing, so that the map gets the new value
@@ -53,6 +58,11 @@ void Channel::SetModeParam(char mode, std::string parameter)
        }
 }
 
+void Channel::SetModeParam(ModeHandler* mode, const std::string& parameter)
+{
+       SetModeParam(mode->GetModeChar(), parameter);
+}
+
 std::string Channel::GetModeParameter(char mode)
 {
        CustomModeList::iterator n = custom_mode_params.find(mode);
@@ -61,6 +71,14 @@ std::string Channel::GetModeParameter(char mode)
        return "";
 }
 
+std::string Channel::GetModeParameter(ModeHandler* mode)
+{
+       CustomModeList::iterator n = custom_mode_params.find(mode->GetModeChar());
+       if (n != custom_mode_params.end())
+               return n->second;
+       return "";
+}
+
 int Channel::SetTopic(User *u, std::string &ntopic, bool forceset)
 {
        if (u)
@@ -70,7 +88,7 @@ int Channel::SetTopic(User *u, std::string &ntopic, bool forceset)
                        ModResult res;
                        /* 0: check status, 1: don't, -1: disallow change silently */
 
-                       FIRST_MOD_RESULT(ServerInstance, OnPreTopicChange, res, (u,this,ntopic));
+                       FIRST_MOD_RESULT(OnPreTopicChange, res, (u,this,ntopic));
 
                        if (res == MOD_RES_DENY)
                                return CMD_FAILURE;
@@ -125,17 +143,32 @@ Membership* Channel::AddUser(User* user)
        return memb;
 }
 
-unsigned long Channel::DelUser(User* user)
+void Channel::DelUser(User* user)
 {
        UserMembIter a = userlist.find(user);
 
        if (a != userlist.end())
        {
+               a->second->cull();
                delete a->second;
                userlist.erase(a);
        }
 
-       return userlist.size();
+       if (userlist.empty())
+       {
+               ModResult res;
+               FIRST_MOD_RESULT(OnChannelPreDelete, res, (this));
+               if (res == MOD_RES_DENY)
+                       return;
+               chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
+               /* kill the record */
+               if (iter != ServerInstance->chanlist->end())
+               {
+                       FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
+                       ServerInstance->chanlist->erase(iter);
+               }
+               ServerInstance->GlobalCulls.AddItem(this);
+       }
 }
 
 bool Channel::HasUser(User* user)
@@ -158,7 +191,8 @@ const UserMembList* Channel::GetUsers()
 
 void Channel::SetDefaultModes()
 {
-       ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s", ServerInstance->Config->DefaultModes);
+       ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s",
+               ServerInstance->Config->DefaultModes.c_str());
        irc::spacesepstream list(ServerInstance->Config->DefaultModes);
        std::string modeseq;
        std::string parameter;
@@ -184,7 +218,7 @@ void Channel::SetDefaultModes()
  * add a channel to a user, creating the record for it if needed and linking
  * it to the user record
  */
-Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS)
+Channel* Channel::JoinUser(User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS)
 {
        // Fix: unregistered users could be joined using /SAJOIN
        if (!user || !cn || user->registered != REG_ALL)
@@ -202,30 +236,29 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
         */
        if (IS_LOCAL(user) && !override)
        {
-               // Checking MyClass exists because we *may* get here with NULL, not 100% sure.
-               if (user->MyClass && user->MyClass->maxchans)
+               if (user->HasPrivPermission("channels/high-join-limit"))
                {
-                       if (user->HasPrivPermission("channels/high-join-limit"))
+                       if (user->chans.size() >= ServerInstance->Config->OperMaxChans)
                        {
-                               if (user->chans.size() >= Instance->Config->OperMaxChans)
-                               {
-                                       user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
-                                       return NULL;
-                               }
+                               user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
+                               return NULL;
                        }
-                       else
+               }
+               else
+               {
+                       unsigned int maxchans = user->GetClass()->maxchans;
+                       if (!maxchans)
+                               maxchans = ServerInstance->Config->MaxChans;
+                       if (user->chans.size() >= maxchans)
                        {
-                               if (user->chans.size() >= user->MyClass->maxchans)
-                               {
-                                       user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
-                                       return NULL;
-                               }
+                               user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
+                               return NULL;
                        }
                }
        }
 
-       strlcpy(cname, cn, Instance->Config->Limits.ChanMax);
-       Ptr = Instance->FindChan(cname);
+       strlcpy(cname, cn, ServerInstance->Config->Limits.ChanMax);
+       Ptr = ServerInstance->FindChan(cname);
        bool created_by_local = false;
 
        if (!Ptr)
@@ -236,23 +269,23 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                if (!IS_LOCAL(user))
                {
                        if (!TS)
-                               Instance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick.c_str(), cn);
+                               ServerInstance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick.c_str(), cn);
                }
                else
                {
-                       privs = "@";
+                       privs = "o";
                        created_by_local = true;
                }
 
                if (IS_LOCAL(user) && override == false)
                {
                        ModResult MOD_RESULT;
-                       FIRST_MOD_RESULT(Instance, OnUserPreJoin, MOD_RESULT, (user, NULL, cname, privs, key ? key : ""));
+                       FIRST_MOD_RESULT(OnUserPreJoin, MOD_RESULT, (user, NULL, cname, privs, key ? key : ""));
                        if (MOD_RESULT == MOD_RES_DENY)
                                return NULL;
                }
 
-               Ptr = new Channel(Instance, cname, TS);
+               Ptr = new Channel(cname, TS);
        }
        else
        {
@@ -267,7 +300,7 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                if (IS_LOCAL(user) && override == false)
                {
                        ModResult MOD_RESULT;
-                       FIRST_MOD_RESULT(Instance, OnUserPreJoin, MOD_RESULT, (user, Ptr, cname, privs, key ? key : ""));
+                       FIRST_MOD_RESULT(OnUserPreJoin, MOD_RESULT, (user, Ptr, cname, privs, key ? key : ""));
                        if (MOD_RESULT == MOD_RES_DENY)
                        {
                                return NULL;
@@ -275,12 +308,12 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                        else if (MOD_RESULT == MOD_RES_PASSTHRU)
                        {
                                std::string ckey = Ptr->GetModeParameter('k');
-                               bool invited = user->IsInvited(Ptr->name.c_str());
-                               bool can_bypass = Instance->Config->InvBypassModes && invited;
+                               bool invited = IS_LOCAL(user)->IsInvited(Ptr->name.c_str());
+                               bool can_bypass = ServerInstance->Config->InvBypassModes && invited;
 
                                if (!ckey.empty())
                                {
-                                       FIRST_MOD_RESULT(Instance, OnCheckKey, MOD_RESULT, (user, Ptr, key ? key : ""));
+                                       FIRST_MOD_RESULT(OnCheckKey, MOD_RESULT, (user, Ptr, key ? key : ""));
                                        if (!MOD_RESULT.check((key && ckey == key) || can_bypass))
                                        {
                                                // If no key provided, or key is not the right one, and can't bypass +k (not invited or option not enabled)
@@ -291,7 +324,7 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 
                                if (Ptr->IsModeSet('i'))
                                {
-                                       FIRST_MOD_RESULT(Instance, OnCheckInvite, MOD_RESULT, (user, Ptr));
+                                       FIRST_MOD_RESULT(OnCheckInvite, MOD_RESULT, (user, Ptr));
                                        if (!MOD_RESULT.check(invited))
                                        {
                                                user->WriteNumeric(ERR_INVITEONLYCHAN, "%s %s :Cannot join channel (Invite only)",user->nick.c_str(), Ptr->name.c_str());
@@ -302,7 +335,7 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                                std::string limit = Ptr->GetModeParameter('l');
                                if (!limit.empty())
                                {
-                                       FIRST_MOD_RESULT(Instance, OnCheckLimit, MOD_RESULT, (user, Ptr));
+                                       FIRST_MOD_RESULT(OnCheckLimit, MOD_RESULT, (user, Ptr));
                                        if (!MOD_RESULT.check((Ptr->GetUserCounter() < atol(limit.c_str()) || can_bypass)))
                                        {
                                                user->WriteNumeric(ERR_CHANNELISFULL, "%s %s :Cannot join channel (Channel is full)",user->nick.c_str(), Ptr->name.c_str());
@@ -322,7 +355,7 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                                 */
                                if (invited)
                                {
-                                       user->RemoveInvite(Ptr->name.c_str());
+                                       IS_LOCAL(user)->RemoveInvite(Ptr->name.c_str());
                                }
                        }
                }
@@ -334,36 +367,37 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
                Ptr->SetDefaultModes();
        }
 
-       return Channel::ForceChan(Instance, Ptr, user, privs, bursting, created_by_local);
+       return Channel::ForceChan(Ptr, user, privs, bursting, created_by_local);
 }
 
-Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const std::string &privs, bool bursting, bool created)
+Channel* Channel::ForceChan(Channel* Ptr, User* user, const std::string &privs, bool bursting, bool created)
 {
        std::string nick = user->nick;
-       bool silent = false;
 
-       Ptr->AddUser(user);
+       Membership* memb = Ptr->AddUser(user);
        user->chans.insert(Ptr);
 
        for (std::string::const_iterator x = privs.begin(); x != privs.end(); x++)
        {
                const char status = *x;
-               ModeHandler* mh = Instance->Modes->FindPrefix(status);
+               ModeHandler* mh = ServerInstance->Modes->FindMode(status, MODETYPE_CHANNEL);
                if (mh)
                {
                        /* Set, and make sure that the mode handler knows this mode was now set */
-                       Ptr->SetPrefix(user, mh->GetModeChar(), mh->GetPrefixRank(), true);
-                       mh->OnModeChange(Instance->FakeClient, Instance->FakeClient, Ptr, nick, true);
+                       Ptr->SetPrefix(user, mh->GetModeChar(), true);
+                       mh->OnModeChange(ServerInstance->FakeClient, ServerInstance->FakeClient, Ptr, nick, true);
                }
        }
 
-       FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, bursting, silent, created));
+       CUList except_list;
+       FOREACH_MOD(I_OnUserJoin,OnUserJoin(memb, bursting, created, except_list));
 
-       if (!silent)
-               Ptr->WriteChannel(user,"JOIN :%s",Ptr->name.c_str());
+       Ptr->WriteAllExcept(user, false, 0, except_list, "JOIN :%s", Ptr->name.c_str());
 
        /* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */
-       std::string ms = Instance->Modes->ModeString(user, Ptr);
+       std::string ms = memb->modes;
+       for(unsigned int i=0; i < memb->modes.length(); i++)
+               ms.append(" ").append(user->nick);
        if ((Ptr->GetUserCounter() > 1) && (ms.length()))
                Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name.c_str(), ms.c_str());
 
@@ -377,166 +411,125 @@ Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const
                }
                Ptr->UserList(user);
        }
-       FOREACH_MOD_I(Instance,I_OnPostJoin,OnPostJoin(user, Ptr));
+       FOREACH_MOD(I_OnPostJoin,OnPostJoin(memb));
        return Ptr;
 }
 
 bool Channel::IsBanned(User* user)
 {
        ModResult result;
-       DO_EACH_HOOK(ServerInstance, OnCheckBan, ModResult modresult, (user, this))
-       {
-               result = result + modresult;
-       }
-       WHILE_EACH_HOOK(ServerInstance, OnCheckBan);
+       FIRST_MOD_RESULT(OnCheckChannelBan, result, (user, this));
 
        if (result != MOD_RES_PASSTHRU)
                return (result == MOD_RES_DENY);
 
-       char mask[MAXBUF];
-       snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString());
        for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
        {
-               if ((InspIRCd::Match(user->GetFullHost(),i->data, NULL)) || // host
-                       (InspIRCd::Match(user->GetFullRealHost(),i->data, NULL)) || // uncloaked host
-                       (InspIRCd::MatchCIDR(mask, i->data, NULL))) // ip
-               {
+               if (CheckBan(user, i->data))
                        return true;
-               }
        }
        return false;
 }
 
-ModResult Channel::GetExtBanStatus(const std::string &str, char type)
+bool Channel::CheckBan(User* user, const std::string& mask)
 {
        ModResult result;
-       DO_EACH_HOOK(ServerInstance, OnCheckStringExtBan, ModResult modresult, (str, this, type))
-       {
-               result = result + modresult;
-       }
-       WHILE_EACH_HOOK(ServerInstance, OnCheckStringExtBan);
-
+       FIRST_MOD_RESULT(OnCheckBan, result, (user, this, mask));
        if (result != MOD_RES_PASSTHRU)
-               return result;
+               return (result == MOD_RES_DENY);
 
-       // nobody decided for us, check the ban list
-       for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
-       {
-               if (i->data[0] != type || i->data[1] != ':')
-                       continue;
+       // extbans were handled above, if this is one it obviously didn't match
+       if (mask[1] == ':')
+               return false;
 
-               std::string maskptr = i->data.substr(2);
-               ServerInstance->Logs->Log("EXTBANS", DEBUG, "Checking %s against %s, type is %c", str.c_str(), maskptr.c_str(), type);
+       std::string::size_type at = mask.find('@');
+       if (at == std::string::npos)
+               return false;
 
-               if (InspIRCd::Match(str, maskptr, NULL))
-                       return MOD_RES_DENY;
+       char tomatch[MAXBUF];
+       snprintf(tomatch, MAXBUF, "%s!%s", user->nick.c_str(), user->ident.c_str());
+       std::string prefix = mask.substr(0, at);
+       if (InspIRCd::Match(tomatch, prefix, NULL))
+       {
+               std::string suffix = mask.substr(at + 1);
+               if (InspIRCd::Match(user->host, suffix, NULL) ||
+                       InspIRCd::Match(user->dhost, suffix, NULL) ||
+                       InspIRCd::MatchCIDR(user->GetIPString(), suffix, NULL))
+                       return true;
        }
-
-       return MOD_RES_PASSTHRU;
+       return false;
 }
 
 ModResult Channel::GetExtBanStatus(User *user, char type)
 {
        ModResult rv;
-       DO_EACH_HOOK(ServerInstance, OnCheckExtBan, ModResult modresult, (user, this, type))
-       {
-               rv = rv + modresult;
-       }
-       WHILE_EACH_HOOK(ServerInstance, OnCheckExtBan);
-
+       FIRST_MOD_RESULT(OnExtBanCheck, rv, (user, this, type));
        if (rv != MOD_RES_PASSTHRU)
                return rv;
-
-       char mask[MAXBUF];
-       snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString());
-
-       rv = rv + this->GetExtBanStatus(mask, type);
-       rv = rv + this->GetExtBanStatus(user->GetFullHost(), type);
-       rv = rv + this->GetExtBanStatus(user->GetFullRealHost(), type);
-       return rv;
+       for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
+       {
+               if (i->data[0] == type && i->data[1] == ':')
+               {
+                       std::string val = i->data.substr(2);
+                       if (CheckBan(user, val))
+                               return MOD_RES_DENY;
+               }
+       }
+       return MOD_RES_PASSTHRU;
 }
 
 /* Channel::PartUser
  * remove a channel from a users record, and return the number of users left.
  * Therefore, if this function returns 0 the caller should delete the Channel.
  */
-long Channel::PartUser(User *user, std::string &reason)
+void Channel::PartUser(User *user, std::string &reason)
 {
-       bool silent = false;
-
        if (!user)
-               return this->GetUserCounter();
+               return;
+
+       Membership* memb = GetUser(user);
 
-       UCListIter i = user->chans.find(this);
-       if (i != user->chans.end())
+       if (memb)
        {
-               FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason, silent));
+               CUList except_list;
+               FOREACH_MOD(I_OnUserPart,OnUserPart(memb, reason, except_list));
 
-               if (!silent)
-                       this->WriteChannel(user, "PART %s%s%s", this->name.c_str(), reason.empty() ? "" : " :", reason.c_str());
+               WriteAllExcept(user, false, 0, except_list, "PART %s%s%s", this->name.c_str(), reason.empty() ? "" : " :", reason.c_str());
 
-               user->chans.erase(i);
+               user->chans.erase(this);
                this->RemoveAllPrefixes(user);
        }
 
-       if (!this->DelUser(user)) /* if there are no users left on the channel... */
-       {
-               chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
-               /* kill the record */
-               if (iter != ServerInstance->chanlist->end())
-               {
-                       ModResult res;
-                       FIRST_MOD_RESULT(ServerInstance, OnChannelPreDelete, res, (this));
-                       if (res == MOD_RES_DENY)
-                               return 1; // delete halted by module
-                       FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
-                       ServerInstance->chanlist->erase(iter);
-               }
-               return 0;
-       }
-
-       return this->GetUserCounter();
+       this->DelUser(user);
 }
 
-long Channel::ServerKickUser(User* user, const char* reason, const char* servername)
+void Channel::KickUser(User *src, User *user, const char* reason)
 {
-       if (servername == NULL || *ServerInstance->Config->HideWhoisServer)
-               servername = ServerInstance->Config->ServerName;
-
-       ServerInstance->FakeClient->server = servername;
-       return this->KickUser(ServerInstance->FakeClient, user, reason);
-}
-
-long Channel::KickUser(User *src, User *user, const char* reason)
-{
-       bool silent = false;
-
        if (!src || !user || !reason)
-               return this->GetUserCounter();
+               return;
 
+       Membership* memb = GetUser(user);
        if (IS_LOCAL(src))
        {
-               if (!this->HasUser(user))
+               if (!memb)
                {
                        src->WriteNumeric(ERR_USERNOTINCHANNEL, "%s %s %s :They are not on that channel",src->nick.c_str(), user->nick.c_str(), this->name.c_str());
-                       return this->GetUserCounter();
+                       return;
                }
                if ((ServerInstance->ULine(user->server)) && (!ServerInstance->ULine(src->server)))
                {
                        src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s %s :Only a u-line may kick a u-line from a channel.",src->nick.c_str(), this->name.c_str());
-                       return this->GetUserCounter();
+                       return;
                }
 
                ModResult res;
                if (ServerInstance->ULine(src->server))
                        res = MOD_RES_ALLOW;
-               if (res == MOD_RES_PASSTHRU)
-                       FIRST_MOD_RESULT(ServerInstance, OnUserPreKick, res, (src,user,this,reason));
-               if (res == MOD_RES_PASSTHRU)
-                       FIRST_MOD_RESULT(ServerInstance, OnAccessCheck, res, (src,user,this,AC_KICK));
+               else
+                       FIRST_MOD_RESULT(OnUserPreKick, res, (src,memb,reason));
 
                if (res == MOD_RES_DENY)
-                       return this->GetUserCounter();
+                       return;
 
                if (res == MOD_RES_PASSTHRU)
                {
@@ -545,43 +538,23 @@ long Channel::KickUser(User *src, User *user, const char* reason)
                        if ((them < HALFOP_VALUE) || (them < us))
                        {
                                src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s %s :You must be a channel %soperator",src->nick.c_str(), this->name.c_str(), them >= HALFOP_VALUE ? "" : "half-");
-                               return this->GetUserCounter();
+                               return;
                        }
                }
        }
 
-       FOREACH_MOD(I_OnUserKick,OnUserKick(src, user, this, reason, silent));
-
-       UCListIter i = user->chans.find(this);
-       if (i != user->chans.end())
+       if (memb)
        {
-               /* zap it from the channel list of the user */
-               if (!silent)
-                       this->WriteChannel(src, "KICK %s %s :%s", this->name.c_str(), user->nick.c_str(), reason);
-
-               user->chans.erase(i);
-               this->RemoveAllPrefixes(user);
-       }
+               CUList except_list;
+               FOREACH_MOD(I_OnUserKick,OnUserKick(src, memb, reason, except_list));
 
-       if (!this->DelUser(user))
-       /* if there are no users left on the channel */
-       {
-               chan_hash::iterator iter = ServerInstance->chanlist->find(this->name.c_str());
+               WriteAllExcept(src, false, 0, except_list, "KICK %s %s :%s", name.c_str(), user->nick.c_str(), reason);
 
-               /* kill the record */
-               if (iter != ServerInstance->chanlist->end())
-               {
-                       ModResult res;
-                       FIRST_MOD_RESULT(ServerInstance, OnChannelPreDelete, res, (this));
-                       if (res == MOD_RES_DENY)
-                               return 1; // delete halted by module
-                       FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
-                       ServerInstance->chanlist->erase(iter);
-               }
-               return 0;
+               user->chans.erase(this);
+               this->RemoveAllPrefixes(user);
        }
 
-       return this->GetUserCounter();
+       this->DelUser(user);
 }
 
 void Channel::WriteChannel(User* user, const char* text, ...)
@@ -616,7 +589,7 @@ void Channel::WriteChannel(User* user, const std::string &text)
        }
 }
 
-void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...)
+void Channel::WriteChannelWithServ(const std::string& ServName, const char* text, ...)
 {
        char textbuffer[MAXBUF];
        va_list argsPtr;
@@ -631,11 +604,11 @@ void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...)
        this->WriteChannelWithServ(ServName, std::string(textbuffer));
 }
 
-void Channel::WriteChannelWithServ(const char* ServName, const std::string &text)
+void Channel::WriteChannelWithServ(const std::string& ServName, const std::string &text)
 {
        char tb[MAXBUF];
 
-       snprintf(tb,MAXBUF,":%s %s", ServName ? ServName : ServerInstance->Config->ServerName, text.c_str());
+       snprintf(tb,MAXBUF,":%s %s", ServName.empty() ? ServerInstance->Config->ServerName.c_str() : ServName.c_str(), text.c_str());
        std::string out = tb;
 
        for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
@@ -683,7 +656,7 @@ void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList
 {
        char tb[MAXBUF];
 
-       snprintf(tb,MAXBUF,":%s %s", serversource ? ServerInstance->Config->ServerName : user->GetFullHost().c_str(), text.c_str());
+       snprintf(tb,MAXBUF,":%s %s", serversource ? ServerInstance->Config->ServerName.c_str() : user->GetFullHost().c_str(), text.c_str());
        std::string out = tb;
 
        this->RawWriteAllExcept(user, serversource, status, except_list, std::string(tb));
@@ -691,12 +664,19 @@ void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList
 
 void Channel::RawWriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const std::string &out)
 {
+       unsigned int minrank = 0;
+       if (status)
+       {
+               ModeHandler* mh = ServerInstance->Modes->FindPrefix(status);
+               if (mh)
+                       minrank = mh->GetPrefixRank();
+       }
        for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
        {
-               if ((IS_LOCAL(i->first)) && (except_list.find(i->first) == except_list.end()))
+               if (IS_LOCAL(i->first) && (except_list.find(i->first) == except_list.end()))
                {
-                       /* User doesnt have the status we're after */
-                       if (status && !strchr(this->GetAllPrefixChars(i->first), status))
+                       /* User doesn't have the status we're after */
+                       if (minrank && i->second->getRank() < minrank)
                                continue;
 
                        i->first->Write(out);
@@ -744,30 +724,13 @@ char* Channel::ChanModes(bool showkey)
                {
                        *offset++ = n + 65;
                        extparam.clear();
-                       switch (n)
+                       if (n == 'k' - 65 && !showkey)
                        {
-                               case CM_KEY:
-                                       // Unfortunately this must be special-cased, as we definitely don't want to always display key.
-                                       if (showkey)
-                                       {
-                                               extparam = this->GetModeParameter('k');
-                                       }
-                                       else
-                                       {
-                                               extparam = "<key>";
-                                       }
-                                       break;
-                               case CM_NOEXTERNAL:
-                               case CM_TOPICLOCK:
-                               case CM_INVITEONLY:
-                               case CM_MODERATED:
-                               case CM_SECRET:
-                               case CM_PRIVATE:
-                                       /* We know these have no parameters */
-                               break;
-                               default:
-                                       extparam = this->GetModeParameter(n + 65);
-                               break;
+                               extparam = "<key>";
+                       }
+                       else
+                       {
+                               extparam = this->GetModeParameter(n + 65);
                        }
                        if (!extparam.empty())
                        {
@@ -795,7 +758,7 @@ void Channel::UserList(User *user)
        if (!IS_LOCAL(user))
                return;
 
-       FIRST_MOD_RESULT(ServerInstance, OnUserList, call_modules, (user, this));
+       FIRST_MOD_RESULT(OnUserList, call_modules, (user, this));
 
        if (call_modules != MOD_RES_ALLOW)
        {
@@ -832,7 +795,7 @@ void Channel::UserList(User *user)
 
                if (call_modules != MOD_RES_DENY)
                {
-                       FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->first, this, prefixlist, nick));
+                       FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->second, prefixlist, nick));
 
                        /* Nick was nuked, a module wants us to skip it */
                        if (nick.empty())
@@ -914,7 +877,7 @@ const char* Channel::GetPrefixChar(User *user)
                {
                        char mchar = m->second->modes[i];
                        ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
-                       if (mh && mh->GetPrefixRank() > bestrank)
+                       if (mh && mh->GetPrefixRank() > bestrank && mh->GetPrefix())
                        {
                                bestrank = mh->GetPrefixRank();
                                pf[0] = mh->GetPrefix();
@@ -924,6 +887,18 @@ const char* Channel::GetPrefixChar(User *user)
        return pf;
 }
 
+unsigned int Membership::getRank()
+{
+       char mchar = modes.c_str()[0];
+       unsigned int rv = 0;
+       if (mchar)
+       {
+               ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+               if (mh)
+                       rv = mh->GetPrefixRank();
+       }
+       return rv;
+}
 
 const char* Channel::GetAllPrefixChars(User* user)
 {
@@ -948,42 +923,35 @@ const char* Channel::GetAllPrefixChars(User* user)
 
 unsigned int Channel::GetPrefixValue(User* user)
 {
-       unsigned int bestrank = 0;
-
        UserMembIter m = userlist.find(user);
-       if (m != userlist.end())
-       {
-               for(unsigned int i=0; i < m->second->modes.length(); i++)
-               {
-                       char mchar = m->second->modes[i];
-                       ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
-                       if (mh && mh->GetPrefixRank() > bestrank)
-                               bestrank = mh->GetPrefixRank();
-               }
-       }
-       return bestrank;
+       if (m == userlist.end())
+               return 0;
+       return m->second->getRank();
 }
 
-void Channel::SetPrefix(User* user, char prefix, unsigned int prefix_value, bool adding)
+void Channel::SetPrefix(User* user, char prefix, bool adding)
 {
+       ModeHandler* delta_mh = ServerInstance->Modes->FindMode(prefix, MODETYPE_CHANNEL);
+       if (!delta_mh)
+               return;
        UserMembIter m = userlist.find(user);
-       if (m != userlist.end())
+       if (m == userlist.end())
+               return;
+       for(unsigned int i=0; i < m->second->modes.length(); i++)
        {
-               for(unsigned int i=0; i < m->second->modes.length(); i++)
+               char mchar = m->second->modes[i];
+               ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+               if (mh && mh->GetPrefixRank() <= delta_mh->GetPrefixRank())
                {
-                       char mchar = m->second->modes[i];
-                       ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
-                       if (mh && mh->GetPrefixRank() <= prefix_value)
-                       {
-                               m->second->modes =
-                                       m->second->modes.substr(0,i-1) +
-                                       (adding ? std::string(1, prefix) : "") +
-                                       m->second->modes.substr(mchar == prefix ? i+1 : i);
-                               return;
-                       }
+                       m->second->modes =
+                               m->second->modes.substr(0,i) +
+                               (adding ? std::string(1, prefix) : "") +
+                               m->second->modes.substr(mchar == prefix ? i+1 : i);
+                       return;
                }
-               m->second->modes += std::string(1, prefix);
        }
+       if (adding)
+               m->second->modes += std::string(1, prefix);
 }
 
 void Channel::RemoveAllPrefixes(User* user)