]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/channels.cpp
Merge insp20
[user/henk/code/inspircd.git] / src / channels.cpp
index 39265764738e7b35aa8c39b9778d1e60c7fdb259..53a48c46970204d108f2eeba992bd6d429b296f2 100644 (file)
@@ -25,8 +25,6 @@
 
 #include "inspircd.h"
 #include "listmode.h"
-#include <cstdarg>
-#include "mode.h"
 
 namespace
 {
@@ -42,36 +40,13 @@ namespace
 Channel::Channel(const std::string &cname, time_t ts)
        : name(cname), age(ts), topicset(0)
 {
-       if (!ServerInstance->chanlist->insert(std::make_pair(cname, this)).second)
+       if (!ServerInstance->chanlist.insert(std::make_pair(cname, this)).second)
                throw CoreException("Cannot create duplicate channel " + cname);
 }
 
 void Channel::SetMode(ModeHandler* mh, bool on)
 {
-       modes[mh->GetModeChar() - 65] = on;
-}
-
-void Channel::SetModeParam(ModeHandler* mh, const std::string& parameter)
-{
-       char mode = mh->GetModeChar();
-       if (parameter.empty())
-       {
-               custom_mode_params.erase(mode);
-               modes[mode-65] = false;
-       }
-       else
-       {
-               custom_mode_params[mode] = parameter;
-               modes[mode-65] = true;
-       }
-}
-
-std::string Channel::GetModeParameter(ModeHandler* mode)
-{
-       CustomModeList::iterator n = custom_mode_params.find(mode->GetModeChar());
-       if (n != custom_mode_params.end())
-               return n->second;
-       return "";
+       modes[mh->GetId()] = on;
 }
 
 void Channel::SetTopic(User* u, const std::string& ntopic)
@@ -86,17 +61,17 @@ void Channel::SetTopic(User* u, const std::string& ntopic)
 
 Membership* Channel::AddUser(User* user)
 {
-       Membership*& memb = userlist[user];
-       if (memb)
+       std::pair<MemberMap::iterator, bool> ret = userlist.insert(std::make_pair(user, insp::aligned_storage<Membership>()));
+       if (!ret.second)
                return NULL;
 
-       memb = new Membership(user, this);
+       Membership* memb = new(ret.first->second) Membership(user, this);
        return memb;
 }
 
 void Channel::DelUser(User* user)
 {
-       UserMembIter it = userlist.find(user);
+       MemberMap::iterator it = userlist.find(user);
        if (it != userlist.end())
                DelUser(it);
 }
@@ -111,23 +86,23 @@ void Channel::CheckDestroy()
        if (res == MOD_RES_DENY)
                return;
 
-       chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
+       chan_hash::iterator iter = ServerInstance->chanlist.find(this->name);
        /* kill the record */
-       if (iter != ServerInstance->chanlist->end())
+       if (iter != ServerInstance->chanlist.end())
        {
                FOREACH_MOD(OnChannelDelete, (this));
-               ServerInstance->chanlist->erase(iter);
+               ServerInstance->chanlist.erase(iter);
        }
 
        ClearInvites();
        ServerInstance->GlobalCulls.AddItem(this);
 }
 
-void Channel::DelUser(const UserMembIter& membiter)
+void Channel::DelUser(const MemberMap::iterator& membiter)
 {
        Membership* memb = membiter->second;
        memb->cull();
-       delete memb;
+       memb->~Membership();
        userlist.erase(membiter);
 
        // If this channel became empty then it should be removed
@@ -136,7 +111,7 @@ void Channel::DelUser(const UserMembIter& membiter)
 
 Membership* Channel::GetUser(User* user)
 {
-       UserMembIter i = userlist.find(user);
+       MemberMap::iterator i = userlist.find(user);
        if (i == userlist.end())
                return NULL;
        return i->second;
@@ -161,10 +136,18 @@ void Channel::SetDefaultModes()
                                continue;
 
                        if (mode->GetNumParams(true))
+                       {
                                list.GetToken(parameter);
+                               // If the parameter begins with a ':' then it's invalid
+                               if (parameter.c_str()[0] == ':')
+                                       continue;
+                       }
                        else
                                parameter.clear();
 
+                       if ((mode->GetNumParams(true)) && (parameter.empty()))
+                               continue;
+
                        mode->OnModeChange(ServerInstance->FakeClient, ServerInstance->FakeClient, this, parameter, true);
                }
        }
@@ -184,30 +167,26 @@ Channel* Channel::JoinUser(LocalUser* user, std::string cname, bool override, co
 
        /*
         * We don't restrict the number of channels that remote users or users that are override-joining may be in.
-        * We restrict local users to MaxChans channels.
-        * We restrict local operators to OperMaxChans channels.
+        * We restrict local users to <connect:maxchans> channels.
+        * We restrict local operators to <oper:maxchans> channels.
         * This is a lot more logical than how it was formerly. -- w00t
         */
        if (!override)
        {
-               if (user->HasPrivPermission("channels/high-join-limit"))
+               unsigned int maxchans = user->GetClass()->maxchans;
+               if (user->IsOper())
                {
-                       if (user->chans.size() >= ServerInstance->Config->OperMaxChans)
-                       {
-                               user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s :You are on too many channels", cname.c_str());
-                               return NULL;
-                       }
+                       unsigned int opermaxchans = ConvToInt(user->oper->getConfig("maxchans"));
+                       // If not set, use 2.0's <channels:opers>, if that's not set either, use limit from CC
+                       if (!opermaxchans)
+                               opermaxchans = ServerInstance->Config->OperMaxChans;
+                       if (opermaxchans)
+                               maxchans = opermaxchans;
                }
-               else
+               if (user->chans.size() >= maxchans)
                {
-                       unsigned int maxchans = user->GetClass()->maxchans;
-                       if (!maxchans)
-                               maxchans = ServerInstance->Config->MaxChans;
-                       if (user->chans.size() >= maxchans)
-                       {
-                               user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s :You are on too many channels", cname.c_str());
-                               return NULL;
-                       }
+                       user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s :You are on too many channels", cname.c_str());
+                       return NULL;
                }
        }
 
@@ -319,17 +298,17 @@ Channel* Channel::JoinUser(LocalUser* user, std::string cname, bool override, co
        return chan;
 }
 
-void Channel::ForceJoin(User* user, const std::string* privs, bool bursting, bool created_by_local)
+Membership* Channel::ForceJoin(User* user, const std::string* privs, bool bursting, bool created_by_local)
 {
        if (IS_SERVER(user))
        {
                ServerInstance->Logs->Log("CHANNELS", LOG_DEBUG, "Attempted to join server user " + user->uuid + " to channel " + this->name);
-               return;
+               return NULL;
        }
 
        Membership* memb = this->AddUser(user);
        if (!memb)
-               return; // Already on the channel
+               return NULL; // Already on the channel
 
        user->chans.push_front(memb);
 
@@ -377,6 +356,7 @@ void Channel::ForceJoin(User* user, const std::string* privs, bool bursting, boo
        }
 
        FOREACH_MOD(OnPostJoin, (memb));
+       return memb;
 }
 
 bool Channel::IsBanned(User* user)
@@ -438,7 +418,6 @@ ModResult Channel::GetExtBanStatus(User *user, char type)
        ListModeBase* banlm = static_cast<ListModeBase*>(*ban);
        const ListModeBase::ModeList* bans = banlm->GetList(this);
        if (bans)
-
        {
                for (ListModeBase::ModeList::const_iterator it = bans->begin(); it != bans->end(); ++it)
                {
@@ -455,7 +434,7 @@ ModResult Channel::GetExtBanStatus(User *user, char type)
  */
 void Channel::PartUser(User *user, std::string &reason)
 {
-       UserMembIter membiter = userlist.find(user);
+       MemberMap::iterator membiter = userlist.find(user);
 
        if (membiter != userlist.end())
        {
@@ -472,52 +451,13 @@ void Channel::PartUser(User *user, std::string &reason)
        }
 }
 
-void Channel::KickUser(User* src, User* victim, const std::string& reason, Membership* srcmemb)
+void Channel::KickUser(User* src, const MemberMap::iterator& victimiter, const std::string& reason)
 {
-       UserMembIter victimiter = userlist.find(victim);
-       Membership* memb = ((victimiter != userlist.end()) ? victimiter->second : NULL);
-
-       if (!memb)
-       {
-               src->WriteNumeric(ERR_USERNOTINCHANNEL, "%s %s :They are not on that channel", victim->nick.c_str(), this->name.c_str());
-               return;
-       }
-
-       // Do the following checks only if the KICK is done by a local user;
-       // each server enforces its own rules.
-       if (IS_LOCAL(src))
-       {
-               // Modules are allowed to explicitly allow or deny kicks done by local users
-               ModResult res;
-               FIRST_MOD_RESULT(OnUserPreKick, res, (src,memb,reason));
-               if (res == MOD_RES_DENY)
-                       return;
-
-               if (res == MOD_RES_PASSTHRU)
-               {
-                       if (!srcmemb)
-                               srcmemb = GetUser(src);
-                       unsigned int them = srcmemb ? srcmemb->getRank() : 0;
-                       unsigned int req = HALFOP_VALUE;
-                       for (std::string::size_type i = 0; i < memb->modes.length(); i++)
-                       {
-                               ModeHandler* mh = ServerInstance->Modes->FindMode(memb->modes[i], MODETYPE_CHANNEL);
-                               if (mh && mh->GetLevelRequired() > req)
-                                       req = mh->GetLevelRequired();
-                       }
-
-                       if (them < req)
-                       {
-                               src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s :You must be a channel %soperator",
-                                       this->name.c_str(), req > HALFOP_VALUE ? "" : "half-");
-                               return;
-                       }
-               }
-       }
-
+       Membership* memb = victimiter->second;
        CUList except_list;
        FOREACH_MOD(OnUserKick, (src, memb, reason, except_list));
 
+       User* victim = memb->user;
        WriteAllExcept(src, false, 0, except_list, "KICK %s %s :%s", name.c_str(), victim->nick.c_str(), reason.c_str());
 
        victim->chans.erase(memb);
@@ -535,7 +475,7 @@ void Channel::WriteChannel(User* user, const std::string &text)
 {
        const std::string message = ":" + user->GetFullHost() + " " + text;
 
-       for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
+       for (MemberMap::iterator i = userlist.begin(); i != userlist.end(); i++)
        {
                if (IS_LOCAL(i->first))
                        i->first->Write(message);
@@ -553,7 +493,7 @@ void Channel::WriteChannelWithServ(const std::string& ServName, const std::strin
 {
        const std::string message = ":" + (ServName.empty() ? ServerInstance->Config->ServerName : ServName) + " " + text;
 
-       for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
+       for (MemberMap::iterator i = userlist.begin(); i != userlist.end(); i++)
        {
                if (IS_LOCAL(i->first))
                        i->first->Write(message);
@@ -592,7 +532,7 @@ void Channel::RawWriteAllExcept(User* user, bool serversource, char status, CULi
                if (mh)
                        minrank = mh->GetPrefixRank();
        }
-       for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
+       for (MemberMap::iterator i = userlist.begin(); i != userlist.end(); i++)
        {
                if (IS_LOCAL(i->first) && (except_list.find(i->first) == except_list.end()))
                {
@@ -622,11 +562,13 @@ const char* Channel::ChanModes(bool showkey)
        /* This was still iterating up to 190, Channel::modes is only 64 elements -- Om */
        for(int n = 0; n < 64; n++)
        {
-               if(this->modes[n])
+               ModeHandler* mh = ServerInstance->Modes->FindMode(n + 65, MODETYPE_CHANNEL);
+               if (mh && IsModeSet(mh))
                {
                        scratch.push_back(n + 65);
-                       ModeHandler* mh = ServerInstance->Modes->FindMode(n+'A', MODETYPE_CHANNEL);
-                       if (!mh)
+
+                       ParamModeBase* pm = mh->IsParameterMode();
+                       if (!pm)
                                continue;
 
                        if (n == 'k' - 65 && !showkey)
@@ -635,12 +577,8 @@ const char* Channel::ChanModes(bool showkey)
                        }
                        else
                        {
-                               const std::string param = this->GetModeParameter(mh);
-                               if (!param.empty())
-                               {
-                                       sparam += ' ';
-                                       sparam += param;
-                               }
+                               sparam += ' ';
+                               pm->GetParameter(this, sparam);
                        }
                }
        }
@@ -652,34 +590,20 @@ const char* Channel::ChanModes(bool showkey)
 /* compile a userlist of a channel into a string, each nick seperated by
  * spaces and op, voice etc status shown as @ and +, and send it to 'user'
  */
-void Channel::UserList(User *user)
+void Channel::UserList(User* user, bool has_user)
 {
        bool has_privs = user->HasPrivPermission("channels/auspex");
-       if (this->IsModeSet(secretmode) && !this->HasUser(user) && !has_privs)
-       {
-               user->WriteNumeric(ERR_NOSUCHNICK, "%s :No such nick/channel", this->name.c_str());
-               return;
-       }
-
        std::string list;
        list.push_back(this->IsModeSet(secretmode) ? '@' : this->IsModeSet(privatemode) ? '*' : '=');
        list.push_back(' ');
        list.append(this->name).append(" :");
        std::string::size_type pos = list.size();
 
-       bool has_one = false;
-
-       /* Improvement by Brain - this doesnt change in value, so why was it inside
-        * the loop?
-        */
-       bool has_user = this->HasUser(user);
-
+       const size_t maxlen = ServerInstance->Config->Limits.MaxLine - 10 - ServerInstance->Config->ServerName.size();
        std::string prefixlist;
        std::string nick;
-       for (UserMembIter i = userlist.begin(); i != userlist.end(); ++i)
+       for (MemberMap::iterator i = userlist.begin(); i != userlist.end(); ++i)
        {
-               if (i->first->quitting)
-                       continue;
                if ((!has_user) && (i->first->IsModeSet(invisiblemode)) && (!has_privs))
                {
                        /*
@@ -689,35 +613,36 @@ void Channel::UserList(User *user)
                        continue;
                }
 
-               prefixlist = this->GetPrefixChar(i->first);
+               Membership* memb = i->second;
+
+               prefixlist.clear();
+               char prefix = memb->GetPrefixChar();
+               if (prefix)
+                       prefixlist.push_back(prefix);
                nick = i->first->nick;
 
-               FOREACH_MOD(OnNamesListItem, (user, i->second, prefixlist, nick));
+               ModResult res;
+               FIRST_MOD_RESULT(OnNamesListItem, res, (user, memb, prefixlist, nick));
 
-               /* Nick was nuked, a module wants us to skip it */
-               if (nick.empty())
+               // See if a module wants us to exclude this user from NAMES
+               if (res == MOD_RES_DENY)
                        continue;
 
-               if (list.size() + prefixlist.length() + nick.length() + 1 > 480)
+               if (list.size() + prefixlist.length() + nick.length() + 1 > maxlen)
                {
                        /* list overflowed into multiple numerics */
                        user->WriteNumeric(RPL_NAMREPLY, list);
 
                        // Erase all nicks, keep the constant part
                        list.erase(pos);
-                       has_one = false;
                }
 
                list.append(prefixlist).append(nick).push_back(' ');
-
-               has_one = true;
        }
 
-       /* if whats left in the list isnt empty, send it */
-       if (has_one)
-       {
+       // Only send the user list numeric if there is at least one user in it
+       if (list.size() != pos)
                user->WriteNumeric(RPL_NAMREPLY, list);
-       }
 
        user->WriteNumeric(RPL_ENDOFNAMES, "%s :End of /NAMES list.", this->name.c_str());
 }
@@ -726,23 +651,18 @@ void Channel::UserList(User *user)
  * % for halfop etc. If the user has several modes set, the highest mode
  * the user has must be returned.
  */
-const char* Channel::GetPrefixChar(User *user)
+char Membership::GetPrefixChar() const
 {
-       static char pf[2] = {0, 0};
-       *pf = 0;
+       char pf = 0;
        unsigned int bestrank = 0;
 
-       UserMembIter m = userlist.find(user);
-       if (m != userlist.end())
+       for (std::string::const_iterator i = modes.begin(); i != modes.end(); ++i)
        {
-               for(unsigned int i=0; i < m->second->modes.length(); i++)
+               PrefixMode* mh = ServerInstance->Modes->FindPrefixMode(*i);
+               if (mh && mh->GetPrefixRank() > bestrank && mh->GetPrefix())
                {
-                       PrefixMode* mh = ServerInstance->Modes->FindPrefixMode(m->second->modes[i]);
-                       if (mh && mh->GetPrefixRank() > bestrank && mh->GetPrefix())
-                       {
-                               bestrank = mh->GetPrefixRank();
-                               pf[0] = mh->GetPrefix();
-                       }
+                       bestrank = mh->GetPrefixRank();
+                       pf = mh->GetPrefix();
                }
        }
        return pf;
@@ -761,20 +681,16 @@ unsigned int Membership::getRank()
        return rv;
 }
 
-const char* Channel::GetAllPrefixChars(User* user)
+const char* Membership::GetAllPrefixChars() const
 {
        static char prefix[64];
        int ctr = 0;
 
-       UserMembIter m = userlist.find(user);
-       if (m != userlist.end())
+       for (std::string::const_iterator i = modes.begin(); i != modes.end(); ++i)
        {
-               for(unsigned int i=0; i < m->second->modes.length(); i++)
-               {
-                       PrefixMode* mh = ServerInstance->Modes->FindPrefixMode(m->second->modes[i]);
-                       if (mh && mh->GetPrefix())
-                               prefix[ctr++] = mh->GetPrefix();
-               }
+               PrefixMode* mh = ServerInstance->Modes->FindPrefixMode(*i);
+               if (mh && mh->GetPrefix())
+                       prefix[ctr++] = mh->GetPrefix();
        }
        prefix[ctr] = 0;
 
@@ -783,7 +699,7 @@ const char* Channel::GetAllPrefixChars(User* user)
 
 unsigned int Channel::GetPrefixValue(User* user)
 {
-       UserMembIter m = userlist.find(user);
+       MemberMap::iterator m = userlist.find(user);
        if (m == userlist.end())
                return 0;
        return m->second->getRank();
@@ -837,8 +753,6 @@ void Invitation::Create(Channel* c, LocalUser* u, time_t timeout)
 Invitation* Invitation::Find(Channel* c, LocalUser* u, bool check_expired)
 {
        ServerInstance->Logs->Log("INVITATION", LOG_DEBUG, "Invitation::Find chan=%s user=%s check_expired=%d", c ? c->name.c_str() : "NULL", u ? u->uuid.c_str() : "NULL", check_expired);
-       if (!u || u->invites.empty())
-               return NULL;
 
        Invitation* result = NULL;
        for (InviteList::iterator i = u->invites.begin(); i != u->invites.end(); )