]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/channels.cpp
Move OnCheckBan into chanrec::IsBanned() so its always called for any attempt to...
[user/henk/code/inspircd.git] / src / channels.cpp
index 8dd8b490e02673ae875f7a9ef7e11bbc7554efff..8e614a8a89267691239f1269f6c5cc27d4a0aec8 100644 (file)
@@ -199,19 +199,23 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
        if (!user || !cn)
                return NULL;
 
-       int created = 0;
+       bool new_channel = false;
        char cname[MAXBUF];
        int MOD_RESULT = 0;
        strlcpy(cname,cn,CHANMAX);
 
+       std::string privs;
+
        chanrec* Ptr = Instance->FindChan(cname);
 
        if (!Ptr)
        {
+               privs = "@";
+
                if (IS_LOCAL(user))
                {
                        MOD_RESULT = 0;
-                       FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,NULL,cname));
+                       FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,NULL,cname,privs));
                        if (MOD_RESULT == 1)
                                return NULL;
                }
@@ -224,15 +228,10 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                Ptr->modes[CM_TOPICLOCK] = Ptr->modes[CM_NOEXTERNAL] = 1;
                Ptr->created = Instance->Time();
                *Ptr->topic = 0;
-               strlcpy(Ptr->setby, user->nick,NICKMAX-1);
+               *Ptr->setby = 0;
                Ptr->topicset = 0;
                Instance->Log(DEBUG,"chanrec::JoinUser(): created: %s",cname);
-               /*
-                * set created to 2 to indicate user
-                * is the first in the channel
-                * and should be given ops
-                */
-               created = 2;
+               new_channel = true;
        }
        else
        {
@@ -247,7 +246,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                if (IS_LOCAL(user)) /* was a check on fd > -1 */
                {
                        MOD_RESULT = 0;
-                       FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,Ptr,cname));
+                       FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,Ptr,cname,privs));
                        if (MOD_RESULT == 1)
                        {
                                return NULL;
@@ -260,21 +259,11 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                                        FOREACH_RESULT_I(Instance,I_OnCheckKey,OnCheckKey(user, Ptr, key ? key : ""));
                                        if (!MOD_RESULT)
                                        {
-                                               if (!key)
+                                               if ((!key) || strcmp(key,Ptr->key))
                                                {
-                                                       Instance->Log(DEBUG,"chanrec::JoinUser(): no key given in JOIN");
-                                                       user->WriteServ("475 %s %s :Cannot join channel (Requires key)",user->nick, Ptr->name);
+                                                       user->WriteServ("475 %s %s :Cannot join channel (Incorrect channel key)",user->nick, Ptr->name);
                                                        return NULL;
                                                }
-                                               else
-                                               {
-                                                       if (strcmp(key,Ptr->key))
-                                                       {
-                                                               Instance->Log(DEBUG,"chanrec::JoinUser(): bad key given in JOIN");
-                                                               user->WriteServ("475 %s %s :Cannot join channel (Incorrect key)",user->nick, Ptr->name);
-                                                               return NULL;
-                                                       }
-                                               }
                                        }
                                }
                                if (Ptr->modes[CM_INVITEONLY])
@@ -312,17 +301,12 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                                }
                                if (Ptr->bans.size())
                                {
-                                       MOD_RESULT = 0;
-                                       FOREACH_RESULT_I(Instance,I_OnCheckBan,OnCheckBan(user, Ptr));
                                        char mask[MAXBUF];
-                                       sprintf(mask,"%s!%s@%s",user->nick, user->ident, user->GetIPString());
-                                       if (!MOD_RESULT)
+                                       snprintf(mask, MAXBUF, "%s!%s@%s",user->nick, user->ident, user->GetIPString());
+                                       if (Ptr->IsBanned(user))
                                        {
-                                               if (Ptr->IsBanned(user))
-                                               {
-                                                       user->WriteServ("474 %s %s :Cannot join channel (You're banned)",user->nick, Ptr->name);
-                                                       return NULL;
-                                               }
+                                               user->WriteServ("474 %s %s :Cannot join channel (You're banned)",user->nick, Ptr->name);
+                                               return NULL;
                                        }
                                }
                        }
@@ -331,14 +315,13 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                {
                        Instance->Log(DEBUG,"chanrec::JoinUser(): Overridden checks");
                }
-               created = 1;
        }
 
        for (UserChanList::const_iterator index = user->chans.begin(); index != user->chans.end(); index++)
        {
                if ((*index)->channel == NULL)
                {
-                       return chanrec::ForceChan(Instance, Ptr, *index, user, created);
+                       return chanrec::ForceChan(Instance, Ptr, *index, user, privs);
                }
        }
 
@@ -350,7 +333,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
        if (!IS_LOCAL(user)) /* was a check on fd < 0 */
        {
                ucrec* a = new ucrec();
-               chanrec* c = chanrec::ForceChan(Instance, Ptr,a,user,created);
+               chanrec* c = chanrec::ForceChan(Instance, Ptr, a, user, privs);
                user->chans.push_back(a);
                return c;
        }
@@ -360,7 +343,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
                if (user->chans.size() < OPERMAXCHANS)
                {
                        ucrec* a = new ucrec();
-                       chanrec* c = chanrec::ForceChan(Instance, Ptr,a,user,created);
+                       chanrec* c = chanrec::ForceChan(Instance, Ptr, a, user, privs);
                        user->chans.push_back(a);
                        return c;
                }
@@ -368,7 +351,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
 
        user->WriteServ("405 %s %s :You are on too many channels",user->nick, cname);
 
-       if (created == 2)
+       if (new_channel)
        {
                Instance->Log(DEBUG,"BLAMMO, Whacking channel.");
                /* Things went seriously pear shaped, so take this away. bwahaha. */
@@ -402,18 +385,30 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
        return NULL;
 }
 
-chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* user, int created)
+chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* user, const std::string &privs)
 {
-       if (created == 2)
-       {
-               /* first user in is given ops */
-               a->uc_modes = UCMODE_OP;
-               Ptr->AddOppedUser(user);
-               Ptr->SetPrefix(user, '@', OP_VALUE, true);
-       }
-       else
+       a->uc_modes = 0;
+
+       for (std::string::const_iterator x = privs.begin(); x != privs.end(); x++)
        {
-               a->uc_modes = 0;
+               const char status = *x;
+               switch (status)
+               {
+                       case '@':
+                               a->uc_modes |= UCMODE_OP;
+                       break;
+                       case '%':
+                               a->uc_modes |= UCMODE_HOP;
+                       break;
+                       case '+':
+                               a->uc_modes |= UCMODE_VOICE;
+                       break;
+               }
+               ModeHandler* mh = Instance->Modes->FindPrefix(status);
+               if (mh)
+               {
+                       Ptr->SetPrefix(user, status, mh->GetPrefixRank(), true);
+               }
        }
 
        a->channel = Ptr;
@@ -421,6 +416,11 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* u
        user->ModChannelCount(1);
        Ptr->WriteChannel(user,"JOIN :%s",Ptr->name);
 
+       /* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */
+       std::string ms = Instance->Modes->ModeString(user, Ptr);
+       if ((Ptr->GetUserCounter() > 1) && (ms.length()))
+               Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name, ms.c_str());
+
        /* Major improvement by Brain - we dont need to be calculating all this pointlessly for remote users */
        if (IS_LOCAL(user))
        {
@@ -438,18 +438,22 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* u
 bool chanrec::IsBanned(userrec* user)
 {
        char mask[MAXBUF];
-       sprintf(mask,"%s!%s@%s",user->nick, user->ident, user->GetIPString());
-       for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
+       int MOD_RESULT = 0;
+       FOREACH_RESULT_I(Instance,I_OnCheckBan,OnCheckBan(user, Ptr));
+       if (!MOD_RESULT)
        {
-               /* This allows CIDR ban matching
-                * 
-                *        Full masked host                      Full unmasked host                   IP with/without CIDR
-                */
-               if ((match(user->GetFullHost(),i->data)) || (match(user->GetFullRealHost(),i->data)) || (match(mask, i->data, true)))
+               snprintf(mask, MAXBUF, "%s!%s@%s", user->nick, user->ident, user->GetIPString());
+               for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
                {
-                       return true;
+                       /* This allows CIDR ban matching
+                        * 
+                        *        Full masked host                      Full unmasked host                   IP with/without CIDR
+                        */
+                       if ((match(user->GetFullHost(),i->data)) || (match(user->GetFullRealHost(),i->data)) || (match(mask, i->data, true)))
+                       {
+                               return true;
+                       }
                }
-
        }
        return false;
 }