This fixes a deletion error here, we were using new[] and not using delete[], but...

[user/henk/code/inspircd.git] / src / cmd_nick.cpp

diff --git a/src/cmd_nick.cpp b/src/cmd_nick.cpp
index 05a66cbfc5a0b86f372b2744f84d0887de3abf46..4eb439895f581d8ef8c5c7241b6239ea5fc6b7be 100644 (file)
--- a/src/cmd_nick.cpp
+++ b/src/cmd_nick.cpp
@@ -11,14 +11,11 @@
  * ---------------------------------------------------
  */
 
-#include "configreader.h"
-#include "users.h"
-#include "modules.h"
 #include "inspircd.h"
 #include "xline.h"
 #include "commands/cmd_nick.h"
 
-extern "C" command_t* init_command(InspIRCd* Instance)
+extern "C" DllExport command_t* init_command(InspIRCd* Instance)
 {
        return new cmd_nick(Instance);
 }
@@ -76,24 +73,17 @@ CmdResult cmd_nick::Handle (const char** parameters, int pcnt, userrec *user)
                 * the nickname too, we force a nickchange on the older user (Simply the one who was
                 * here first, no TS checks need to take place here)
                 */
-               userrec* InUse = ServerInstance->FindNick(parameters[0]);
-               if (InUse && (InUse != user) && (ServerInstance->IsNick(parameters[0])))
+               userrec* InUse = ServerInstance->FindNickOnly(parameters[0]);
+               if (InUse && (InUse != user) && ((ServerInstance->IsNick(parameters[0]) || allowinvalid)))
                {
                        if (InUse->registered != REG_ALL)
                        {
-                               /* change the nick of the older user to nnn-overruled,
-                                * where nnn is their file descriptor. We know this to be unique.
-                                * NOTE: We must do this and not quit the user, even though we do
-                                * not have UID support yet. This is because if we set this user
-                                * as quitting and then introduce the new user before the old one
-                                * has quit, then the user hash gets totally buggered.
-                                * (Yes, that is a technical term). -- Brain
+                               /* change the nick of the older user to its UUID
                                 */
-                               std::string changeback = ConvToStr(InUse->GetFd()) + "-overruled";
-                               InUse->WriteTo(InUse, "NICK %s", changeback.c_str());
+                               InUse->WriteTo(InUse, "NICK %s", InUse->uuid);
                                InUse->WriteServ("433 %s %s :Nickname overruled.", InUse->nick, InUse->nick);
-                               InUse->UpdateNickHash(changeback.c_str());
-                               strlcpy(InUse->nick, changeback.c_str(), NICKMAX - 1);
+                               InUse->UpdateNickHash(InUse->uuid);
+                               strlcpy(InUse->nick, InUse->uuid, NICKMAX - 1);
                                InUse->InvalidateCache();
                                /* Take away their nickname-sent state forcing them to send a nick again */
                                InUse->registered &= ~REG_NICK;
@@ -105,24 +95,23 @@ CmdResult cmd_nick::Handle (const char** parameters, int pcnt, userrec *user)
                        }
                }
        }
-       if ((!ServerInstance->IsNick(parameters[0])) && (IS_LOCAL(user)))
+       if (((!ServerInstance->IsNick(parameters[0]))) && (IS_LOCAL(user)))
        {
-               user->WriteServ("432 %s %s :Erroneous Nickname",user->nick,parameters[0]);
-               return CMD_FAILURE;
-       }
-
-       if (user->registered == REG_ALL)
-       {
-               int MOD_RESULT = 0;
-               FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
-               if (MOD_RESULT) {
-                       // if a module returns true, the nick change is silently forbidden.
+               if (!allowinvalid)
+               {
+                       user->WriteServ("432 %s %s :Erroneous Nickname",user->nick,parameters[0]);
                        return CMD_FAILURE;
                }
+       }
 
-               user->WriteCommon("NICK %s",parameters[0]);
+       int MOD_RESULT = 0;
+       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
+       if (MOD_RESULT)
+               // if a module returns true, the nick change is silently forbidden.
+               return CMD_FAILURE;
 
-       }
+       if (user->registered == REG_ALL)
+               user->WriteCommon("NICK %s",parameters[0]);
 
        strlcpy(oldnick, user->nick, NICKMAX - 1);
 
@@ -130,13 +119,24 @@ CmdResult cmd_nick::Handle (const char** parameters, int pcnt, userrec *user)
        user = user->UpdateNickHash(parameters[0]);
 
        /* actually change the nick within the record */
-       if (!user) return CMD_FAILURE;
-       if (!*user->nick) return CMD_FAILURE;
+       if (!user)
+               return CMD_FAILURE;
+       if (!*user->nick)
+               return CMD_FAILURE;
 
        strlcpy(user->nick, parameters[0], NICKMAX - 1);
 
        user->InvalidateCache();
 
+       /* Update display nicks */
+       for (UCListIter v = user->chans.begin(); v != user->chans.end(); v++)
+       {
+               CUList* ulist = v->first->GetUsers();
+               CUList::iterator i = ulist->find(user);
+               if (i != ulist->end())
+                       i->second = user->nick;
+       }
+
        if (user->registered < REG_NICKUSER)
        {
                user->registered = (user->registered | REG_NICK);
@@ -178,3 +178,9 @@ CmdResult cmd_nick::Handle (const char** parameters, int pcnt, userrec *user)
 
 }
 
+CmdResult cmd_nick::HandleInternal(const unsigned int id, const std::deque<classbase*> &parameters)
+{
+       allowinvalid = (id != 0);
+       return CMD_SUCCESS;
+}
+