]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/cmd_oper.cpp
Change to use std::string::iterator rather than making a copy of the pointer and...
[user/henk/code/inspircd.git] / src / cmd_oper.cpp
index 6fd610322222cf59a4670340606381d1c658c27c..af0ad838b5bea24b3d03df2f455195ea7be96894 100644 (file)
@@ -2,39 +2,22 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                       E-mail:
- *                <brain@chatspike.net>
- *                <Craig@chatspike.net>
+ *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
  *
- * Written by Craig Edwards, Craig McLure, and others.
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-#include <string>
-#include <sstream>
-#include <vector>
-#include "inspircd_config.h"
 #include "configreader.h"
 #include "typedefs.h"
 #include "users.h"
-#include "globals.h"
 #include "modules.h"
-#include "dynamic.h"
 #include "wildcard.h"
-#include "commands.h"
-#include "mode.h"
-#include "xline.h"
-#include "inspstring.h"
-
-#include "hashcomp.h"
-#include "socketengine.h"
-
-#include "command_parse.h"
 #include "commands/cmd_oper.h"
+#include "hashcomp.h"
 
 bool OneOfMatches(const char* host, const char* ip, const char* hostlist)
 {
@@ -50,7 +33,12 @@ bool OneOfMatches(const char* host, const char* ip, const char* hostlist)
        return false;
 }
 
-void cmd_oper::Handle (const char** parameters, int pcnt, userrec *user)
+extern "C" command_t* init_command(InspIRCd* Instance)
+{
+       return new cmd_oper(Instance);
+}
+
+CmdResult cmd_oper::Handle (const char** parameters, int pcnt, userrec *user)
 {
        char LoginName[MAXBUF];
        char Password[MAXBUF];
@@ -61,7 +49,11 @@ void cmd_oper::Handle (const char** parameters, int pcnt, userrec *user)
        char TheIP[MAXBUF];
        int j;
        bool found = false;
-       bool fail2 = false;
+       bool type_invalid = false;
+
+       bool match_login = false;
+       bool match_pass = false;
+       bool match_hosts = false;
 
        snprintf(TheHost,MAXBUF,"%s@%s",user->ident,user->host);
        snprintf(TheIP, MAXBUF,"%s@%s",user->ident,user->GetIPString());
@@ -73,9 +65,13 @@ void cmd_oper::Handle (const char** parameters, int pcnt, userrec *user)
                ServerInstance->Config->ConfValue(ServerInstance->Config->config_data, "oper", "type", i, OperType, MAXBUF);
                ServerInstance->Config->ConfValue(ServerInstance->Config->config_data, "oper", "host", i, HostName, MAXBUF);
 
-               if ((!strcmp(LoginName,parameters[0])) && (!ServerInstance->OperPassCompare(Password,parameters[1])) && (OneOfMatches(TheHost,TheIP,HostName)))
+               match_login = !strcmp(LoginName,parameters[0]);
+               match_pass = !ServerInstance->OperPassCompare(Password,parameters[1], i);
+               match_hosts = OneOfMatches(TheHost,TheIP,HostName);
+
+               if (match_login && match_pass && match_hosts)
                {
-                       fail2 = true;
+                       type_invalid = true;
                        for (j =0; j < ServerInstance->Config->ConfValueEnum(ServerInstance->Config->config_data, "type"); j++)
                        {
                                ServerInstance->Config->ConfValue(ServerInstance->Config->config_data, "type","name", j, TypeName, MAXBUF);
@@ -89,41 +85,51 @@ void cmd_oper::Handle (const char** parameters, int pcnt, userrec *user)
                                        if (!ServerInstance->IsNick(TypeName))
                                        {
                                                user->WriteServ("491 %s :Invalid oper type (oper types must follow the same syntax as nicknames)",user->nick);
-                                               ServerInstance->WriteOpers("*** CONFIGURATION ERROR! Oper type invalid for OperType '%s'",OperType);
+                                               ServerInstance->SNO->WriteToSnoMask('o',"CONFIGURATION ERROR! Oper type '%s' contains invalid characters",OperType);
                                                ServerInstance->Log(DEFAULT,"OPER: Failed oper attempt by %s!%s@%s: credentials valid, but oper type erroneous.",user->nick,user->ident,user->host);
-                                               return;
+                                               return CMD_FAILURE;
                                        }
                                        found = true;
-                                       fail2 = false;
+                                       type_invalid = false;
                                        break;
                                }
                        }
                }
-               if (found)
+               if (match_login || found)
                        break;
        }
        if (found)
        {
                /* correct oper credentials */
-               ServerInstance->WriteOpers("*** %s (%s@%s) is now an IRC operator of type %s",user->nick,user->ident,user->host,OperType);
-               user->WriteServ("381 %s :You are now an IRC operator of type %s",user->nick,OperType);
+               ServerInstance->SNO->WriteToSnoMask('o',"%s (%s@%s) is now an IRC operator of type %s (using oper '%s')",user->nick,user->ident,user->host,irc::Spacify(OperType),parameters[0]);
+               user->WriteServ("381 %s :You are now an IRC operator of type %s",user->nick,irc::Spacify(OperType));
                if (!user->modes[UM_OPERATOR])
                        user->Oper(OperType);
        }
        else
        {
-               if (!fail2)
+               if (!type_invalid)
                {
+                       std::string fields = "";
+                       if (!match_login)
+                               fields.append("login ");
+                       if (!match_pass)
+                               fields.append("password ");
+                       if (!match_hosts)
+                               fields.append("hosts");
                        user->WriteServ("491 %s :Invalid oper credentials",user->nick);
-                       ServerInstance->WriteOpers("*** WARNING! Failed oper attempt by %s!%s@%s!",user->nick,user->ident,user->host);
-                       ServerInstance->Log(DEFAULT,"OPER: Failed oper attempt by %s!%s@%s: user, host or password did not match.",user->nick,user->ident,user->host);
+                       ServerInstance->SNO->WriteToSnoMask('o',"WARNING! Failed oper attempt by %s!%s@%s using login '%s': The following fields do not match: %s",user->nick,user->ident,user->host, parameters[0], fields.c_str());
+                       ServerInstance->Log(DEFAULT,"OPER: Failed oper attempt by %s!%s@%s using login '%s': The following fields did not match: %s",user->nick,user->ident,user->host,parameters[0],fields.c_str());
+                       return CMD_FAILURE;
                }
                else
                {
                        user->WriteServ("491 %s :Your oper block does not have a valid opertype associated with it",user->nick);
-                       ServerInstance->WriteOpers("*** CONFIGURATION ERROR! Oper block mismatch for OperType %s",OperType);
-                       ServerInstance->Log(DEFAULT,"OPER: Failed oper attempt by %s!%s@%s: credentials valid, but oper type nonexistent.",user->nick,user->ident,user->host);
+                       ServerInstance->SNO->WriteToSnoMask('o',"CONFIGURATION ERROR! Oper block '%s': missing OperType %s",parameters[0],OperType);
+                       ServerInstance->Log(DEFAULT,"OPER: Failed oper attempt by %s!%s@%s using login '%s': credentials valid, but oper type nonexistent.",user->nick,user->ident,user->host,parameters[0]);
+                       return CMD_FAILURE;
                }
        }
-       return;
+       return CMD_SUCCESS;
 }
+