Make the message when reloading a command fails more accurate, and fix reloading...

[user/henk/code/inspircd.git] / src / command_parse.cpp

diff --git a/src/command_parse.cpp b/src/command_parse.cpp
index 92428fd32b5842f32a3abf48f40edbdc6480c86f..409444e0c3db3493b6e397f4b44e5738e0341247 100644 (file)
--- a/src/command_parse.cpp
+++ b/src/command_parse.cpp
@@ -3,7 +3,7 @@
  *       +------------------------------------+
  *
  *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *         the file COPYING for details.
@@ -374,7 +374,7 @@ bool CommandParser::ProcessCommand(User *user, std::string &cmd)
                                                                                user->nick.c_str(), command.c_str());
                }
 
-               ServerInstance->SNO->WriteToSnoMask('d', "%s denied for %s (%s@%s)",
+               ServerInstance->SNO->WriteToSnoMask('t', "%s denied for %s (%s@%s)",
                                command.c_str(), user->nick.c_str(), user->ident.c_str(), user->host.c_str());
                return do_more;
        }
@@ -506,23 +506,20 @@ bool CommandParser::ReloadCommand(std::string cmd, User* user)
                cmdlist.erase(cmdlist.find(cmd));
 
                RFCCommands.erase(cmd);
-               std::transform(cmd.begin(), cmd.end(), cmd.begin(), ::tolower);
                delete cmdptr;
                dlclose(command->second);
-
-               snprintf(filename, MAXBUF, "cmd_%s.so", cmd.c_str());
-               const char* err = this->LoadCommand(filename);
-               if (err)
-               {
-                       if (user)
-                               user->WriteServ("NOTICE %s :*** Error loading 'cmd_%s.so': %s", user->nick.c_str(), cmd.c_str(), err);
-                       return false;
-               }
-
-               return true;
        }
 
-       return false;
+       std::transform(cmd.begin(), cmd.end(), cmd.begin(), ::tolower);
+       snprintf(filename, MAXBUF, "cmd_%s.so", cmd.c_str());
+       const char* err = this->LoadCommand(filename);
+       if (err)
+       {
+               if (user)
+                       user->WriteServ("NOTICE %s :*** Error loading '%s': %s", user->nick.c_str(), filename, err);
+               return false;
+       }
+       return true;
 }
 
 CmdResult CommandReload::Handle(const std::vector<std::string>& parameters, User *user)
@@ -539,7 +536,7 @@ CmdResult CommandReload::Handle(const std::vector<std::string>& parameters, User
        }
        else
        {
-               user->WriteServ("NOTICE %s :*** Could not reload command '%s' -- fix this problem, then /REHASH as soon as possible!", user->nick.c_str(), parameters[0].c_str());
+               user->WriteServ("NOTICE %s :*** Could not reload command '%s'. The command will not work until reloaded successfully.", user->nick.c_str(), parameters[0].c_str());
                return CMD_FAILURE;
        }
 }