]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/commands/cmd_nick.cpp
Fix for bug found by danieldg, where remote nicks were truncated to NICKMAX, but...
[user/henk/code/inspircd.git] / src / commands / cmd_nick.cpp
index 5a7ed846af4baf2183edf924d4a3aab870394bd8..4621a0a291c97343a675ab5b66e064283e102ee3 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -25,47 +25,97 @@ extern "C" DllExport Command* init_command(InspIRCd* Instance)
  * for the client introduction code in here, youre in the wrong place.
  * You need to look in the spanningtree module for this!
  */
-CmdResult CommandNick::Handle (const char** parameters, int, User *user)
+CmdResult CommandNick::Handle (const std::vector<std::string>& parameters, User *user)
 {
-       char oldnick[NICKMAX];
+       std::string oldnick;
 
-       if (!*parameters[0] || !*user->nick)
+       if (parameters[0].empty())
        {
                /* We cant put blanks in the parameters, so for this (extremely rare) issue we just put '*' here. */
-               user->WriteServ("432 %s * :Erroneous Nickname", *user->nick ? user->nick : "*");
+               user->WriteNumeric(432, "%s * :Erroneous Nickname", user->nick.empty() ? user->nick.c_str() : "*");
                return CMD_FAILURE;
        }
 
-       if (irc::string(user->nick) == irc::string(parameters[0]))
+       if (((!ServerInstance->IsNick(parameters[0].c_str(), ServerInstance->Config->Limits.NickMax))) && (IS_LOCAL(user)))
+       {
+               if (!allowinvalid)
+               {
+                       if (parameters[0] == "0")
+                       {
+                               // Special case, Fake a /nick UIDHERE. Useful for evading "ERR: NICK IN USE" on connect etc.
+                               std::vector<std::string> p2;
+                               std::deque<classbase*> dummy;
+                               p2.push_back(user->uuid);
+                               this->HandleInternal(1, dummy);
+                               this->Handle(p2, user);
+                               this->HandleInternal(0, dummy);
+                               return CMD_SUCCESS;
+                       }
+
+                       user->WriteNumeric(432, "%s %s :Erroneous Nickname", user->nick.c_str(),parameters[0].c_str());
+                       return CMD_FAILURE;
+               }
+       }
+
+       if (assign(user->nick) == parameters[0])
        {
                /* If its exactly the same, even case, dont do anything. */
-               if (!strcmp(user->nick,parameters[0]))
+               if (parameters[0] == user->nick)
+               {
                        return CMD_SUCCESS;
+               }
 
                /* Its a change of case. People insisted that they should be
                 * able to do silly things like this even though the RFC says
                 * the nick AAA is the same as the nick aaa.
                 */
-               strlcpy(oldnick, user->nick, NICKMAX - 1);
+               oldnick.assign(user->nick, 0, IS_LOCAL(user) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
                int MOD_RESULT = 0;
                FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
                if (MOD_RESULT)
                        return CMD_FAILURE;
                if (user->registered == REG_ALL)
-                       user->WriteCommon("NICK %s",parameters[0]);
-               strlcpy(user->nick, parameters[0], NICKMAX - 1);
+                       user->WriteCommon("NICK %s",parameters[0].c_str());
+               user->nick.assign(parameters[0], 0, IS_LOCAL(user) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
                user->InvalidateCache();
                FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(user,oldnick));
                return CMD_SUCCESS;
        }
        else
        {
-               XLine* mq = ServerInstance->XLines->MatchesLine("Q",parameters[0]);
-               if (mq)
+               /*
+                * Don't check Q:Lines if it's a server-enforced change, just on the off-chance some fucking *moron*
+                * tries to Q:Line SIDs, also, this means we just get our way period, as it really should be.
+                * Thanks Kein for finding this. -- w00t
+                *
+                * Also don't check Q:Lines for remote nickchanges, they should have our Q:Lines anyway to enforce themselves.
+                *              -- w00t
+                */
+               if (!allowinvalid || !IS_LOCAL(user))
                {
-                       ServerInstance->SNO->WriteToSnoMask('x', "Q-Lined nickname %s from %s!%s@%s: %s", parameters[0], user->nick, user->ident, user->host, mq->reason);
-                       user->WriteServ("432 %s %s :Invalid nickname: %s",user->nick,parameters[0], mq->reason);
-                       return CMD_FAILURE;
+                       XLine* mq = ServerInstance->XLines->MatchesLine("Q",parameters[0]);
+                       if (mq)
+                       {
+                               if (user->registered == REG_ALL)
+                               {
+                                       ServerInstance->SNO->WriteToSnoMask('x', "Q-Lined nickname %s from %s!%s@%s: %s", parameters[0].c_str(), user->nick.c_str(), user->ident.c_str(), user->host.c_str(), mq->reason);
+                               }
+                               user->WriteNumeric(432, "%s %s :Invalid nickname: %s",user->nick.c_str(), parameters[0].c_str(), mq->reason);
+                               return CMD_FAILURE;
+                       }
+
+                       if (ServerInstance->Config->RestrictBannedUsers)
+                       {
+                               for (UCListIter i = user->chans.begin(); i != user->chans.end(); i++)
+                               {
+                                       Channel *chan = i->first;
+                                       if (chan->GetStatus(user) < STATUS_VOICE && chan->IsBanned(user))
+                                       {
+                                               user->WriteNumeric(404, "%s %s :Cannot send to channel (you're banned)", user->nick.c_str(), chan->name.c_str());
+                                               return CMD_FAILURE;
+                                       }
+                               }
+                       }
                }
 
                /*
@@ -78,57 +128,47 @@ CmdResult CommandNick::Handle (const char** parameters, int, User *user)
                 * because the nick is already (rightfully) in use. -- w00t
                 */
                User* InUse = ServerInstance->FindNickOnly(parameters[0]);
-               if (InUse && (InUse != user) && ((ServerInstance->IsNick(parameters[0]) || allowinvalid)))
+               if (InUse && (InUse != user))
                {
                        if (InUse->registered != REG_ALL)
                        {
                                /* force the camper to their UUID, and ask them to re-send a NICK. */
-                               InUse->WriteTo(InUse, "NICK %s", InUse->uuid);
-                               InUse->WriteServ("433 %s %s :Nickname overruled.", InUse->nick, InUse->nick);
-                               InUse->UpdateNickHash(InUse->uuid);
-                               strlcpy(InUse->nick, InUse->uuid, NICKMAX - 1);
+                               InUse->WriteTo(InUse, "NICK %s", InUse->uuid.c_str());
+                               InUse->WriteNumeric(433, "%s %s :Nickname overruled.", InUse->nick.c_str(), InUse->nick.c_str());
+                               InUse->UpdateNickHash(InUse->uuid.c_str());
+                               InUse->nick.assign(InUse->uuid, 0, IS_LOCAL(InUse) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
                                InUse->InvalidateCache();
                                InUse->registered &= ~REG_NICK;
                        }
                        else
                        {
                                /* No camping, tell the incoming user  to stop trying to change nick ;p */
-                               user->WriteServ("433 %s %s :Nickname is already in use.", user->registered >= REG_NICK ? user->nick : "*", parameters[0]);
+                               user->WriteNumeric(433, "%s %s :Nickname is already in use.", user->registered >= REG_NICK ? user->nick.c_str() : "*", parameters[0].c_str());
                                return CMD_FAILURE;
                        }
                }
        }
-       if (((!ServerInstance->IsNick(parameters[0]))) && (IS_LOCAL(user)))
-       {
-               if (!allowinvalid)
-               {
-                       user->WriteServ("432 %s %s :Erroneous Nickname",user->nick,parameters[0]);
-                       return CMD_FAILURE;
-               }
-       }
+
 
        int MOD_RESULT = 0;
-       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
+       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user, parameters[0]));
        if (MOD_RESULT)
                // if a module returns true, the nick change is silently forbidden.
                return CMD_FAILURE;
 
        if (user->registered == REG_ALL)
-               user->WriteCommon("NICK %s",parameters[0]);
+               user->WriteCommon("NICK %s", parameters[0].c_str());
 
-       strlcpy(oldnick, user->nick, NICKMAX - 1);
+       oldnick.assign(user->nick, 0, IS_LOCAL(user) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
 
        /* change the nick of the user in the users_hash */
-       user = user->UpdateNickHash(parameters[0]);
+       user = user->UpdateNickHash(parameters[0].c_str());
 
        /* actually change the nick within the record */
        if (!user)
                return CMD_FAILURE;
-       if (!*user->nick)
-               return CMD_FAILURE;
-
-       strlcpy(user->nick, parameters[0], NICKMAX - 1);
 
+       user->nick.assign(parameters[0], 0, IS_LOCAL(user) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
        user->InvalidateCache();
 
        /* Update display nicks */
@@ -144,7 +184,10 @@ CmdResult CommandNick::Handle (const char** parameters, int, User *user)
        {
                user->registered = (user->registered | REG_NICK);
        }
-       else if (user->registered == REG_NICKUSER)
+
+       // Keep these seperate!
+
+       if (user->registered == REG_NICKUSER)
        {
                /* user is registered now, bit 0 = USER command, bit 1 = sent a NICK command */
                MOD_RESULT = 0;
@@ -155,7 +198,7 @@ CmdResult CommandNick::Handle (const char** parameters, int, User *user)
        else if (user->registered == REG_ALL)
        {
                user->IncreasePenalty(10);
-               FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(user,oldnick));
+               FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(user, oldnick));
        }
 
        return CMD_SUCCESS;