]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/commands/cmd_who.cpp
Remove channel argument from OnSendWhoLine, this information is already available...
[user/henk/code/inspircd.git] / src / commands / cmd_who.cpp
index a0eeaac3d04d9693c3b472ac282489911c8d4df3..5f4f08717c9c1dda561048f04a317597df4b8223 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
  * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
@@ -23,7 +23,6 @@ class CommandWho : public Command
        bool CanView(Channel* chan, User* user);
        bool opt_viewopersonly;
        bool opt_showrealhost;
-       bool opt_unlimit;
        bool opt_realname;
        bool opt_mode;
        bool opt_ident;
@@ -37,8 +36,10 @@ class CommandWho : public Command
  public:
        /** Constructor for who.
         */
-       CommandWho ( Module* parent) : Command(parent,"WHO", 1) { Penalty = 2; syntax = "<server>|<nickname>|<channel>|<realname>|<host>|0 [ohurmMiaplf]"; }
-       void SendWhoLine(User* user, const std::string &initial, Channel* ch, User* u, std::vector<std::string> &whoresults);
+       CommandWho ( Module* parent) : Command(parent,"WHO", 1) {
+               syntax = "<server>|<nickname>|<channel>|<realname>|<host>|0 [ohurmMiaplf]";
+       }
+       void SendWhoLine(User* user, const std::vector<std::string>& parms, const std::string &initial, Channel* ch, User* u, std::vector<std::string> &whoresults);
        /** Handle command.
         * @param parameters The parameters to the comamnd
         * @param pcnt The number of parameters passed to teh command
@@ -50,19 +51,16 @@ class CommandWho : public Command
 };
 
 
-static const std::string star = "*";
-
-static const std::string& get_first_visible_channel(User *u)
+static Channel* get_first_visible_channel(User *u)
 {
        UCListIter i = u->chans.begin();
        while (i != u->chans.end())
        {
                Channel* c = *i++;
                if (!c->IsModeSet('s'))
-                       return c->name;
+                       return c;
        }
-
-       return star;
+       return NULL;
 }
 
 bool CommandWho::whomatch(User* cuser, User* user, const char* matchtext)
@@ -109,7 +107,7 @@ bool CommandWho::whomatch(User* cuser, User* user, const char* matchtext)
                        match = false;
                        const Extensible::ExtensibleStore& list = user->GetExtList();
                        for(Extensible::ExtensibleStore::const_iterator i = list.begin(); i != list.end(); ++i)
-                               if (InspIRCd::Match(i->first->key, matchtext))
+                               if (InspIRCd::Match(i->first->name, matchtext))
                                        match = true;
                }
                else if (opt_realname)
@@ -123,7 +121,7 @@ bool CommandWho::whomatch(User* cuser, User* user, const char* matchtext)
                        irc::portparser portrange(matchtext, false);
                        long portno = -1;
                        while ((portno = portrange.GetToken()))
-                               if (portno == user->GetServerPort())
+                               if (IS_LOCAL(user) && portno == IS_LOCAL(user)->GetServerPort())
                                {
                                        match = true;
                                        break;
@@ -161,8 +159,6 @@ bool CommandWho::whomatch(User* cuser, User* user, const char* matchtext)
        }
 }
 
-
-
 bool CommandWho::CanView(Channel* chan, User* user)
 {
        if (!user || !chan)
@@ -183,14 +179,19 @@ bool CommandWho::CanView(Channel* chan, User* user)
        return false;
 }
 
-void CommandWho::SendWhoLine(User* user, const std::string &initial, Channel* ch, User* u, std::vector<std::string> &whoresults)
+void CommandWho::SendWhoLine(User* user, const std::vector<std::string>& parms, const std::string &initial, Channel* ch, User* u, std::vector<std::string> &whoresults)
 {
-       const std::string& lcn = get_first_visible_channel(u);
-       Channel* chlast = ServerInstance->FindChan(lcn);
+       if (!ch)
+               ch = get_first_visible_channel(u);
 
-       std::string wholine =   initial + (ch ? ch->name : lcn) + " " + u->ident + " " + (opt_showrealhost ? u->host : u->dhost) + " " +
-                               ((!ServerInstance->Config->HideWhoisServer.empty() && !user->HasPrivPermission("servers/auspex")) ? ServerInstance->Config->HideWhoisServer : u->server) +
-                               " " + u->nick + " ";
+       std::string wholine = initial + (ch ? ch->name : "*") + " " + u->ident + " " +
+               (opt_showrealhost ? u->host : u->dhost) + " ";
+       if (!ServerInstance->Config->HideWhoisServer.empty() && !user->HasPrivPermission("servers/auspex"))
+               wholine.append(ServerInstance->Config->HideWhoisServer);
+       else
+               wholine.append(u->server);
+       
+       wholine.append(" " + u->nick + " ");
 
        /* away? */
        if (IS_AWAY(u))
@@ -205,12 +206,15 @@ void CommandWho::SendWhoLine(User* user, const std::string &initial, Channel* ch
        /* oper? */
        if (IS_OPER(u))
        {
-               wholine.append("*");
+               wholine.push_back('*');
        }
 
-       wholine = wholine + (ch ? ch->GetPrefixChar(u) : (chlast ? chlast->GetPrefixChar(u) : "")) + " :0 " + u->fullname;
+       if (ch)
+               wholine.append(ch->GetPrefixChar(u));
+
+       wholine.append(" :0 " + u->fullname);
 
-       FOREACH_MOD(I_OnSendWhoLine, OnSendWhoLine(user, u, ch, wholine));
+       FOREACH_MOD(I_OnSendWhoLine, OnSendWhoLine(user, parms, u, wholine));
 
        if (!wholine.empty())
                whoresults.push_back(wholine);
@@ -228,7 +232,6 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
        /* WHO options */
        opt_viewopersonly = false;
        opt_showrealhost = false;
-       opt_unlimit = false;
        opt_realname = false;
        opt_mode = false;
        opt_ident = false;
@@ -277,10 +280,6 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                        if (user->HasPrivPermission("users/auspex"))
                                                opt_showrealhost = true;
                                        break;
-                               case 'u':
-                                       if (user->HasPrivPermission("users/auspex"))
-                                               opt_unlimit = true;
-                                       break;
                                case 'r':
                                        opt_realname = true;
                                        break;
@@ -344,7 +343,7 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                                continue;
                                }
 
-                               SendWhoLine(user, initial, ch, i->first, whoresults);
+                               SendWhoLine(user, parameters, initial, ch, i->first, whoresults);
                        }
                }
        }
@@ -366,7 +365,7 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                                        continue;
                                        }
 
-                                       SendWhoLine(user, initial, NULL, oper, whoresults);
+                                       SendWhoLine(user, parameters, initial, NULL, oper, whoresults);
                                }
                        }
                }
@@ -382,25 +381,21 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                                        continue;
                                        }
 
-                                       SendWhoLine(user, initial, NULL, i->second, whoresults);
+                                       SendWhoLine(user, parameters, initial, NULL, i->second, whoresults);
                                }
                        }
                }
        }
        /* Send the results out */
-       if ((ServerInstance->Config->MaxWhoResults && (whoresults.size() <= (size_t)ServerInstance->Config->MaxWhoResults)) || opt_unlimit)
-       {
-               for (std::vector<std::string>::const_iterator n = whoresults.begin(); n != whoresults.end(); n++)
-                       user->WriteServ(*n);
-               user->WriteNumeric(315, "%s %s :End of /WHO list.",user->nick.c_str(), *parameters[0].c_str() ? parameters[0].c_str() : "*");
-               return CMD_SUCCESS;
-       }
-       else
-       {
-               /* BZZT! Too many results. */
-               user->WriteNumeric(315, "%s %s :Too many results",user->nick.c_str(), parameters[0].c_str());
-               return CMD_FAILURE;
-       }
+       for (std::vector<std::string>::const_iterator n = whoresults.begin(); n != whoresults.end(); n++)
+               user->WriteServ(*n);
+       user->WriteNumeric(315, "%s %s :End of /WHO list.",user->nick.c_str(), *parameters[0].c_str() ? parameters[0].c_str() : "*");
+
+       // Penalize the user a bit for large queries
+       // (add one unit of penalty per 200 results)
+       if (IS_LOCAL(user))
+               IS_LOCAL(user)->CommandFloodPenalty += whoresults.size() * 5;
+       return CMD_SUCCESS;
 }
 
 COMMAND_INIT(CommandWho)