]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/commands/cmd_who.cpp
ThreadEngine: remove excessive mutex use on thread creation
[user/henk/code/inspircd.git] / src / commands / cmd_who.cpp
index 7f4365204a85f91163363dcbe3d6413e26af4ad5..718eb20020b3078e6d0f24d1b214ffe99493d547 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *         the file COPYING for details.
  */
 
 #include "inspircd.h"
-#include "wildcard.h"
 #include "commands/cmd_who.h"
 
-static const char *get_first_visible_channel(User *u)
+static const std::string star = "*";
+
+static const std::string& get_first_visible_channel(User *u)
 {
        UCListIter i = u->chans.begin();
        if (i != u->chans.end())
@@ -24,18 +25,13 @@ static const char *get_first_visible_channel(User *u)
                        return i->first->name;
        }
 
-       return "*";
+       return star;
 }
 
 bool CommandWho::whomatch(User* user, const char* matchtext)
 {
-       bool realhost = false;
-       bool realname = false;
-       bool positive = true;
-       bool metadata = false;
-       bool ident = false;
-       bool away = false;
-       bool port = false;
+       bool match = false;
+       bool positive = false;
        char* dummy = NULL;
 
        if (user->registered != REG_ALL)
@@ -67,41 +63,58 @@ bool CommandWho::whomatch(User* user, const char* matchtext)
        }
        else
        {
-
+               /*
+                * This was previously one awesome pile of ugly nested if, when really, it didn't need
+                * to be, since only one condition was ever checked, a chained if works just fine.
+                * -- w00t
+                */
                if (opt_metadata)
-                       metadata = user->GetExt(matchtext, dummy);
-               else
+                       match = user->GetExt(matchtext, dummy);
+               else if (opt_realname)
+                       match = InspIRCd::Match(user->fullname, matchtext);
+               else if (opt_showrealhost)
+                       match = InspIRCd::Match(user->host, matchtext, ascii_case_insensitive_map);
+               else if (opt_ident)
+                       match = InspIRCd::Match(user->ident, matchtext, ascii_case_insensitive_map);
+               else if (opt_port)
                {
-                       if (opt_realname)
-                               realname = match(user->fullname, matchtext);
-                       else
-                       {
-                               if (opt_showrealhost)
-                                       realhost = match(user->host, matchtext);
-                               else
+                       irc::portparser portrange(matchtext, false);
+                       long portno = -1;
+                       while ((portno = portrange.GetToken()))
+                               if (portno == user->GetPort())
                                {
-                                       if (opt_ident)
-                                               ident = match(user->ident, matchtext);
-                                       else
-                                       {
-                                               if (opt_port)
-                                               {
-                                                       irc::portparser portrange(matchtext, false);
-                                                       long portno = -1;
-                                                       while ((portno = portrange.GetToken()))
-                                                               if (portno == user->GetPort())
-                                                                       port = true;
-                                               }
-                                               else
-                                               {
-                                                       if (opt_away)
-                                                               away = match(user->awaymsg, matchtext);
-                                               }
-                                       }
+                                       match = true;
+                                       break;
                                }
-                       }
                }
-               return ((port) || (away) || (ident) || (metadata) || (realname) || (realhost) || (match(user->dhost, matchtext)) || (match(user->nick, matchtext)) || (match(user->server, matchtext)));
+               else if (opt_away)
+                       match = InspIRCd::Match(user->awaymsg, matchtext);
+               else if (opt_time)
+               {
+                       long seconds = ServerInstance->Duration(matchtext);
+
+                       // Okay, so time matching, we want all users connected `seconds' ago
+                       if (user->age >= ServerInstance->Time() - seconds)
+                               match = true;
+               }
+
+               /*
+                * Once the conditionals have been checked, only check dhost/nick/server
+                * if they didn't match this user -- and only match if we don't find a match.
+                *
+                * This should make things minutely faster, and again, less ugly.
+                * -- w00t
+                */
+               if (!match)
+                       match = InspIRCd::Match(user->dhost, matchtext, ascii_case_insensitive_map);
+
+               if (!match)
+                       match = InspIRCd::Match(user->nick, matchtext);
+
+               if (!match)
+                       match = InspIRCd::Match(user->server, matchtext);
+
+               return match;
        }
 }
 
@@ -123,7 +136,7 @@ bool CommandWho::CanView(Channel* chan, User* user)
        if (chan->HasUser(user))
                return true;
        /* Opers see all */
-       if (IS_OPER(user))
+       if (user->HasPrivPermission("users/auspex"))
                return true;
        /* Cant see inside a +s or a +p channel unless we are a member (see above) */
        else if (!chan->IsModeSet('s') && !chan->IsModeSet('p'))
@@ -138,11 +151,11 @@ void CommandWho::SendWhoLine(User* user, const std::string &initial, Channel* ch
        if (u->Visibility && !u->Visibility->VisibleTo(user))
                return;
 
-       std::string lcn = get_first_visible_channel(u);
+       const std::string& lcn = get_first_visible_channel(u);
        Channel* chlast = ServerInstance->FindChan(lcn);
 
        std::string wholine =   initial + (ch ? ch->name : lcn) + " " + u->ident + " " + (opt_showrealhost ? u->host : u->dhost) + " " +
-                               ((*ServerInstance->Config->HideWhoisServer && !IS_OPER(user)) ? ServerInstance->Config->HideWhoisServer : u->server) +
+                               ((*ServerInstance->Config->HideWhoisServer && !user->HasPrivPermission("servers/auspex")) ? ServerInstance->Config->HideWhoisServer : u->server) +
                                " " + u->nick + " ";
 
        /* away? */
@@ -186,6 +199,7 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
        opt_away = false;
        opt_local = false;
        opt_far = false;
+       opt_time = false;
 
        Channel *ch = NULL;
        std::vector<std::string> whoresults;
@@ -223,39 +237,47 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                        {
                                case 'o':
                                        opt_viewopersonly = true;
-                               break;
+                                       break;
                                case 'h':
-                                       if (IS_OPER(user))
+                                       if (user->HasPrivPermission("users/auspex"))
                                                opt_showrealhost = true;
-                               break;
+                                       break;
                                case 'u':
-                                       if (IS_OPER(user))
+                                       if (user->HasPrivPermission("users/auspex"))
                                                opt_unlimit = true;
-                               break;
+                                       break;
                                case 'r':
                                        opt_realname = true;
-                               break;
+                                       break;
                                case 'm':
-                                       opt_mode = true;
-                               break;
+                                       if (user->HasPrivPermission("users/auspex"))
+                                               opt_mode = true;
+                                       break;
                                case 'M':
-                                       opt_metadata = true;
-                               break;
+                                       if (user->HasPrivPermission("users/auspex"))
+                                               opt_metadata = true;
+                                       break;
                                case 'i':
                                        opt_ident = true;
-                               break;
+                                       break;
                                case 'p':
-                                       opt_port = true;
-                               break;
+                                       if (user->HasPrivPermission("users/auspex"))
+                                               opt_port = true;
+                                       break;
                                case 'a':
                                        opt_away = true;
-                               break;
+                                       break;
                                case 'l':
-                                       opt_local = true;
-                               break;
+                                       if (user->HasPrivPermission("users/auspex") || !*ServerInstance->Config->HideWhoisServer)
+                                               opt_local = true;
+                                       break;
                                case 'f':
-                                       opt_far = true;
-                               break;
+                                       if (user->HasPrivPermission("users/auspex") || !*ServerInstance->Config->HideWhoisServer)
+                                               opt_far = true;
+                                       break;
+                               case 't':
+                                       opt_time = true;
+                                       break;
                        }
                }
        }
@@ -269,10 +291,10 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                if (CanView(ch,user))
                {
                        bool inside = ch->HasUser(user);
-       
+
                        /* who on a channel. */
                        CUList *cu = ch->GetUsers();
-       
+
                        for (CUList::iterator i = cu->begin(); i != cu->end(); i++)
                        {
                                /* None of this applies if we WHO ourselves */
@@ -281,12 +303,12 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                        /* opers only, please */
                                        if (opt_viewopersonly && !IS_OPER(i->first))
                                                continue;
-       
+
                                        /* If we're not inside the channel, hide +i users */
-                                       if (i->first->IsModeSet('i') && !inside && !IS_OPER(user))
+                                       if (i->first->IsModeSet('i') && !inside && !user->HasPrivPermission("users/auspex"))
                                                continue;
                                }
-       
+
                                SendWhoLine(user, initial, ch, i->first, whoresults);
                        }
                }
@@ -305,7 +327,7 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                {
                                        if (!user->SharesChannelWith(oper))
                                        {
-                                               if (usingwildcards && (!oper->IsModeSet('i')) && (!IS_OPER(user)))
+                                               if (usingwildcards && (!oper->IsModeSet('i')) && (!user->HasPrivPermission("users/auspex")))
                                                        continue;
                                        }
 
@@ -321,7 +343,7 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                                {
                                        if (!user->SharesChannelWith(i->second))
                                        {
-                                               if (usingwildcards && (i->second->IsModeSet('i')) && (!IS_OPER(user)))
+                                               if (usingwildcards && (i->second->IsModeSet('i')) && (!user->HasPrivPermission("users/auspex")))
                                                        continue;
                                        }
 
@@ -345,4 +367,3 @@ CmdResult CommandWho::Handle (const std::vector<std::string>& parameters, User *
                return CMD_FAILURE;
        }
 }
-