/who tidyup - needs QA'ing

[user/henk/code/inspircd.git] / src / commands.cpp

diff --git a/src/commands.cpp b/src/commands.cpp
index aa43685d4c9e3b007bb7a47ca0e48462f4281503..c31885483df4d404922c8678747078575898e409 100644 (file)
--- a/src/commands.cpp
+++ b/src/commands.cpp
@@ -103,7 +103,6 @@ long InspIRCd::Duration(const char* str)
 
 bool InspIRCd::HostMatchesEveryone(const std::string &mask, userrec* user)
 {
-       char buffer[MAXBUF];
        char itrigger[MAXBUF];
        long matches = 0;
        
@@ -115,12 +114,15 @@ bool InspIRCd::HostMatchesEveryone(const std::string &mask, userrec* user)
        
        for (user_hash::iterator u = clientlist->begin(); u != clientlist->end(); u++)
        {
-               strlcpy(buffer,u->second->ident,MAXBUF);
-               charlcat(buffer,'@',MAXBUF);
-               strlcat(buffer,u->second->host,MAXBUF);
-               if (match(buffer,mask.c_str()))
+               if ((match(u->second->MakeHost(),mask.c_str(),true)) || (match(u->second->MakeHostIP(),mask.c_str(),true)))
+               {
                        matches++;
+               }
        }
+
+       if (!matches)
+               return false;
+
        float percent = ((float)matches / (float)clientlist->size()) * 100;
        if (percent > (float)atof(itrigger))
        {
@@ -146,7 +148,10 @@ bool InspIRCd::IPMatchesEveryone(const std::string &ip, userrec* user)
                if (match(u->second->GetIPString(),ip.c_str(),true))
                        matches++;
        }
-       
+
+       if (!matches)
+               return false;
+
        float percent = ((float)matches / (float)clientlist->size()) * 100;
        if (percent > (float)atof(itrigger))
        {
@@ -172,7 +177,10 @@ bool InspIRCd::NickMatchesEveryone(const std::string &nick, userrec* user)
                if (match(u->second->nick,nick.c_str()))
                        matches++;
        }
-       
+
+       if (!matches)
+               return false;
+
        float percent = ((float)matches / (float)clientlist->size()) * 100;
        if (percent > (float)atof(itrigger))
        {