]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Refactor port binding, warning not yet tested fully
[user/henk/code/inspircd.git] / src / configreader.cpp
index 4124f9c87430cb4323f1900dd3412ef23e732b5f..1bc530b9b3c21f857bbe32fc8f104b7677c146de 100644 (file)
@@ -25,9 +25,9 @@ ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
 {
        this->ClearStack();
        *ServerName = *Network = *ServerDesc = *AdminName = '\0';
-       *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = '\0';
+       *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = *FixedQuit = *HideKillsServer = '\0';
        *CustomVersion = *motd = *rules = *PrefixQuit = *DieValue = *DNSServer = '\0';
-       *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = '\0';
+       *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = *SuffixQuit = '\0';
        WhoWasGroupSize = WhoWasMaxGroups = WhoWasMaxKeep = 0;
        log_file = NULL;
        NoUserDns = forcedebug = OperSpyWhois = nofork = HideBans = HideSplits = UndernetMsgPrefix = false;
@@ -39,6 +39,8 @@ ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
        MaxConn = SOMAXCONN;
        MaxWhoResults = 100;
        debugging = 0;
+       MaxChans = 20;
+       OperMaxChans = 30;
        LogLevel = DEFAULT;
        maxbans.clear();
 }
@@ -148,7 +150,7 @@ void ServerConfig::Send005(userrec* user)
 bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
 {
        int count = ConfValueEnum(this->config_data, tag);
-       
+
        if (count > 1)
        {
                throw CoreException("You have more than one <"+std::string(tag)+"> tag, this is not permitted.");
@@ -200,13 +202,13 @@ bool InitializeDisabledCommands(const char* data, InspIRCd* ServerInstance)
        std::string thiscmd;
 
        /* Enable everything first */
-       for (nspace::hash_map<std::string,command_t*>::iterator x = ServerInstance->Parser->cmdlist.begin(); x != ServerInstance->Parser->cmdlist.end(); x++)
+       for (command_table::iterator x = ServerInstance->Parser->cmdlist.begin(); x != ServerInstance->Parser->cmdlist.end(); x++)
                x->second->Disable(false);
 
        /* Now disable all the ones which the user wants disabled */
        while (dcmds >> thiscmd)
        {
-               nspace::hash_map<std::string,command_t*>::iterator cm = ServerInstance->Parser->cmdlist.find(thiscmd);
+               command_table::iterator cm = ServerInstance->Parser->cmdlist.find(thiscmd);
                if (cm != ServerInstance->Parser->cmdlist.end())
                {
                        cm->second->Disable(true);
@@ -256,7 +258,7 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, V
 bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
        /* If we already have a servername, and they changed it, we should throw an exception. */
-       if ((strcasecmp(conf->ServerName, data.GetString())) && (*conf->ServerName)) 
+       if ((strcasecmp(conf->ServerName, data.GetString())) && (*conf->ServerName))
        {
                throw CoreException("Configuration error: You cannot change your servername at runtime! Please restart your server for this change to be applied.");
                /* XXX: We don't actually reach this return of course... */
@@ -318,12 +320,27 @@ bool ValidateMotd(ServerConfig* conf, const char* tag, const char* value, ValueI
        return true;
 }
 
+bool ValidateNotEmpty(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+{
+       if (!*data.GetString())
+               throw CoreException(std::string("The value for ")+tag+" cannot be empty!");
+       return true;
+}
+
 bool ValidateRules(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
        conf->ReadFile(conf->RULES, data.GetString());
        return true;
 }
 
+bool ValidateModeLists(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+{
+       memset(conf->HideModeLists, 0, 256);
+       for (const unsigned char* x = (const unsigned char*)data.GetString(); *x; ++x)
+               conf->HideModeLists[*x] = true;
+       return true;
+}
+
 bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
        conf->WhoWasMaxKeep = conf->GetInstance()->Duration(data.GetString());
@@ -410,7 +427,8 @@ bool InitULine(ServerConfig* conf, const char* tag)
 bool DoULine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
 {
        const char* server = values[0].GetString();
-       conf->ulines.push_back(server);
+       const bool silent = values[1].GetBool();
+       conf->ulines[server] = silent;
        return true;
 }
 
@@ -521,9 +539,9 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                unsigned int prefixlen;
                start = 0;
                /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
-               prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
                if (user)
                {
+                       prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
                        user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick);
                        while (start < errors.length())
                        {
@@ -548,6 +566,7 @@ void ServerConfig::Read(bool bail, userrec* user)
 {
        static char debug[MAXBUF];      /* Temporary buffer for debugging value */
        static char maxkeep[MAXBUF];    /* Temporary buffer for WhoWasMaxKeep value */
+       static char hidemodes[MAXBUF];  /* Modes to not allow listing from users below halfop */
        int rem = 0, add = 0;           /* Number of modules added, number of modules removed */
        std::ostringstream errstr;      /* String stream containing the error output */
 
@@ -566,10 +585,12 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
                {"files",       "motd",         "",                     new ValueContainerChar (this->motd),                    DT_CHARPTR, ValidateMotd},
                {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR, ValidateRules},
-               {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR, NoValidation},      
+               {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR, ValidateNotEmpty},
                {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER, NoValidation},
-               {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR, NoValidation},
+               {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR, ValidateNotEmpty},
                {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR, NoValidation},
+               {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR, NoValidation},
+               {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR, NoValidation},
                {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR, ValidateLogLevel},
                {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER, ValidateNetBufferSize},
                {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER, ValidateMaxWho},
@@ -583,16 +604,22 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"options",     "hidesplits",   "0",                    new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN, NoValidation},
                {"options",     "hidebans",     "0",                    new ValueContainerBool (&this->HideBans),               DT_BOOLEAN, NoValidation},
                {"options",     "hidewhois",    "",                     new ValueContainerChar (this->HideWhoisServer),         DT_CHARPTR, NoValidation},
+               {"options", "hidekills",    "",         new ValueContainerChar (this->HideKillsServer),     DT_CHARPTR, NoValidation},
                {"options",     "operspywhois", "0",                    new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN, NoValidation},
                {"options",     "nouserdns",    "0",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN, NoValidation},
                {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
                {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
                {"options",     "ircumsgprefix","0",                    new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN, NoValidation},
+               {"options",     "announceinvites", "1",                 new ValueContainerBool (&this->AnnounceInvites),        DT_BOOLEAN, NoValidation},
+               {"options",     "hostintopic",  "1",                    new ValueContainerBool (&this->FullHostInTopic),        DT_BOOLEAN, NoValidation},
+               {"options",     "hidemodes",    "",                     new ValueContainerChar (hidemodes),                     DT_CHARPTR, ValidateModeLists},
                {"pid",         "file",         "",                     new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
                {"whowas",      "groupsize",    "10",                   new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
                {"whowas",      "maxgroups",    "10240",                new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER, NoValidation},
                {"whowas",      "maxkeep",      "3600",                 new ValueContainerChar (maxkeep),                       DT_CHARPTR, ValidateWhoWas},
                {"die",         "value",        "",                     new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
+               {"channels",    "users",        "20",                   new ValueContainerUInt (&this->MaxChans),               DT_INTEGER, NoValidation},
+               {"channels",    "opers",        "60",                   new ValueContainerUInt (&this->OperMaxChans),           DT_INTEGER, NoValidation},
                {NULL}
        };
 
@@ -603,17 +630,19 @@ void ServerConfig::Read(bool bail, userrec* user)
 
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
-                               "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    NULL},
+                               "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
+                               NULL},
                                {"",            "",             "",             "",             "120",          "",
-                                "",            "",             "",             "3",            "3",            NULL},
+                                "",            "",             "",             "3",            "3",            "0",
+                                NULL},
                                {DT_CHARPTR,    DT_CHARPTR,     DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                                DT_INTEGER,    DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER},
+                                DT_INTEGER,    DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER},
                                InitConnect, DoConnect, DoneConnect},
 
                {"uline",
-                               {"server",      NULL},
-                               {"",            NULL},
-                               {DT_CHARPTR},
+                               {"server",      "silent",       NULL},
+                               {"",            "0",            NULL},
+                               {DT_CHARPTR,    DT_BOOLEAN},
                                InitULine,DoULine,DoneULine},
 
                {"banlist",
@@ -670,14 +699,14 @@ void ServerConfig::Read(bool bail, userrec* user)
        include_stack.clear();
 
        /* Load and parse the config file, if there are any errors then explode */
-       
+
        /* Make a copy here so if it fails then we can carry on running with an unaffected config */
        ConfigDataHash newconfig;
-       
-       if (this->LoadConf(newconfig, CONFIG_FILE, errstr))
+
+       if (this->LoadConf(newconfig, ServerInstance->ConfigFileName, errstr))
        {
                /* If we succeeded, set the ircd config to the new one */
-               this->config_data = newconfig;  
+               this->config_data = newconfig;
        }
        else
        {
@@ -714,7 +743,8 @@ void ServerConfig::Read(bool bail, userrec* user)
                                case DT_CHARPTR:
                                {
                                        ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                       vcc->Set(vi.GetString(), strlen(vi.GetString()));
+                                       /* Make sure we also copy the null terminator */
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
                                }
                                break;
                                case DT_INTEGER:
@@ -735,7 +765,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                                        /* You don't want to know what happens if someones bad code sends us here. */
                                break;
                        }
-       
+
                        /* We're done with this now */
                        delete Values[Index].val;
                }
@@ -790,10 +820,10 @@ void ServerConfig::Read(bool bail, userrec* user)
                                                break;
                                        }
                                }
-       
+
                                MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
-       
+
                        MultiValues[Index].finish_function(this, MultiValues[Index].tag);
                }
 
@@ -816,12 +846,12 @@ void ServerConfig::Read(bool bail, userrec* user)
        {
                int found_ports = 0;
                FailedPortList pl;
-               ServerInstance->stats->BoundPortCount = ServerInstance->BindPorts(false, found_ports, pl);
+               ServerInstance->BindPorts(false, found_ports, pl);
 
                if (pl.size())
                {
                        user->WriteServ("NOTICE %s :*** Not all your client ports could be bound.", user->nick);
-                       user->WriteServ("NOTICE %s :*** The following port%s failed to bind:", user->nick, found_ports - ServerInstance->stats->BoundPortCount != 1 ? "s" : "");
+                       user->WriteServ("NOTICE %s :*** The following port(s) failed to bind:", user->nick);
                        int j = 1;
                        for (FailedPortList::iterator i = pl.begin(); i != pl.end(); i++, j++)
                        {
@@ -857,10 +887,10 @@ void ServerConfig::Read(bool bail, userrec* user)
                                if (ServerInstance->LoadModule(adding->c_str()))
                                {
                                        ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
-       
+
                                        if (user)
                                                user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
-       
+
                                        add++;
                                }
                                else
@@ -873,6 +903,11 @@ void ServerConfig::Read(bool bail, userrec* user)
 
                ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
        }
+
+       if (user)
+               user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
+       else
+               ServerInstance->WriteOpers("*** Successfully rehashed server.");
 }
 
 bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::ostringstream &errorstream)
@@ -884,22 +919,22 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
        bool in_tag;
        bool in_quote;
        bool in_comment;
-       
+
        linenumber = 1;
        in_tag = false;
        in_quote = false;
        in_comment = false;
-       
+
        /* Check if the file open failed first */
        if (!conf)
        {
                errorstream << "LoadConf: Couldn't open config file: " << filename << std::endl;
                return false;
        }
-       
+
        /* Fix the chmod of the file to restrict it to the current user and group */
        chmod(filename,0600);
-       
+
        for (unsigned int t = 0; t < include_stack.size(); t++)
        {
                if (std::string(filename) == include_stack[t])
@@ -908,11 +943,11 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        return false;
                }
        }
-       
+
        /* It's not already included, add it to the list of files we've loaded */
        include_stack.push_back(filename);
-       
-       /* Start reading characters... */       
+
+       /* Start reading characters... */
        while(conf.get(ch))
        {
                /*
@@ -923,16 +958,16 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                 * we get a '>' not inside quotes. If we find two '<' and
                 * no '>' then die with an error.
                 */
-               
+
                if((ch == '#') && !in_quote)
                        in_comment = true;
-               
+
                /*if(((ch == '\n') || (ch == '\r')) && in_quote)
                {
                        errorstream << "Got a newline within a quoted section, this is probably a typo: " << filename << ":" << linenumber << std::endl;
                        return false;
                }*/
-               
+
                switch(ch)
                {
                        case '\n':
@@ -947,7 +982,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        case '\t':
                                ch = ' ';
                }
-               
+
                if(in_comment)
                        continue;
 
@@ -979,7 +1014,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
 
                if (ch != '\r')
                        line += ch;
-               
+
                if(ch == '<')
                {
                        if(in_tag)
@@ -1044,10 +1079,10 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                         * If this finds an <include> then ParseLine can simply call
                                         * LoadConf() and load the included config into the same ConfigDataHash
                                         */
-                                       
+
                                        if(!this->ParseLine(target, line, linenumber, errorstream))
                                                return false;
-                                       
+
                                        line.clear();
                                }
                                else
@@ -1058,7 +1093,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                }
        }
-       
+
        return true;
 }
 
@@ -1076,17 +1111,17 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
        bool got_name;
        bool got_key;
        bool in_quote;
-       
+
        got_name = got_key = in_quote = false;
 
        //std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
-       
+
        for(std::string::iterator c = line.begin(); c != line.end(); c++)
        {
                if(!got_name)
                {
                        /* We don't know the tag name yet. */
-                       
+
                        if(*c != ' ')
                        {
                                if(*c != '<')
@@ -1161,16 +1196,16 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                                results.push_back(KeyVal(current_key, current_value));
 
                                                // std::cout << "<" << tagname << ":" << current_key << "> " << current_value << std::endl;
-                                               
+
                                                in_quote = false;
                                                got_key = false;
-                                               
+
                                                if((tagname == "include") && (current_key == "file"))
                                                {
                                                        if(!this->DoInclude(target, current_value, errorstream))
                                                                return false;
                                                }
-                                               
+
                                                current_key.clear();
                                                current_value.clear();
                                        }
@@ -1185,10 +1220,10 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                        }
                }
        }
-       
+
        /* Finished parsing the tag, add it to the config hash */
        target.insert(std::pair<std::string, KeyValList > (tagname, results));
-       
+
        return true;
 }
 
@@ -1197,10 +1232,10 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
        std::string confpath;
        std::string newfile;
        std::string::size_type pos;
-       
-       confpath = CONFIG_FILE;
+
+       confpath = ServerInstance->ConfigFileName;
        newfile = file;
-       
+
        for (std::string::iterator c = newfile.begin(); c != newfile.end(); c++)
        {
                if (*c == '\\')
@@ -1211,7 +1246,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
 
        if (file[0] != '/')
        {
-               if((pos = confpath.find("/inspircd.conf")) != std::string::npos)
+               if((pos = confpath.rfind("/")) != std::string::npos)
                {
                        /* Leaves us with just the path */
                        newfile = confpath.substr(0, pos) + std::string("/") + newfile;
@@ -1222,7 +1257,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
                        return false;
                }
        }
-       
+
        return LoadConf(target, newfile, errorstream);
 }
 
@@ -1288,7 +1323,7 @@ bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, con
        }
        return false;
 }
-       
+
 bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const char* tag, const char* var, int index, int &result)
 {
        return ConfValueInteger(target, std::string(tag), std::string(var), "", index, result);
@@ -1351,7 +1386,7 @@ bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const std::string &t
        return r;
 }
 
-       
+
 bool ServerConfig::ConfValueBool(ConfigDataHash &target, const char* tag, const char* var, int index)
 {
        return ConfValueBool(target, std::string(tag), std::string(var), "", index);
@@ -1372,10 +1407,10 @@ bool ServerConfig::ConfValueBool(ConfigDataHash &target, const std::string &tag,
        std::string result;
        if(!ConfValue(target, tag, var, default_value, index, result))
                return false;
-       
+
        return ((result == "yes") || (result == "true") || (result == "1"));
 }
-       
+
 int ServerConfig::ConfValueEnum(ConfigDataHash &target, const char* tag)
 {
        return target.count(tag);
@@ -1385,7 +1420,7 @@ int ServerConfig::ConfValueEnum(ConfigDataHash &target, const std::string &tag)
 {
        return target.count(tag);
 }
-       
+
 int ServerConfig::ConfVarEnum(ConfigDataHash &target, const char* tag, int index)
 {
        return ConfVarEnum(target, std::string(tag), index);
@@ -1394,17 +1429,17 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const char* tag, int index
 int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, int index)
 {
        ConfigDataHash::size_type pos = index;
-       
+
        if((pos >= 0) && (pos < target.count(tag)))
        {
                ConfigDataHash::const_iterator iter = target.find(tag);
-               
+
                for(int i = 0; i < index; i++)
                        iter++;
-               
+
                return iter->second.size();
        }
-       
+
        return 0;
 }
 
@@ -1419,21 +1454,27 @@ bool ServerConfig::ReadFile(file_cache &F, const char* fname)
        char linebuf[MAXBUF];
 
        F.clear();
-       
+
        if (*fname != '/')
        {
                std::string::size_type pos;
-               std::string confpath = CONFIG_FILE;
-               if((pos = confpath.find("/inspircd.conf")) != std::string::npos)
+               std::string confpath = ServerInstance->ConfigFileName;
+               if((pos = confpath.rfind("/")) != std::string::npos)
                {
                        /* Leaves us with just the path */
                        std::string newfile = confpath.substr(0, pos) + std::string("/") + fname;
+                       if (!FileExists(newfile.c_str()))
+                               return false;
                        file =  fopen(newfile.c_str(), "r");
-                       
+
                }
        }
        else
+       {
+               if (!FileExists(fname))
+                       return false;
                file =  fopen(fname, "r");
+       }
 
        if (file)
        {
@@ -1460,11 +1501,16 @@ bool ServerConfig::ReadFile(file_cache &F, const char* fname)
 
 bool ServerConfig::FileExists(const char* file)
 {
+       struct stat sb;
+       if (stat(file, &sb) == -1)
+               return false;
+
+       if ((sb.st_mode & S_IFDIR) > 0)
+               return false;
+            
        FILE *input;
        if ((input = fopen (file, "r")) == NULL)
-       {
                return false;
-       }
        else
        {
                fclose(input);
@@ -1482,12 +1528,12 @@ char* ServerConfig::CleanFilename(char* name)
 
 bool ServerConfig::DirValid(const char* dirandfile)
 {
-       char work[MAXBUF];
-       char buffer[MAXBUF];
-       char otherdir[MAXBUF];
+       char work[1024];
+       char buffer[1024];
+       char otherdir[1024];
        int p;
 
-       strlcpy(work, dirandfile, MAXBUF);
+       strlcpy(work, dirandfile, 1024);
        p = strlen(work);
 
        // we just want the dir
@@ -1503,13 +1549,13 @@ bool ServerConfig::DirValid(const char* dirandfile)
        }
 
        // Get the current working directory
-       if (getcwd(buffer, MAXBUF ) == NULL )
+       if (getcwd(buffer, 1024 ) == NULL )
                return false;
 
        if (chdir(work) == -1)
                return false;
 
-       if (getcwd(otherdir, MAXBUF ) == NULL )
+       if (getcwd(otherdir, 1024 ) == NULL )
                return false;
 
        if (chdir(buffer) == -1)
@@ -1536,12 +1582,12 @@ bool ServerConfig::DirValid(const char* dirandfile)
 
 std::string ServerConfig::GetFullProgDir(char** argv, int argc)
 {
-       char work[MAXBUF];
-       char buffer[MAXBUF];
-       char otherdir[MAXBUF];
+       char work[1024];
+       char buffer[1024];
+       char otherdir[1024];
        int p;
 
-       strlcpy(work,argv[0],MAXBUF);
+       strlcpy(work,argv[0],1024);
        p = strlen(work);
 
        // we just want the dir
@@ -1557,13 +1603,13 @@ std::string ServerConfig::GetFullProgDir(char** argv, int argc)
        }
 
        // Get the current working directory
-       if (getcwd(buffer, MAXBUF) == NULL)
+       if (getcwd(buffer, 1024) == NULL)
                return "";
 
        if (chdir(work) == -1)
                return "";
 
-       if (getcwd(otherdir, MAXBUF) == NULL)
+       if (getcwd(otherdir, 1024) == NULL)
                return "";
 
        if (chdir(buffer) == -1)