]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Add extra /map info (connection uptime, and lag time) to /MAP for opers. Adds feature...
[user/henk/code/inspircd.git] / src / configreader.cpp
index f7c867544c47c7606e8a783ec102a6bf4664f85c..26e9634d13c9c9f421c7fe503b1d5e4053dda0be 100644 (file)
@@ -2,14 +2,11 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                    E-mail:
- *             <brain@chatspike.net>
- *             <Craig@chatspike.net>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
+ *
  * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
@@ -19,6 +16,8 @@
 #include <fstream>
 #include "inspircd.h"
 #include "xline.h"
+#include "exitcodes.h"
+#include "commands/cmd_whowas.h"
 
 std::vector<std::string> old_module_names, new_module_names, added_modules, removed_modules;
 
@@ -26,11 +25,12 @@ ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
 {
        this->ClearStack();
        *ServerName = *Network = *ServerDesc = *AdminName = '\0';
-       *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = '\0';
+       *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = *FixedQuit = '\0';
        *CustomVersion = *motd = *rules = *PrefixQuit = *DieValue = *DNSServer = '\0';
-       *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = '\0';
+       *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = *SuffixQuit = '\0';
+       WhoWasGroupSize = WhoWasMaxGroups = WhoWasMaxKeep = 0;
        log_file = NULL;
-       NoUserDns = forcedebug = OperSpyWhois = nofork = HideBans = HideSplits = false;
+       NoUserDns = forcedebug = OperSpyWhois = nofork = HideBans = HideSplits = UndernetMsgPrefix = false;
        CycleHosts = writelog = AllowHalfop = true;
        dns_timeout = DieDelay = 5;
        MaxTargets = 20;
@@ -39,11 +39,10 @@ ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
        MaxConn = SOMAXCONN;
        MaxWhoResults = 100;
        debugging = 0;
+       MaxChans = 20;
+       OperMaxChans = 30;
        LogLevel = DEFAULT;
        maxbans.clear();
-       WhoWasGroupSize = 10;
-       WhoWasMaxGroups = WhoWasGroupSize * MAXCLIENTS;
-       WhoWasMaxKeep = 3600*24*3; // 3 days
 }
 
 void ServerConfig::ClearStack()
@@ -77,7 +76,7 @@ bool ServerConfig::AddIOHook(int port, Module* iomod)
        }
 }
 
-bool ServerConfig::AddIOHook(InspSocket* is, Module* iomod)
+bool ServerConfig::AddIOHook(Module* iomod, InspSocket* is)
 {
        if (!GetIOHook(is))
        {
@@ -114,52 +113,52 @@ bool ServerConfig::DelIOHook(InspSocket* is)
        return false;
 }
 
+void ServerConfig::Update005()
+{
+       std::stringstream out(data005);
+       std::string token;
+       std::string line5;
+       int token_counter = 0;
+       isupport.clear();
+       while (out >> token)
+       {
+               line5 = line5 + token + " ";
+               token_counter++;
+               if (token_counter >= 13)
+               {
+                       char buf[MAXBUF];
+                       snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
+                       isupport.push_back(buf);
+                       line5 = "";
+                       token_counter = 0;
+               }
+       }
+       if (!line5.empty())
+       {
+               char buf[MAXBUF];
+               snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
+               isupport.push_back(buf);
+       }
+}
+
+void ServerConfig::Send005(userrec* user)
+{
+       for (std::vector<std::string>::iterator line = ServerInstance->Config->isupport.begin(); line != ServerInstance->Config->isupport.end(); line++)
+               user->WriteServ("005 %s %s", user->nick, line->c_str());
+}
+
 bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
 {
        int count = ConfValueEnum(this->config_data, tag);
-       
+
        if (count > 1)
        {
-               if (bail)
-               {
-                       printf("There were errors in your configuration:\nYou have more than one <%s> tag, this is not permitted.\n",tag);
-                       InspIRCd::Exit(ERROR);
-               }
-               else
-               {
-                       if (user)
-                       {
-                               user->WriteServ("There were errors in your configuration:");
-                               user->WriteServ("You have more than one <%s> tag, this is not permitted.\n",tag);
-                       }
-                       else
-                       {
-                               ServerInstance->WriteOpers("There were errors in the configuration file:");
-                               ServerInstance->WriteOpers("You have more than one <%s> tag, this is not permitted.\n",tag);
-                       }
-               }
+               throw CoreException("You have more than one <"+std::string(tag)+"> tag, this is not permitted.");
                return false;
        }
        if (count < 1)
        {
-               if (bail)
-               {
-                       printf("There were errors in your configuration:\nYou have not defined a <%s> tag, this is required.\n",tag);
-                       InspIRCd::Exit(ERROR);
-               }
-               else
-               {
-                       if (user)
-                       {
-                               user->WriteServ("There were errors in your configuration:");
-                               user->WriteServ("You have not defined a <%s> tag, this is required.",tag);
-                       }
-                       else
-                       {
-                               ServerInstance->WriteOpers("There were errors in the configuration file:");
-                               ServerInstance->WriteOpers("You have not defined a <%s> tag, this is required.",tag);
-                       }
-               }
+               throw CoreException("You have not defined a <"+std::string(tag)+"> tag, this is required.");
                return false;
        }
        return true;
@@ -167,7 +166,6 @@ bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
 
 bool NoValidation(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       conf->GetInstance()->Log(DEBUG,"No validation for <%s:%s>",tag,value);
        return true;
 }
 
@@ -195,15 +193,6 @@ bool ValidateMaxConn(ServerConfig* conf, const char* tag, const char* value, Val
 {
        if (data.GetInteger() > SOMAXCONN)
                conf->GetInstance()->Log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
-       if (!data.GetInteger())
-               data.Set(SOMAXCONN);
-       return true;
-}
-
-bool ValidateDnsTimeout(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
-{
-       if (!data.GetInteger())
-               data.Set(5);
        return true;
 }
 
@@ -222,7 +211,6 @@ bool InitializeDisabledCommands(const char* data, InspIRCd* ServerInstance)
                nspace::hash_map<std::string,command_t*>::iterator cm = ServerInstance->Parser->cmdlist.find(thiscmd);
                if (cm != ServerInstance->Parser->cmdlist.end())
                {
-                       ServerInstance->Log(DEBUG,"Disabling command '%s'",cm->second->command.c_str());
                        cm->second->Disable(true);
                }
        }
@@ -267,16 +255,15 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, V
        return true;
 }
 
-bool ValidateModPath(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
-{
-       if (!*(data.GetString()))
-               data.Set(MOD_PATH);
-       return true;
-}
-
-
 bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
+       /* If we already have a servername, and they changed it, we should throw an exception. */
+       if ((strcasecmp(conf->ServerName, data.GetString())) && (*conf->ServerName))
+       {
+               throw CoreException("Configuration error: You cannot change your servername at runtime! Please restart your server for this change to be applied.");
+               /* XXX: We don't actually reach this return of course... */
+               return false;
+       }
        if (!strchr(data.GetString(),'.'))
        {
                conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
@@ -354,8 +341,14 @@ bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, Valu
                conf->WhoWasMaxKeep = 3600;
                conf->GetInstance()->Log(DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
        }
-       conf->GetInstance()->Log(DEBUG,"whowas:groupsize:%d maxgroups:%d maxkeep:%d",conf->WhoWasGroupSize,conf->WhoWasMaxGroups,conf->WhoWasMaxKeep);
-       irc::whowas::PruneWhoWas(conf->GetInstance(), conf->GetInstance()->Time());
+
+       command_t* whowas_command = conf->GetInstance()->Parser->GetHandler("WHOWAS");
+       if (whowas_command)
+       {
+               std::deque<classbase*> params;
+               whowas_command->HandleInternal(WHOWAS_PRUNE, params);
+       }
+
        return true;
 }
 
@@ -387,45 +380,13 @@ bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &v
 
        if (*allow)
        {
-               c.host = allow;
-               c.type = CC_ALLOW;
-               c.pass = password;
-               c.registration_timeout = timeout;
-               c.pingtime = pingfreq;
-               c.flood = flood;
-               c.threshold = threshold;
-               c.sendqmax = sendq;
-               c.recvqmax = recvq;
-               c.maxlocal = localmax;
-               c.maxglobal = globalmax;
-
-
-               if (c.maxlocal == 0)
-                       c.maxlocal = 3;
-               if (c.maxglobal == 0)
-                       c.maxglobal = 3;
-               if (c.threshold == 0)
-               {
-                       c.threshold = 1;
-                       c.flood = 999;
-                       conf->GetInstance()->Log(DEFAULT,"Warning: Connect allow line '%s' has no flood/threshold settings. Setting this tag to 999 lines in 1 second.",c.host.c_str());
-               }
-               if (c.sendqmax == 0)
-                       c.sendqmax = 262114;
-               if (c.recvqmax == 0)
-                       c.recvqmax = 4096;
-               if (c.registration_timeout == 0)
-                       c.registration_timeout = 90;
-               if (c.pingtime == 0)
-                       c.pingtime = 120;
+               ConnectClass c(timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax);
                conf->Classes.push_back(c);
        }
        else
        {
-               c.host = deny;
-               c.type = CC_DENY;
+               ConnectClass c(deny);
                conf->Classes.push_back(c);
-               conf->GetInstance()->Log(DEBUG,"Read connect class type DENY, host=%s",deny);
        }
 
        return true;
@@ -435,7 +396,6 @@ bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &v
  */
 bool DoneConnect(ServerConfig* conf, const char* tag)
 {
-       conf->GetInstance()->Log(DEBUG,"DoneConnect called for tag: %s",tag);
        return true;
 }
 
@@ -452,7 +412,6 @@ bool InitULine(ServerConfig* conf, const char* tag)
 bool DoULine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
 {
        const char* server = values[0].GetString();
-       conf->GetInstance()->Log(DEBUG,"Read ULINE '%s'",server);
        conf->ulines.push_back(server);
        return true;
 }
@@ -548,6 +507,45 @@ bool DoneMaxBans(ServerConfig* conf, const char* tag)
        return true;
 }
 
+void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, userrec* user)
+{
+       ServerInstance->Log(DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
+       if (bail)
+       {
+               /* Unneeded because of the ServerInstance->Log() aboive? */
+               printf("There were errors in your configuration:\n%s\n\n",errormessage.c_str());
+               InspIRCd::Exit(EXIT_STATUS_CONFIG);
+       }
+       else
+       {
+               std::string errors = errormessage;
+               std::string::size_type start;
+               unsigned int prefixlen;
+               start = 0;
+               /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
+               if (user)
+               {
+                       prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
+                       user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick);
+                       while (start < errors.length())
+                       {
+                               user->WriteServ("NOTICE %s :%s",user->nick, errors.substr(start, 510 - prefixlen).c_str());
+                               start += 510 - prefixlen;
+                       }
+               }
+               else
+               {
+                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       while (start < errors.length())
+                       {
+                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               start += 360;
+                       }
+               }
+               return;
+       }
+}
+
 void ServerConfig::Read(bool bail, userrec* user)
 {
        static char debug[MAXBUF];      /* Temporary buffer for debugging value */
@@ -560,42 +558,49 @@ void ServerConfig::Read(bool bail, userrec* user)
 
        /* These tags can occur ONCE or not at all */
        InitialConfig Values[] = {
-               {"options",             "softlimit",                    new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER, ValidateSoftLimit},
-               {"options",             "somaxconn",                    new ValueContainerInt  (&this->MaxConn),                DT_INTEGER, ValidateMaxConn},
-               {"server",              "name",                         new ValueContainerChar (this->ServerName),              DT_CHARPTR, ValidateServerName},
-               {"server",              "description",                  new ValueContainerChar (this->ServerDesc),              DT_CHARPTR, NoValidation},
-               {"server",              "network",                      new ValueContainerChar (this->Network),                 DT_CHARPTR, NoValidation},
-               {"admin",               "name",                         new ValueContainerChar (this->AdminName),               DT_CHARPTR, NoValidation},
-               {"admin",               "email",                        new ValueContainerChar (this->AdminEmail),              DT_CHARPTR, NoValidation},
-               {"admin",               "nick",                         new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
-               {"files",               "motd",                         new ValueContainerChar (this->motd),                    DT_CHARPTR, ValidateMotd},
-               {"files",               "rules",                        new ValueContainerChar (this->rules),                   DT_CHARPTR, ValidateRules},
-               {"power",               "diepass",                      new ValueContainerChar (this->diepass),                 DT_CHARPTR, NoValidation},      
-               {"power",               "pause",                        new ValueContainerInt  (&this->DieDelay),               DT_INTEGER, NoValidation},
-               {"power",               "restartpass",                  new ValueContainerChar (this->restartpass),             DT_CHARPTR, NoValidation},
-               {"options",             "prefixquit",                   new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR, NoValidation},
-               {"options",             "loglevel",                     new ValueContainerChar (debug),                         DT_CHARPTR, ValidateLogLevel},
-               {"options",             "netbuffersize",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER, ValidateNetBufferSize},
-               {"options",             "maxwho",                       new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER, ValidateMaxWho},
-               {"options",             "allowhalfop",                  new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN, NoValidation},
-               {"dns",                 "server",                       new ValueContainerChar (this->DNSServer),               DT_CHARPTR, ValidateDnsServer},
-               {"dns",                 "timeout",                      new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER, ValidateDnsTimeout},
-               {"options",             "moduledir",                    new ValueContainerChar (this->ModPath),                 DT_CHARPTR, ValidateModPath},
-               {"disabled",            "commands",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR, NoValidation},
-               {"options",             "userstats",                    new ValueContainerChar (this->UserStats),               DT_CHARPTR, NoValidation},
-               {"options",             "customversion",                new ValueContainerChar (this->CustomVersion),           DT_CHARPTR, NoValidation},
-               {"options",             "hidesplits",                   new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN, NoValidation},
-               {"options",             "hidebans",                     new ValueContainerBool (&this->HideBans),               DT_BOOLEAN, NoValidation},
-               {"options",             "hidewhois",                    new ValueContainerChar (this->HideWhoisServer),         DT_CHARPTR, NoValidation},
-               {"options",             "operspywhois",                 new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN, NoValidation},
-               {"options",             "nouserdns",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN, NoValidation},
-               {"options",             "syntaxhints",                  new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
-               {"options",             "cyclehosts",                   new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
-               {"pid",                 "file",                         new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
-               {"whowas",              "groupsize",                    new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
-               {"whowas",              "maxgroups",                    new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER, NoValidation},
-               {"whowas",              "maxkeep",                      new ValueContainerChar (maxkeep),                       DT_CHARPTR, ValidateWhoWas},
-               {"die",                 "value",                        new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
+               {"options",     "softlimit",    MAXCLIENTS_S,           new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER, ValidateSoftLimit},
+               {"options",     "somaxconn",    SOMAXCONN_S,            new ValueContainerInt  (&this->MaxConn),                DT_INTEGER, ValidateMaxConn},
+               {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_CHARPTR, ValidateServerName},
+               {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR, NoValidation},
+               {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_CHARPTR, NoValidation},
+               {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR, NoValidation},
+               {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR, NoValidation},
+               {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
+               {"files",       "motd",         "",                     new ValueContainerChar (this->motd),                    DT_CHARPTR, ValidateMotd},
+               {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR, ValidateRules},
+               {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR, NoValidation},
+               {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER, NoValidation},
+               {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR, NoValidation},
+               {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR, NoValidation},
+               {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR, NoValidation},
+               {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR, NoValidation},
+               {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR, ValidateLogLevel},
+               {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER, ValidateNetBufferSize},
+               {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER, ValidateMaxWho},
+               {"options",     "allowhalfop",  "0",                    new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN, NoValidation},
+               {"dns",         "server",       "",                     new ValueContainerChar (this->DNSServer),               DT_CHARPTR, ValidateDnsServer},
+               {"dns",         "timeout",      "5",                    new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER, NoValidation},
+               {"options",     "moduledir",    MOD_PATH,               new ValueContainerChar (this->ModPath),                 DT_CHARPTR, NoValidation},
+               {"disabled",    "commands",     "",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR, NoValidation},
+               {"options",     "userstats",    "",                     new ValueContainerChar (this->UserStats),               DT_CHARPTR, NoValidation},
+               {"options",     "customversion","",                     new ValueContainerChar (this->CustomVersion),           DT_CHARPTR, NoValidation},
+               {"options",     "hidesplits",   "0",                    new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN, NoValidation},
+               {"options",     "hidebans",     "0",                    new ValueContainerBool (&this->HideBans),               DT_BOOLEAN, NoValidation},
+               {"options",     "hidewhois",    "",                     new ValueContainerChar (this->HideWhoisServer),         DT_CHARPTR, NoValidation},
+               {"options",     "operspywhois", "0",                    new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN, NoValidation},
+               {"options",     "nouserdns",    "0",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN, NoValidation},
+               {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
+               {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
+               {"options",     "ircumsgprefix","0",                    new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN, NoValidation},
+               {"options",     "announceinvites", "1",                 new ValueContainerBool (&this->AnnounceInvites),        DT_BOOLEAN, NoValidation},
+               {"options",     "hostintopic",  "1",                    new ValueContainerBool (&this->FullHostInTopic),        DT_BOOLEAN, NoValidation},
+               {"pid",         "file",         "",                     new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
+               {"whowas",      "groupsize",    "10",                   new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
+               {"whowas",      "maxgroups",    "10240",                new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER, NoValidation},
+               {"whowas",      "maxkeep",      "3600",                 new ValueContainerChar (maxkeep),                       DT_CHARPTR, ValidateWhoWas},
+               {"die",         "value",        "",                     new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
+               {"channels",    "users",        "20",                   new ValueContainerUInt (&this->MaxChans),               DT_INTEGER, NoValidation},
+               {"channels",    "opers",        "60",                   new ValueContainerUInt (&this->OperMaxChans),           DT_INTEGER, NoValidation},
                {NULL}
        };
 
@@ -607,52 +612,63 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
                                "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    NULL},
+                               {"",            "",             "",             "",             "120",          "",
+                                "",            "",             "",             "3",            "3",            NULL},
                                {DT_CHARPTR,    DT_CHARPTR,     DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
                                 DT_INTEGER,    DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER},
                                InitConnect, DoConnect, DoneConnect},
 
                {"uline",
                                {"server",      NULL},
+                               {"",            NULL},
                                {DT_CHARPTR},
                                InitULine,DoULine,DoneULine},
 
                {"banlist",
                                {"chan",        "limit",        NULL},
+                               {"",            "",             NULL},
                                {DT_CHARPTR,    DT_INTEGER},
                                InitMaxBans, DoMaxBans, DoneMaxBans},
 
                {"module",
                                {"name",        NULL},
+                               {"",            NULL},
                                {DT_CHARPTR},
                                InitModule, DoModule, DoneModule},
 
                {"badip",
                                {"reason",      "ipmask",       NULL},
+                               {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoZLine, DoneXLine},
+                               InitXLine, DoZLine, DoneZLine},
 
                {"badnick",
                                {"reason",      "nick",         NULL},
+                               {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoQLine, DoneXLine},
+                               InitXLine, DoQLine, DoneQLine},
 
                {"badhost",
                                {"reason",      "host",         NULL},
+                               {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoKLine, DoneXLine},
+                               InitXLine, DoKLine, DoneKLine},
 
                {"exception",
                                {"reason",      "host",         NULL},
+                               {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoELine, DoneXLine},
+                               InitXLine, DoELine, DoneELine},
 
                {"type",
                                {"name",        "classes",      NULL},
+                               {"",            "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
                                InitTypes, DoType, DoneClassesAndTypes},
 
                {"class",
                                {"name",        "commands",     NULL},
+                               {"",            "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
                                InitClasses, DoClass, DoneClassesAndTypes},
 
@@ -662,154 +678,139 @@ void ServerConfig::Read(bool bail, userrec* user)
        include_stack.clear();
 
        /* Load and parse the config file, if there are any errors then explode */
-       
+
        /* Make a copy here so if it fails then we can carry on running with an unaffected config */
        ConfigDataHash newconfig;
-       
-       if (this->LoadConf(newconfig, CONFIG_FILE, errstr))
+
+       if (this->LoadConf(newconfig, ServerInstance->ConfigFileName, errstr))
        {
                /* If we succeeded, set the ircd config to the new one */
-               this->config_data = newconfig;  
+               this->config_data = newconfig;
        }
        else
        {
-               ServerInstance->Log(DEFAULT, "There were errors in your configuration:\n%s", errstr.str().c_str());
-
-               if (bail)
-               {
-                       /* Unneeded because of the ServerInstance->Log() aboive? */
-                       printf("There were errors in your configuration:\n%s",errstr.str().c_str());
-                       InspIRCd::Exit(ERROR);
-               }
-               else
-               {
-                       std::string errors = errstr.str();
-                       std::string::size_type start;
-                       unsigned int prefixlen;
-                       
-                       start = 0;
-                       /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
-                       prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
-       
-                       if (user)
-                       {
-                               user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick);
-                               
-                               while(start < errors.length())
-                               {
-                                       user->WriteServ("NOTICE %s :%s",user->nick, errors.substr(start, 510 - prefixlen).c_str());
-                                       start += 510 - prefixlen;
-                               }
-                       }
-                       else
-                       {
-                               ServerInstance->WriteOpers("There were errors in the configuration file:");
-                               
-                               while(start < errors.length())
-                               {
-                                       ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
-                                       start += 360;
-                               }
-                       }
-
-                       return;
-               }
+               ReportConfigError(errstr.str(), bail, user);
+               return;
        }
 
-       /* Check we dont have more than one of singular tags, or any of them missing
-        */
-       for (int Index = 0; Once[Index]; Index++)
-               if (!CheckOnce(Once[Index], bail, user))
-                       return;
-
-       /* Read the values of all the tags which occur once or not at all, and call their callbacks.
-        */
-       for (int Index = 0; Values[Index].tag; Index++)
+       /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
+       try
        {
-               char item[MAXBUF];
-               ConfValue(this->config_data, Values[Index].tag, Values[Index].value, 0, item, MAXBUF);
-               ValueItem vi(item);
-
-               Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi);
+               /* Check we dont have more than one of singular tags, or any of them missing
+                */
+               for (int Index = 0; Once[Index]; Index++)
+                       if (!CheckOnce(Once[Index], bail, user))
+                               return;
 
-               switch (Values[Index].datatype)
+               /* Read the values of all the tags which occur once or not at all, and call their callbacks.
+                */
+               for (int Index = 0; Values[Index].tag; Index++)
                {
-                       case DT_CHARPTR:
+                       char item[MAXBUF];
+                       int dt = Values[Index].datatype;
+                       bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
+                       dt &= ~DT_ALLOW_NEWLINE;
+
+                       ConfValue(this->config_data, Values[Index].tag, Values[Index].value, Values[Index].default_value, 0, item, MAXBUF, allow_newlines);
+                       ValueItem vi(item);
+
+                       if (!Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi))
+                               throw CoreException("One or more values in your configuration file failed to validate. Please see your ircd.log for more information.");
+
+                       switch (Values[Index].datatype)
+                       {
+                               case DT_CHARPTR:
                                {
                                        ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
                                        vcc->Set(vi.GetString(), strlen(vi.GetString()));
                                }
-                       break;
-                       case DT_INTEGER:
+                               break;
+                               case DT_INTEGER:
                                {
                                        int val = vi.GetInteger();
                                        ValueContainerInt* vci = (ValueContainerInt*)Values[Index].val;
                                        vci->Set(&val, sizeof(int));
                                }
-                       break;
-                       case DT_BOOLEAN:
+                               break;
+                               case DT_BOOLEAN:
                                {
                                        bool val = vi.GetBool();
                                        ValueContainerBool* vcb = (ValueContainerBool*)Values[Index].val;
                                        vcb->Set(&val, sizeof(bool));
                                }
-                       break;
-                       default:
-                               /* You don't want to know what happens if someones bad code sends us here. */
-                       break;
-               }
+                               break;
+                               default:
+                                       /* You don't want to know what happens if someones bad code sends us here. */
+                               break;
+                       }
 
-               /* We're done with this now */
-               delete Values[Index].val;
-       }
+                       /* We're done with this now */
+                       delete Values[Index].val;
+               }
 
-       /* Read the multiple-tag items (class tags, connect tags, etc)
-        * and call the callbacks associated with them. We have three
-        * callbacks for these, a 'start', 'item' and 'end' callback.
-        */
-       for (int Index = 0; MultiValues[Index].tag; Index++)
-       {
-               MultiValues[Index].init_function(this, MultiValues[Index].tag);
+               /* Read the multiple-tag items (class tags, connect tags, etc)
+                * and call the callbacks associated with them. We have three
+                * callbacks for these, a 'start', 'item' and 'end' callback.
+                */
+               for (int Index = 0; MultiValues[Index].tag; Index++)
+               {
+                       MultiValues[Index].init_function(this, MultiValues[Index].tag);
 
-               int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
+                       int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
 
-               for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
-               {
-                       ValueList vl;
-                       for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
+                       for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
                        {
-                               switch (MultiValues[Index].datatype[valuenum])
+                               ValueList vl;
+                               for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
                                {
-                                       case DT_CHARPTR:
+                                       int dt = MultiValues[Index].datatype[valuenum];
+                                       bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
+                                       dt &= ~DT_ALLOW_NEWLINE;
+
+                                       switch (dt)
+                                       {
+                                               case DT_CHARPTR:
                                                {
                                                        char item[MAXBUF];
-                                                       ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item, MAXBUF);
-                                                       vl.push_back(ValueItem(item));
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
                                                }
-                                       break;
-                                       case DT_INTEGER:
+                                               break;
+                                               case DT_INTEGER:
                                                {
-                                                       int item;
-                                                       ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item);
-                                                       vl.push_back(ValueItem(item));
+                                                       int item = 0;
+                                                       if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(0));
                                                }
-                                       break;
-                                       case DT_BOOLEAN:
+                                               break;
+                                               case DT_BOOLEAN:
                                                {
-                                                       bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum);
+                                                       bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum);
                                                        vl.push_back(ValueItem(item));
                                                }
-                                       break;
-                                       default:
-                                               /* Someone was smoking craq if we got here, and we're all gonna die. */
-                                       break;
+                                               break;
+                                               default:
+                                                       /* Someone was smoking craq if we got here, and we're all gonna die. */
+                                               break;
+                                       }
                                }
+
+                               MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
 
-                       MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
+                       MultiValues[Index].finish_function(this, MultiValues[Index].tag);
                }
 
-               MultiValues[Index].finish_function(this, MultiValues[Index].tag);
+       }
+
+       catch (CoreException &ce)
+       {
+               ReportConfigError(ce.GetReason(), bail, user);
+               return;
        }
 
        // write once here, to try it out and make sure its ok
@@ -864,10 +865,10 @@ void ServerConfig::Read(bool bail, userrec* user)
                                if (ServerInstance->LoadModule(adding->c_str()))
                                {
                                        ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
-       
+
                                        if (user)
                                                user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
-       
+
                                        add++;
                                }
                                else
@@ -880,6 +881,11 @@ void ServerConfig::Read(bool bail, userrec* user)
 
                ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
        }
+
+       if (user)
+               user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
+       else
+               ServerInstance->WriteOpers("*** Successfully rehashed server.");
 }
 
 bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::ostringstream &errorstream)
@@ -891,22 +897,22 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
        bool in_tag;
        bool in_quote;
        bool in_comment;
-       
+
        linenumber = 1;
        in_tag = false;
        in_quote = false;
        in_comment = false;
-       
+
        /* Check if the file open failed first */
        if (!conf)
        {
                errorstream << "LoadConf: Couldn't open config file: " << filename << std::endl;
                return false;
        }
-       
+
        /* Fix the chmod of the file to restrict it to the current user and group */
        chmod(filename,0600);
-       
+
        for (unsigned int t = 0; t < include_stack.size(); t++)
        {
                if (std::string(filename) == include_stack[t])
@@ -915,11 +921,11 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        return false;
                }
        }
-       
+
        /* It's not already included, add it to the list of files we've loaded */
        include_stack.push_back(filename);
-       
-       /* Start reading characters... */       
+
+       /* Start reading characters... */
        while(conf.get(ch))
        {
                /*
@@ -930,28 +936,31 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                 * we get a '>' not inside quotes. If we find two '<' and
                 * no '>' then die with an error.
                 */
-               
+
                if((ch == '#') && !in_quote)
                        in_comment = true;
-               
-               if(((ch == '\n') || (ch == '\r')) && in_quote)
+
+               /*if(((ch == '\n') || (ch == '\r')) && in_quote)
                {
                        errorstream << "Got a newline within a quoted section, this is probably a typo: " << filename << ":" << linenumber << std::endl;
                        return false;
-               }
-               
+               }*/
+
                switch(ch)
                {
                        case '\n':
+                               if (in_quote)
+                                       line += '\n';
                                linenumber++;
                        case '\r':
-                               in_comment = false;
+                               if (!in_quote)
+                                       in_comment = false;
                        case '\0':
                                continue;
                        case '\t':
                                ch = ' ';
                }
-               
+
                if(in_comment)
                        continue;
 
@@ -966,11 +975,9 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                if ((ch == '\\') && (in_quote) && (in_tag))
                {
                        line += ch;
-                       ServerInstance->Log(DEBUG,"Escape sequence in config line.");
                        char real_character;
                        if (conf.get(real_character))
                        {
-                               ServerInstance->Log(DEBUG,"Escaping %c", real_character);
                                if (real_character == 'n')
                                        real_character = '\n';
                                line += real_character;
@@ -983,8 +990,9 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                }
 
-               line += ch;
-               
+               if (ch != '\r')
+                       line += ch;
+
                if(ch == '<')
                {
                        if(in_tag)
@@ -1049,10 +1057,10 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                         * If this finds an <include> then ParseLine can simply call
                                         * LoadConf() and load the included config into the same ConfigDataHash
                                         */
-                                       
+
                                        if(!this->ParseLine(target, line, linenumber, errorstream))
                                                return false;
-                                       
+
                                        line.clear();
                                }
                                else
@@ -1063,7 +1071,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                }
        }
-       
+
        return true;
 }
 
@@ -1081,17 +1089,17 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
        bool got_name;
        bool got_key;
        bool in_quote;
-       
+
        got_name = got_key = in_quote = false;
-       
-       // std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
-       
+
+       //std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
+
        for(std::string::iterator c = line.begin(); c != line.end(); c++)
        {
                if(!got_name)
                {
                        /* We don't know the tag name yet. */
-                       
+
                        if(*c != ' ')
                        {
                                if(*c != '<')
@@ -1143,6 +1151,16 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                                current_value += *c;
                                        continue;
                                }
+                               else if ((*c == '\n') && (in_quote))
+                               {
+                                       /* Got a 'real' \n, treat it as part of the value */
+                                       current_value += '\n';
+                                       continue;
+                               }
+                               else if ((*c == '\r') && (in_quote))
+                                       /* Got a \r, drop it */
+                                       continue;
+
                                if (*c == '"')
                                {
                                        if (!in_quote)
@@ -1154,18 +1172,18 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                        {
                                                /* Leaving quotes, we have the value */
                                                results.push_back(KeyVal(current_key, current_value));
-                                               
+
                                                // std::cout << "<" << tagname << ":" << current_key << "> " << current_value << std::endl;
-                                               
+
                                                in_quote = false;
                                                got_key = false;
-                                               
+
                                                if((tagname == "include") && (current_key == "file"))
                                                {
                                                        if(!this->DoInclude(target, current_value, errorstream))
                                                                return false;
                                                }
-                                               
+
                                                current_key.clear();
                                                current_value.clear();
                                        }
@@ -1180,10 +1198,10 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                        }
                }
        }
-       
+
        /* Finished parsing the tag, add it to the config hash */
        target.insert(std::pair<std::string, KeyValList > (tagname, results));
-       
+
        return true;
 }
 
@@ -1192,10 +1210,10 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
        std::string confpath;
        std::string newfile;
        std::string::size_type pos;
-       
-       confpath = CONFIG_FILE;
+
+       confpath = ServerInstance->ConfigFileName;
        newfile = file;
-       
+
        for (std::string::iterator c = newfile.begin(); c != newfile.end(); c++)
        {
                if (*c == '\\')
@@ -1206,7 +1224,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
 
        if (file[0] != '/')
        {
-               if((pos = confpath.find("/inspircd.conf")) != std::string::npos)
+               if((pos = confpath.rfind("/")) != std::string::npos)
                {
                        /* Leaves us with just the path */
                        newfile = confpath.substr(0, pos) + std::string("/") + newfile;
@@ -1217,79 +1235,160 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
                        return false;
                }
        }
-       
+
        return LoadConf(target, newfile, errorstream);
 }
 
-bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length)
+bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length, bool allow_linefeeds)
+{
+       return ConfValue(target, tag, var, "", index, result, length, allow_linefeeds);
+}
+
+bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, const char* default_value, int index, char* result, int length, bool allow_linefeeds)
 {
        std::string value;
-       bool r = ConfValue(target, std::string(tag), std::string(var), index, value);
+       bool r = ConfValue(target, std::string(tag), std::string(var), std::string(default_value), index, value, allow_linefeeds);
        strlcpy(result, value.c_str(), length);
        return r;
 }
 
-bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, int index, std::string &result)
+bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, int index, std::string &result, bool allow_linefeeds)
+{
+       return ConfValue(target, tag, var, "", index, result, allow_linefeeds);
+}
+
+bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, const std::string &default_value, int index, std::string &result, bool allow_linefeeds)
 {
        ConfigDataHash::size_type pos = index;
        if((pos >= 0) && (pos < target.count(tag)))
        {
-               ConfigDataHash::const_iterator iter = target.find(tag);
-               
+               ConfigDataHash::iterator iter = target.find(tag);
+
                for(int i = 0; i < index; i++)
                        iter++;
-               
-               for(KeyValList::const_iterator j = iter->second.begin(); j != iter->second.end(); j++)
+
+               for(KeyValList::iterator j = iter->second.begin(); j != iter->second.end(); j++)
                {
                        if(j->first == var)
                        {
-                               result = j->second;
-                               return true;
+                               if ((!allow_linefeeds) && (j->second.find('\n') != std::string::npos))
+                               {
+                                       ServerInstance->Log(DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
+                                       for (std::string::iterator n = j->second.begin(); n != j->second.end(); n++)
+                                               if (*n == '\n')
+                                                       *n = ' ';
+                               }
+                               else
+                               {
+                                       result = j->second;
+                                       return true;
+                               }
                        }
                }
+               if (!default_value.empty())
+               {
+                       result = default_value;
+                       return true;
+               }
        }
        else if(pos == 0)
        {
-               ServerInstance->Log(DEBUG, "No <%s> tags in config file.", tag.c_str());
-       }
-       else
-       {
-               ServerInstance->Log(DEBUG, "ConfValue got an out-of-range index %d, there are only %d occurences of %s", pos, target.count(tag), tag.c_str());
+               if (!default_value.empty())
+               {
+                       result = default_value;
+                       return true;
+               }
        }
-       
        return false;
 }
-       
+
 bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const char* tag, const char* var, int index, int &result)
 {
-       return ConfValueInteger(target, std::string(tag), std::string(var), index, result);
+       return ConfValueInteger(target, std::string(tag), std::string(var), "", index, result);
+}
+
+bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const char* tag, const char* var, const char* default_value, int index, int &result)
+{
+       return ConfValueInteger(target, std::string(tag), std::string(var), std::string(default_value), index, result);
 }
 
 bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const std::string &tag, const std::string &var, int index, int &result)
+{
+       return ConfValueInteger(target, tag, var, "", index, result);
+}
+
+bool ServerConfig::ConfValueInteger(ConfigDataHash &target, const std::string &tag, const std::string &var, const std::string &default_value, int index, int &result)
 {
        std::string value;
        std::istringstream stream;
-       bool r = ConfValue(target, tag, var, index, value);
+       bool r = ConfValue(target, tag, var, default_value, index, value);
        stream.str(value);
        if(!(stream >> result))
                return false;
+       else
+       {
+               if (!value.empty())
+               {
+                       if (value.substr(0,2) == "0x")
+                       {
+                               char* endptr;
+
+                               value.erase(0,2);
+                               result = strtol(value.c_str(), &endptr, 16);
+
+                               /* No digits found */
+                               if (endptr == value.c_str())
+                                       return false;
+                       }
+                       else
+                       {
+                               char denominator = *(value.end() - 1);
+                               switch (toupper(denominator))
+                               {
+                                       case 'K':
+                                               /* Kilobytes -> bytes */
+                                               result = result * 1024;
+                                       break;
+                                       case 'M':
+                                               /* Megabytes -> bytes */
+                                               result = result * 1024 * 1024;
+                                       break;
+                                       case 'G':
+                                               /* Gigabytes -> bytes */
+                                               result = result * 1024 * 1024 * 1024;
+                                       break;
+                               }
+                       }
+               }
+       }
        return r;
 }
-       
+
+
 bool ServerConfig::ConfValueBool(ConfigDataHash &target, const char* tag, const char* var, int index)
 {
-       return ConfValueBool(target, std::string(tag), std::string(var), index);
+       return ConfValueBool(target, std::string(tag), std::string(var), "", index);
+}
+
+bool ServerConfig::ConfValueBool(ConfigDataHash &target, const char* tag, const char* var, const char* default_value, int index)
+{
+       return ConfValueBool(target, std::string(tag), std::string(var), std::string(default_value), index);
 }
 
 bool ServerConfig::ConfValueBool(ConfigDataHash &target, const std::string &tag, const std::string &var, int index)
+{
+       return ConfValueBool(target, tag, var, "", index);
+}
+
+bool ServerConfig::ConfValueBool(ConfigDataHash &target, const std::string &tag, const std::string &var, const std::string &default_value, int index)
 {
        std::string result;
-       if(!ConfValue(target, tag, var, index, result))
+       if(!ConfValue(target, tag, var, default_value, index, result))
                return false;
-       
+
        return ((result == "yes") || (result == "true") || (result == "1"));
 }
-       
+
 int ServerConfig::ConfValueEnum(ConfigDataHash &target, const char* tag)
 {
        return target.count(tag);
@@ -1299,7 +1398,7 @@ int ServerConfig::ConfValueEnum(ConfigDataHash &target, const std::string &tag)
 {
        return target.count(tag);
 }
-       
+
 int ServerConfig::ConfVarEnum(ConfigDataHash &target, const char* tag, int index)
 {
        return ConfVarEnum(target, std::string(tag), index);
@@ -1308,25 +1407,17 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const char* tag, int index
 int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, int index)
 {
        ConfigDataHash::size_type pos = index;
-       
+
        if((pos >= 0) && (pos < target.count(tag)))
        {
                ConfigDataHash::const_iterator iter = target.find(tag);
-               
+
                for(int i = 0; i < index; i++)
                        iter++;
-               
+
                return iter->second.size();
        }
-       else if(pos == 0)
-       {
-               ServerInstance->Log(DEBUG, "No <%s> tags in config file.", tag.c_str());
-       }
-       else
-       {
-               ServerInstance->Log(DEBUG, "ConfVarEnum got an out-of-range index %d, there are only %d occurences of %s", pos, target.count(tag), tag.c_str());
-       }
-       
+
        return 0;
 }
 
@@ -1334,25 +1425,34 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, in
  */
 bool ServerConfig::ReadFile(file_cache &F, const char* fname)
 {
+       if (!fname || !*fname)
+               return false;
+
        FILE* file = NULL;
        char linebuf[MAXBUF];
 
        F.clear();
-       
+
        if (*fname != '/')
        {
                std::string::size_type pos;
-               std::string confpath = CONFIG_FILE;
-               if((pos = confpath.find("/inspircd.conf")) != std::string::npos)
+               std::string confpath = ServerInstance->ConfigFileName;
+               if((pos = confpath.rfind("/")) != std::string::npos)
                {
                        /* Leaves us with just the path */
                        std::string newfile = confpath.substr(0, pos) + std::string("/") + fname;
+                       if (!FileExists(newfile.c_str()))
+                               return false;
                        file =  fopen(newfile.c_str(), "r");
-                       
+
                }
        }
        else
+       {
+               if (!FileExists(fname))
+                       return false;
                file =  fopen(fname, "r");
+       }
 
        if (file)
        {
@@ -1379,11 +1479,16 @@ bool ServerConfig::ReadFile(file_cache &F, const char* fname)
 
 bool ServerConfig::FileExists(const char* file)
 {
+       struct stat sb;
+       if (stat(file, &sb) == -1)
+               return false;
+
+       if ((sb.st_mode & S_IFDIR) > 0)
+               return false;
+            
        FILE *input;
        if ((input = fopen (file, "r")) == NULL)
-       {
                return false;
-       }
        else
        {
                fclose(input);
@@ -1401,12 +1506,12 @@ char* ServerConfig::CleanFilename(char* name)
 
 bool ServerConfig::DirValid(const char* dirandfile)
 {
-       char work[MAXBUF];
-       char buffer[MAXBUF];
-       char otherdir[MAXBUF];
+       char work[1024];
+       char buffer[1024];
+       char otherdir[1024];
        int p;
 
-       strlcpy(work, dirandfile, MAXBUF);
+       strlcpy(work, dirandfile, 1024);
        p = strlen(work);
 
        // we just want the dir
@@ -1422,13 +1527,13 @@ bool ServerConfig::DirValid(const char* dirandfile)
        }
 
        // Get the current working directory
-       if (getcwd(buffer, MAXBUF ) == NULL )
+       if (getcwd(buffer, 1024 ) == NULL )
                return false;
 
        if (chdir(work) == -1)
                return false;
 
-       if (getcwd(otherdir, MAXBUF ) == NULL )
+       if (getcwd(otherdir, 1024 ) == NULL )
                return false;
 
        if (chdir(buffer) == -1)
@@ -1455,12 +1560,12 @@ bool ServerConfig::DirValid(const char* dirandfile)
 
 std::string ServerConfig::GetFullProgDir(char** argv, int argc)
 {
-       char work[MAXBUF];
-       char buffer[MAXBUF];
-       char otherdir[MAXBUF];
+       char work[1024];
+       char buffer[1024];
+       char otherdir[1024];
        int p;
 
-       strlcpy(work,argv[0],MAXBUF);
+       strlcpy(work,argv[0],1024);
        p = strlen(work);
 
        // we just want the dir
@@ -1476,13 +1581,13 @@ std::string ServerConfig::GetFullProgDir(char** argv, int argc)
        }
 
        // Get the current working directory
-       if (getcwd(buffer, MAXBUF) == NULL)
+       if (getcwd(buffer, 1024) == NULL)
                return "";
 
        if (chdir(work) == -1)
                return "";
 
-       if (getcwd(otherdir, MAXBUF) == NULL)
+       if (getcwd(otherdir, 1024) == NULL)
                return "";
 
        if (chdir(buffer) == -1)
@@ -1535,6 +1640,8 @@ void ValueItem::Set(int value)
 
 int ValueItem::GetInteger()
 {
+       if (v.empty())
+               return 0;
        return atoi(v.c_str());
 }