]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Add capability for m_services_account to broadcast login events, with the user who...
[user/henk/code/inspircd.git] / src / configreader.cpp
index eff49307c9c4b08e1ea29d957298927b630c6c58..45574a5319bcf9d3d470e5d0af14416ccd1ef91a 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -160,7 +160,7 @@ void ServerConfig::Send005(User* user)
                user->WriteServ("005 %s %s", user->nick, line->c_str());
 }
 
-bool ServerConfig::CheckOnce(char* tag)
+bool ServerConfig::CheckOnce(const char* tag)
 {
        int count = ConfValueEnum(this->config_data, tag);
 
@@ -284,7 +284,7 @@ bool ValidateMaxTargets(ServerConfig* conf, const char*, const char*, ValueItem
 {
        if ((data.GetInteger() < 0) || (data.GetInteger() > 31))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:maxtargets> value is greater than 31 or less than 0, set to 20.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:maxtargets> value is greater than 31 or less than 0, set to 20.");
                data.Set(20);
        }
        return true;
@@ -294,7 +294,7 @@ bool ValidateSoftLimit(ServerConfig* conf, const char*, const char*, ValueItem &
 {
        if ((data.GetInteger() < 1) || (data.GetInteger() > MAXCLIENTS))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:softlimit> value is greater than %d or less than 0, set to %d.",MAXCLIENTS,MAXCLIENTS);
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:softlimit> value is greater than %d or less than 0, set to %d.",MAXCLIENTS,MAXCLIENTS);
                data.Set(MAXCLIENTS);
        }
        return true;
@@ -303,7 +303,7 @@ bool ValidateSoftLimit(ServerConfig* conf, const char*, const char*, ValueItem &
 bool ValidateMaxConn(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if (data.GetInteger() > SOMAXCONN)
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
        return true;
 }
 
@@ -334,8 +334,8 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
        {
                std::string nameserver;
                // attempt to look up their nameserver from /etc/resolv.conf
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
-               ifstream resolv("/etc/resolv.conf");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
+               std::ifstream resolv("/etc/resolv.conf");
                bool found_server = false;
 
                if (resolv.is_open())
@@ -347,19 +347,19 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
                                        resolv >> nameserver;
                                        data.Set(nameserver.c_str());
                                        found_server = true;
-                                       conf->GetInstance()->Log(DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
+                                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
                                }
                        }
 
                        if (!found_server)
                        {
-                               conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf contains no viable nameserver entries! Defaulting to nameserver '127.0.0.1'!");
+                               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"/etc/resolv.conf contains no viable nameserver entries! Defaulting to nameserver '127.0.0.1'!");
                                data.Set("127.0.0.1");
                        }
                }
                else
                {
-                       conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf can't be opened! Defaulting to nameserver '127.0.0.1'!");
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"/etc/resolv.conf can't be opened! Defaulting to nameserver '127.0.0.1'!");
                        data.Set("127.0.0.1");
                }
        }
@@ -368,16 +368,11 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
 
 bool ValidateServerName(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Validating server name");
        /* If we already have a servername, and they changed it, we should throw an exception. */
-       if ((strcasecmp(conf->ServerName, data.GetString())) && (*conf->ServerName))
+       if (!strchr(data.GetString(), '.'))
        {
-               throw CoreException("Configuration error: You cannot change your servername at runtime! Please restart your server for this change to be applied.");
-               /* We don't actually reach this return of course... */
-               return false;
-       }
-       if (!strchr(data.GetString(),'.'))
-       {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
                std::string moo = std::string(data.GetString()).append(".");
                data.Set(moo.c_str());
        }
@@ -388,7 +383,7 @@ bool ValidateNetBufferSize(ServerConfig* conf, const char*, const char*, ValueIt
 {
        if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1024))
        {
-               conf->GetInstance()->Log(DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
                data.Set(10240);
        }
        return true;
@@ -398,7 +393,7 @@ bool ValidateMaxWho(ServerConfig* conf, const char*, const char*, ValueItem &dat
 {
        if ((data.GetInteger() > 65535) || (data.GetInteger() < 1))
        {
-               conf->GetInstance()->Log(DEFAULT,"<options:maxwhoresults> size out of range, setting to default of 128.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"<options:maxwhoresults> size out of range, setting to default of 128.");
                data.Set(128);
        }
        return true;
@@ -478,7 +473,17 @@ bool ValidateInvite(ServerConfig* conf, const char*, const char*, ValueItem &dat
 
 bool ValidateSID(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
-//     std::string  sid = data.GetString();
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Validating server id");
+
+       const char *sid = data.GetString();
+
+       if (*sid && !conf->GetInstance()->IsSID(sid))
+       {
+               throw CoreException(std::string(sid) + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
+       }
+
+       strlcpy(conf->sid, sid, 5);
+
        return true;
 }
 
@@ -495,7 +500,7 @@ bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &dat
        if (conf->WhoWasMaxKeep < 3600)
        {
                conf->WhoWasMaxKeep = 3600;
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
        }
 
        Command* whowas_command = conf->GetInstance()->Parser->GetHandler("WHOWAS");
@@ -512,14 +517,7 @@ bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &dat
  */
 bool InitConnect(ServerConfig* conf, const char*)
 {
-       conf->GetInstance()->Log(DEFAULT,"Reading connect classes...");
-
-       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
-       {
-               ConnectClass *c = *i;
-
-               conf->GetInstance()->Log(DEBUG, "Address of class is %p", c);
-       }
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Reading connect classes...");
 
        for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end() ; )
        {
@@ -528,7 +526,7 @@ bool InitConnect(ServerConfig* conf, const char*)
                /* only delete a class with refcount 0 */
                if (c->RefCount == 0)
                {
-                       conf->GetInstance()->Log(DEFAULT, "Removing connect class, refcount is 0!");
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Removing connect class, refcount is 0!");
                        
                        /* This was causing a crash, because we'd set i to .begin() just here, but then the for loop's increment would
                         * set it to .begin() + 1. Which if it was already the last thing in the list, wasn't good.
@@ -569,6 +567,7 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        const char* parent = values[13].GetString();
        int maxchans = values[14].GetInteger();
        unsigned long limit = values[15].GetInteger();
+       const char* hashtype = values[16].GetString();
 
        /*
         * duplicates check: Now we don't delete all connect classes on rehash, we need to ensure we don't add dupes.
@@ -576,17 +575,17 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
         */
        for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
        {
-               ConnectClass* c = *item;
-               if ((*name && (c->GetName() == name)) || (*allow && (c->GetHost() == allow)) || (*deny && (c->GetHost() == deny)))
+               ConnectClass* cc = *item;
+               if ((*name && (cc->GetName() == name)) || (*allow && (cc->GetHost() == allow)) || (*deny && (cc->GetHost() == deny)))
                {
                        /* reenable class so users can be shoved into it :P */
-                       c->SetDisabled(false);
-                       conf->GetInstance()->Log(DEFAULT, "Not adding class, it already exists!");
+                       cc->SetDisabled(false);
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Not adding class, it already exists!");
                        return true;
                } 
        }
 
-       conf->GetInstance()->Log(DEFAULT,"Adding a connect class!");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Adding a connect class!");
 
        if (*parent)
        {
@@ -596,11 +595,11 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                ClassVector::iterator item = conf->Classes.begin();
                for (; item != conf->Classes.end(); ++item)
                {
-                       ConnectClass* c = *item;
-                       conf->GetInstance()->Log(DEBUG,"Class: %s", c->GetName().c_str());
-                       if (c->GetName() == parent)
+                       ConnectClass* cc = *item;
+                       conf->GetInstance()->Logs->Log("CONFIG",DEBUG,"Class: %s", cc->GetName().c_str());
+                       if (cc->GetName() == parent)
                        {
-                               ConnectClass* newclass = new ConnectClass(name, c);
+                               ConnectClass* newclass = new ConnectClass(name, cc);
                                newclass->Update(timeout, flood, *allow ? allow : deny, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
                                conf->Classes.push_back(newclass);
                                break;
@@ -613,16 +612,16 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        {
                if (*allow)
                {
-                       ConnectClass* c = new ConnectClass(name, timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans);
-                       c->limit = limit;
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, timeout, flood, allow, pingfreq, password, hashtype, threshold, sendq, recvq, localmax, globalmax, maxchans);
+                       cc->limit = limit;
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
                else
                {
-                       ConnectClass* c = new ConnectClass(name, deny);
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, deny);
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
        }
 
@@ -633,7 +632,7 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
  */
 bool DoneConnect(ServerConfig *conf, const char*)
 {
-       conf->GetInstance()->Log(DEFAULT, "Done adding connect classes!");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Done adding connect classes!");
        return true;
 }
 
@@ -744,7 +743,7 @@ bool DoneMaxBans(ServerConfig*, const char*)
 
 void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, User* user)
 {
-       ServerInstance->Log(DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
+       ServerInstance->Logs->Log("CONFIG",DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
        if (bail)
        {
                /* Unneeded because of the ServerInstance->Log() aboive? */
@@ -770,10 +769,10 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                }
                else
                {
-                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       ServerInstance->SNO->WriteToSnoMask('A', "There were errors in the configuration file:");
                        while (start < errors.length())
                        {
-                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', errors.substr(start, 360).c_str());
                                start += 360;
                        }
                }
@@ -781,9 +780,9 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
        }
 }
 
-void ServerConfig::Read(bool bail, User* user, int pass)
+void ServerConfig::Read(bool bail, User* user)
 {
-       int rem = 0, add = 0;           /* Number of modules added, number of modules removed */
+       int rem = 0, add = 0;      /* Number of modules added, number of modules removed */
 
        static char debug[MAXBUF];      /* Temporary buffer for debugging value */
        static char maxkeep[MAXBUF];    /* Temporary buffer for WhoWasMaxKeep value */
@@ -792,18 +791,20 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        static char announceinvites[MAXBUF];    /* options:announceinvites setting */
        errstr.clear();
 
+       include_stack.clear();
+
        /* These tags MUST occur and must ONLY occur once in the config file */
-       static char* Once[] = { "server", "admin", "files", "power", "options", NULL };
+       static const char* Once[] = { "server", "admin", "files", "power", "options", NULL };
 
        /* These tags can occur ONCE or not at all */
        InitialConfig Values[] = {
                {"options",     "softlimit",    MAXCLIENTS_S,           new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER,  ValidateSoftLimit},
                {"options",     "somaxconn",    SOMAXCONN_S,            new ValueContainerInt  (&this->MaxConn),                DT_INTEGER,  ValidateMaxConn},
                {"options",     "moronbanner",  "Youre banned!",        new ValueContainerChar (this->MoronBanner),             DT_CHARPTR,  NoValidation},
-               {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME, ValidateServerName},
+               {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME|DT_BOOTONLY, ValidateServerName},
                {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR,  NoValidation},
                {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_NOSPACES, NoValidation},
-               {"server",      "id",           "",                     new ValueContainerChar (this->sid),                     DT_CHARPTR,  ValidateSID},
+               {"server",      "id",           "",                     new ValueContainerChar (this->sid),                     DT_CHARPTR|DT_BOOTONLY,  ValidateSID},
                {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR,  NoValidation},
                {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR,  NoValidation},
                {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR,  NoValidation},
@@ -811,10 +812,14 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR,  ValidateRules},
                {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR,  ValidateNotEmpty},
                {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER,  NoValidation},
+               {"power",       "hash",         "",                     new ValueContainerChar (this->powerhash),               DT_CHARPTR,  NoValidation},
                {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR,  ValidateNotEmpty},
                {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR,  NoValidation},
+               {"options",     "prefixpart",   "",                     new ValueContainerChar (this->PrefixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "suffixpart",   "",                     new ValueContainerChar (this->SuffixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "fixedpart",    "",                     new ValueContainerChar (this->FixedPart),               DT_CHARPTR,  NoValidation},
                {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR,  ValidateLogLevel},
                {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
                {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
@@ -858,17 +863,17 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
                                "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
-                               "name",         "parent",       "maxchans",     "limit",
+                               "name",         "parent",       "maxchans",     "limit",        "hash",
                                NULL},
                                {"",            "",             "",             "",             "120",          "",
                                 "",            "",             "",             "3",            "3",            "0",
-                                "",            "",             "0",        "0",
+                                "",            "",             "0",        "0",        "",
                                 NULL},
                                {DT_IPADDRESS|DT_ALLOW_WILD,
                                                DT_IPADDRESS|DT_ALLOW_WILD,
                                                                DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
                                DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                               DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER},
+                               DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER,     DT_CHARPTR},
                                InitConnect, DoConnect, DoneConnect},
 
                {"uline",
@@ -937,10 +942,12 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        /* Make a copy here so if it fails then we can carry on running with an unaffected config */
        newconfig.clear();
 
-       if (this->LoadConf(newconfig, ServerInstance->ConfigFileName, errstr, pass))
+       if (this->DoInclude(newconfig, ServerInstance->ConfigFileName, errstr))
        {
                /* If we succeeded, set the ircd config to the new one */
+               ServerInstance->Threads->Mutex(true);
                this->config_data = newconfig;
+               ServerInstance->Threads->Mutex(false);
        }
        else
        {
@@ -951,6 +958,12 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
        try
        {
+               /* Check we dont have more than one of singular tags, or any of them missing
+                */
+               for (int Index = 0; Once[Index]; Index++)
+                       if (!CheckOnce(Once[Index]))
+                               return;
+
                /* Read the values of all the tags which occur once or not at all, and call their callbacks.
                 */
                for (int Index = 0; Values[Index].tag; Index++)
@@ -959,8 +972,14 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                        int dt = Values[Index].datatype;
                        bool allow_newlines = ((dt & DT_ALLOW_NEWLINE) > 0);
                        bool allow_wild = ((dt & DT_ALLOW_WILD) > 0);
+                       bool bootonly = ((dt & DT_BOOTONLY) > 0);
                        dt &= ~DT_ALLOW_NEWLINE;
                        dt &= ~DT_ALLOW_WILD;
+                       dt &= ~DT_BOOTONLY;
+
+                       /* Silently ignore boot only values */
+                       if (bootonly && !bail)
+                               continue;
 
                        ConfValue(this->config_data, Values[Index].tag, Values[Index].value, Values[Index].default_value, 0, item, MAXBUF, allow_newlines);
                        ValueItem vi(item);
@@ -968,7 +987,8 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                        if (!Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi))
                                throw CoreException("One or more values in your configuration file failed to validate. Please see your ircd.log for more information.");
        
-                       switch (Values[Index].datatype)
+                       ServerInstance->Threads->Mutex(true);
+                       switch (dt)
                        {
                                case DT_NOSPACES:
                                {
@@ -982,6 +1002,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                                        ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
                                        this->ValidateHostname(vi.GetString(), Values[Index].tag, Values[Index].value);
                                        vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
+                                       ServerInstance->Logs->Log("CONFIG",DEFAULT,"Got %s", vi.GetString());
                                }
                                break;
                                case DT_IPADDRESS:
@@ -995,7 +1016,10 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                                {
                                        ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
                                        if (*(vi.GetString()) && !ServerInstance->IsChannel(vi.GetString()))
+                                       {
+                                               ServerInstance->Threads->Mutex(false);
                                                throw CoreException("The value of <"+std::string(Values[Index].tag)+":"+Values[Index].value+"> is not a valid channel name");
+                                       }
                                        vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
                                }
                                break;
@@ -1026,6 +1050,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                        }
                        /* We're done with this now */
                        delete Values[Index].val;
+                       ServerInstance->Threads->Mutex(false);
                }
 
                /* Read the multiple-tag items (class tags, connect tags, etc)
@@ -1034,7 +1059,9 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                 */
                for (int Index = 0; MultiValues[Index].tag; Index++)
                {
+                       ServerInstance->Threads->Mutex(true);
                        MultiValues[Index].init_function(this, MultiValues[Index].tag);
+                       ServerInstance->Threads->Mutex(false);
 
                        int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
 
@@ -1049,81 +1076,93 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                                        dt &= ~DT_ALLOW_NEWLINE;
                                        dt &= ~DT_ALLOW_WILD;
 
-                                       switch (dt)
+                                       ServerInstance->Threads->Mutex(true);
+                                       /* We catch and rethrow any exception here just so we can free our mutex
+                                        */
+                                       try
                                        {
-                                               case DT_NOSPACES:
-                                               {
-                                                       char item[MAXBUF];
-                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                               vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(""));
-                                                       this->ValidateNoSpaces(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
-                                               }
-                                               break;
-                                               case DT_HOSTNAME:
+                                               switch (dt)
                                                {
-                                                       char item[MAXBUF];
-                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                       case DT_NOSPACES:
+                                                       {
+                                                               char item[MAXBUF];
+                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(""));
+                                                               this->ValidateNoSpaces(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
+                                                       }
+                                                       break;
+                                                       case DT_HOSTNAME:
+                                                       {
+                                                               char item[MAXBUF];
+                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(""));
+                                                               this->ValidateHostname(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
+                                                       }
+                                                       break;
+                                                       case DT_IPADDRESS:
+                                                       {
+                                                               char item[MAXBUF];
+                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(""));
+                                                               this->ValidateIP(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum], allow_wild);
+                                                       }
+                                                       break;
+                                                       case DT_CHANNEL:
+                                                       {
+                                                               char item[MAXBUF];
+                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(""));
+                                                               if (!ServerInstance->IsChannel(vl[vl.size()-1].GetString()))
+                                                                       throw CoreException("The value of <"+std::string(MultiValues[Index].tag)+":"+MultiValues[Index].items[valuenum]+"> number "+ConvToStr(tagnum + 1)+" is not a valid channel name");
+                                                       }
+                                                       break;
+                                                       case DT_CHARPTR:
+                                                       {
+                                                               char item[MAXBUF];
+                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(""));
+                                                       }
+                                                       break;
+                                                       case DT_INTEGER:
+                                                       {
+                                                               int item = 0;
+                                                               if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item))
+                                                                       vl.push_back(ValueItem(item));
+                                                               else
+                                                                       vl.push_back(ValueItem(0));
+                                                       }
+                                                       break;
+                                                       case DT_BOOLEAN:
+                                                       {
+                                                               bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum);
                                                                vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(""));
-                                                       this->ValidateHostname(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
+                                                       }
+                                                       break;
+                                                       default:
+                                                               /* Someone was smoking craq if we got here, and we're all gonna die. */
+                                                       break;
                                                }
-                                               break;
-                                               case DT_IPADDRESS:
-                                               {
-                                                       char item[MAXBUF];
-                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                               vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(""));
-                                                       this->ValidateIP(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum], allow_wild);
-                                               }
-                                               break;
-                                               case DT_CHANNEL:
-                                               {
-                                                       char item[MAXBUF];
-                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                               vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(""));
-                                                       if (!ServerInstance->IsChannel(vl[vl.size()-1].GetString()))
-                                                               throw CoreException("The value of <"+std::string(MultiValues[Index].tag)+":"+MultiValues[Index].items[valuenum]+"> number "+ConvToStr(tagnum + 1)+" is not a valid channel name");
-                                               }
-                                               break;
-                                               case DT_CHARPTR:
-                                               {
-                                                       char item[MAXBUF];
-                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                               vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(""));
-                                               }
-                                               break;
-                                               case DT_INTEGER:
-                                               {
-                                                       int item = 0;
-                                                       if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item))
-                                                               vl.push_back(ValueItem(item));
-                                                       else
-                                                               vl.push_back(ValueItem(0));
-                                               }
-                                               break;
-                                               case DT_BOOLEAN:
-                                               {
-                                                       bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum);
-                                                       vl.push_back(ValueItem(item));
-                                               }
-                                               break;
-                                               default:
-                                                       /* Someone was smoking craq if we got here, and we're all gonna die. */
-                                               break;
                                        }
+                                       catch (CoreException &e)
+                                       {
+                                               ServerInstance->Threads->Mutex(false);
+                                               throw e;
+                                       }
+                                       ServerInstance->Threads->Mutex(false);
                                }
-                                       MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
+                               MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
-                               MultiValues[Index].finish_function(this, MultiValues[Index].tag);
+                       MultiValues[Index].finish_function(this, MultiValues[Index].tag);
                }
 
        }
@@ -1134,49 +1173,15 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                return;
        }
 
-       /** XXX END PASS **/
-       ServerInstance->Log(DEBUG,"End config pass %d", pass);
-
-       if (pass == 0)
-       {
-               /* FIRST PASS: Set up commands, load modules.
-                * We cannot gaurantee that all config is correct
-                * at this point
-                */
-
-               if (pass == 0)
-               {
-                       ServerInstance->Log(DEBUG, "Downloading configuration");
-
-                       TotalDownloaded = 0;
-                       FileErrors = 0;
-               }
-
-               if (!ServerInstance->Res)
-                       ServerInstance->Res = new DNS(ServerInstance);
-               /** Note: This is safe, the method checks for user == NULL */
-               ServerInstance->Parser->SetupCommandTable(user);
-               ServerInstance->Modules->LoadAll();
-       }
-       else
-       {
-               /* SECOND PASS: Call modules to read configs, finalize
-                * stuff. Check that we have at least the required number
-                * of whichever items. This is no longer done first.
-                */
-               ConfigReader* n = new ConfigReader(ServerInstance);
-               FOREACH_MOD(I_OnReadConfig,OnReadConfig(this, n));
-
-               for (int Index = 0; Once[Index]; Index++)
-                       if (!CheckOnce(Once[Index]))
-                               return;
-       }
-
        // write once here, to try it out and make sure its ok
        ServerInstance->WritePID(this->PID);
 
        ServerInstance->Log(DEFAULT,"Done reading configuration file.");
 
+       /* Switch over logfiles */
+       ServerInstance->Logs->CloseLogs();
+       ServerInstance->Logs->OpenFileLogs();
+
        /* If we're rehashing, let's load any new modules, and unload old ones
         */
        if (!bail)
@@ -1187,6 +1192,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
 
                if (pl.size() && user)
                {
+                       ServerInstance->Threads->Mutex(true);
                        user->WriteServ("NOTICE %s :*** Not all your client ports could be bound.", user->nick);
                        user->WriteServ("NOTICE %s :*** The following port(s) failed to bind:", user->nick);
                        int j = 1;
@@ -1194,134 +1200,74 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                        {
                                user->WriteServ("NOTICE %s :*** %d.   IP: %s     Port: %lu", user->nick, j, i->first.empty() ? "<all>" : i->first.c_str(), (unsigned long)i->second);
                        }
+                       ServerInstance->Threads->Mutex(false);
                }
-       }
 
-       if (!removed_modules.empty())
-       {
-               for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
+               ServerInstance->Threads->Mutex(true);
+               if (!removed_modules.empty())
                {
-                       if (ServerInstance->Modules->Unload(removing->c_str()))
-                       {
-                               ServerInstance->WriteOpers("*** REHASH UNLOADED MODULE: %s",removing->c_str());
-                               if (user)
-                                       user->WriteServ("973 %s %s :Module %s successfully unloaded.",user->nick, removing->c_str(), removing->c_str());
-                               rem++;
-                       }
-                       else
+                       for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
                        {
-                               if (user)
-                                       user->WriteServ("972 %s %s :%s",user->nick, removing->c_str(), ServerInstance->Modules->LastError().c_str());
+                               if (ServerInstance->Modules->Unload(removing->c_str()))
+                               {
+                                       ServerInstance->SNO->WriteToSnoMask('A', "*** REHASH UNLOADED MODULE: %s",removing->c_str());
+
+                                       if (user)
+                                               user->WriteServ("973 %s %s :Module %s successfully unloaded.",user->nick, removing->c_str(), removing->c_str());
+
+                                       rem++;
+                               }
+                               else
+                               {
+                                       if (user)
+                                               user->WriteServ("972 %s %s :Failed to unload module %s: %s",user->nick, removing->c_str(), removing->c_str(), ServerInstance->Modules->LastError().c_str());
+                               }
                        }
                }
-       }
 
-       if (!added_modules.empty())
-       {
-               for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
+               if (!added_modules.empty())
                {
-                       /* Skip over modules that are aleready loaded for some reason */
-                       if (ServerInstance->Modules->Find(*adding))
-                               continue;
-
-                       if (bail)
-                               printf_c("[\033[1;32m*\033[0m] Loading module:\t\033[1;32m%s\033[0m\n", adding->c_str());
-
-                       if (ServerInstance->Modules->Load(adding->c_str()))
+                       for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
-                               if (user)
-                                       user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
+                               if (ServerInstance->Modules->Load(adding->c_str()))
+                               {
+                                       ServerInstance->SNO->WriteToSnoMask('A', "*** REHASH LOADED MODULE: %s",adding->c_str());
 
-                               add++;
-                       }
-                       else
-                       {
-                               if (user)
-                                       user->WriteServ("974 %s %s :%s",user->nick, adding->c_str(), ServerInstance->Modules->LastError().c_str());
+                                       if (user)
+                                               user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
 
-                               if (bail)
+                                       add++;
+                               }
+                               else
                                {
-                                       printf_c("\n[\033[1;31m*\033[0m] %s\n\n", ServerInstance->Modules->LastError().c_str());
-                                       ServerInstance->Exit(EXIT_STATUS_MODULE);
+                                       if (user)
+                                               user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->Modules->LastError().c_str());
                                }
                        }
                }
+
+               ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
+
+               ServerInstance->Threads->Mutex(false);
+
        }
 
-       ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
+       /** Note: This is safe, the method checks for user == NULL */
+       ServerInstance->Threads->Mutex(true);
+       ServerInstance->Parser->SetupCommandTable(user);
+       ServerInstance->Threads->Mutex(false);
 
        if (user)
                user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
        else
-               ServerInstance->WriteOpers("*** Successfully rehashed server.");
-}
-
-/* XXX: This can and will block! */
-void ServerConfig::DoDownloads()
-{
-       ServerInstance->Log(DEBUG,"In DoDownloads()");
-
-       /* Reads all local files into the IncludedFiles map, then initiates sockets for the remote ones */
-       for (std::map<std::string, std::istream*>::iterator x = IncludedFiles.begin(); x != IncludedFiles.end(); ++x)
-       {
-               if (CompletedFiles.find(x->first) != CompletedFiles.end())
-                       continue;
-
-               ServerInstance->Log(DEBUG,"StartDownloads File: %s", x->first.c_str());
+               ServerInstance->SNO->WriteToSnoMask('A', "*** Successfully rehashed server.");
 
-               std::string file = x->first;
-               if ((file[0] == '/') || (file.substr(0, 7) == "file://"))
-               {
-                       /* For file:// schema files, we use std::ifstream which is a derivative of std::istream.
-                        * For all other file schemas, we use a std::stringstream.
-                        */
-
-                       /* Add our own ifstream */
-                       std::ifstream* conf = new std::ifstream(file.c_str());
-                       if (!conf->fail())
-                       {
-                               ServerInstance->Log(DEBUG,"file:// schema file %s loaded OK", file.c_str());
-                               delete x->second;
-                               x->second = conf;
-                       }
-                       else
-                       {
-                               delete x->second;
-                               x->second = NULL;
-                               FileErrors++;
-                       }
-                       TotalDownloaded++;
-               }
-               else
-               {
-                       /* Modules handle these */
-                       ServerInstance->Log(DEBUG,"Module-handled schema for %s", x->first.c_str());
-
-                       /* For now, error it */
-                       int MOD_RESULT = 0;
-                       FOREACH_RESULT(I_OnDownloadFile, OnDownloadFile(file, x->second));
-                       if (MOD_RESULT == 0)
-                       {
-                               /* No module claimed this file */
-                               TotalDownloaded++;
-                               FileErrors++;
-                               delete x->second;
-                               x->second = NULL;
-                       }
-                       else
-                       {
-                               /* Search new file here for more includes to parse */
-                       }
-               }
-               CompletedFiles[x->first] = true;
-       }
 }
 
-bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::ostringstream &errorstream, int pass, std::istream *scan_for_includes_only)
+
+bool ServerConfig::LoadConf(ConfigDataHash &target, FILE* &conf, const char* filename, std::ostringstream &errorstream)
 {
        std::string line;
-       std::istream* conf = NULL;
        char ch;
        long linenumber;
        bool in_tag;
@@ -1334,65 +1280,31 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
        in_quote = false;
        in_comment = false;
 
-       if (scan_for_includes_only)
-       {
-               ServerInstance->Log(DEBUG,"scan_for_includes_only set");
-               conf = scan_for_includes_only;
-       }
+       ServerInstance->Logs->Log("CONFIG", DEBUG, "Reading %s", filename);
 
-       if (std::string(filename) == CONFIG_FILE)
+       /* Check if the file open failed first */
+       if (!conf)
        {
-               if (!scan_for_includes_only)
-               {
-                       conf = new std::ifstream(filename);
-                       if (conf->fail())
-                       {
-                               errorstream << "File " << filename << " could not be opened." << std::endl;
-                               return false;
-                       }
-               }
+               errorstream << "LoadConf: Couldn't open config file: " << filename << std::endl;
+               return false;
        }
-       else
+
+       for (unsigned int t = 0; t < include_stack.size(); t++)
        {
-               std::map<std::string, std::istream*>::iterator x = IncludedFiles.find(filename);
-               if (x == IncludedFiles.end())
+               if (std::string(filename) == include_stack[t])
                {
-                       if (pass == 0)
-                       {
-                               ServerInstance->Log(DEBUG,"Push include file %s onto map", filename);
-                               /* First pass, we insert the file into a map, and just return true */
-                               IncludedFiles.insert(std::make_pair(filename,new std::stringstream));
-                               return true;
-                       }
-                       else
-                       {
-                               /* Second pass, look for the file in the map */
-                               ServerInstance->Log(DEBUG,"We are in the second pass, and %s is not in the map!", filename);
-                               errorstream << "File " << filename << " could not be opened." << std::endl;
-                               return false;
-                       }
-               }
-               else
-               {
-                       if (!scan_for_includes_only)
-                       {
-                               if (x->second)
-                                       conf = IncludedFiles.find(filename)->second;
-                               else
-                               {
-                                       errorstream << "File " << filename << " could not be opened." << std::endl;
-                                       return false;
-                               }
-                       }
+                       errorstream << "File " << filename << " is included recursively (looped inclusion)." << std::endl;
+                       return false;
                }
        }
 
-       ServerInstance->Log(DEBUG,"Start to read conf %s %08lx", filename, conf);
+       /* It's not already included, add it to the list of files we've loaded */
+       include_stack.push_back(filename);
 
        /* Start reading characters... */
-       while (conf->get(ch))
+       while (!feof(conf))
        {
-
+               ch = fgetc(conf);
                /*
                 * Fix for moronic windows issue spotted by Adremelech.
                 * Some windows editors save text files as utf-16, which is
@@ -1404,8 +1316,6 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                if ((character_count++ < 2) && (ch == '\xFF' || ch == '\xFE'))
                {
                        errorstream << "File " << filename << " cannot be read, as it is encoded in braindead UTF-16. Save your file as plain ASCII!" << std::endl;
-                       if (!scan_for_includes_only)
-                               delete conf;
                        return false;
                }
 
@@ -1451,8 +1361,9 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                {
                        line += ch;
                        char real_character;
-                       if (conf->get(real_character))
+                       if (!feof(conf))
                        {
+                               real_character = fgetc(conf);
                                if (real_character == 'n')
                                        real_character = '\n';
                                line += real_character;
@@ -1461,8 +1372,6 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        else
                        {
                                errorstream << "End of file after a \\, what did you want to escape?: " << filename << ":" << linenumber << std::endl;
-                               if (!scan_for_includes_only)
-                                       delete conf;
                                return false;
                        }
                }
@@ -1477,8 +1386,6 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                if (!in_quote)
                                {
                                        errorstream << "Got another opening < when the first one wasn't closed: " << filename << ":" << linenumber << std::endl;
-                                       if (!scan_for_includes_only)
-                                               delete conf;
                                        return false;
                                }
                        }
@@ -1487,8 +1394,6 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                if (in_quote)
                                {
                                        errorstream << "We're in a quote but outside a tag, interesting. " << filename << ":" << linenumber << std::endl;
-                                       if (!scan_for_includes_only)
-                                               delete conf;
                                        return false;
                                }
                                else
@@ -1527,7 +1432,6 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                }
                else if (ch == '>')
                {
-                       if (!in_quote)
                        {
                                if (in_tag)
                                {
@@ -1539,20 +1443,14 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                         * LoadConf() and load the included config into the same ConfigDataHash
                                         */
 
-                                       if (!this->ParseLine(target, line, linenumber, errorstream, pass, scan_for_includes_only))
-                                       {
-                                               if (!scan_for_includes_only)
-                                                       delete conf;
+                                       if (!this->ParseLine(target, line, linenumber, errorstream))
                                                return false;
-                                       }
 
                                        line.clear();
                                }
                                else
                                {
                                        errorstream << "Got a closing > when we weren't inside a tag: " << filename << ":" << linenumber << std::endl;
-                                       if (!scan_for_includes_only)
-                                               delete conf;
                                        return false;
                                }
                        }
@@ -1566,17 +1464,16 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        is a newline missing from the end of the file: " << filename << ":" << linenumber << std::endl;
        }
 
-       if (!scan_for_includes_only)
-               delete conf;
        return true;
 }
 
-bool ServerConfig::LoadConf(ConfigDataHash &target, const std::string &filename, std::ostringstream &errorstream, int pass, std::istream* scan_for_includs_only)
+
+bool ServerConfig::LoadConf(ConfigDataHash &target, FILE* &conf, const std::string &filename, std::ostringstream &errorstream)
 {
-       return this->LoadConf(target, filename.c_str(), errorstream, pass, scan_for_includs_only);
+       return this->LoadConf(target, conf, filename.c_str(), errorstream);
 }
 
-bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &linenumber, std::ostringstream &errorstream, int pass, std::istream* scan_for_includes_only)
+bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &linenumber, std::ostringstream &errorstream)
 {
        std::string tagname;
        std::string current_key;
@@ -1665,9 +1562,8 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
                                        }
                                        else
                                        {
-                                               /* Leaving quotes, we have the value */
-                                               if (!scan_for_includes_only)
-                                                       results.push_back(KeyVal(current_key, current_value));
+                                               /* Leaving the quotes, we have the current value */
+                                               results.push_back(KeyVal(current_key, current_value));
 
                                                // std::cout << "<" << tagname << ":" << current_key << "> " << current_value << std::endl;
 
@@ -1676,7 +1572,13 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
 
                                                if ((tagname == "include") && (current_key == "file"))
                                                {       
-                                                       if (!this->DoInclude(target, current_value, errorstream, pass, scan_for_includes_only))
+                                                       if (!this->DoInclude(target, current_value, errorstream))
+                                                               return false;
+                                               }
+                                               else if ((tagname == "include") && (current_key == "executable"))
+                                               {
+                                                       /* Pipe an executable and use its stdout as config data */
+                                                       if (!this->DoPipe(target, current_value, errorstream))
                                                                return false;
                                                }
 
@@ -1696,13 +1598,28 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
        }
 
        /* Finished parsing the tag, add it to the config hash */
-       if (!scan_for_includes_only)
-               target.insert(std::pair<std::string, KeyValList > (tagname, results));
+       target.insert(std::pair<std::string, KeyValList > (tagname, results));
 
        return true;
 }
 
-bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, std::ostringstream &errorstream, int pass, std::istream* scan_for_includes_only)
+bool ServerConfig::DoPipe(ConfigDataHash &target, const std::string &file, std::ostringstream &errorstream)
+{
+       FILE* conf = popen(file.c_str(), "r");
+       bool ret = false;
+
+       if (conf)
+       {
+               ret = LoadConf(target, conf, file.c_str(), errorstream);
+               pclose(conf);
+       }
+       else
+               errorstream << "Couldn't execute: " << file << std::endl;
+
+       return ret;
+}
+
+bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, std::ostringstream &errorstream)
 {
        std::string confpath;
        std::string newfile;
@@ -1728,7 +1645,18 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
                }
        }
 
-       return LoadConf(target, newfile, errorstream, pass, scan_for_includes_only);
+       FILE* conf = fopen(newfile.c_str(), "r");
+       bool ret = false;
+
+       if (conf)
+       {
+               ret = LoadConf(target, conf, newfile, errorstream);
+               fclose(conf);
+       }
+       else
+               errorstream << "Couldn't open config file: " << file << std::endl;
+
+       return ret;
 }
 
 bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length, bool allow_linefeeds)
@@ -1765,7 +1693,7 @@ bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, con
                        {
                                if ((!allow_linefeeds) && (j->second.find('\n') != std::string::npos))
                                {
-                                       ServerInstance->Log(DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
+                                       ServerInstance->Logs->Log("CONFIG",DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
                                        for (std::string::iterator n = j->second.begin(); n != j->second.end(); n++)
                                                if (*n == '\n')
                                                        *n = ' ';
@@ -2113,12 +2041,7 @@ ValueItem::ValueItem(bool value)
        v = n.str();
 }
 
-ValueItem::ValueItem(char* value)
-{
-       v = value;
-}
-
-void ValueItem::Set(char* value)
+ValueItem::ValueItem(const char* value)
 {
        v = value;
 }
@@ -2287,7 +2210,7 @@ bool DoELine(ServerConfig* conf, const char* tag, char** entries, ValueList &val
 // this should probably be moved to configreader, but atm it relies on CheckELines above.
 bool DoneELine(ServerConfig* conf, const char* tag)
 {
-       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->local_users.begin(); u2 != conf->GetInstance()->local_users.end(); u2++)
+       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->Users->local_users.begin(); u2 != conf->GetInstance()->Users->local_users.end(); u2++)
        {
                User* u = (User*)(*u2);
                u->exempt = false;
@@ -2296,3 +2219,13 @@ bool DoneELine(ServerConfig* conf, const char* tag)
        conf->GetInstance()->XLines->CheckELines();
        return true;
 }
+
+void ConfigReaderThread::Run()
+{
+       /* TODO: TheUser may be invalid by the time we get here! Check its validity, or pass a UID would be better */
+       ServerInstance->Config->Read(do_bail, TheUser);
+       ServerInstance->Threads->Mutex(true);
+       this->SetExitFlag();
+       ServerInstance->Threads->Mutex(false);
+}
+