]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Remove InspIRCd::WriteOpers in favour of snomask O
[user/henk/code/inspircd.git] / src / configreader.cpp
index 47c8ec234e164047149133273c31376b32317e99..46db43def4ecca18772e484909b50ef1f9c507bd 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -478,13 +478,13 @@ bool ValidateInvite(ServerConfig* conf, const char*, const char*, ValueItem &dat
 
 bool ValidateSID(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
-       int sid = data.GetInteger();
-       if ((sid > 999) || (sid < 0))
+       const char *sid = data.GetString();
+
+       if (*sid && !conf->GetInstance()->IsSID(sid))
        {
-               sid = sid % 1000;
-               data.Set(sid);
-               conf->GetInstance()->Log(DEFAULT,"WARNING: Server ID is less than 0 or greater than 999. Set to %d", sid);
+               throw CoreException(std::string(sid) + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
        }
+
        return true;
 }
 
@@ -527,20 +527,28 @@ bool InitConnect(ServerConfig* conf, const char*)
                conf->GetInstance()->Log(DEBUG, "Address of class is %p", c);
        }
 
-       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
+       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end() ; )
        {
-               ConnectClass *c = *i;
+               ConnectClassc = *i;
 
                /* only delete a class with refcount 0 */
                if (c->RefCount == 0)
                {
                        conf->GetInstance()->Log(DEFAULT, "Removing connect class, refcount is 0!");
+                       
+                       /* This was causing a crash, because we'd set i to .begin() just here, but then the for loop's increment would
+                        * set it to .begin() + 1. Which if it was already the last thing in the list, wasn't good.
+                        * Now the increment is in the else { } below.
+                        */
                        conf->Classes.erase(i);
                        i = conf->Classes.begin(); // start over so we don't trample on a bad iterator
                }
-
-               /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
-               c->SetDisabled(true);
+               else
+               {
+                       /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
+                       c->SetDisabled(true);
+                       i++;
+               }
        }
 
        return true;
@@ -768,10 +776,10 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                }
                else
                {
-                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       ServerInstance->SNO->WriteToSnoMask('O', "There were errors in the configuration file:");
                        while (start < errors.length())
                        {
-                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               ServerInstance->SNO->WriteToSnoMask('O', errors.substr(start, 360).c_str());
                                start += 360;
                        }
                }
@@ -801,7 +809,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME, ValidateServerName},
                {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR,  NoValidation},
                {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_NOSPACES, NoValidation},
-               {"server",      "id",           "0",                    new ValueContainerInt  (&this->sid),                    DT_NOSPACES, ValidateSID},
+               {"server",      "id",           "",                     new ValueContainerChar (this->sid),                     DT_CHARPTR,  ValidateSID},
                {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR,  NoValidation},
                {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR,  NoValidation},
                {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR,  NoValidation},
@@ -813,6 +821,9 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR,  NoValidation},
+               {"options",     "prefixpart",   "",                     new ValueContainerChar (this->PrefixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "suffixpart",   "",                     new ValueContainerChar (this->SuffixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "fixedpart",    "",                     new ValueContainerChar (this->FixedPart),               DT_CHARPTR,  NoValidation},
                {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR,  ValidateLogLevel},
                {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
                {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
@@ -1144,8 +1155,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
 
                if (pass == 0)
                {
-                       if (isatty(0) && isatty(1) && isatty(2))
-                               printf("Downloading configuration ");
+                       ServerInstance->Log(DEBUG, "Downloading configuration");
 
                        TotalDownloaded = 0;
                        FileErrors = 0;
@@ -1202,7 +1212,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {
                        if (ServerInstance->Modules->Unload(removing->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH UNLOADED MODULE: %s",removing->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('O', "REHASH UNLOADED MODULE: %s",removing->c_str());
                                if (user)
                                        user->WriteServ("973 %s %s :Module %s successfully unloaded.",user->nick, removing->c_str(), removing->c_str());
                                rem++;
@@ -1228,7 +1238,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
 
                        if (ServerInstance->Modules->Load(adding->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('O', "REHASH LOADED MODULE: %s",adding->c_str());
                                if (user)
                                        user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
 
@@ -1253,45 +1263,13 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        if (user)
                user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
        else
-               ServerInstance->WriteOpers("*** Successfully rehashed server.");
-}
-
-bool ServerConfig::Downloading()
-{
-       if (isatty(0) && isatty(1) && isatty(2))
-       {
-               printf(".");
-               fflush(stdout);
-       }
-
-       ServerInstance->Log(DEBUG, "ServerConfig::Downloading %d %d", TotalDownloaded, IncludedFiles.size());
-
-       /* Returns true if there are still files in the process of downloading */
-       return (TotalDownloaded < IncludedFiles.size());
+               ServerInstance->SNO->WriteToSnoMask('O', "Successfully rehashed server.");
 }
 
-void ServerConfig::Complete(const std::string &filename, bool error)
+/* XXX: This can and will block! */
+void ServerConfig::DoDownloads()
 {
-       ServerInstance->Log(DEBUG,"Flag complete: %s %d", filename.c_str(), error);
-       std::map<std::string, std::istream*>::iterator x = IncludedFiles.find(filename);
-
-       if (x != IncludedFiles.end())
-       {
-               if (error)
-               {
-                       delete x->second;
-                       x->second = NULL;
-                       FileErrors++;
-               }
-               TotalDownloaded++;
-       }
-
-       return;
-}
-
-void ServerConfig::StartDownloads()
-{
-       ServerInstance->Log(DEBUG,"((((((((((((((((((((((((( StartDownloads() size=%d )))))))))))))))))))))))))))))))))))))", IncludedFiles.size());
+       ServerInstance->Log(DEBUG,"In DoDownloads()");
 
        /* Reads all local files into the IncludedFiles map, then initiates sockets for the remote ones */
        for (std::map<std::string, std::istream*>::iterator x = IncludedFiles.begin(); x != IncludedFiles.end(); ++x)
@@ -1340,6 +1318,10 @@ void ServerConfig::StartDownloads()
                                delete x->second;
                                x->second = NULL;
                        }
+                       else
+                       {
+                               /* Search new file here for more includes to parse */
+                       }
                }
                CompletedFiles[x->first] = true;
        }
@@ -2123,11 +2105,7 @@ InspIRCd* ServerConfig::GetInstance()
 
 std::string ServerConfig::GetSID()
 {
-       std::string OurSID;
-       OurSID += (char)((sid / 100) + 48);
-       OurSID += (char)((sid / 10) % 10 + 48);
-       OurSID += (char)(sid % 10 + 48);
-       return OurSID;
+       return sid;
 }
 
 ValueItem::ValueItem(int value)
@@ -2327,4 +2305,3 @@ bool DoneELine(ServerConfig* conf, const char* tag)
        conf->GetInstance()->XLines->CheckELines();
        return true;
 }
-