]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
w00t broke it :p
[user/henk/code/inspircd.git] / src / configreader.cpp
index 5b2cdd9d4e9888a94c67398f780487d7fe77a663..92d2c9aead1df02986a1d17ba5875319417cfa39 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -160,7 +160,7 @@ void ServerConfig::Send005(User* user)
                user->WriteServ("005 %s %s", user->nick, line->c_str());
 }
 
-bool ServerConfig::CheckOnce(char* tag)
+bool ServerConfig::CheckOnce(const char* tag)
 {
        int count = ConfValueEnum(this->config_data, tag);
 
@@ -284,7 +284,7 @@ bool ValidateMaxTargets(ServerConfig* conf, const char*, const char*, ValueItem
 {
        if ((data.GetInteger() < 0) || (data.GetInteger() > 31))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:maxtargets> value is greater than 31 or less than 0, set to 20.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:maxtargets> value is greater than 31 or less than 0, set to 20.");
                data.Set(20);
        }
        return true;
@@ -294,7 +294,7 @@ bool ValidateSoftLimit(ServerConfig* conf, const char*, const char*, ValueItem &
 {
        if ((data.GetInteger() < 1) || (data.GetInteger() > MAXCLIENTS))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:softlimit> value is greater than %d or less than 0, set to %d.",MAXCLIENTS,MAXCLIENTS);
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:softlimit> value is greater than %d or less than 0, set to %d.",MAXCLIENTS,MAXCLIENTS);
                data.Set(MAXCLIENTS);
        }
        return true;
@@ -303,7 +303,7 @@ bool ValidateSoftLimit(ServerConfig* conf, const char*, const char*, ValueItem &
 bool ValidateMaxConn(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if (data.GetInteger() > SOMAXCONN)
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
        return true;
 }
 
@@ -334,8 +334,8 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
        {
                std::string nameserver;
                // attempt to look up their nameserver from /etc/resolv.conf
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
-               ifstream resolv("/etc/resolv.conf");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
+               std::ifstream resolv("/etc/resolv.conf");
                bool found_server = false;
 
                if (resolv.is_open())
@@ -347,19 +347,19 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
                                        resolv >> nameserver;
                                        data.Set(nameserver.c_str());
                                        found_server = true;
-                                       conf->GetInstance()->Log(DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
+                                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
                                }
                        }
 
                        if (!found_server)
                        {
-                               conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf contains no viable nameserver entries! Defaulting to nameserver '127.0.0.1'!");
+                               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"/etc/resolv.conf contains no viable nameserver entries! Defaulting to nameserver '127.0.0.1'!");
                                data.Set("127.0.0.1");
                        }
                }
                else
                {
-                       conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf can't be opened! Defaulting to nameserver '127.0.0.1'!");
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"/etc/resolv.conf can't be opened! Defaulting to nameserver '127.0.0.1'!");
                        data.Set("127.0.0.1");
                }
        }
@@ -377,7 +377,7 @@ bool ValidateServerName(ServerConfig* conf, const char*, const char*, ValueItem
        }
        if (!strchr(data.GetString(),'.'))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
                std::string moo = std::string(data.GetString()).append(".");
                data.Set(moo.c_str());
        }
@@ -388,7 +388,7 @@ bool ValidateNetBufferSize(ServerConfig* conf, const char*, const char*, ValueIt
 {
        if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1024))
        {
-               conf->GetInstance()->Log(DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
                data.Set(10240);
        }
        return true;
@@ -398,7 +398,7 @@ bool ValidateMaxWho(ServerConfig* conf, const char*, const char*, ValueItem &dat
 {
        if ((data.GetInteger() > 65535) || (data.GetInteger() < 1))
        {
-               conf->GetInstance()->Log(DEFAULT,"<options:maxwhoresults> size out of range, setting to default of 128.");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"<options:maxwhoresults> size out of range, setting to default of 128.");
                data.Set(128);
        }
        return true;
@@ -478,13 +478,13 @@ bool ValidateInvite(ServerConfig* conf, const char*, const char*, ValueItem &dat
 
 bool ValidateSID(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
-       int sid = data.GetInteger();
-       if ((sid > 999) || (sid < 0))
+       const char *sid = data.GetString();
+
+       if (*sid && !conf->GetInstance()->IsSID(sid))
        {
-               sid = sid % 1000;
-               data.Set(sid);
-               conf->GetInstance()->Log(DEFAULT,"WARNING: Server ID is less than 0 or greater than 999. Set to %d", sid);
+               throw CoreException(std::string(sid) + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
        }
+
        return true;
 }
 
@@ -501,7 +501,7 @@ bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &dat
        if (conf->WhoWasMaxKeep < 3600)
        {
                conf->WhoWasMaxKeep = 3600;
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
        }
 
        Command* whowas_command = conf->GetInstance()->Parser->GetHandler("WHOWAS");
@@ -518,29 +518,37 @@ bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &dat
  */
 bool InitConnect(ServerConfig* conf, const char*)
 {
-       conf->GetInstance()->Log(DEFAULT,"Reading connect classes...");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Reading connect classes...");
 
        for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
        {
                ConnectClass *c = *i;
 
-               conf->GetInstance()->Log(DEBUG, "Address of class is %p", c);
+               conf->GetInstance()->Logs->Log("CONFIG",DEBUG, "Address of class is %p", c);
        }
 
-       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
+       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end() ; )
        {
-               ConnectClass *c = *i;
+               ConnectClassc = *i;
 
                /* only delete a class with refcount 0 */
                if (c->RefCount == 0)
                {
-                       conf->GetInstance()->Log(DEFAULT, "Removing connect class, refcount is 0!");
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Removing connect class, refcount is 0!");
+                       
+                       /* This was causing a crash, because we'd set i to .begin() just here, but then the for loop's increment would
+                        * set it to .begin() + 1. Which if it was already the last thing in the list, wasn't good.
+                        * Now the increment is in the else { } below.
+                        */
                        conf->Classes.erase(i);
                        i = conf->Classes.begin(); // start over so we don't trample on a bad iterator
                }
-
-               /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
-               c->SetDisabled(true);
+               else
+               {
+                       /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
+                       c->SetDisabled(true);
+                       i++;
+               }
        }
 
        return true;
@@ -567,6 +575,7 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        const char* parent = values[13].GetString();
        int maxchans = values[14].GetInteger();
        unsigned long limit = values[15].GetInteger();
+       const char* hashtype = values[16].GetString();
 
        /*
         * duplicates check: Now we don't delete all connect classes on rehash, we need to ensure we don't add dupes.
@@ -574,17 +583,17 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
         */
        for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
        {
-               ConnectClass* c = *item;
-               if ((*name && (c->GetName() == name)) || (*allow && (c->GetHost() == allow)) || (*deny && (c->GetHost() == deny)))
+               ConnectClass* cc = *item;
+               if ((*name && (cc->GetName() == name)) || (*allow && (cc->GetHost() == allow)) || (*deny && (cc->GetHost() == deny)))
                {
                        /* reenable class so users can be shoved into it :P */
-                       c->SetDisabled(false);
-                       conf->GetInstance()->Log(DEFAULT, "Not adding class, it already exists!");
+                       cc->SetDisabled(false);
+                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Not adding class, it already exists!");
                        return true;
                } 
        }
 
-       conf->GetInstance()->Log(DEFAULT,"Adding a connect class!");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Adding a connect class!");
 
        if (*parent)
        {
@@ -594,11 +603,11 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                ClassVector::iterator item = conf->Classes.begin();
                for (; item != conf->Classes.end(); ++item)
                {
-                       ConnectClass* c = *item;
-                       conf->GetInstance()->Log(DEBUG,"Class: %s", c->GetName().c_str());
-                       if (c->GetName() == parent)
+                       ConnectClass* cc = *item;
+                       conf->GetInstance()->Logs->Log("CONFIG",DEBUG,"Class: %s", cc->GetName().c_str());
+                       if (cc->GetName() == parent)
                        {
-                               ConnectClass* newclass = new ConnectClass(name, c);
+                               ConnectClass* newclass = new ConnectClass(name, cc);
                                newclass->Update(timeout, flood, *allow ? allow : deny, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
                                conf->Classes.push_back(newclass);
                                break;
@@ -611,16 +620,16 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        {
                if (*allow)
                {
-                       ConnectClass* c = new ConnectClass(name, timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans);
-                       c->limit = limit;
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, timeout, flood, allow, pingfreq, password, hashtype, threshold, sendq, recvq, localmax, globalmax, maxchans);
+                       cc->limit = limit;
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
                else
                {
-                       ConnectClass* c = new ConnectClass(name, deny);
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, deny);
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
        }
 
@@ -631,7 +640,7 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
  */
 bool DoneConnect(ServerConfig *conf, const char*)
 {
-       conf->GetInstance()->Log(DEFAULT, "Done adding connect classes!");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Done adding connect classes!");
        return true;
 }
 
@@ -742,7 +751,7 @@ bool DoneMaxBans(ServerConfig*, const char*)
 
 void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, User* user)
 {
-       ServerInstance->Log(DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
+       ServerInstance->Logs->Log("CONFIG",DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
        if (bail)
        {
                /* Unneeded because of the ServerInstance->Log() aboive? */
@@ -768,10 +777,10 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                }
                else
                {
-                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       ServerInstance->SNO->WriteToSnoMask('A', "There were errors in the configuration file:");
                        while (start < errors.length())
                        {
-                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', errors.substr(start, 360).c_str());
                                start += 360;
                        }
                }
@@ -791,7 +800,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        errstr.clear();
 
        /* These tags MUST occur and must ONLY occur once in the config file */
-       static char* Once[] = { "server", "admin", "files", "power", "options", NULL };
+       static const char* Once[] = { "server", "admin", "files", "power", "options", NULL };
 
        /* These tags can occur ONCE or not at all */
        InitialConfig Values[] = {
@@ -801,7 +810,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME, ValidateServerName},
                {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR,  NoValidation},
                {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_NOSPACES, NoValidation},
-               {"server",      "id",           "0",                    new ValueContainerInt  (&this->sid),                    DT_NOSPACES, ValidateSID},
+               {"server",      "id",           "",                     new ValueContainerChar (this->sid),                     DT_CHARPTR,  ValidateSID},
                {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR,  NoValidation},
                {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR,  NoValidation},
                {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR,  NoValidation},
@@ -809,10 +818,14 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR,  ValidateRules},
                {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR,  ValidateNotEmpty},
                {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER,  NoValidation},
+               {"power",       "hash",         "",                     new ValueContainerChar (this->powerhash),               DT_CHARPTR,  NoValidation},
                {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR,  ValidateNotEmpty},
                {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR,  NoValidation},
                {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR,  NoValidation},
+               {"options",     "prefixpart",   "",                     new ValueContainerChar (this->PrefixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "suffixpart",   "",                     new ValueContainerChar (this->SuffixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "fixedpart",    "",                     new ValueContainerChar (this->FixedPart),               DT_CHARPTR,  NoValidation},
                {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR,  ValidateLogLevel},
                {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
                {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
@@ -856,17 +869,17 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
                                "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
-                               "name",         "parent",       "maxchans",     "limit",
+                               "name",         "parent",       "maxchans",     "limit",        "hash",
                                NULL},
                                {"",            "",             "",             "",             "120",          "",
                                 "",            "",             "",             "3",            "3",            "0",
-                                "",            "",             "0",        "0",
+                                "",            "",             "0",        "0",        "",
                                 NULL},
                                {DT_IPADDRESS|DT_ALLOW_WILD,
                                                DT_IPADDRESS|DT_ALLOW_WILD,
                                                                DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
                                DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                               DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER},
+                               DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER,     DT_CHARPTR},
                                InitConnect, DoConnect, DoneConnect},
 
                {"uline",
@@ -1133,7 +1146,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        }
 
        /** XXX END PASS **/
-       ServerInstance->Log(DEBUG,"End config pass %d", pass);
+       ServerInstance->Logs->Log("CONFIG",DEBUG,"End config pass %d", pass);
 
        if (pass == 0)
        {
@@ -1144,8 +1157,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
 
                if (pass == 0)
                {
-                       if (isatty(0) && isatty(1) && isatty(2))
-                               printf("Downloading configuration ");
+                       ServerInstance->Logs->Log("CONFIG",DEBUG, "Downloading configuration");
 
                        TotalDownloaded = 0;
                        FileErrors = 0;
@@ -1163,6 +1175,9 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                 * stuff. Check that we have at least the required number
                 * of whichever items. This is no longer done first.
                 */
+               /* Close all logs at this point and reopen <log method="file"> logs. */
+               ServerInstance->Logs->CloseLogs();
+               ServerInstance->Logs->OpenFileLogs();
                ConfigReader* n = new ConfigReader(ServerInstance);
                FOREACH_MOD(I_OnReadConfig,OnReadConfig(this, n));
 
@@ -1174,7 +1189,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
        // write once here, to try it out and make sure its ok
        ServerInstance->WritePID(this->PID);
 
-       ServerInstance->Log(DEFAULT,"Done reading configuration file.");
+       ServerInstance->Logs->Log("CONFIG",DEFAULT,"Done reading configuration file.");
 
        /* If we're rehashing, let's load any new modules, and unload old ones
         */
@@ -1202,7 +1217,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                {
                        if (ServerInstance->Modules->Unload(removing->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH UNLOADED MODULE: %s",removing->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "REHASH UNLOADED MODULE: %s",removing->c_str());
                                if (user)
                                        user->WriteServ("973 %s %s :Module %s successfully unloaded.",user->nick, removing->c_str(), removing->c_str());
                                rem++;
@@ -1228,7 +1243,7 @@ void ServerConfig::Read(bool bail, User* user, int pass)
 
                        if (ServerInstance->Modules->Load(adding->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "REHASH LOADED MODULE: %s",adding->c_str());
                                if (user)
                                        user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
 
@@ -1248,18 +1263,18 @@ void ServerConfig::Read(bool bail, User* user, int pass)
                }
        }
 
-       ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
+       ServerInstance->Logs->Log("CONFIG",DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
 
        if (user)
                user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
        else
-               ServerInstance->WriteOpers("*** Successfully rehashed server.");
+               ServerInstance->SNO->WriteToSnoMask('A', "Successfully rehashed server.");
 }
 
 /* XXX: This can and will block! */
 void ServerConfig::DoDownloads()
 {
-       ServerInstance->Log(DEBUG,"In DoDownloads()");
+       ServerInstance->Logs->Log("CONFIG",DEBUG,"In DoDownloads()");
 
        /* Reads all local files into the IncludedFiles map, then initiates sockets for the remote ones */
        for (std::map<std::string, std::istream*>::iterator x = IncludedFiles.begin(); x != IncludedFiles.end(); ++x)
@@ -1267,7 +1282,7 @@ void ServerConfig::DoDownloads()
                if (CompletedFiles.find(x->first) != CompletedFiles.end())
                        continue;
 
-               ServerInstance->Log(DEBUG,"StartDownloads File: %s", x->first.c_str());
+               ServerInstance->Logs->Log("CONFIG",DEBUG,"StartDownloads File: %s", x->first.c_str());
 
                std::string file = x->first;
                if ((file[0] == '/') || (file.substr(0, 7) == "file://"))
@@ -1280,7 +1295,7 @@ void ServerConfig::DoDownloads()
                        std::ifstream* conf = new std::ifstream(file.c_str());
                        if (!conf->fail())
                        {
-                               ServerInstance->Log(DEBUG,"file:// schema file %s loaded OK", file.c_str());
+                               ServerInstance->Logs->Log("CONFIG",DEBUG,"file:// schema file %s loaded OK", file.c_str());
                                delete x->second;
                                x->second = conf;
                        }
@@ -1295,7 +1310,7 @@ void ServerConfig::DoDownloads()
                else
                {
                        /* Modules handle these */
-                       ServerInstance->Log(DEBUG,"Module-handled schema for %s", x->first.c_str());
+                       ServerInstance->Logs->Log("CONFIG",DEBUG,"Module-handled schema for %s", x->first.c_str());
 
                        /* For now, error it */
                        int MOD_RESULT = 0;
@@ -1335,7 +1350,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
 
        if (scan_for_includes_only)
        {
-               ServerInstance->Log(DEBUG,"scan_for_includes_only set");
+               ServerInstance->Logs->Log("CONFIG",DEBUG,"scan_for_includes_only set");
                conf = scan_for_includes_only;
        }
 
@@ -1358,7 +1373,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                {
                        if (pass == 0)
                        {
-                               ServerInstance->Log(DEBUG,"Push include file %s onto map", filename);
+                               ServerInstance->Logs->Log("CONFIG",DEBUG,"Push include file %s onto map", filename);
                                /* First pass, we insert the file into a map, and just return true */
                                IncludedFiles.insert(std::make_pair(filename,new std::stringstream));
                                return true;
@@ -1366,7 +1381,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        else
                        {
                                /* Second pass, look for the file in the map */
-                               ServerInstance->Log(DEBUG,"We are in the second pass, and %s is not in the map!", filename);
+                               ServerInstance->Logs->Log("CONFIG",DEBUG,"We are in the second pass, and %s is not in the map!", filename);
                                errorstream << "File " << filename << " could not be opened." << std::endl;
                                return false;
                        }
@@ -1386,7 +1401,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                }
        }
 
-       ServerInstance->Log(DEBUG,"Start to read conf %s %08lx", filename, conf);
+       ServerInstance->Logs->Log("CONFIG",DEBUG,"Start to read conf %s %08lx", filename, conf);
 
        /* Start reading characters... */
        while (conf->get(ch))
@@ -1764,7 +1779,7 @@ bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, con
                        {
                                if ((!allow_linefeeds) && (j->second.find('\n') != std::string::npos))
                                {
-                                       ServerInstance->Log(DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
+                                       ServerInstance->Logs->Log("CONFIG",DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
                                        for (std::string::iterator n = j->second.begin(); n != j->second.end(); n++)
                                                if (*n == '\n')
                                                        *n = ' ';
@@ -2095,11 +2110,7 @@ InspIRCd* ServerConfig::GetInstance()
 
 std::string ServerConfig::GetSID()
 {
-       std::string OurSID;
-       OurSID += (char)((sid / 100) + 48);
-       OurSID += (char)((sid / 10) % 10 + 48);
-       OurSID += (char)(sid % 10 + 48);
-       return OurSID;
+       return sid;
 }
 
 ValueItem::ValueItem(int value)
@@ -2116,12 +2127,7 @@ ValueItem::ValueItem(bool value)
        v = n.str();
 }
 
-ValueItem::ValueItem(char* value)
-{
-       v = value;
-}
-
-void ValueItem::Set(char* value)
+ValueItem::ValueItem(const char* value)
 {
        v = value;
 }
@@ -2290,7 +2296,7 @@ bool DoELine(ServerConfig* conf, const char* tag, char** entries, ValueList &val
 // this should probably be moved to configreader, but atm it relies on CheckELines above.
 bool DoneELine(ServerConfig* conf, const char* tag)
 {
-       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->local_users.begin(); u2 != conf->GetInstance()->local_users.end(); u2++)
+       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->Users->local_users.begin(); u2 != conf->GetInstance()->Users->local_users.end(); u2++)
        {
                User* u = (User*)(*u2);
                u->exempt = false;
@@ -2299,4 +2305,3 @@ bool DoneELine(ServerConfig* conf, const char* tag)
        conf->GetInstance()->XLines->CheckELines();
        return true;
 }
-