]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Fixified some more
[user/henk/code/inspircd.git] / src / configreader.cpp
index 46bb9231ea8e55e8f6c81b63134c2a764071509d..96f46116239cdd655b0ca875ea9c81d8a02db219 100644 (file)
  * ---------------------------------------------------
  */
 
+/* $Core: libIRCDconfigreader */
+/* $CopyInstall: conf/inspircd.quotes.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.rules.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.motd.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.helpop-full.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.helpop.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.censor.example $(CONPATH) */
+/* $CopyInstall: conf/inspircd.filter.example $(CONPATH) */
+/* $CopyInstall: docs/inspircd.conf.example $(CONPATH) */
+
 #include "inspircd.h"
-#include "configreader.h"
-#include <sstream>
 #include <fstream>
 #include "xline.h"
 #include "exitcodes.h"
@@ -60,9 +68,9 @@ Module* ServerConfig::GetIOHook(int port)
        return (x != IOHookModule.end() ? x->second : NULL);
 }
 
-Module* ServerConfig::GetIOHook(InspSocket* is)
+Module* ServerConfig::GetIOHook(BufferedSocket* is)
 {
-       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       std::map<BufferedSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
        return (x != SocketIOHookModule.end() ? x->second : NULL);
 }
 
@@ -80,7 +88,7 @@ bool ServerConfig::AddIOHook(int port, Module* iomod)
        }
 }
 
-bool ServerConfig::AddIOHook(Module* iomod, InspSocket* is)
+bool ServerConfig::AddIOHook(Module* iomod, BufferedSocket* is)
 {
        if (!GetIOHook(is))
        {
@@ -90,7 +98,7 @@ bool ServerConfig::AddIOHook(Module* iomod, InspSocket* is)
        }
        else
        {
-               throw ModuleException("InspSocket derived class already hooked by another module");
+               throw ModuleException("BufferedSocket derived class already hooked by another module");
                return false;
        }
 }
@@ -106,9 +114,9 @@ bool ServerConfig::DelIOHook(int port)
        return false;
 }
 
-bool ServerConfig::DelIOHook(InspSocket* is)
+bool ServerConfig::DelIOHook(BufferedSocket* is)
 {
-       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       std::map<BufferedSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
        if (x != SocketIOHookModule.end())
        {
                SocketIOHookModule.erase(x);
@@ -145,13 +153,13 @@ void ServerConfig::Update005()
        }
 }
 
-void ServerConfig::Send005(userrec* user)
+void ServerConfig::Send005(User* user)
 {
        for (std::vector<std::string>::iterator line = ServerInstance->Config->isupport.begin(); line != ServerInstance->Config->isupport.end(); line++)
                user->WriteServ("005 %s %s", user->nick, line->c_str());
 }
 
-bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
+bool ServerConfig::CheckOnce(char* tag)
 {
        int count = ConfValueEnum(this->config_data, tag);
 
@@ -168,12 +176,17 @@ bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
        return true;
 }
 
-bool NoValidation(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool NoValidation(ServerConfig*, const char*, const char*, ValueItem&)
+{
+       return true;
+}
+
+bool DoneConfItem(ServerConfig* conf, const char* tag)
 {
        return true;
 }
 
-bool ValidateMaxTargets(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateMaxTargets(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if ((data.GetInteger() < 0) || (data.GetInteger() > 31))
        {
@@ -183,7 +196,7 @@ bool ValidateMaxTargets(ServerConfig* conf, const char* tag, const char* value,
        return true;
 }
 
-bool ValidateSoftLimit(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateSoftLimit(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if ((data.GetInteger() < 1) || (data.GetInteger() > MAXCLIENTS))
        {
@@ -193,7 +206,7 @@ bool ValidateSoftLimit(ServerConfig* conf, const char* tag, const char* value, V
        return true;
 }
 
-bool ValidateMaxConn(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateMaxConn(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if (data.GetInteger() > SOMAXCONN)
                conf->GetInstance()->Log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
@@ -206,13 +219,13 @@ bool InitializeDisabledCommands(const char* data, InspIRCd* ServerInstance)
        std::string thiscmd;
 
        /* Enable everything first */
-       for (command_table::iterator x = ServerInstance->Parser->cmdlist.begin(); x != ServerInstance->Parser->cmdlist.end(); x++)
+       for (Commandable::iterator x = ServerInstance->Parser->cmdlist.begin(); x != ServerInstance->Parser->cmdlist.end(); x++)
                x->second->Disable(false);
 
        /* Now disable all the ones which the user wants disabled */
        while (dcmds >> thiscmd)
        {
-               command_table::iterator cm = ServerInstance->Parser->cmdlist.find(thiscmd);
+               Commandable::iterator cm = ServerInstance->Parser->cmdlist.find(thiscmd);
                if (cm != ServerInstance->Parser->cmdlist.end())
                {
                        cm->second->Disable(true);
@@ -221,7 +234,7 @@ bool InitializeDisabledCommands(const char* data, InspIRCd* ServerInstance)
        return true;
 }
 
-bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if (!*(data.GetString()))
        {
@@ -259,13 +272,13 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, V
        return true;
 }
 
-bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateServerName(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        /* If we already have a servername, and they changed it, we should throw an exception. */
        if ((strcasecmp(conf->ServerName, data.GetString())) && (*conf->ServerName))
        {
                throw CoreException("Configuration error: You cannot change your servername at runtime! Please restart your server for this change to be applied.");
-               /* XXX: We don't actually reach this return of course... */
+               /* We don't actually reach this return of course... */
                return false;
        }
        if (!strchr(data.GetString(),'.'))
@@ -277,7 +290,7 @@ bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value,
        return true;
 }
 
-bool ValidateNetBufferSize(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateNetBufferSize(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1024))
        {
@@ -287,7 +300,7 @@ bool ValidateNetBufferSize(ServerConfig* conf, const char* tag, const char* valu
        return true;
 }
 
-bool ValidateMaxWho(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateMaxWho(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        if ((data.GetInteger() > 65535) || (data.GetInteger() < 1))
        {
@@ -297,7 +310,7 @@ bool ValidateMaxWho(ServerConfig* conf, const char* tag, const char* value, Valu
        return true;
 }
 
-bool ValidateLogLevel(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateLogLevel(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        std::string dbg = data.GetString();
        conf->LogLevel = DEFAULT;
@@ -318,26 +331,26 @@ bool ValidateLogLevel(ServerConfig* conf, const char* tag, const char* value, Va
        return true;
 }
 
-bool ValidateMotd(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateMotd(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        conf->ReadFile(conf->MOTD, data.GetString());
        return true;
 }
 
-bool ValidateNotEmpty(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateNotEmpty(ServerConfig*, const char* tag, const char*, ValueItem &data)
 {
        if (!*data.GetString())
                throw CoreException(std::string("The value for ")+tag+" cannot be empty!");
        return true;
 }
 
-bool ValidateRules(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateRules(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        conf->ReadFile(conf->RULES, data.GetString());
        return true;
 }
 
-bool ValidateModeLists(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateModeLists(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        memset(conf->HideModeLists, 0, 256);
        for (const unsigned char* x = (const unsigned char*)data.GetString(); *x; ++x)
@@ -345,7 +358,7 @@ bool ValidateModeLists(ServerConfig* conf, const char* tag, const char* value, V
        return true;
 }
 
-bool ValidateExemptChanOps(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateExemptChanOps(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        memset(conf->ExemptChanOps, 0, 256);
        for (const unsigned char* x = (const unsigned char*)data.GetString(); *x; ++x)
@@ -353,7 +366,35 @@ bool ValidateExemptChanOps(ServerConfig* conf, const char* tag, const char* valu
        return true;
 }
 
-bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
+bool ValidateInvite(ServerConfig* conf, const char*, const char*, ValueItem &data)
+{
+       std::string v = data.GetString();
+
+       if (v == "ops")
+               conf->AnnounceInvites = ServerConfig::INVITE_ANNOUNCE_OPS;
+       else if (v == "all")
+               conf->AnnounceInvites = ServerConfig::INVITE_ANNOUNCE_ALL;
+       else if (v == "dynamic")
+               conf->AnnounceInvites = ServerConfig::INVITE_ANNOUNCE_DYNAMIC;
+       else
+               conf->AnnounceInvites = ServerConfig::INVITE_ANNOUNCE_NONE;
+
+       return true;
+}
+
+bool ValidateSID(ServerConfig* conf, const char*, const char*, ValueItem &data)
+{
+       int sid = data.GetInteger();
+       if ((sid > 999) || (sid < 0))
+       {
+               sid = sid % 1000;
+               data.Set(sid);
+               conf->GetInstance()->Log(DEFAULT,"WARNING: Server ID is less than 0 or greater than 999. Set to %d", sid);
+       }
+       return true;
+}
+
+bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        conf->WhoWasMaxKeep = conf->GetInstance()->Duration(data.GetString());
 
@@ -369,7 +410,7 @@ bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, Valu
                conf->GetInstance()->Log(DEFAULT,"WARNING: <whowas:maxkeep> value less than 3600, setting to default 3600");
        }
 
-       command_t* whowas_command = conf->GetInstance()->Parser->GetHandler("WHOWAS");
+       Command* whowas_command = conf->GetInstance()->Parser->GetHandler("WHOWAS");
        if (whowas_command)
        {
                std::deque<classbase*> params;
@@ -381,16 +422,39 @@ bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, Valu
 
 /* Callback called before processing the first <connect> tag
  */
-bool InitConnect(ServerConfig* conf, const char* tag)
+bool InitConnect(ServerConfig* conf, const char*)
 {
        conf->GetInstance()->Log(DEFAULT,"Reading connect classes...");
-       conf->Classes.clear();
+
+       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
+       {
+               ConnectClass *c = *i;
+
+               conf->GetInstance()->Log(DEBUG, "Address of class is %p", c);
+       }
+
+       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
+       {
+               ConnectClass *c = *i;
+
+               /* only delete a class with refcount 0 */
+               if (c->RefCount == 0)
+               {
+                       conf->GetInstance()->Log(DEFAULT, "Removing connect class, refcount is 0!");
+                       conf->Classes.erase(i);
+                       i = conf->Classes.begin(); // start over so we don't trample on a bad iterator
+               }
+
+               /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
+               c->SetDisabled(true);
+       }
+
        return true;
 }
 
 /* Callback called to process a single <connect> tag
  */
-bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
 {
        ConnectClass c;
        const char* allow = values[0].GetString(); /* Yeah, there are a lot of values. Live with it. */
@@ -404,16 +468,66 @@ bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &v
        int recvq = values[8].GetInteger();
        int localmax = values[9].GetInteger();
        int globalmax = values[10].GetInteger();
+       int port = values[11].GetInteger();
+       const char* name = values[12].GetString();
+       const char* parent = values[13].GetString();
+       int maxchans = values[14].GetInteger();
+       unsigned long limit = values[15].GetInteger();
+
+       /*
+        * duplicates check: Now we don't delete all connect classes on rehash, we need to ensure we don't add dupes.
+        * easier said than done, but for now we'll just disallow anything with a duplicate host or name. -- w00t
+        */
+       for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
+       {
+               ConnectClass* c = *item;
+               if ((*name && (c->GetName() == name)) || (*allow && (c->GetHost() == allow)) || (*deny && (c->GetHost() == deny)))
+               {
+                       /* reenable class so users can be shoved into it :P */
+                       c->SetDisabled(false);
+                       conf->GetInstance()->Log(DEFAULT, "Not adding class, it already exists!");
+                       return true;
+               } 
+       }
+
+       conf->GetInstance()->Log(DEFAULT,"Adding a connect class!");
 
-       if (*allow)
+       if (*parent)
        {
-               ConnectClass c(timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax);
-               conf->Classes.push_back(c);
+               /* Find 'parent' and inherit a new class from it,
+                * then overwrite any values that are set here
+                */
+               ClassVector::iterator item = conf->Classes.begin();
+               for (; item != conf->Classes.end(); ++item)
+               {
+                       ConnectClass* c = *item;
+                       conf->GetInstance()->Log(DEBUG,"Class: %s", c->GetName().c_str());
+                       if (c->GetName() == parent)
+                       {
+                               ConnectClass* newclass = new ConnectClass(name, c);
+                               newclass->Update(timeout, flood, *allow ? allow : deny, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
+                               conf->Classes.push_back(newclass);
+                               break;
+                       }
+               }
+               if (item == conf->Classes.end())
+                       throw CoreException("Class name '" + std::string(name) + "' is configured to inherit from class '" + std::string(parent) + "' which cannot be found.");
        }
        else
        {
-               ConnectClass c(deny);
-               conf->Classes.push_back(c);
+               if (*allow)
+               {
+                       ConnectClass* c = new ConnectClass(name, timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans);
+                       c->limit = limit;
+                       c->SetPort(port);
+                       conf->Classes.push_back(c);
+               }
+               else
+               {
+                       ConnectClass* c = new ConnectClass(name, deny);
+                       c->SetPort(port);
+                       conf->Classes.push_back(c);
+               }
        }
 
        return true;
@@ -421,14 +535,15 @@ bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &v
 
 /* Callback called when there are no more <connect> tags
  */
-bool DoneConnect(ServerConfig* conf, const char* tag)
+bool DoneConnect(ServerConfig *conf, const char*)
 {
+       conf->GetInstance()->Log(DEFAULT, "Done adding connect classes!");
        return true;
 }
 
 /* Callback called before processing the first <uline> tag
  */
-bool InitULine(ServerConfig* conf, const char* tag)
+bool InitULine(ServerConfig* conf, const char*)
 {
        conf->ulines.clear();
        return true;
@@ -436,7 +551,7 @@ bool InitULine(ServerConfig* conf, const char* tag)
 
 /* Callback called to process a single <uline> tag
  */
-bool DoULine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+bool DoULine(ServerConfig* conf, const char*, char**, ValueList &values, int*)
 {
        const char* server = values[0].GetString();
        const bool silent = values[1].GetBool();
@@ -446,14 +561,14 @@ bool DoULine(ServerConfig* conf, const char* tag, char** entries, ValueList &val
 
 /* Callback called when there are no more <uline> tags
  */
-bool DoneULine(ServerConfig* conf, const char* tag)
+bool DoneULine(ServerConfig*, const char*)
 {
        return true;
 }
 
 /* Callback called before processing the first <module> tag
  */
-bool InitModule(ServerConfig* conf, const char* tag)
+bool InitModule(ServerConfig* conf, const char*)
 {
        old_module_names.clear();
        new_module_names.clear();
@@ -468,7 +583,7 @@ bool InitModule(ServerConfig* conf, const char* tag)
 
 /* Callback called to process a single <module> tag
  */
-bool DoModule(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+bool DoModule(ServerConfig*, const char*, char**, ValueList &values, int*)
 {
        const char* modname = values[0].GetString();
        new_module_names.push_back(modname);
@@ -477,7 +592,7 @@ bool DoModule(ServerConfig* conf, const char* tag, char** entries, ValueList &va
 
 /* Callback called when there are no more <module> tags
  */
-bool DoneModule(ServerConfig* conf, const char* tag)
+bool DoneModule(ServerConfig*, const char*)
 {
        // now create a list of new modules that are due to be loaded
        // and a seperate list of modules which are due to be unloaded
@@ -512,7 +627,7 @@ bool DoneModule(ServerConfig* conf, const char* tag)
 
 /* Callback called before processing the first <banlist> tag
  */
-bool InitMaxBans(ServerConfig* conf, const char* tag)
+bool InitMaxBans(ServerConfig* conf, const char*)
 {
        conf->maxbans.clear();
        return true;
@@ -520,7 +635,7 @@ bool InitMaxBans(ServerConfig* conf, const char* tag)
 
 /* Callback called to process a single <banlist> tag
  */
-bool DoMaxBans(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+bool DoMaxBans(ServerConfig* conf, const char*, char**, ValueList &values, int*)
 {
        const char* channel = values[0].GetString();
        int limit = values[1].GetInteger();
@@ -530,12 +645,12 @@ bool DoMaxBans(ServerConfig* conf, const char* tag, char** entries, ValueList &v
 
 /* Callback called when there are no more <banlist> tags.
  */
-bool DoneMaxBans(ServerConfig* conf, const char* tag)
+bool DoneMaxBans(ServerConfig*, const char*)
 {
        return true;
 }
 
-void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, userrec* user)
+void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, User* user)
 {
        ServerInstance->Log(DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
        if (bail)
@@ -574,12 +689,13 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
        }
 }
 
-void ServerConfig::Read(bool bail, userrec* user)
+void ServerConfig::Read(bool bail, User* user)
 {
        static char debug[MAXBUF];      /* Temporary buffer for debugging value */
        static char maxkeep[MAXBUF];    /* Temporary buffer for WhoWasMaxKeep value */
        static char hidemodes[MAXBUF];  /* Modes to not allow listing from users below halfop */
        static char exemptchanops[MAXBUF];      /* Exempt channel ops from these modes */
+       static char announceinvites[MAXBUF];    /* options:announceinvites setting */
        int rem = 0, add = 0;           /* Number of modules added, number of modules removed */
        std::ostringstream errstr;      /* String stream containing the error output */
 
@@ -594,6 +710,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_CHARPTR, ValidateServerName},
                {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR, NoValidation},
                {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_CHARPTR, NoValidation},
+               {"server",      "id",           "0",                    new ValueContainerInt  (&this->sid),                    DT_INTEGER, ValidateSID},
                {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR, NoValidation},
                {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR, NoValidation},
                {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
@@ -624,10 +741,11 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
                {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
                {"options",     "ircumsgprefix","0",                    new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN, NoValidation},
-               {"options",     "announceinvites", "1",                 new ValueContainerBool (&this->AnnounceInvites),        DT_BOOLEAN, NoValidation},
+               {"options",     "announceinvites", "1",                 new ValueContainerChar (announceinvites),               DT_CHARPTR, ValidateInvite},
                {"options",     "hostintopic",  "1",                    new ValueContainerBool (&this->FullHostInTopic),        DT_BOOLEAN, NoValidation},
                {"options",     "hidemodes",    "",                     new ValueContainerChar (hidemodes),                     DT_CHARPTR, ValidateModeLists},
                {"options",     "exemptchanops","",                     new ValueContainerChar (exemptchanops),                 DT_CHARPTR, ValidateExemptChanOps},
+               {"options",     "maxtargets",   "20",                   new ValueContainerUInt (&this->MaxTargets),             DT_INTEGER, ValidateMaxTargets},
                {"options",     "defaultmodes", "nt",                   new ValueContainerChar (this->DefaultModes),            DT_CHARPTR, NoValidation},
                {"pid",         "file",         "",                     new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
                {"whowas",      "groupsize",    "10",                   new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
@@ -636,7 +754,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"die",         "value",        "",                     new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
                {"channels",    "users",        "20",                   new ValueContainerUInt (&this->MaxChans),               DT_INTEGER, NoValidation},
                {"channels",    "opers",        "60",                   new ValueContainerUInt (&this->OperMaxChans),           DT_INTEGER, NoValidation},
-               {NULL}
+               {NULL,          NULL,           NULL,                   NULL,                                                   DT_NOTHING, NoValidation}
        };
 
        /* These tags can occur multiple times, and therefore they have special code to read them
@@ -647,12 +765,15 @@ void ServerConfig::Read(bool bail, userrec* user)
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
                                "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
+                               "name",         "parent",       "maxchans",     "limit",
                                NULL},
                                {"",            "",             "",             "",             "120",          "",
                                 "",            "",             "",             "3",            "3",            "0",
+                                "",            "",             "0",            "0",
                                 NULL},
                                {DT_CHARPTR,    DT_CHARPTR,     DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                                DT_INTEGER,    DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER},
+                                DT_INTEGER,    DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
+                                DT_CHARPTR,    DT_CHARPTR,     DT_INTEGER,     DT_INTEGER},
                                InitConnect, DoConnect, DoneConnect},
 
                {"uline",
@@ -677,19 +798,19 @@ void ServerConfig::Read(bool bail, userrec* user)
                                {"reason",      "ipmask",       NULL},
                                {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoZLine, DoneZLine},
+                               InitXLine, DoZLine, DoneConfItem},
 
                {"badnick",
                                {"reason",      "nick",         NULL},
                                {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoQLine, DoneQLine},
+                               InitXLine, DoQLine, DoneConfItem},
 
                {"badhost",
                                {"reason",      "host",         NULL},
                                {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
-                               InitXLine, DoKLine, DoneKLine},
+                               InitXLine, DoKLine, DoneConfItem},
 
                {"exception",
                                {"reason",      "host",         NULL},
@@ -709,7 +830,11 @@ void ServerConfig::Read(bool bail, userrec* user)
                                {DT_CHARPTR,    DT_CHARPTR},
                                InitClasses, DoClass, DoneClassesAndTypes},
 
-               {NULL}
+               {NULL,
+                               {NULL},
+                               {NULL},
+                               {0},
+                               NULL, NULL, NULL}
        };
 
        include_stack.clear();
@@ -736,7 +861,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                /* Check we dont have more than one of singular tags, or any of them missing
                 */
                for (int Index = 0; Once[Index]; Index++)
-                       if (!CheckOnce(Once[Index], bail, user))
+                       if (!CheckOnce(Once[Index]))
                                return;
 
                /* Read the values of all the tags which occur once or not at all, and call their callbacks.
@@ -879,7 +1004,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                {
                        for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
                        {
-                               if (ServerInstance->UnloadModule(removing->c_str()))
+                               if (ServerInstance->Modules->Unload(removing->c_str()))
                                {
                                        ServerInstance->WriteOpers("*** REHASH UNLOADED MODULE: %s",removing->c_str());
 
@@ -891,7 +1016,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                                else
                                {
                                        if (user)
-                                               user->WriteServ("972 %s %s :Failed to unload module %s: %s",user->nick, removing->c_str(), removing->c_str(), ServerInstance->ModuleError());
+                                               user->WriteServ("972 %s %s :Failed to unload module %s: %s",user->nick, removing->c_str(), removing->c_str(), ServerInstance->Modules->LastError());
                                }
                        }
                }
@@ -900,7 +1025,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                {
                        for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                        {
-                               if (ServerInstance->LoadModule(adding->c_str()))
+                               if (ServerInstance->Modules->Load(adding->c_str()))
                                {
                                        ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
 
@@ -912,7 +1037,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                                else
                                {
                                        if (user)
-                                               user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->ModuleError());
+                                               user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->Modules->LastError());
                                }
                        }
                }
@@ -920,6 +1045,9 @@ void ServerConfig::Read(bool bail, userrec* user)
                ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
        }
 
+       /** Note: This is safe, the method checks for user == NULL */
+       ServerInstance->Parser->SetupCommandTable(user);
+
        if (user)
                user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
        else
@@ -965,7 +1093,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
        include_stack.push_back(filename);
 
        /* Start reading characters... */
-       while(conf.get(ch))
+       while (conf.get(ch))
        {
 
                /*
@@ -991,10 +1119,10 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                 * no '>' then die with an error.
                 */
 
-               if((ch == '#') && !in_quote)
+               if ((ch == '#') && !in_quote)
                        in_comment = true;
 
-               switch(ch)
+               switch (ch)
                {
                        case '\n':
                                if (in_quote)
@@ -1041,11 +1169,11 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                if (ch != '\r')
                        line += ch;
 
-               if(ch == '<')
+               if (ch == '<')
                {
-                       if(in_tag)
+                       if (in_tag)
                        {
-                               if(!in_quote)
+                               if (!in_quote)
                                {
                                        errorstream << "Got another opening < when the first one wasn't closed: " << filename << ":" << linenumber << std::endl;
                                        return false;
@@ -1053,7 +1181,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                        else
                        {
-                               if(in_quote)
+                               if (in_quote)
                                {
                                        errorstream << "We're in a quote but outside a tag, interesting. " << filename << ":" << linenumber << std::endl;
                                        return false;
@@ -1065,11 +1193,11 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                }
                        }
                }
-               else if(ch == '"')
+               else if (ch == '"')
                {
-                       if(in_tag)
+                       if (in_tag)
                        {
-                               if(in_quote)
+                               if (in_quote)
                                {
                                        // errorstream << "Closing quote in config tag on line " << linenumber << std::endl;
                                        in_quote = false;
@@ -1082,7 +1210,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                        else
                        {
-                               if(in_quote)
+                               if (in_quote)
                                {
                                        errorstream << "Found a (closing) \" outside a tag: " << filename << ":" << linenumber << std::endl;
                                }
@@ -1092,11 +1220,11 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                }
                        }
                }
-               else if(ch == '>')
+               else if (ch == '>')
                {
-                       if(!in_quote)
+                       if (!in_quote)
                        {
-                               if(in_tag)
+                               if (in_tag)
                                {
                                        // errorstream << "Closing config tag on line " << linenumber << std::endl;
                                        in_tag = false;
@@ -1106,7 +1234,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                         * LoadConf() and load the included config into the same ConfigDataHash
                                         */
 
-                                       if(!this->ParseLine(target, line, linenumber, errorstream))
+                                       if (!this->ParseLine(target, line, linenumber, errorstream))
                                                return false;
 
                                        line.clear();
@@ -1120,6 +1248,13 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                }
        }
 
+       /* Fix for bug #392 - if we reach the end of a file and we are still in a quote or comment, most likely the user fucked up */
+       if (in_comment || in_quote)
+       {
+               errorstream << "Reached end of file whilst still inside a quoted section or tag. This is most likely an error or there \
+                       is a newline missing from the end of the file: " << filename << ":" << linenumber << std::endl;
+       }
+
        return true;
 }
 
@@ -1128,7 +1263,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const std::string &filename,
        return this->LoadConf(target, filename.c_str(), errorstream);
 }
 
-bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long linenumber, std::ostringstream &errorstream)
+bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &linenumber, std::ostringstream &errorstream)
 {
        std::string tagname;
        std::string current_key;
@@ -1140,17 +1275,15 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
 
        got_name = got_key = in_quote = false;
 
-       //std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
-
        for(std::string::iterator c = line.begin(); c != line.end(); c++)
        {
-               if(!got_name)
+               if (!got_name)
                {
                        /* We don't know the tag name yet. */
 
-                       if(*c != ' ')
+                       if (*c != ' ')
                        {
-                               if(*c != '<')
+                               if (*c != '<')
                                {
                                        tagname += *c;
                                }
@@ -1203,6 +1336,7 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                {
                                        /* Got a 'real' \n, treat it as part of the value */
                                        current_value += '\n';
+                                       linenumber++;
                                        continue;
                                }
                                else if ((*c == '\r') && (in_quote))
@@ -1226,9 +1360,9 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                                in_quote = false;
                                                got_key = false;
 
-                                               if((tagname == "include") && (current_key == "file"))
+                                               if ((tagname == "include") && (current_key == "file"))
                                                {
-                                                       if(!this->DoInclude(target, current_value, errorstream))
+                                                       if (!this->DoInclude(target, current_value, errorstream))
                                                                return false;
                                                }
 
@@ -1238,7 +1372,7 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                }
                                else
                                {
-                                       if(in_quote)
+                                       if (in_quote)
                                        {
                                                current_value += *c;
                                        }
@@ -1262,15 +1396,10 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
        confpath = ServerInstance->ConfigFileName;
        newfile = file;
 
-       for (std::string::iterator c = newfile.begin(); c != newfile.end(); c++)
-       {
-               if (*c == '\\')
-               {
-                       *c = '/';
-               }
-       }
+       std::replace(newfile.begin(),newfile.end(),'\\','/');
+       std::replace(confpath.begin(),confpath.end(),'\\','/');
 
-       if (file[0] != '/')
+       if (newfile[0] != '/')
        {
                if((pos = confpath.rfind("/")) != std::string::npos)
                {
@@ -1279,7 +1408,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
                }
                else
                {
-                       errorstream << "Couldn't get config path from: " << confpath << std::endl;
+                       errorstream << "Couldn't get config path from: " << ServerInstance->ConfigFileName << std::endl;
                        return false;
                }
        }
@@ -1308,7 +1437,7 @@ bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, con
 bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, const std::string &default_value, int index, std::string &result, bool allow_linefeeds)
 {
        ConfigDataHash::size_type pos = index;
-       if((pos >= 0) && (pos < target.count(tag)))
+       if (pos < target.count(tag))
        {
                ConfigDataHash::iterator iter = target.find(tag);
 
@@ -1456,7 +1585,7 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, in
 {
        ConfigDataHash::size_type pos = index;
 
-       if((pos >= 0) && (pos < target.count(tag)))
+       if (pos < target.count(tag))
        {
                ConfigDataHash::const_iterator iter = target.find(tag);
 
@@ -1650,6 +1779,14 @@ InspIRCd* ServerConfig::GetInstance()
        return ServerInstance;
 }
 
+std::string ServerConfig::GetSID()
+{
+       std::string OurSID;
+       OurSID += (char)((sid / 100) + 48);
+       OurSID += (char)((sid / 10) % 10 + 48);
+       OurSID += (char)(sid % 10 + 48);
+       return OurSID;
+}
 
 ValueItem::ValueItem(int value)
 {
@@ -1704,3 +1841,135 @@ bool ValueItem::GetBool()
        return (GetInteger() || v == "yes" || v == "true");
 }
 
+
+
+
+/*
+ * XXX should this be in a class? -- w00t
+ */
+bool InitTypes(ServerConfig* conf, const char*)
+{
+       if (conf->opertypes.size())
+       {
+               for (opertype_t::iterator n = conf->opertypes.begin(); n != conf->opertypes.end(); n++)
+               {
+                       if (n->second)
+                               delete[] n->second;
+               }
+       }
+
+       conf->opertypes.clear();
+       return true;
+}
+
+/*
+ * XXX should this be in a class? -- w00t
+ */
+bool InitClasses(ServerConfig* conf, const char*)
+{
+       if (conf->operclass.size())
+       {
+               for (operclass_t::iterator n = conf->operclass.begin(); n != conf->operclass.end(); n++)
+               {
+                       if (n->second)
+                               delete[] n->second;
+               }
+       }
+
+       conf->operclass.clear();
+       return true;
+}
+
+/*
+ * XXX should this be in a class? -- w00t
+ */
+bool DoType(ServerConfig* conf, const char*, char**, ValueList &values, int*)
+{
+       const char* TypeName = values[0].GetString();
+       const char* Classes = values[1].GetString();
+
+       conf->opertypes[TypeName] = strnewdup(Classes);
+       return true;
+}
+
+/*
+ * XXX should this be in a class? -- w00t
+ */
+bool DoClass(ServerConfig* conf, const char*, char**, ValueList &values, int*)
+{
+       const char* ClassName = values[0].GetString();
+       const char* CommandList = values[1].GetString();
+
+       conf->operclass[ClassName] = strnewdup(CommandList);
+       return true;
+}
+
+/*
+ * XXX should this be in a class? -- w00t
+ */
+bool DoneClassesAndTypes(ServerConfig*, const char*)
+{
+       return true;
+}
+
+
+
+bool InitXLine(ServerConfig* conf, const char* tag)
+{
+       return true;
+}
+
+bool DoZLine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+{
+       const char* reason = values[0].GetString();
+       const char* ipmask = values[1].GetString();
+
+       ZLine* zl = new ZLine(conf->GetInstance(), conf->GetInstance()->Time(), 0, "<Config>", reason, ipmask);
+       if (!conf->GetInstance()->XLines->AddLine(zl))
+               delete zl;
+
+       return true;
+}
+
+bool DoQLine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+{
+       const char* reason = values[0].GetString();
+       const char* nick = values[1].GetString();
+
+       QLine* ql = new QLine(conf->GetInstance(), conf->GetInstance()->Time(), 0, "<Config>", reason, nick);
+       if (!conf->GetInstance()->XLines->AddLine(ql))
+               delete ql;
+
+       return true;
+}
+
+bool DoKLine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+{
+       const char* reason = values[0].GetString();
+       const char* host = values[1].GetString();
+
+       XLineManager* xlm = conf->GetInstance()->XLines;
+
+       IdentHostPair ih = xlm->IdentSplit(host);
+
+       KLine* kl = new KLine(conf->GetInstance(), conf->GetInstance()->Time(), 0, "<Config>", reason, ih.first.c_str(), ih.second.c_str());
+       if (!xlm->AddLine(kl))
+               delete kl;
+       return true;
+}
+
+bool DoELine(ServerConfig* conf, const char* tag, char** entries, ValueList &values, int* types)
+{
+       const char* reason = values[0].GetString();
+       const char* host = values[1].GetString();
+
+       XLineManager* xlm = conf->GetInstance()->XLines;
+
+       IdentHostPair ih = xlm->IdentSplit(host);
+
+       ELine* el = new ELine(conf->GetInstance(), conf->GetInstance()->Time(), 0, "<Config>", reason, ih.first.c_str(), ih.second.c_str());
+       if (!xlm->AddLine(el))
+               delete el;
+       return true;
+}
+