]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Add RAWIO log level which is more verbose than DEBUG
[user/henk/code/inspircd.git] / src / configreader.cpp
index 3785e066c0dc6cc10d421deb3c0b50117682c53c..c93e37e1fc35f8a649e873af09cba4c481df5b02 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
  * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  * ---------------------------------------------------
  */
 
-/* $Core */
-/* $CopyInstall: conf/inspircd.quotes.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.rules.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.motd.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.helpop-full.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.helpop.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.censor.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.filter.example $(CONPATH) */
-/* $CopyInstall: conf/inspircd.conf.example $(CONPATH) */
-/* $CopyInstall: conf/modules.conf.example $(CONPATH) */
-/* $CopyInstall: conf/opers.conf.example $(CONPATH) */
-/* $CopyInstall: conf/links.conf.example $(CONPATH) */
-/* $CopyInstall: tools/gdbargs $(BASE)/.gdbargs */
-
 #include "inspircd.h"
 #include <fstream>
 #include "xline.h"
 #include "exitcodes.h"
 #include "commands/cmd_whowas.h"
-#include "modes/cmode_h.h"
 #include "configparser.h"
 
 ServerConfig::ServerConfig()
 {
        WhoWasGroupSize = WhoWasMaxGroups = WhoWasMaxKeep = 0;
-       NoUserDns = OperSpyWhois = HideBans = HideSplits = UndernetMsgPrefix = false;
-       CycleHosts = AllowHalfop = InvBypassModes = true;
-       dns_timeout = DieDelay = 5;
+       RawLog = NoUserDns = OperSpyWhois = HideBans = HideSplits = UndernetMsgPrefix = false;
+       WildcardIPv6 = CycleHosts = InvBypassModes = true;
+       dns_timeout = 5;
        MaxTargets = 20;
        NetBufferSize = 10240;
        SoftLimit = ServerInstance->SE->GetMaxFds();
        MaxConn = SOMAXCONN;
-       MaxWhoResults = 0;
        MaxChans = 20;
        OperMaxChans = 30;
        c_ipv4_range = 32;
@@ -53,28 +37,29 @@ ServerConfig::ServerConfig()
 void ServerConfig::Update005()
 {
        std::stringstream out(data005);
+       std::vector<std::string> data;
        std::string token;
+       while (out >> token)
+               data.push_back(token);
+       sort(data.begin(), data.end());
+
        std::string line5;
-       int token_counter = 0;
        isupport.clear();
-       while (out >> token)
+       for(unsigned int i=0; i < data.size(); i++)
        {
+               token = data[i];
                line5 = line5 + token + " ";
-               token_counter++;
-               if (token_counter >= 13)
+               if (i % 13 == 12)
                {
-                       char buf[MAXBUF];
-                       snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
-                       isupport.push_back(buf);
+                       line5.append(":are supported by this server");
+                       isupport.push_back(line5);
                        line5.clear();
-                       token_counter = 0;
                }
        }
        if (!line5.empty())
        {
-               char buf[MAXBUF];
-               snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
-               isupport.push_back(buf);
+               line5.append(":are supported by this server");
+               isupport.push_back(line5);
        }
 }
 
@@ -84,13 +69,6 @@ void ServerConfig::Send005(User* user)
                user->WriteNumeric(RPL_ISUPPORT, "%s %s", user->nick.c_str(), line->c_str());
 }
 
-static void ReqRead(ServerConfig* src, const std::string& tag, const std::string& key, std::string& dest)
-{
-       ConfigTag* t = src->ConfValue(tag);
-       if (!t || !t->readString(key, dest))
-               throw CoreException("You must specify a value for <" + tag + ":" + key + ">");
-}
-
 template<typename T, typename V>
 static void range(T& value, V min, V max, V def, const char* msg)
 {
@@ -103,63 +81,11 @@ static void range(T& value, V min, V max, V def, const char* msg)
 }
 
 
-/* NOTE: Before anyone asks why we're not using inet_pton for this, it is because inet_pton and friends do not return so much detail,
- * even in strerror(errno). They just return 'yes' or 'no' to an address without such detail as to whats WRONG with the address.
- * Because ircd users arent as technical as they used to be (;)) we are going to give more of a useful error message.
- */
 static void ValidIP(const std::string& ip, const std::string& key)
 {
-       const char* p = ip.c_str();
-       int num_dots = 0;
-       int num_seps = 0;
-       int not_numbers = false;
-       int not_hex = false;
-
-       if (*p)
-       {
-               if (*p == '.')
-                       throw CoreException("The value of "+key+" is not an IP address");
-
-               for (const char* ptr = p; *ptr; ++ptr)
-               {
-                       if (*ptr != ':' && *ptr != '.')
-                       {
-                               if (*ptr < '0' || *ptr > '9')
-                                       not_numbers = true;
-                               if ((*ptr < '0' || *ptr > '9') && (toupper(*ptr) < 'A' || toupper(*ptr) > 'F'))
-                                       not_hex = true;
-                       }
-                       switch (*ptr)
-                       {
-                               case ' ':
-                                       throw CoreException("The value of "+key+" is not an IP address");
-                               case '.':
-                                       num_dots++;
-                               break;
-                               case ':':
-                                       num_seps++;
-                               break;
-                       }
-               }
-
-               if (num_dots > 3)
-                       throw CoreException("The value of "+key+" is an IPv4 address with too many fields!");
-
-               if (num_seps > 8)
-                       throw CoreException("The value of "+key+" is an IPv6 address with too many fields!");
-
-               if (num_seps == 0 && num_dots < 3)
-                       throw CoreException("The value of "+key+" looks to be a malformed IPv4 address");
-
-               if (num_seps == 0 && num_dots == 3 && not_numbers)
-                       throw CoreException("The value of "+key+" contains non-numeric characters in an IPv4 address");
-
-               if (num_seps != 0 && not_hex)
-                       throw CoreException("The value of "+key+" contains non-hexdecimal characters in an IPv6 address");
-
-               if (num_seps != 0 && num_dots != 3 && num_dots != 0)
-                       throw CoreException("The value of "+key+" is a malformed IPv6 4in6 address");
-       }
+       irc::sockets::sockaddrs dummy;
+       if (!irc::sockets::aptosa(ip, 0, dummy))
+               throw CoreException("The value of "+key+" is not an IP address");
 }
 
 static void ValidHost(const std::string& p, const std::string& msg)
@@ -182,8 +108,6 @@ static void ValidHost(const std::string& p, const std::string& msg)
                throw CoreException("The value of "+msg+" is not a valid hostname");
 }
 
-// Specialized validators
-
 bool ServerConfig::ApplyDisabledCommands(const std::string& data)
 {
        std::stringstream dcmds(data);
@@ -224,8 +148,11 @@ static void FindDNS(std::string& server)
                if (server == "nameserver")
                {
                        resolv >> server;
-                       ServerInstance->Logs->Log("CONFIG",DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",server.c_str());
-                       return;
+                       if (server.find_first_not_of("0123456789.") == std::string::npos)
+                       {
+                               ServerInstance->Logs->Log("CONFIG",DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",server.c_str());
+                               return;
+                       }
                }
        }
 
@@ -261,6 +188,8 @@ void ServerConfig::CrossCheckOperClassType()
                std::string name = tag->getString("name");
                if (name.empty())
                        throw CoreException("<class:name> missing from tag at " + tag->getTagLocation());
+               if (operclass.find(name) != operclass.end())
+                       throw CoreException("Duplicate class block with name " + name + " at " + tag->getTagLocation());
                operclass[name] = tag;
        }
        tags = ConfTags("type");
@@ -270,12 +199,14 @@ void ServerConfig::CrossCheckOperClassType()
                std::string name = tag->getString("name");
                if (name.empty())
                        throw CoreException("<type:name> is missing from tag at " + tag->getTagLocation());
-
                if (!ServerInstance->IsNick(name.c_str(), Limits.NickMax))
                        throw CoreException("<type:name> is invalid (value '" + name + "')");
+               if (oper_blocks.find(" " + name) != oper_blocks.end())
+                       throw CoreException("Duplicate type block with name " + name + " at " + tag->getTagLocation());
 
                OperInfo* ifo = new OperInfo;
                oper_blocks[" " + name] = ifo;
+               ifo->name = name;
                ifo->type_block = tag;
 
                std::string classname;
@@ -323,14 +254,31 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                for(ClassVector::iterator i = current->Classes.begin(); i != current->Classes.end(); ++i)
                {
                        ConnectClass* c = *i;
-                       std::string typeMask = (c->type == CC_ALLOW) ? "a" : "d";
-                       typeMask += c->host;
-                       oldBlocksByMask[typeMask] = c;
+                       if (c->name.substr(0, 8) != "unnamed-")
+                       {
+                               oldBlocksByMask["n" + c->name] = c;
+                       }
+                       else if (c->type == CC_ALLOW || c->type == CC_DENY)
+                       {
+                               std::string typeMask = (c->type == CC_ALLOW) ? "a" : "d";
+                               typeMask += c->host;
+                               oldBlocksByMask[typeMask] = c;
+                       }
                }
        }
 
-       ClassMap newBlocksByMask;
-       Classes.resize(config_data.count("connect"));
+       int blk_count = config_data.count("connect");
+       if (blk_count == 0)
+       {
+               // No connect blocks found; make a trivial default block
+               std::vector<KeyVal>* items;
+               ConfigTag* tag = ConfigTag::create("connect", "<auto>", 0, items);
+               items->push_back(std::make_pair("allow", "*"));
+               config_data.insert(std::make_pair("connect", tag));
+               blk_count = 1;
+       }
+
+       Classes.resize(blk_count);
        std::map<std::string, int> names;
 
        bool try_again = true;
@@ -354,21 +302,14 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                                {
                                        try_again = true;
                                        // couldn't find parent this time. If it's the last time, we'll never find it.
-                                       if (tries == 50)
-                                               throw CoreException("Could not find parent connect class \"" + parentName + "\" for connect block " + ConvToStr(i));
+                                       if (tries >= blk_count)
+                                               throw CoreException("Could not find parent connect class \"" + parentName + "\" for connect block at " + tag->getTagLocation());
                                        continue;
                                }
                                parent = Classes[parentIter->second];
                        }
 
                        std::string name = tag->getString("name");
-                       if (!name.empty())
-                       {
-                               if (names.find(name) != names.end())
-                                       throw CoreException("Two connect classes with name \"" + name + "\" defined!");
-                               names[name] = i;
-                       }
-
                        std::string mask, typeMask;
                        char type;
 
@@ -382,23 +323,36 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                                type = CC_DENY;
                                typeMask = 'd' + mask;
                        }
+                       else if (!name.empty())
+                       {
+                               type = CC_NAMED;
+                               mask = name;
+                               typeMask = 'n' + mask;
+                       }
                        else
                        {
-                               throw CoreException("Connect class must have an allow or deny mask at " + tag->getTagLocation());
+                               throw CoreException("Connect class must have allow, deny, or name specified at " + tag->getTagLocation());
                        }
-                       ClassMap::iterator dupMask = newBlocksByMask.find(typeMask);
-                       if (dupMask != newBlocksByMask.end())
-                               throw CoreException("Two connect classes cannot have the same mask (" + mask + ")");
+
+                       if (name.empty())
+                       {
+                               name = "unnamed-" + ConvToStr(i);
+                       }
+                       else
+                       {
+                               typeMask = 'n' + name;
+                       }
+
+                       if (names.find(name) != names.end())
+                               throw CoreException("Two connect classes with name \"" + name + "\" defined!");
+                       names[name] = i;
 
                        ConnectClass* me = parent ? 
                                new ConnectClass(tag, type, mask, *parent) :
                                new ConnectClass(tag, type, mask);
 
-                       if (!name.empty())
-                               me->name = name;
+                       me->name = name;
 
-                       tag->readString("password", me->pass);
-                       tag->readString("hash", me->hash);
                        me->registration_timeout = tag->getInt("timeout", me->registration_timeout);
                        me->pingtime = tag->getInt("pingfreq", me->pingtime);
                        std::string sendq;
@@ -416,9 +370,10 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                        me->hardsendqmax = tag->getInt("hardsendq", me->hardsendqmax);
                        me->recvqmax = tag->getInt("recvq", me->recvqmax);
                        me->penaltythreshold = tag->getInt("threshold", me->penaltythreshold);
+                       me->commandrate = tag->getInt("commandrate", me->commandrate);
+                       me->fakelag = tag->getBool("fakelag", me->fakelag);
                        me->maxlocal = tag->getInt("localmax", me->maxlocal);
                        me->maxglobal = tag->getInt("globalmax", me->maxglobal);
-                       me->port = tag->getInt("port", me->port);
                        me->maxchans = tag->getInt("maxchans", me->maxchans);
                        me->limit = tag->getInt("limit", me->limit);
 
@@ -431,7 +386,6 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                                delete me;
                                me = old;
                        }
-                       newBlocksByMask[typeMask] = me;
                        Classes[i] = me;
                }
        }
@@ -471,19 +425,32 @@ static const Deprecated ChangedConfig[] = {
        {"options", "netbuffersize",    "has been moved to <performance:netbuffersize> as of 1.2a3"},
        {"options", "maxwho",           "has been moved to <performance:maxwho> as of 1.2a3"},
        {"options",     "loglevel",             "1.2 does not use the loglevel value. Please define <log> tags instead."},
-       {"die",     "value",            "has always been deprecated"},
+       {"die",     "value",            "you need to reread your config"},
 };
 
 void ServerConfig::Fill()
 {
-       ReqRead(this, "server", "name", ServerName);
-       ReqRead(this, "power", "diepass", diepass);
-       ReqRead(this, "power", "restartpass", restartpass);
-
        ConfigTag* options = ConfValue("options");
        ConfigTag* security = ConfValue("security");
+       if (sid.empty())
+       {
+               ServerName = ConfValue("server")->getString("name");
+               sid = ConfValue("server")->getString("id");
+               ValidHost(ServerName, "<server:name>");
+               if (!sid.empty() && !ServerInstance->IsSID(sid))
+                       throw CoreException(sid + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
+       }
+       else
+       {
+               if (ServerName != ConfValue("server")->getString("name"))
+                       throw CoreException("You must restart to change the server name or SID");
+               std::string nsid = ConfValue("server")->getString("id");
+               if (!nsid.empty() && nsid != sid)
+                       throw CoreException("You must restart to change the server name or SID");
+       }
+       diepass = ConfValue("power")->getString("diepass");
+       restartpass = ConfValue("power")->getString("restartpass");
        powerhash = ConfValue("power")->getString("hash");
-       DieDelay = ConfValue("power")->getInt("pause");
        PrefixQuit = options->getString("prefixquit");
        SuffixQuit = options->getString("suffixquit");
        FixedQuit = options->getString("fixedquit");
@@ -495,18 +462,16 @@ void ServerConfig::Fill()
        MoronBanner = options->getString("moronbanner", "You're banned!");
        ServerDesc = ConfValue("server")->getString("description", "Configure Me");
        Network = ConfValue("server")->getString("network", "Network");
-       sid = ConfValue("server")->getString("id", "");
        AdminName = ConfValue("admin")->getString("name", "");
        AdminEmail = ConfValue("admin")->getString("email", "null@example.com");
        AdminNick = ConfValue("admin")->getString("nick", "admin");
        ModPath = ConfValue("path")->getString("moduledir", MOD_PATH);
        NetBufferSize = ConfValue("performance")->getInt("netbuffersize", 10240);
-       MaxWhoResults = ConfValue("performance")->getInt("maxwho", 1024);
        dns_timeout = ConfValue("dns")->getInt("timeout", 5);
        DisabledCommands = ConfValue("disabled")->getString("commands", "");
        DisabledDontExist = ConfValue("disabled")->getBool("fakenonexistant");
        UserStats = security->getString("userstats");
-       CustomVersion = security->getString("customversion");
+       CustomVersion = security->getString("customversion", Network + " IRCd");
        HideSplits = security->getBool("hidesplits");
        HideBans = security->getBool("hidebans");
        HideWhoisServer = security->getString("hidewhois");
@@ -517,6 +482,7 @@ void ServerConfig::Fill()
        NoUserDns = ConfValue("performance")->getBool("nouserdns");
        SyntaxHints = options->getBool("syntaxhints");
        CycleHosts = options->getBool("cyclehosts");
+       CycleHostsFromUser = options->getBool("cyclehostsfromuser");
        UndernetMsgPrefix = options->getBool("ircumsgprefix");
        FullHostInTopic = options->getBool("hostintopic");
        MaxTargets = security->getInt("maxtargets", 20);
@@ -525,11 +491,10 @@ void ServerConfig::Fill()
        WhoWasGroupSize = ConfValue("whowas")->getInt("groupsize");
        WhoWasMaxGroups = ConfValue("whowas")->getInt("maxgroups");
        WhoWasMaxKeep = ServerInstance->Duration(ConfValue("whowas")->getString("maxkeep"));
-       DieValue = ConfValue("die")->getString("value");
-       MaxChans = ConfValue("channels")->getInt("users");
-       OperMaxChans = ConfValue("channels")->getInt("opers");
-       c_ipv4_range = ConfValue("cidr")->getInt("ipv4clone");
-       c_ipv6_range = ConfValue("cidr")->getInt("ipv6clone");
+       MaxChans = ConfValue("channels")->getInt("users", 20);
+       OperMaxChans = ConfValue("channels")->getInt("opers", 60);
+       c_ipv4_range = ConfValue("cidr")->getInt("ipv4clone", 32);
+       c_ipv6_range = ConfValue("cidr")->getInt("ipv6clone", 128);
        Limits.NickMax = ConfValue("limits")->getInt("maxnick", 32);
        Limits.ChanMax = ConfValue("limits")->getInt("maxchan", 64);
        Limits.MaxModes = ConfValue("limits")->getInt("maxmodes", 20);
@@ -545,16 +510,30 @@ void ServerConfig::Fill()
        range(MaxConn, 0, SOMAXCONN, SOMAXCONN, "<performance:somaxconn>");
        range(MaxTargets, 1, 31, 20, "<security:maxtargets>");
        range(NetBufferSize, 1024, 65534, 10240, "<performance:netbuffersize>");
-       range(MaxWhoResults, 1, 65535, 1024, "<performace:maxwho>");
        range(WhoWasGroupSize, 0, 10000, 10, "<whowas:groupsize>");
        range(WhoWasMaxGroups, 0, 1000000, 10240, "<whowas:maxgroups>");
        range(WhoWasMaxKeep, 3600, INT_MAX, 3600, "<whowas:maxkeep>");
 
        ValidIP(DNSServer, "<dns:server>");
-       ValidHost(ServerName, "<server:name>");
-       if (!sid.empty() && !ServerInstance->IsSID(sid))
-               throw CoreException(sid + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
 
+       std::string defbind = options->getString("defaultbind");
+       if (assign(defbind) == "ipv4")
+       {
+               WildcardIPv6 = false;
+       }
+       else if (assign(defbind) == "ipv6")
+       {
+               WildcardIPv6 = true;
+       }
+       else
+       {
+               WildcardIPv6 = true;
+               int socktest = socket(AF_INET6, SOCK_STREAM, 0);
+               if (socktest < 0)
+                       WildcardIPv6 = false;
+               else
+                       close(socktest);
+       }
        ConfigTagList tags = ConfTags("uline");
        for(ConfigIter i = tags.first; i != tags.second; ++i)
        {
@@ -612,9 +591,6 @@ void ServerConfig::Fill()
        Limits.Finalise();
 }
 
-/* These tags MUST occur and must ONLY occur once in the config file */
-static const char* const Once[] = { "server", "admin", "files", "power", "options" };
-
 // WARNING: it is not safe to use most of the codebase in this function, as it
 // will run in the config reader thread
 void ServerConfig::Read()
@@ -633,8 +609,6 @@ void ServerConfig::Read()
        }
        if (valid)
        {
-               ReadFile(MOTD, ConfValue("files")->getString("motd"));
-               ReadFile(RULES, ConfValue("files")->getString("rules"));
                DNSServer = ConfValue("dns")->getString("server");
                FindDNS(DNSServer);
        }
@@ -643,27 +617,19 @@ void ServerConfig::Read()
 void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
 {
        valid = true;
+       if (old)
+       {
+               /*
+                * These values can only be set on boot. Keep their old values. Do it before we send messages so we actually have a servername.
+                */
+               this->ServerName = old->ServerName;
+               this->sid = old->sid;
+               this->cmdline = old->cmdline;
+       }
 
        /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
        try
        {
-               /* Check we dont have more than one of singular tags, or any of them missing
-                */
-               for (int Index = 0; Index * sizeof(*Once) < sizeof(Once); Index++)
-               {
-                       std::string tag = Once[Index];
-                       ConfigTagList tags = ConfTags(tag);
-                       if (tags.first == tags.second)
-                               throw CoreException("You have not defined a <"+tag+"> tag, this is required.");
-                       tags.first++;
-                       if (tags.first != tags.second)
-                       {
-                               errstr << "You have more than one <" << tag << "> tag.\n"
-                                       << "First occurrence at " << ConfValue(tag)->getTagLocation()
-                                       << "; second occurrence at " << tags.first->second->getTagLocation() << std::endl;
-                       }
-               }
-
                for (int Index = 0; Index * sizeof(Deprecated) < sizeof(ChangedConfig); Index++)
                {
                        std::string dummy;
@@ -687,16 +653,12 @@ void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
        // write once here, to try it out and make sure its ok
        ServerInstance->WritePID(this->PID);
 
-       /*
-        * These values can only be set on boot. Keep their old values. Do it before we send messages so we actually have a servername.
-        */
+       // Check errors before dealing with failed binds, since continuing on failed bind is wanted in some circumstances.
+       valid = errstr.str().empty();
+
        if (old)
        {
-               this->ServerName = old->ServerName;
-               this->sid = old->sid;
-               this->cmdline = old->cmdline;
-
-               // Same for ports... they're bound later on first run.
+               // On first run, ports are bound later on
                FailedPortList pl;
                ServerInstance->BindPorts(pl);
                if (pl.size())
@@ -715,7 +677,6 @@ void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
 
        User* user = useruid.empty() ? NULL : ServerInstance->FindNick(useruid);
 
-       valid = errstr.str().empty();
        if (!valid)
                ServerInstance->Logs->Log("CONFIG",DEFAULT, "There were errors in your configuration file:");
 
@@ -749,9 +710,6 @@ void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
                        ServerInstance->Exit(EXIT_STATUS_CONFIG);
                }
 
-               if (ConfValue("options")->getBool("allowhalfop"))
-                       ServerInstance->Modes->AddMode(new ModeChannelHalfOp);
-
                return;
        }
 
@@ -768,18 +726,6 @@ void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
 
 void ServerConfig::ApplyModules(User* user)
 {
-       bool AllowHalfOp = ConfValue("options")->getBool("allowhalfop");
-       ModeHandler* mh = ServerInstance->Modes->FindMode('h', MODETYPE_CHANNEL);
-       if (AllowHalfOp && !mh) {
-               ServerInstance->Logs->Log("CONFIG", DEFAULT, "Enabling halfop mode.");
-               mh = new ModeChannelHalfOp;
-               ServerInstance->Modes->AddMode(mh);
-       } else if (!AllowHalfOp && mh) {
-               ServerInstance->Logs->Log("CONFIG", DEFAULT, "Disabling halfop mode.");
-               ServerInstance->Modes->DelMode(mh);
-               delete mh;
-       }
-
        Module* whowas = ServerInstance->Modules->Find("cmd_whowas.so");
        if (whowas)
                WhowasRequest(NULL, whowas, WhowasRequest::WHOWAS_PRUNE).Send();
@@ -802,6 +748,9 @@ void ServerConfig::ApplyModules(User* user)
                }
        }
 
+       if (ConfValue("options")->getBool("allowhalfop") && removed_modules.erase("m_halfop.so") == 0)
+               added_modules.push_back("m_halfop.so");
+
        for (std::set<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
        {
                // Don't remove cmd_*.so, just remove m_*.so
@@ -853,10 +802,15 @@ bool ServerConfig::StartsWithWindowsDriveLetter(const std::string &path)
 
 ConfigTag* ServerConfig::ConfValue(const std::string &tag)
 {
-       ConfigDataHash::iterator iter = config_data.find(tag);
-       if (iter == config_data.end())
+       ConfigTagList found = config_data.equal_range(tag);
+       if (found.first == found.second)
                return NULL;
-       return iter->second;
+       ConfigTag* rv = found.first->second;
+       found.first++;
+       if (found.first != found.second)
+               ServerInstance->Logs->Log("CONFIG",DEFAULT, "Multiple <" + tag + "> tags found; only first will be used "
+                       "(first at " + rv->getTagLocation() + "; second at " + found.first->second->getTagLocation() + ")");
+       return rv;
 }
 
 ConfigTagList ServerConfig::ConfTags(const std::string& tag)
@@ -864,34 +818,6 @@ ConfigTagList ServerConfig::ConfTags(const std::string& tag)
        return config_data.equal_range(tag);
 }
 
-/** Read the contents of a file located by `fname' into a file_cache pointed at by `F'.
- */
-bool ServerConfig::ReadFile(file_cache &F, const std::string& fname)
-{
-       if (fname.empty())
-               return false;
-
-       char linebuf[MAXBUF];
-
-       F.clear();
-
-       FileWrapper file(fopen(fname.c_str(), "r"));
-
-       if (!file)
-               return false;
-       while (!feof(file))
-       {
-               if (fgets(linebuf, sizeof(linebuf), file))
-                       linebuf[strlen(linebuf)-1] = 0;
-               else
-                       *linebuf = 0;
-
-               F.push_back(*linebuf ? linebuf : " ");
-       }
-
-       return true;
-}
-
 bool ServerConfig::FileExists(const char* file)
 {
        struct stat sb;
@@ -933,9 +859,7 @@ void ConfigReaderThread::Finish()
 {
        ServerConfig* old = ServerInstance->Config;
        ServerInstance->Logs->Log("CONFIG",DEBUG,"Switching to new configuration...");
-       ServerInstance->Logs->CloseLogs();
        ServerInstance->Config = this->Config;
-       ServerInstance->Logs->OpenFileLogs();
        Config->Apply(old, TheUserUID);
 
        if (Config->valid)
@@ -952,17 +876,21 @@ void ConfigReaderThread::Finish()
                ServerInstance->Res->Rehash();
                ServerInstance->ResetMaxBans();
                Config->ApplyDisabledCommands(Config->DisabledCommands);
-               User* user = TheUserUID.empty() ? ServerInstance->FindNick(TheUserUID) : NULL;
+               User* user = ServerInstance->FindNick(TheUserUID);
                FOREACH_MOD(I_OnRehash, OnRehash(user));
                ServerInstance->BuildISupport();
 
+               ServerInstance->Logs->CloseLogs();
+               ServerInstance->Logs->OpenFileLogs();
+
+               if (Config->RawLog)
+                       ServerInstance->Users->ServerNoticeAll("*** Raw I/O logging is enabled on this server. All messages, passwords, and commands are being recorded.");
+
                Config = old;
        }
        else
        {
                // whoops, abort!
-               ServerInstance->Logs->CloseLogs();
                ServerInstance->Config = old;
-               ServerInstance->Logs->OpenFileLogs();
        }
 }