]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Cut down on debug on restart
[user/henk/code/inspircd.git] / src / configreader.cpp
index 37153afdd945641f7826f1eb2e72bafaf3d23168..dde2d04db0793bbe64b974208a449d1c8224318d 100644 (file)
@@ -2,14 +2,11 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                    E-mail:
- *             <brain@chatspike.net>
- *             <Craig@chatspike.net>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
+ *
  * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
@@ -25,7 +22,7 @@ std::vector<std::string> old_module_names, new_module_names, added_modules, remo
 ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
 {
        this->ClearStack();
-       *TempDir = *ServerName = *Network = *ServerDesc = *AdminName = '\0';
+       *ServerName = *Network = *ServerDesc = *AdminName = '\0';
        *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = '\0';
        *CustomVersion = *motd = *rules = *PrefixQuit = *DieValue = *DNSServer = '\0';
        *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = '\0';
@@ -57,6 +54,12 @@ Module* ServerConfig::GetIOHook(int port)
        return (x != IOHookModule.end() ? x->second : NULL);
 }
 
+Module* ServerConfig::GetIOHook(InspSocket* is)
+{
+       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       return (x != SocketIOHookModule.end() ? x->second : NULL);
+}
+
 bool ServerConfig::AddIOHook(int port, Module* iomod)
 {
        if (!GetIOHook(port))
@@ -66,8 +69,23 @@ bool ServerConfig::AddIOHook(int port, Module* iomod)
        }
        else
        {
-               ModuleException err("Port already hooked by another module");
-               throw(err);
+               throw ModuleException("Port already hooked by another module");
+               return false;
+       }
+}
+
+bool ServerConfig::AddIOHook(Module* iomod, InspSocket* is)
+{
+       if (!GetIOHook(is))
+       {
+               ServerInstance->Log(DEBUG,"Hooked inspsocket %08x", is);
+               SocketIOHookModule[is] = iomod;
+               is->IsIOHooked = true;
+               return true;
+       }
+       else
+       {
+               throw ModuleException("InspSocket derived class already hooked by another module");
                return false;
        }
 }
@@ -83,6 +101,48 @@ bool ServerConfig::DelIOHook(int port)
        return false;
 }
 
+bool ServerConfig::DelIOHook(InspSocket* is)
+{
+       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       if (x != SocketIOHookModule.end())
+       {
+               SocketIOHookModule.erase(x);
+               return true;
+       }
+       return false;
+}
+
+void ServerConfig::Update005()
+{
+       std::stringstream out(data005);
+       std::string token;
+       std::string line5;
+       int token_counter = 0;
+       isupport.clear();
+       while (out >> token)
+       {
+               line5 = line5 + token + " ";
+               token_counter++;
+               if (token_counter >= 13)
+               {
+                       char buf[MAXBUF];
+                       snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
+                       isupport.push_back(buf);
+                       line5 = "";
+                       token_counter = 0;
+               }
+       }
+       char buf[MAXBUF];
+       snprintf(buf, MAXBUF, "%s:are supported by this server", line5.c_str());
+       isupport.push_back(buf);
+}
+
+void ServerConfig::Send005(userrec* user)
+{
+       for (std::vector<std::string>::iterator line = ServerInstance->Config->isupport.begin(); line != ServerInstance->Config->isupport.end(); line++)
+               user->WriteServ("005 %s %s", user->nick, line->c_str());
+}
+
 bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
 {
        int count = ConfValueEnum(this->config_data, tag);
@@ -140,13 +200,6 @@ bool NoValidation(ServerConfig* conf, const char* tag, const char* value, ValueI
        return true;
 }
 
-bool ValidateTempDir(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
-{
-       if (!*(data.GetString()))
-               data.Set("/tmp");
-       return true;
-}
 bool ValidateMaxTargets(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
        if ((data.GetInteger() < 0) || (data.GetInteger() > 31))
@@ -222,7 +275,7 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, V
                                if ((nameserver == "nameserver") && (!found_server))
                                {
                                        resolv >> nameserver;
-                                       data.Set(nameserver);
+                                       data.Set(nameserver.c_str());
                                        found_server = true;
                                        conf->GetInstance()->Log(DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
                                }
@@ -256,7 +309,8 @@ bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value,
        if (!strchr(data.GetString(),'.'))
        {
                conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
-               data.Set(std::string(data.GetString()) + ".");
+               std::string moo = std::string(data.GetString()).append(".");
+               data.Set(moo.c_str());
        }
        return true;
 }
@@ -362,45 +416,13 @@ bool DoConnect(ServerConfig* conf, const char* tag, char** entries, ValueList &v
 
        if (*allow)
        {
-               c.host = allow;
-               c.type = CC_ALLOW;
-               c.pass = password;
-               c.registration_timeout = timeout;
-               c.pingtime = pingfreq;
-               c.flood = flood;
-               c.threshold = threshold;
-               c.sendqmax = sendq;
-               c.recvqmax = recvq;
-               c.maxlocal = localmax;
-               c.maxglobal = globalmax;
-
-
-               if (c.maxlocal == 0)
-                       c.maxlocal = 3;
-               if (c.maxglobal == 0)
-                       c.maxglobal = 3;
-               if (c.threshold == 0)
-               {
-                       c.threshold = 1;
-                       c.flood = 999;
-                       conf->GetInstance()->Log(DEFAULT,"Warning: Connect allow line '%s' has no flood/threshold settings. Setting this tag to 999 lines in 1 second.",c.host.c_str());
-               }
-               if (c.sendqmax == 0)
-                       c.sendqmax = 262114;
-               if (c.recvqmax == 0)
-                       c.recvqmax = 4096;
-               if (c.registration_timeout == 0)
-                       c.registration_timeout = 90;
-               if (c.pingtime == 0)
-                       c.pingtime = 120;
+               ConnectClass c(timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax);
                conf->Classes.push_back(c);
        }
        else
        {
-               c.host = deny;
-               c.type = CC_DENY;
+               ConnectClass c(deny);
                conf->Classes.push_back(c);
-               conf->GetInstance()->Log(DEBUG,"Read connect class type DENY, host=%s",deny);
        }
 
        return true;
@@ -523,6 +545,45 @@ bool DoneMaxBans(ServerConfig* conf, const char* tag)
        return true;
 }
 
+void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, userrec* user)
+{
+       ServerInstance->Log(DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
+       if (bail)
+       {
+               /* Unneeded because of the ServerInstance->Log() aboive? */
+               printf("There were errors in your configuration:\n%s\n\n",errormessage.c_str());
+               InspIRCd::Exit(ERROR);
+       }
+       else
+       {
+               std::string errors = errormessage;
+               std::string::size_type start;
+               unsigned int prefixlen;
+               start = 0;
+               /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
+               prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
+               if (user)
+               {
+                       user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick);
+                       while (start < errors.length())
+                       {
+                               user->WriteServ("NOTICE %s :%s",user->nick, errors.substr(start, 510 - prefixlen).c_str());
+                               start += 510 - prefixlen;
+                       }
+               }
+               else
+               {
+                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       while (start < errors.length())
+                       {
+                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               start += 360;
+                       }
+               }
+               return;
+       }
+}
+
 void ServerConfig::Read(bool bail, userrec* user)
 {
        static char debug[MAXBUF];      /* Temporary buffer for debugging value */
@@ -534,51 +595,51 @@ void ServerConfig::Read(bool bail, userrec* user)
        static char* Once[] = { "server", "admin", "files", "power", "options", NULL };
 
        /* These tags can occur ONCE or not at all */
-       static InitialConfig Values[] = {
-               {"options",             "softlimit",                    &this->SoftLimit,               DT_INTEGER, ValidateSoftLimit},
-               {"options",             "somaxconn",                    &this->MaxConn,                 DT_INTEGER, ValidateMaxConn},
-               {"server",              "name",                         &this->ServerName,              DT_CHARPTR, ValidateServerName},
-               {"server",              "description",                  &this->ServerDesc,              DT_CHARPTR, NoValidation},
-               {"server",              "network",                      &this->Network,                 DT_CHARPTR, NoValidation},
-               {"admin",               "name",                         &this->AdminName,               DT_CHARPTR, NoValidation},
-               {"admin",               "email",                        &this->AdminEmail,              DT_CHARPTR, NoValidation},
-               {"admin",               "nick",                         &this->AdminNick,               DT_CHARPTR, NoValidation},
-               {"files",               "motd",                         &this->motd,                    DT_CHARPTR, ValidateMotd},
-               {"files",               "rules",                        &this->rules,                   DT_CHARPTR, ValidateRules},
-               {"power",               "diepass",                      &this->diepass,                 DT_CHARPTR, NoValidation},      
-               {"power",               "pause",                        &this->DieDelay,                DT_INTEGER, NoValidation},
-               {"power",               "restartpass",                  &this->restartpass,             DT_CHARPTR, NoValidation},
-               {"options",             "prefixquit",                   &this->PrefixQuit,              DT_CHARPTR, NoValidation},
-               {"die",                 "value",                        &this->DieValue,                DT_CHARPTR, NoValidation},
-               {"options",             "loglevel",                     &debug,                         DT_CHARPTR, ValidateLogLevel},
-               {"options",             "netbuffersize",                &this->NetBufferSize,           DT_INTEGER, ValidateNetBufferSize},
-               {"options",             "maxwho",                       &this->MaxWhoResults,           DT_INTEGER, ValidateMaxWho},
-               {"options",             "allowhalfop",                  &this->AllowHalfop,             DT_BOOLEAN, NoValidation},
-               {"dns",                 "server",                       &this->DNSServer,               DT_CHARPTR, ValidateDnsServer},
-               {"dns",                 "timeout",                      &this->dns_timeout,             DT_INTEGER, ValidateDnsTimeout},
-               {"options",             "moduledir",                    &this->ModPath,                 DT_CHARPTR, ValidateModPath},
-               {"disabled",            "commands",                     &this->DisabledCommands,        DT_CHARPTR, NoValidation},
-               {"options",             "userstats",                    &this->UserStats,               DT_CHARPTR, NoValidation},
-               {"options",             "customversion",                &this->CustomVersion,           DT_CHARPTR, NoValidation},
-               {"options",             "hidesplits",                   &this->HideSplits,              DT_BOOLEAN, NoValidation},
-               {"options",             "hidebans",                     &this->HideBans,                DT_BOOLEAN, NoValidation},
-               {"options",             "hidewhois",                    &this->HideWhoisServer,         DT_CHARPTR, NoValidation},
-               {"options",             "operspywhois",                 &this->OperSpyWhois,            DT_BOOLEAN, NoValidation},
-               {"options",             "tempdir",                      &this->TempDir,                 DT_CHARPTR, ValidateTempDir},
-               {"options",             "nouserdns",                    &this->NoUserDns,               DT_BOOLEAN, NoValidation},
-               {"options",             "syntaxhints",                  &this->SyntaxHints,             DT_BOOLEAN, NoValidation},
-               {"options",             "cyclehosts",                   &this->CycleHosts,              DT_BOOLEAN, NoValidation},
-               {"pid",                 "file",                         &this->PID,                     DT_CHARPTR, NoValidation},
-               {"whowas",              "groupsize",                    &this->WhoWasGroupSize,         DT_INTEGER, NoValidation},
-               {"whowas",              "maxgroups",                    &this->WhoWasMaxGroups,         DT_INTEGER, NoValidation},
-               {"whowas",              "maxkeep",                      &maxkeep,                       DT_CHARPTR, ValidateWhoWas},
+       InitialConfig Values[] = {
+               {"options",             "softlimit",                    new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER, ValidateSoftLimit},
+               {"options",             "somaxconn",                    new ValueContainerInt  (&this->MaxConn),                DT_INTEGER, ValidateMaxConn},
+               {"server",              "name",                         new ValueContainerChar (this->ServerName),              DT_CHARPTR, ValidateServerName},
+               {"server",              "description",                  new ValueContainerChar (this->ServerDesc),              DT_CHARPTR, NoValidation},
+               {"server",              "network",                      new ValueContainerChar (this->Network),                 DT_CHARPTR, NoValidation},
+               {"admin",               "name",                         new ValueContainerChar (this->AdminName),               DT_CHARPTR, NoValidation},
+               {"admin",               "email",                        new ValueContainerChar (this->AdminEmail),              DT_CHARPTR, NoValidation},
+               {"admin",               "nick",                         new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
+               {"files",               "motd",                         new ValueContainerChar (this->motd),                    DT_CHARPTR, ValidateMotd},
+               {"files",               "rules",                        new ValueContainerChar (this->rules),                   DT_CHARPTR, ValidateRules},
+               {"power",               "diepass",                      new ValueContainerChar (this->diepass),                 DT_CHARPTR, NoValidation},      
+               {"power",               "pause",                        new ValueContainerInt  (&this->DieDelay),               DT_INTEGER, NoValidation},
+               {"power",               "restartpass",                  new ValueContainerChar (this->restartpass),             DT_CHARPTR, NoValidation},
+               {"options",             "prefixquit",                   new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR, NoValidation},
+               {"options",             "loglevel",                     new ValueContainerChar (debug),                         DT_CHARPTR, ValidateLogLevel},
+               {"options",             "netbuffersize",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER, ValidateNetBufferSize},
+               {"options",             "maxwho",                       new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER, ValidateMaxWho},
+               {"options",             "allowhalfop",                  new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN, NoValidation},
+               {"dns",                 "server",                       new ValueContainerChar (this->DNSServer),               DT_CHARPTR, ValidateDnsServer},
+               {"dns",                 "timeout",                      new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER, ValidateDnsTimeout},
+               {"options",             "moduledir",                    new ValueContainerChar (this->ModPath),                 DT_CHARPTR, ValidateModPath},
+               {"disabled",            "commands",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR, NoValidation},
+               {"options",             "userstats",                    new ValueContainerChar (this->UserStats),               DT_CHARPTR, NoValidation},
+               {"options",             "customversion",                new ValueContainerChar (this->CustomVersion),           DT_CHARPTR, NoValidation},
+               {"options",             "hidesplits",                   new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN, NoValidation},
+               {"options",             "hidebans",                     new ValueContainerBool (&this->HideBans),               DT_BOOLEAN, NoValidation},
+               {"options",             "hidewhois",                    new ValueContainerChar (this->HideWhoisServer),         DT_CHARPTR, NoValidation},
+               {"options",             "operspywhois",                 new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN, NoValidation},
+               {"options",             "nouserdns",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN, NoValidation},
+               {"options",             "syntaxhints",                  new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
+               {"options",             "cyclehosts",                   new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
+               {"options",             "ircumsgprefix",                new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN, NoValidation},
+               {"pid",                 "file",                         new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
+               {"whowas",              "groupsize",                    new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
+               {"whowas",              "maxgroups",                    new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER, NoValidation},
+               {"whowas",              "maxkeep",                      new ValueContainerChar (maxkeep),                       DT_CHARPTR, ValidateWhoWas},
+               {"die",                 "value",                        new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
                {NULL}
        };
 
        /* These tags can occur multiple times, and therefore they have special code to read them
         * which is different to the code for reading the singular tags listed above.
         */
-       static MultiConfig MultiValues[] = {
+       MultiConfig MultiValues[] = {
 
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
@@ -649,130 +710,127 @@ void ServerConfig::Read(bool bail, userrec* user)
        }
        else
        {
-               ServerInstance->Log(DEFAULT, "There were errors in your configuration:\n%s", errstr.str().c_str());
+               ReportConfigError(errstr.str(), bail, user);
+               return;
+       }
 
-               if (bail)
-               {
-                       /* Unneeded because of the ServerInstance->Log() aboive? */
-                       printf("There were errors in your configuration:\n%s",errstr.str().c_str());
-                       InspIRCd::Exit(ERROR);
-               }
-               else
+       /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
+       try
+       {
+               /* Check we dont have more than one of singular tags, or any of them missing
+                */
+               for (int Index = 0; Once[Index]; Index++)
+                       if (!CheckOnce(Once[Index], bail, user))
+                               return;
+
+               /* Read the values of all the tags which occur once or not at all, and call their callbacks.
+                */
+               for (int Index = 0; Values[Index].tag; Index++)
                {
-                       std::string errors = errstr.str();
-                       std::string::size_type start;
-                       unsigned int prefixlen;
-                       
-                       start = 0;
-                       /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
-                       prefixlen = strlen(this->ServerName) + strlen(user->nick) + 11;
-       
-                       if (user)
+                       char item[MAXBUF];
+                       int dt = Values[Index].datatype;
+                       bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
+                       dt &= ~DT_ALLOW_NEWLINE;
+
+                       ConfValue(this->config_data, Values[Index].tag, Values[Index].value, 0, item, MAXBUF, allow_newlines);
+                       ValueItem vi(item);
+
+                       Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi);
+
+                       switch (Values[Index].datatype)
                        {
-                               user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick);
-                               
-                               while(start < errors.length())
+                               case DT_CHARPTR:
                                {
-                                       user->WriteServ("NOTICE %s :%s",user->nick, errors.substr(start, 510 - prefixlen).c_str());
-                                       start += 510 - prefixlen;
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()));
                                }
-                       }
-                       else
-                       {
-                               ServerInstance->WriteOpers("There were errors in the configuration file:");
-                               
-                               while(start < errors.length())
+                               break;
+                               case DT_INTEGER:
                                {
-                                       ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
-                                       start += 360;
+                                       int val = vi.GetInteger();
+                                       ValueContainerInt* vci = (ValueContainerInt*)Values[Index].val;
+                                       vci->Set(&val, sizeof(int));
                                }
+                               break;
+                               case DT_BOOLEAN:
+                               {
+                                       bool val = vi.GetBool();
+                                       ValueContainerBool* vcb = (ValueContainerBool*)Values[Index].val;
+                                       vcb->Set(&val, sizeof(bool));
+                               }
+                               break;
+                               default:
+                                       /* You don't want to know what happens if someones bad code sends us here. */
+                               break;
                        }
-
-                       return;
+       
+                       /* We're done with this now */
+                       delete Values[Index].val;
                }
-       }
-
-       /* Check we dont have more than one of singular tags, or any of them missing
-        */
-       for (int Index = 0; Once[Index]; Index++)
-               if (!CheckOnce(Once[Index],bail,user))
-                       return;
-
-       /* Read the values of all the tags which occur once or not at all, and call their callbacks.
-        */
-       for (int Index = 0; Values[Index].tag; Index++)
-       {
-               char item[MAXBUF];
-               ConfValue(this->config_data, Values[Index].tag, Values[Index].value, 0, item, MAXBUF);
-               ValueItem vi(item);
-
-               Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi);
 
-               switch (Values[Index].datatype)
+               /* Read the multiple-tag items (class tags, connect tags, etc)
+                * and call the callbacks associated with them. We have three
+                * callbacks for these, a 'start', 'item' and 'end' callback.
+                */
+               for (int Index = 0; MultiValues[Index].tag; Index++)
                {
-                       case DT_CHARPTR:
-                               strlcpy((char*)Values[Index].val, vi.GetString(), MAXBUF);
-                       break;
-                       case DT_INTEGER:
-                               *((int*)Values[Index].val) = vi.GetInteger();
-                       break;
-                       case DT_BOOLEAN:
-                               *((bool*)(Values[Index].val)) = vi.GetBool();
-                       break;
-                       default:
-                       break;
-               }
-       }
-
-       /* Read the multiple-tag items (class tags, connect tags, etc)
-        * and call the callbacks associated with them. We have three
-        * callbacks for these, a 'start', 'item' and 'end' callback.
-        */
-       for (int Index = 0; MultiValues[Index].tag; Index++)
-       {
-               MultiValues[Index].init_function(this, MultiValues[Index].tag);
+                       MultiValues[Index].init_function(this, MultiValues[Index].tag);
 
-               int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
+                       int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
 
-               for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
-               {
-                       ValueList vl;
-                       for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
+                       for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
                        {
-                               switch (MultiValues[Index].datatype[valuenum])
+                               ValueList vl;
+                               for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
                                {
-                                       case DT_CHARPTR:
+                                       int dt = MultiValues[Index].datatype[valuenum];
+                                       bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
+                                       dt &= ~DT_ALLOW_NEWLINE;
+
+                                       switch (dt)
+                                       {
+                                               case DT_CHARPTR:
                                                {
                                                        char item[MAXBUF];
-                                                       ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item, MAXBUF);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_CHARPTR multi-item <%s:%s>[%d] = '%s'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
-                                                       vl.push_back(ValueItem(item));
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
                                                }
-                                       break;
-                                       case DT_INTEGER:
+                                               break;
+                                               case DT_INTEGER:
                                                {
-                                                       int item;
-                                                       ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_INTEGER multi-item <%s:%s>[%d] = '%d'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
-                                                       vl.push_back(ValueItem(item));
+                                                       int item = 0;
+                                                       if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(0));
                                                }
-                                       break;
-                                       case DT_BOOLEAN:
+                                               break;
+                                               case DT_BOOLEAN:
                                                {
                                                        bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_BOOLEAN multi-item <%s:%s>[%d] = '%d'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
                                                        vl.push_back(ValueItem(item));
                                                }
-                                       break;
-                                       default:
-                                       break;
+                                               break;
+                                               default:
+                                                       /* Someone was smoking craq if we got here, and we're all gonna die. */
+                                               break;
+                                       }
                                }
+       
+                               MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
-                       ServerInstance->Log(DEBUG,"Call validation function for multi-value <%s>", MultiValues[Index].tag);
-                       MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
+       
+                       MultiValues[Index].finish_function(this, MultiValues[Index].tag);
                }
 
-               MultiValues[Index].finish_function(this, MultiValues[Index].tag);
+       }
+
+       catch (CoreException &ce)
+       {
+               ReportConfigError(ce.GetReason(), bail, user);
+               return;
        }
 
        // write once here, to try it out and make sure its ok
@@ -800,6 +858,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                }
 
                if (!removed_modules.empty())
+               {
                        for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
                        {
                                if (ServerInstance->UnloadModule(removing->c_str()))
@@ -817,23 +876,26 @@ void ServerConfig::Read(bool bail, userrec* user)
                                                user->WriteServ("972 %s %s :Failed to unload module %s: %s",user->nick, removing->c_str(), removing->c_str(), ServerInstance->ModuleError());
                                }
                        }
+               }
 
                if (!added_modules.empty())
-               for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                {
-                       if (ServerInstance->LoadModule(adding->c_str()))
+                       for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
-
-                               if (user)
-                                       user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
-
-                               add++;
-                       }
-                       else
-                       {
-                               if (user)
-                                       user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->ModuleError());
+                               if (ServerInstance->LoadModule(adding->c_str()))
+                               {
+                                       ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
+       
+                                       if (user)
+                                               user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
+       
+                                       add++;
+                               }
+                               else
+                               {
+                                       if (user)
+                                               user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->ModuleError());
+                               }
                        }
                }
 
@@ -893,18 +955,24 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                if((ch == '#') && !in_quote)
                        in_comment = true;
                
-               if(((ch == '\n') || (ch == '\r')) && in_quote)
+               /*if(((ch == '\n') || (ch == '\r')) && in_quote)
                {
                        errorstream << "Got a newline within a quoted section, this is probably a typo: " << filename << ":" << linenumber << std::endl;
                        return false;
-               }
+               }*/
                
                switch(ch)
                {
                        case '\n':
+                               if (in_quote)
+                               {
+                                       ServerInstance->Log(DEBUG, "Got \\n inside value");
+                                       line += '\n';
+                               }
                                linenumber++;
                        case '\r':
-                               in_comment = false;
+                               if (!in_quote)
+                                       in_comment = false;
                        case '\0':
                                continue;
                        case '\t':
@@ -942,7 +1010,8 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        }
                }
 
-               line += ch;
+               if (ch != '\r')
+                       line += ch;
                
                if(ch == '<')
                {
@@ -1042,8 +1111,8 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
        bool in_quote;
        
        got_name = got_key = in_quote = false;
-       
-       // std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
+
+       //std::cout << "ParseLine(data, '" << line << "', " << linenumber << ", stream)" << std::endl;
        
        for(std::string::iterator c = line.begin(); c != line.end(); c++)
        {
@@ -1102,6 +1171,16 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                                current_value += *c;
                                        continue;
                                }
+                               else if ((*c == '\n') && (in_quote))
+                               {
+                                       /* Got a 'real' \n, treat it as part of the value */
+                                       current_value += '\n';
+                                       continue;
+                               }
+                               else if ((*c == '\r') && (in_quote))
+                                       /* Got a \r, drop it */
+                                       continue;
+
                                if (*c == '"')
                                {
                                        if (!in_quote)
@@ -1113,7 +1192,7 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long lin
                                        {
                                                /* Leaving quotes, we have the value */
                                                results.push_back(KeyVal(current_key, current_value));
-                                               
+
                                                // std::cout << "<" << tagname << ":" << current_key << "> " << current_value << std::endl;
                                                
                                                in_quote = false;
@@ -1180,30 +1259,40 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
        return LoadConf(target, newfile, errorstream);
 }
 
-bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length)
+bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length, bool allow_linefeeds)
 {
        std::string value;
-       bool r = ConfValue(target, std::string(tag), std::string(var), index, value);
+       bool r = ConfValue(target, std::string(tag), std::string(var), index, value, allow_linefeeds);
        strlcpy(result, value.c_str(), length);
        return r;
 }
 
-bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, int index, std::string &result)
+bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, const std::string &var, int index, std::string &result, bool allow_linefeeds)
 {
        ConfigDataHash::size_type pos = index;
        if((pos >= 0) && (pos < target.count(tag)))
        {
-               ConfigDataHash::const_iterator iter = target.find(tag);
-               
+               ConfigDataHash::iterator iter = target.find(tag);
+
                for(int i = 0; i < index; i++)
                        iter++;
-               
-               for(KeyValList::const_iterator j = iter->second.begin(); j != iter->second.end(); j++)
+
+               for(KeyValList::iterator j = iter->second.begin(); j != iter->second.end(); j++)
                {
                        if(j->first == var)
                        {
-                               result = j->second;
-                               return true;
+                               if ((!allow_linefeeds) && (j->second.find('\n') != std::string::npos))
+                               {
+                                       ServerInstance->Log(DEFAULT, "Value of <" + tag + ":" + var+ "> contains a linefeed, and linefeeds in this value are not permitted -- stripped to spaces.");
+                                       for (std::string::iterator n = j->second.begin(); n != j->second.end(); n++)
+                                               if (*n == '\n')
+                                                       *n = ' ';
+                               }
+                               else
+                               {
+                                       result = j->second;
+                                       return true;
+                               }
                        }
                }
        }
@@ -1215,7 +1304,7 @@ bool ServerConfig::ConfValue(ConfigDataHash &target, const std::string &tag, con
        {
                ServerInstance->Log(DEBUG, "ConfValue got an out-of-range index %d, there are only %d occurences of %s", pos, target.count(tag), tag.c_str());
        }
-       
+
        return false;
 }
        
@@ -1293,7 +1382,7 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, in
  */
 bool ServerConfig::ReadFile(file_cache &F, const char* fname)
 {
-       FILE* file;
+       FILE* file = NULL;
        char linebuf[MAXBUF];
 
        F.clear();
@@ -1317,8 +1406,10 @@ bool ServerConfig::ReadFile(file_cache &F, const char* fname)
        {
                while (!feof(file))
                {
-                       fgets(linebuf, sizeof(linebuf), file);
-                       linebuf[strlen(linebuf)-1] = 0;
+                       if (fgets(linebuf, sizeof(linebuf), file))
+                               linebuf[strlen(linebuf)-1] = 0;
+                       else
+                               *linebuf = 0;
 
                        if (!feof(file))
                        {
@@ -1382,12 +1473,14 @@ bool ServerConfig::DirValid(const char* dirandfile)
        if (getcwd(buffer, MAXBUF ) == NULL )
                return false;
 
-       chdir(work);
+       if (chdir(work) == -1)
+               return false;
 
        if (getcwd(otherdir, MAXBUF ) == NULL )
                return false;
 
-       chdir(buffer);
+       if (chdir(buffer) == -1)
+               return false;
 
        size_t t = strlen(work);
 
@@ -1434,12 +1527,15 @@ std::string ServerConfig::GetFullProgDir(char** argv, int argc)
        if (getcwd(buffer, MAXBUF) == NULL)
                return "";
 
-       chdir(work);
+       if (chdir(work) == -1)
+               return "";
 
        if (getcwd(otherdir, MAXBUF) == NULL)
                return "";
 
-       chdir(buffer);
+       if (chdir(buffer) == -1)
+               return "";
+
        return otherdir;
 }
 
@@ -1448,3 +1544,57 @@ InspIRCd* ServerConfig::GetInstance()
        return ServerInstance;
 }
 
+
+ValueItem::ValueItem(int value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+ValueItem::ValueItem(bool value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+ValueItem::ValueItem(char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(const char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(int value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+int ValueItem::GetInteger()
+{
+       if (v.empty())
+               return 0;
+       return atoi(v.c_str());
+}
+
+char* ValueItem::GetString()
+{
+       return (char*)v.c_str();
+}
+
+bool ValueItem::GetBool()
+{
+       return (GetInteger() || v == "yes" || v == "true");
+}
+