]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Remove unneeded "fd" member of issl_session
[user/henk/code/inspircd.git] / src / configreader.cpp
index 117546f0938bffe9cfe4187ba308526dd3cf1537..e7613ce5a6c1b92803652f10bb6d74004e714378 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -11,7 +11,7 @@
  * ---------------------------------------------------
  */
 
-/* $Core: libIRCDconfigreader */
+/* $Core */
 /* $CopyInstall: conf/inspircd.quotes.example $(CONPATH) */
 /* $CopyInstall: conf/inspircd.rules.example $(CONPATH) */
 /* $CopyInstall: conf/inspircd.motd.example $(CONPATH) */
 /* $CopyInstall: conf/inspircd.filter.example $(CONPATH) */
 /* $CopyInstall: conf/inspircd.conf.example $(CONPATH) */
 /* $CopyInstall: conf/modules.conf.example $(CONPATH) */
+/* $CopyInstall: conf/opers.conf.example $(CONPATH) */
+/* $CopyInstall: conf/links.conf.example $(CONPATH) */
+/* $CopyInstall: .gdbargs $(BASE) */
 
 #include "inspircd.h"
 #include <fstream>
 #include "xline.h"
 #include "exitcodes.h"
 #include "commands/cmd_whowas.h"
+#include "modes/cmode_h.h"
 
 std::vector<std::string> old_module_names, new_module_names, added_modules, removed_modules;
 
@@ -44,7 +48,7 @@ ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
        WhoWasGroupSize = WhoWasMaxGroups = WhoWasMaxKeep = 0;
        log_file = NULL;
        NoUserDns = forcedebug = OperSpyWhois = nofork = HideBans = HideSplits = UndernetMsgPrefix = false;
-       CycleHosts = writelog = AllowHalfop = true;
+       CycleHosts = writelog = AllowHalfop = InvBypassModes = true;
        dns_timeout = DieDelay = 5;
        MaxTargets = 20;
        NetBufferSize = 10240;
@@ -65,38 +69,6 @@ void ServerConfig::ClearStack()
        include_stack.clear();
 }
 
-Module* ServerConfig::GetIOHook(BufferedSocket* is)
-{
-       std::map<BufferedSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
-       return (x != SocketIOHookModule.end() ? x->second : NULL);
-}
-
-bool ServerConfig::AddIOHook(Module* iomod, BufferedSocket* is)
-{
-       if (!GetIOHook(is))
-       {
-               SocketIOHookModule[is] = iomod;
-               is->IsIOHooked = true;
-               return true;
-       }
-       else
-       {
-               throw ModuleException("BufferedSocket derived class already hooked by another module");
-               return false;
-       }
-}
-
-bool ServerConfig::DelIOHook(BufferedSocket* is)
-{
-       std::map<BufferedSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
-       if (x != SocketIOHookModule.end())
-       {
-               SocketIOHookModule.erase(x);
-               return true;
-       }
-       return false;
-}
-
 void ServerConfig::Update005()
 {
        std::stringstream out(data005);
@@ -136,15 +108,9 @@ bool ServerConfig::CheckOnce(const char* tag, ConfigDataHash &newconf)
        int count = ConfValueEnum(newconf, tag);
 
        if (count > 1)
-       {
                throw CoreException("You have more than one <"+std::string(tag)+"> tag, this is not permitted.");
-               return false;
-       }
        if (count < 1)
-       {
                throw CoreException("You have not defined a <"+std::string(tag)+"> tag, this is required.");
-               return false;
-       }
        return true;
 }
 
@@ -375,7 +341,8 @@ bool ValidateServerName(ServerConfig* conf, const char*, const char*, ValueItem
 
 bool ValidateNetBufferSize(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
-       if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1024))
+       // 65534 not 65535 because of null terminator
+       if ((!data.GetInteger()) || (data.GetInteger() > 65534) || (data.GetInteger() < 1024))
        {
                conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
                data.Set(10240);
@@ -393,16 +360,34 @@ bool ValidateMaxWho(ServerConfig* conf, const char*, const char*, ValueItem &dat
        return true;
 }
 
+bool ValidateHalfOp(ServerConfig* conf, const char*, const char*, ValueItem &data)
+{
+       ModeHandler* mh = conf->GetInstance()->Modes->FindMode('h', MODETYPE_CHANNEL);
+       if (data.GetBool() && !mh)
+       {
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Enabling halfop mode.");
+               mh = new ModeChannelHalfOp(conf->GetInstance());
+               conf->GetInstance()->Modes->AddMode(mh);
+       }
+       else if (!data.GetBool() && mh)
+       {
+               conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Disabling halfop mode.");
+               conf->GetInstance()->Modes->DelMode(mh);
+               delete mh;
+       }
+       return true;
+}
+
 bool ValidateMotd(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
        conf->ReadFile(conf->MOTD, data.GetString());
        return true;
 }
 
-bool ValidateNotEmpty(ServerConfig*, const char* tag, const char*, ValueItem &data)
+bool ValidateNotEmpty(ServerConfig*, const char* tag, const char* val, ValueItem &data)
 {
        if (!*data.GetString())
-               throw CoreException(std::string("The value for ")+tag+" cannot be empty!");
+               throw CoreException(std::string("The value for <")+tag+":"+val+"> cannot be empty!");
        return true;
 }
 
@@ -490,17 +475,22 @@ bool ValidateWhoWas(ServerConfig* conf, const char*, const char*, ValueItem &dat
  */
 bool InitConnect(ServerConfig* conf, const char*)
 {
-       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Reading connect classes...");
+       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Reading connect classes... class list is:");
 
        for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end() ; )
        {
                ConnectClass* c = *i;
 
-               /* only delete a class with refcount 0 */
+               /*
+                * only delete a class with refcount 0.
+                * this is needed to avoid trampling on a wild pointer (User::MyClass)!
+                * it's also the most simple way to do it, given that we're looking at threads..
+                * -- w00t
+                */
                if (c->RefCount == 0)
                {
                        conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Removing connect class, refcount is 0!");
-                       
+
                        /* This was causing a crash, because we'd set i to .begin() just here, but then the for loop's increment would
                         * set it to .begin() + 1. Which if it was already the last thing in the list, wasn't good.
                         * Now the increment is in the else { } below.
@@ -529,42 +519,21 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        const char* password = values[2].GetString();
        int timeout = values[3].GetInteger();
        int pingfreq = values[4].GetInteger();
-       int flood = values[5].GetInteger();
-       int threshold = values[6].GetInteger();
-       int sendq = values[7].GetInteger();
-       int recvq = values[8].GetInteger();
-       int localmax = values[9].GetInteger();
-       int globalmax = values[10].GetInteger();
-       int port = values[11].GetInteger();
-       const char* name = values[12].GetString();
-       const char* parent = values[13].GetString();
-       int maxchans = values[14].GetInteger();
-       unsigned long limit = values[15].GetInteger();
-       const char* hashtype = values[16].GetString();
-
-       /*
-        * duplicates check: Now we don't delete all connect classes on rehash, we need to ensure we don't add dupes.
-        * easier said than done, but for now we'll just disallow anything with a duplicate host or name. -- w00t
-        */
-       for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
-       {
-               ConnectClass* cc = *item;
-               if (
-                        ((*name && (cc->GetName() == name)) || // if the name is the same
-                        (*allow && (cc->GetHost() == allow)) || // or the allow is the same
-                        (*deny && (cc->GetHost() == deny))) && // or the deny is the same
-                        (!port || (port && (cc->GetPort() == port))) // and there is no port, or there is a port and the port is the same
-                  )
-               {
-                       /* reenable class so users can be shoved into it :P */
-                       cc->SetDisabled(false);
-                       conf->GetInstance()->Logs->Log("CONFIG",DEFAULT, "Not adding class, it already exists!");
-                       return true;
-               } 
-       }
+       int sendq = values[5].GetInteger();
+       int recvq = values[6].GetInteger();
+       int localmax = values[7].GetInteger();
+       int globalmax = values[8].GetInteger();
+       int port = values[9].GetInteger();
+       const char* name = values[10].GetString();
+       const char* parent = values[11].GetString();
+       int maxchans = values[12].GetInteger();
+       unsigned long limit = values[13].GetInteger();
+       const char* hashtype = values[14].GetString();
 
        conf->GetInstance()->Logs->Log("CONFIG",DEFAULT,"Adding a connect class!");
 
+       ConnectClass *cc = NULL;
+
        if (*parent)
        {
                /* Find 'parent' and inherit a new class from it,
@@ -573,13 +542,13 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                ClassVector::iterator item = conf->Classes.begin();
                for (; item != conf->Classes.end(); ++item)
                {
-                       ConnectClass* cc = *item;
+                       cc = *item;
                        conf->GetInstance()->Logs->Log("CONFIG",DEBUG,"Class: %s", cc->GetName().c_str());
                        if (cc->GetName() == parent)
                        {
-                               ConnectClass* newclass = new ConnectClass(name, cc);
-                               newclass->Update(timeout, flood, *allow ? allow : deny, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
-                               conf->Classes.push_back(newclass);
+                               cc = new ConnectClass(name, cc);
+                               cc->Update(timeout, *allow ? allow : deny, pingfreq, password, sendq, recvq, localmax, globalmax, maxchans, port, limit);
+                               conf->Classes.push_back(cc);
                                break;
                        }
                }
@@ -593,13 +562,13 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                        /* Find existing class by mask, the mask should be unique */
                        for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
                        {
-                               if ((*item)->GetHost() == allow)
+                               if ((*item)->GetHost() == allow && !(*item)->GetDisabled())
                                {
-                                       (*item)->Update(timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
+                                       (*item)->Update(timeout, allow, pingfreq, password, sendq, recvq, localmax, globalmax, maxchans, port, limit);
                                        return true;
                                }
                        }
-                       ConnectClass* cc = new ConnectClass(name, timeout, flood, allow, pingfreq, password, hashtype, threshold, sendq, recvq, localmax, globalmax, maxchans);
+                       cc = new ConnectClass(name, timeout, allow, pingfreq, password, hashtype, sendq, recvq, localmax, globalmax, maxchans);
                        cc->limit = limit;
                        cc->SetPort(port);
                        conf->Classes.push_back(cc);
@@ -609,14 +578,14 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                        /* Find existing class by mask, the mask should be unique */
                        for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
                        {
-                               if ((*item)->GetHost() == deny)
+                               if ((*item)->GetHost() == deny && !(*item)->GetDisabled())
                                {
                                        (*item)->Update(name, deny);
                                        (*item)->SetPort(port);
                                        return true;
                                }
                        }
-                       ConnectClass* cc = new ConnectClass(name, deny);
+                       cc = new ConnectClass(name, deny);
                        cc->SetPort(port);
                        conf->Classes.push_back(cc);
                }
@@ -738,7 +707,7 @@ bool DoneMaxBans(ServerConfig*, const char*)
        return true;
 }
 
-void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, User* user)
+void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail, const std::string &useruid)
 {
        ServerInstance->Logs->Log("CONFIG",DEFAULT, "There were errors in your configuration file: %s", errormessage.c_str());
        if (bail)
@@ -754,14 +723,18 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                unsigned int prefixlen;
                start = 0;
                /* ":ServerInstance->Config->ServerName NOTICE user->nick :" */
-               if (user)
+               if (!useruid.empty())
                {
-                       prefixlen = strlen(this->ServerName) + user->nick.length() + 11;
-                       user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick.c_str());
-                       while (start < errors.length())
+                       User* user = ServerInstance->FindNick(useruid);
+                       if (user)
                        {
-                               user->WriteServ("NOTICE %s :%s",user->nick.c_str(), errors.substr(start, 510 - prefixlen).c_str());
-                               start += 510 - prefixlen;
+                               prefixlen = strlen(this->ServerName) + user->nick.length() + 11;
+                               user->WriteServ("NOTICE %s :There were errors in the configuration file:",user->nick.c_str());
+                               while (start < errors.length())
+                               {
+                                       user->WriteServ("NOTICE %s :%s",user->nick.c_str(), errors.substr(start, 510 - prefixlen).c_str());
+                                       start += 510 - prefixlen;
+                               }
                        }
                }
                else
@@ -777,7 +750,7 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
        }
 }
 
-void ServerConfig::Read(bool bail, User* user)
+void ServerConfig::Read(bool bail, const std::string &useruid)
 {
        int rem = 0, add = 0;      /* Number of modules added, number of modules removed */
 
@@ -787,7 +760,8 @@ void ServerConfig::Read(bool bail, User* user)
        static char announceinvites[MAXBUF];    /* options:announceinvites setting */
        static char disabledumodes[MAXBUF]; /* Disabled usermodes */
        static char disabledcmodes[MAXBUF]; /* Disabled chanmodes */
-       errstr.clear();
+       /* std::ostringstream::clear() does not clear the string itself, only the error flags. */
+       this->errstr = new std::ostringstream(std::stringstream::in | std::stringstream::out);
 
        include_stack.clear();
 
@@ -842,13 +816,17 @@ void ServerConfig::Read(bool bail, User* user)
                {"options",     "fixedpart",    "",                     new ValueContainerChar (this->FixedPart),               DT_CHARPTR,  NoValidation},
                {"performance", "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
                {"performance", "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
-               {"options",     "allowhalfop",  "0",                    new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN,  NoValidation},
+               {"options",     "allowhalfop",  "0",                    new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN,  ValidateHalfOp},
                {"dns",         "server",       "",                     new ValueContainerChar (this->DNSServer),               DT_IPADDRESS,DNSServerValidator},
                {"dns",         "timeout",      "5",                    new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER,  NoValidation},
                {"options",     "moduledir",    MOD_PATH,               new ValueContainerChar (this->ModPath),                 DT_CHARPTR,  NoValidation},
                {"disabled",    "commands",     "",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR,  NoValidation},
                {"disabled",    "usermodes",    "",                     new ValueContainerChar (disabledumodes),                DT_CHARPTR,  ValidateDisabledUModes},
                {"disabled",    "chanmodes",    "",                     new ValueContainerChar (disabledcmodes),                DT_CHARPTR,  ValidateDisabledCModes},
+               {"disabled",    "fakenonexistant",      "0",            new ValueContainerBool (&this->DisabledDontExist),              DT_BOOLEAN,  NoValidation},
+
+               {"security",            "runasuser",    "",             new ValueContainerChar(this->SetUser),                          DT_CHARPTR, NoValidation},
+               {"security",            "runasgroup",   "",             new ValueContainerChar(this->SetGroup),                         DT_CHARPTR, NoValidation},
                {"security",    "userstats",    "",                     new ValueContainerChar (this->UserStats),               DT_CHARPTR,  NoValidation},
                {"security",    "customversion","",                     new ValueContainerChar (this->CustomVersion),           DT_CHARPTR,  NoValidation},
                {"security",    "hidesplits",   "0",                    new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN,  NoValidation},
@@ -856,6 +834,8 @@ void ServerConfig::Read(bool bail, User* user)
                {"security",    "hidewhois",    "",                     new ValueContainerChar (this->HideWhoisServer),         DT_NOSPACES, NoValidation},
                {"security",    "hidekills",    "",                     new ValueContainerChar (this->HideKillsServer),         DT_NOSPACES,  NoValidation},
                {"security",    "operspywhois", "0",                    new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN,  NoValidation},
+               {"security",    "restrictbannedusers",  "1",            new ValueContainerBool (&this->RestrictBannedUsers),            DT_BOOLEAN,  NoValidation},
+               {"security",    "genericoper",  "0",                    new ValueContainerBool (&this->GenericOper),            DT_BOOLEAN,  NoValidation},
                {"performance", "nouserdns",    "0",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN,  NoValidation},
                {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN,  NoValidation},
                {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN,  NoValidation},
@@ -884,6 +864,7 @@ void ServerConfig::Read(bool bail, User* user)
                {"limits",      "maxkick",      "255",                  new ValueContainerST (&this->Limits.MaxKick),           DT_INTEGER,  NoValidation},
                {"limits",      "maxgecos",     "128",                  new ValueContainerST (&this->Limits.MaxGecos),          DT_INTEGER,  NoValidation},
                {"limits",      "maxaway",      "200",                  new ValueContainerST (&this->Limits.MaxAway),           DT_INTEGER,  NoValidation},
+               {"options",     "invitebypassmodes",    "1",                    new ValueContainerBool (&this->InvBypassModes),         DT_BOOLEAN,  NoValidation},
                {NULL,          NULL,           NULL,                   NULL,                                                   DT_NOTHING,  NoValidation}
        };
 
@@ -894,18 +875,16 @@ void ServerConfig::Read(bool bail, User* user)
        MultiConfig MultiValues[] = {
 
                {"connect",
-                               {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
-                               "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
+                               {"allow",       "deny",         "password",     "timeout",      "pingfreq",
+                               "sendq",        "recvq",        "localmax",     "globalmax",    "port",
                                "name",         "parent",       "maxchans",     "limit",        "hash",
                                NULL},
-                               {"",            "",             "",             "",             "120",          "",
-                                "",            "",             "",             "3",            "3",            "0",
-                                "",            "",             "0",        "0",        "",
+                               {"",            "",                             "",                     "",                     "120",
+                                "",            "",                             "3",            "3",            "0",
+                                "",            "",                             "0",        "0",                "",
                                 NULL},
-                               {DT_IPADDRESS|DT_ALLOW_WILD,
-                                               DT_IPADDRESS|DT_ALLOW_WILD,
-                                                               DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                               DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
+                               {DT_IPADDRESS|DT_ALLOW_WILD, DT_IPADDRESS|DT_ALLOW_WILD, DT_CHARPTR,    DT_INTEGER,     DT_INTEGER,
+                               DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
                                DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER,     DT_CHARPTR},
                                InitConnect, DoConnect, DoneConnect},
 
@@ -938,7 +917,7 @@ void ServerConfig::Read(bool bail, User* user)
                                {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
                                InitXLine, DoQLine, DoneConfItem},
-       
+
                {"badhost",
                                {"reason",      "host",         NULL},
                                {"No reason",   "",             NULL},
@@ -950,7 +929,7 @@ void ServerConfig::Read(bool bail, User* user)
                                {"No reason",   "",             NULL},
                                {DT_CHARPTR,    DT_CHARPTR},
                                InitXLine, DoELine, DoneELine},
-       
+
                {"type",
                                {"name",        "classes",      NULL},
                                {"",            "",             NULL},
@@ -958,11 +937,11 @@ void ServerConfig::Read(bool bail, User* user)
                                InitTypes, DoType, DoneClassesAndTypes},
 
                {"class",
-                               {"name",        "commands",     "usermodes",    "chanmodes",    NULL},
-                               {"",            "",             "",             "",             NULL},
-                               {DT_NOSPACES,   DT_CHARPTR,     DT_CHARPTR,     DT_CHARPTR},
+                               {"name",        "commands",     "usermodes",    "chanmodes",    "privs",        NULL},
+                               {"",            "",                             "",                             "",                     "",                     NULL},
+                               {DT_NOSPACES,   DT_CHARPTR,     DT_CHARPTR,     DT_CHARPTR, DT_CHARPTR},
                                InitClasses, DoClass, DoneClassesAndTypes},
-       
+
                {NULL,
                                {NULL},
                                {NULL},
@@ -975,12 +954,15 @@ void ServerConfig::Read(bool bail, User* user)
        /* Make a copy here so if it fails then we can carry on running with an unaffected config */
        newconfig.clear();
 
-       if (!this->DoInclude(newconfig, ServerInstance->ConfigFileName, errstr))
+       if (!this->DoInclude(newconfig, ServerInstance->ConfigFileName, *errstr))
        {
-               ReportConfigError(errstr.str(), bail, user);
+               ReportConfigError(errstr->str(), bail, useruid);
+               delete errstr;
                return;
        }
 
+       delete errstr;
+
        /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
        try
        {
@@ -996,8 +978,6 @@ void ServerConfig::Read(bool bail, User* user)
                        *item = 0;
                        if (ConfValue(newconfig, ChangedConfig[Index].tag, ChangedConfig[Index].value, "", 0, item, MAXBUF, true) || *item)
                                throw CoreException(std::string("Your configuration contains a deprecated value: <") + ChangedConfig[Index].tag + ":" + ChangedConfig[Index].value + "> - " + ChangedConfig[Index].reason);
-                       else
-                               ServerInstance->Logs->Log("CONFIG",DEBUG,"Deprecated item <%s:%s> does not exist, good.", ChangedConfig[Index].tag, ChangedConfig[Index].value);
                }
 
                /* Read the values of all the tags which occur once or not at all, and call their callbacks.
@@ -1015,15 +995,18 @@ void ServerConfig::Read(bool bail, User* user)
 
                        /* Silently ignore boot only values */
                        if (bootonly && !bail)
+                       {
+                               delete Values[Index].val;
                                continue;
+                       }
 
                        ConfValue(newconfig, Values[Index].tag, Values[Index].value, Values[Index].default_value, 0, item, MAXBUF, allow_newlines);
                        ValueItem vi(item);
-                       
+
                        if (!Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi))
                                throw CoreException("One or more values in your configuration file failed to validate. Please see your ircd.log for more information.");
-       
-                       ServerInstance->Threads->Mutex(true);
+
+                       ServerInstance->Threads->Lock();
                        switch (dt)
                        {
                                case DT_NOSPACES:
@@ -1052,7 +1035,7 @@ void ServerConfig::Read(bool bail, User* user)
                                        ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
                                        if (*(vi.GetString()) && !ServerInstance->IsChannel(vi.GetString(), MAXBUF))
                                        {
-                                               ServerInstance->Threads->Mutex(false);
+                                               ServerInstance->Threads->Unlock();
                                                throw CoreException("The value of <"+std::string(Values[Index].tag)+":"+Values[Index].value+"> is not a valid channel name");
                                        }
                                        vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
@@ -1085,7 +1068,7 @@ void ServerConfig::Read(bool bail, User* user)
                        }
                        /* We're done with this now */
                        delete Values[Index].val;
-                       ServerInstance->Threads->Mutex(false);
+                       ServerInstance->Threads->Unlock();
                }
 
                /* Read the multiple-tag items (class tags, connect tags, etc)
@@ -1094,9 +1077,9 @@ void ServerConfig::Read(bool bail, User* user)
                 */
                for (int Index = 0; MultiValues[Index].tag; ++Index)
                {
-                       ServerInstance->Threads->Mutex(true);
+                       ServerInstance->Threads->Lock();
                        MultiValues[Index].init_function(this, MultiValues[Index].tag);
-                       ServerInstance->Threads->Mutex(false);
+                       ServerInstance->Threads->Unlock();
 
                        int number_of_tags = ConfValueEnum(newconfig, MultiValues[Index].tag);
 
@@ -1111,7 +1094,7 @@ void ServerConfig::Read(bool bail, User* user)
                                        dt &= ~DT_ALLOW_NEWLINE;
                                        dt &= ~DT_ALLOW_WILD;
 
-                                       ServerInstance->Threads->Mutex(true);
+                                       ServerInstance->Threads->Lock();
                                        /* We catch and rethrow any exception here just so we can free our mutex
                                         */
                                        try
@@ -1190,10 +1173,10 @@ void ServerConfig::Read(bool bail, User* user)
                                        }
                                        catch (CoreException &e)
                                        {
-                                               ServerInstance->Threads->Mutex(false);
+                                               ServerInstance->Threads->Unlock();
                                                throw e;
                                        }
-                                       ServerInstance->Threads->Mutex(false);
+                                       ServerInstance->Threads->Unlock();
                                }
                                MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
@@ -1209,11 +1192,11 @@ void ServerConfig::Read(bool bail, User* user)
 
        catch (CoreException &ce)
        {
-               ReportConfigError(ce.GetReason(), bail, user);
+               ReportConfigError(ce.GetReason(), bail, useruid);
                return;
        }
 
-       ServerInstance->Threads->Mutex(true);
+       ServerInstance->Threads->Lock();
        for (int i = 0; i < ConfValueEnum(newconfig, "type"); ++i)
        {
                char item[MAXBUF], classn[MAXBUF], classes[MAXBUF];
@@ -1236,8 +1219,12 @@ void ServerConfig::Read(bool bail, User* user)
                        }
                        if (!foundclass)
                        {
-                               if (user)
-                                       user->WriteServ("NOTICE %s :*** Warning: Oper type '%s' has a missing class named '%s', this does nothing!", user->nick.c_str(), item, classname.c_str());
+                               if (!useruid.empty())
+                               {
+                                       User* user = ServerInstance->FindNick(useruid);
+                                       if (user)
+                                               user->WriteServ("NOTICE %s :*** Warning: Oper type '%s' has a missing class named '%s', this does nothing!", user->nick.c_str(), item, classname.c_str());
+                               }
                                else
                                {
                                        if (bail)
@@ -1252,17 +1239,11 @@ void ServerConfig::Read(bool bail, User* user)
        /* If we succeeded, set the ircd config to the new one */
        this->config_data = newconfig;
 
-       ServerInstance->Threads->Mutex(false);
+       ServerInstance->Threads->Unlock();
 
        // write once here, to try it out and make sure its ok
        ServerInstance->WritePID(this->PID);
 
-       /* Switch over logfiles */
-       ServerInstance->Logs->CloseLogs();
-       ServerInstance->Logs->OpenFileLogs();
-
-       ServerInstance->Logs->Log("CONFIG", DEFAULT, "Done reading configuration file.");
-
        /* If we're rehashing, let's load any new modules, and unload old ones
         */
        if (!bail)
@@ -1271,20 +1252,24 @@ void ServerConfig::Read(bool bail, User* user)
                FailedPortList pl;
                ServerInstance->BindPorts(false, found_ports, pl);
 
-               if (pl.size() && user)
+               if (pl.size() && !useruid.empty())
                {
-                       ServerInstance->Threads->Mutex(true);
-                       user->WriteServ("NOTICE %s :*** Not all your client ports could be bound.", user->nick.c_str());
-                       user->WriteServ("NOTICE %s :*** The following port(s) failed to bind:", user->nick.c_str());
-                       int j = 1;
-                       for (FailedPortList::iterator i = pl.begin(); i != pl.end(); i++, j++)
+                       ServerInstance->Threads->Lock();
+                       User* user = ServerInstance->FindNick(useruid);
+                       if (user)
                        {
-                               user->WriteServ("NOTICE %s :*** %d.   Address: %s        Reason: %s", user->nick.c_str(), j, i->first.empty() ? "<all>" : i->first.c_str(), i->second.c_str());
+                               user->WriteServ("NOTICE %s :*** Not all your client ports could be bound.", user->nick.c_str());
+                               user->WriteServ("NOTICE %s :*** The following port(s) failed to bind:", user->nick.c_str());
+                               int j = 1;
+                               for (FailedPortList::iterator i = pl.begin(); i != pl.end(); i++, j++)
+                               {
+                                       user->WriteServ("NOTICE %s :*** %d.   Address: %s        Reason: %s", user->nick.c_str(), j, i->first.empty() ? "<all>" : i->first.c_str(), i->second.c_str());
+                               }
                        }
-                       ServerInstance->Threads->Mutex(false);
+                       ServerInstance->Threads->Unlock();
                }
 
-               ServerInstance->Threads->Mutex(true);
+               ServerInstance->Threads->Lock();
                if (!removed_modules.empty())
                {
                        for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
@@ -1293,15 +1278,27 @@ void ServerConfig::Read(bool bail, User* user)
                                {
                                        ServerInstance->SNO->WriteToSnoMask('A', "*** REHASH UNLOADED MODULE: %s",removing->c_str());
 
-                                       if (user)
-                                               user->WriteNumeric(RPL_UNLOADEDMODULE, "%s %s :Module %s successfully unloaded.",user->nick.c_str(), removing->c_str(), removing->c_str());
+                                       if (!useruid.empty())
+                                       {
+                                               User* user = ServerInstance->FindNick(useruid);
+                                               if (user)
+                                                       user->WriteNumeric(RPL_UNLOADEDMODULE, "%s %s :Module %s successfully unloaded.",user->nick.c_str(), removing->c_str(), removing->c_str());
+                                       }
+                                       else
+                                               ServerInstance->SNO->WriteToSnoMask('A', "Module %s successfully unloaded.", removing->c_str());
 
                                        rem++;
                                }
                                else
                                {
-                                       if (user)
-                                               user->WriteNumeric(ERR_CANTUNLOADMODULE, "%s %s :Failed to unload module %s: %s",user->nick.c_str(), removing->c_str(), removing->c_str(), ServerInstance->Modules->LastError().c_str());
+                                       if (!useruid.empty())
+                                       {
+                                               User* user = ServerInstance->FindNick(useruid);
+                                               if (user)
+                                                       user->WriteNumeric(ERR_CANTUNLOADMODULE, "%s %s :Failed to unload module %s: %s",user->nick.c_str(), removing->c_str(), removing->c_str(), ServerInstance->Modules->LastError().c_str());
+                                       }
+                                       else
+                                                ServerInstance->SNO->WriteToSnoMask('A', "Failed to unload module %s: %s", removing->c_str(), ServerInstance->Modules->LastError().c_str());
                                }
                        }
                }
@@ -1313,37 +1310,42 @@ void ServerConfig::Read(bool bail, User* user)
                                if (ServerInstance->Modules->Load(adding->c_str()))
                                {
                                        ServerInstance->SNO->WriteToSnoMask('A', "*** REHASH LOADED MODULE: %s",adding->c_str());
-
-                                       if (user)
-                                               user->WriteNumeric(RPL_LOADEDMODULE, "%s %s :Module %s successfully loaded.",user->nick.c_str(), adding->c_str(), adding->c_str());
+                                       if (!useruid.empty())
+                                       {
+                                               User* user = ServerInstance->FindNick(useruid);
+                                               if (user)
+                                                       user->WriteNumeric(RPL_LOADEDMODULE, "%s %s :Module %s successfully loaded.",user->nick.c_str(), adding->c_str(), adding->c_str());
+                                       }
+                                       else
+                                               ServerInstance->SNO->WriteToSnoMask('A', "Module %s successfully loaded.", adding->c_str());
 
                                        add++;
                                }
                                else
                                {
-                                       if (user)
-                                               user->WriteNumeric(ERR_CANTLOADMODULE, "%s %s :Failed to load module %s: %s",user->nick.c_str(), adding->c_str(), adding->c_str(), ServerInstance->Modules->LastError().c_str());
+                                       if (!useruid.empty())
+                                       {
+                                               User* user = ServerInstance->FindNick(useruid);
+                                               if (user)
+                                                       user->WriteNumeric(ERR_CANTLOADMODULE, "%s %s :Failed to load module %s: %s",user->nick.c_str(), adding->c_str(), adding->c_str(), ServerInstance->Modules->LastError().c_str());
+                                       }
+                                       else
+                                               ServerInstance->SNO->WriteToSnoMask('A', "Failed to load module %s: %s", adding->c_str(), ServerInstance->Modules->LastError().c_str());
                                }
                        }
                }
-
-               ServerInstance->Logs->Log("CONFIG", DEFAULT, "Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
-
-               ServerInstance->Threads->Mutex(false);
+               ServerInstance->Threads->Unlock();
 
        }
 
-       if (bail)
-       {
-               /** Note: This is safe, the method checks for user == NULL */
-               ServerInstance->Threads->Mutex(true);
-               ServerInstance->Parser->SetupCommandTable(user);
-               ServerInstance->Threads->Mutex(false);
-       }
-       else
+       if (!bail)
        {
-               if (user)
-                       user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick.c_str());
+               if (!useruid.empty())
+               {
+                       User* user = ServerInstance->FindNick(useruid);
+                       if (user)
+                               user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick.c_str());
+               }
                else
                        ServerInstance->SNO->WriteToSnoMask('A', "*** Successfully rehashed server.");
        }
@@ -1529,7 +1531,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, FILE* &conf, const char* fil
                                {
                                        // errorstream << "Closing config tag on line " << linenumber << std::endl;
                                        in_tag = false;
-       
+
                                        /*
                                         * If this finds an <include> then ParseLine can simply call
                                         * LoadConf() and load the included config into the same ConfigDataHash
@@ -1540,7 +1542,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, FILE* &conf, const char* fil
                                        last_successful_parse = linenumber;
 
                                        linenumber = bl;
-       
+
                                        line.clear();
                                }
                                else
@@ -1685,7 +1687,7 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, const std::string &filename
                                                got_key = false;
 
                                                if ((tagname == "include") && (current_key == "file"))
-                                               {       
+                                               {
                                                        if (!this->DoInclude(target, current_value, errorstream))
                                                                return false;
                                                }
@@ -2025,7 +2027,7 @@ bool ServerConfig::FileExists(const char* file)
 
        if ((sb.st_mode & S_IFDIR) > 0)
                return false;
-            
+
        FILE *input;
        if ((input = fopen (file, "r")) == NULL)
                return false;
@@ -2231,6 +2233,8 @@ bool InitClasses(ServerConfig* conf, const char*)
                                delete[] n->second.cmodelist;
                        if (n->second.umodelist)
                                delete[] n->second.umodelist;
+                       if (n->second.privs)
+                               delete[] n->second.privs;
                }
        }
 
@@ -2259,6 +2263,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char**, ValueList &values, int
        const char* CommandList = values[1].GetString();
        const char* UModeList = values[2].GetString();
        const char* CModeList = values[3].GetString();
+       const char *PrivsList = values[4].GetString();
 
        for (const char* c = UModeList; *c; ++c)
        {
@@ -2278,6 +2283,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char**, ValueList &values, int
        conf->operclass[ClassName].commandlist = strnewdup(CommandList);
        conf->operclass[ClassName].umodelist = strnewdup(UModeList);
        conf->operclass[ClassName].cmodelist = strnewdup(CModeList);
+       conf->operclass[ClassName].privs = strnewdup(PrivsList);
        return true;
 }
 
@@ -2365,10 +2371,8 @@ bool DoneELine(ServerConfig* conf, const char* tag)
 
 void ConfigReaderThread::Run()
 {
-       /* TODO: TheUser may be invalid by the time we get here! Check its validity, or pass a UID would be better */
-       ServerInstance->Config->Read(do_bail, TheUser);
-       ServerInstance->Threads->Mutex(true);
+       ServerInstance->Config->Read(do_bail, TheUserUID);
+       ServerInstance->Threads->Lock();
        this->SetExitFlag();
-       ServerInstance->Threads->Mutex(false);
+       ServerInstance->Threads->Unlock();
 }
-