]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Not yet tested -- allow iohooking of inspsockets
[user/henk/code/inspircd.git] / src / configreader.cpp
index 15feacd37e60c3be19029d9c49eed0ae92271d7e..f7c867544c47c7606e8a783ec102a6bf4664f85c 100644 (file)
@@ -25,7 +25,7 @@ std::vector<std::string> old_module_names, new_module_names, added_modules, remo
 ServerConfig::ServerConfig(InspIRCd* Instance) : ServerInstance(Instance)
 {
        this->ClearStack();
-       *TempDir = *ServerName = *Network = *ServerDesc = *AdminName = '\0';
+       *ServerName = *Network = *ServerDesc = *AdminName = '\0';
        *HideWhoisServer = *AdminEmail = *AdminNick = *diepass = *restartpass = '\0';
        *CustomVersion = *motd = *rules = *PrefixQuit = *DieValue = *DNSServer = '\0';
        *UserStats = *ModPath = *MyExecutable = *DisabledCommands = *PID = '\0';
@@ -57,6 +57,12 @@ Module* ServerConfig::GetIOHook(int port)
        return (x != IOHookModule.end() ? x->second : NULL);
 }
 
+Module* ServerConfig::GetIOHook(InspSocket* is)
+{
+       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       return (x != SocketIOHookModule.end() ? x->second : NULL);
+}
+
 bool ServerConfig::AddIOHook(int port, Module* iomod)
 {
        if (!GetIOHook(port))
@@ -66,8 +72,22 @@ bool ServerConfig::AddIOHook(int port, Module* iomod)
        }
        else
        {
-               ModuleException err("Port already hooked by another module");
-               throw(err);
+               throw ModuleException("Port already hooked by another module");
+               return false;
+       }
+}
+
+bool ServerConfig::AddIOHook(InspSocket* is, Module* iomod)
+{
+       if (!GetIOHook(is))
+       {
+               SocketIOHookModule[is] = iomod;
+               is->IsIOHooked = true;
+               return true;
+       }
+       else
+       {
+               throw ModuleException("InspSocket derived class already hooked by another module");
                return false;
        }
 }
@@ -83,6 +103,17 @@ bool ServerConfig::DelIOHook(int port)
        return false;
 }
 
+bool ServerConfig::DelIOHook(InspSocket* is)
+{
+       std::map<InspSocket*,Module*>::iterator x = SocketIOHookModule.find(is);
+       if (x != SocketIOHookModule.end())
+       {
+               SocketIOHookModule.erase(x);
+               return true;
+       }
+       return false;
+}
+
 bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
 {
        int count = ConfValueEnum(this->config_data, tag);
@@ -134,57 +165,45 @@ bool ServerConfig::CheckOnce(char* tag, bool bail, userrec* user)
        return true;
 }
 
-bool NoValidation(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool NoValidation(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
        conf->GetInstance()->Log(DEBUG,"No validation for <%s:%s>",tag,value);
        return true;
 }
 
-bool ValidateTempDir(ServerConfig* conf, const char* tag, const char* value, void* data)
-{
-       char* x = (char*)data;
-       if (!*x)
-               strlcpy(x,"/tmp",1024);
-       return true;
-}
-bool ValidateMaxTargets(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateMaxTargets(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       int* x = (int*)data;
-       if ((*x < 0) || (*x > 31))
+       if ((data.GetInteger() < 0) || (data.GetInteger() > 31))
        {
                conf->GetInstance()->Log(DEFAULT,"WARNING: <options:maxtargets> value is greater than 31 or less than 0, set to 20.");
-               *x = 20;
+               data.Set(20);
        }
        return true;
 }
 
-bool ValidateSoftLimit(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateSoftLimit(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       int* x = (int*)data;    
-       if ((*x < 1) || (*x > MAXCLIENTS))
+       if ((data.GetInteger() < 1) || (data.GetInteger() > MAXCLIENTS))
        {
                conf->GetInstance()->Log(DEFAULT,"WARNING: <options:softlimit> value is greater than %d or less than 0, set to %d.",MAXCLIENTS,MAXCLIENTS);
-               *x = MAXCLIENTS;
+               data.Set(MAXCLIENTS);
        }
        return true;
 }
 
-bool ValidateMaxConn(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateMaxConn(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       int* x = (int*)data;    
-       if (*x > SOMAXCONN)
+       if (data.GetInteger() > SOMAXCONN)
                conf->GetInstance()->Log(DEFAULT,"WARNING: <options:somaxconn> value may be higher than the system-defined SOMAXCONN value!");
-       if (!*x)
-               *x = SOMAXCONN;
+       if (!data.GetInteger())
+               data.Set(SOMAXCONN);
        return true;
 }
 
-bool ValidateDnsTimeout(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateDnsTimeout(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       int* x = (int*)data;
-       if (!*x)
-               *x = 5;
+       if (!data.GetInteger())
+               data.Set(5);
        return true;
 }
 
@@ -210,10 +229,9 @@ bool InitializeDisabledCommands(const char* data, InspIRCd* ServerInstance)
        return true;
 }
 
-bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       char* x = (char*)data;
-       if (!*x)
+       if (!*(data.GetString()))
        {
                // attempt to look up their nameserver from /etc/resolv.conf
                conf->GetInstance()->Log(DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
@@ -228,7 +246,7 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, v
                                if ((nameserver == "nameserver") && (!found_server))
                                {
                                        resolv >> nameserver;
-                                       strlcpy(x,nameserver.c_str(),MAXBUF);
+                                       data.Set(nameserver.c_str());
                                        found_server = true;
                                        conf->GetInstance()->Log(DEFAULT,"<dns:server> set to '%s' as first resolver in /etc/resolv.conf.",nameserver.c_str());
                                }
@@ -237,95 +255,93 @@ bool ValidateDnsServer(ServerConfig* conf, const char* tag, const char* value, v
                        if (!found_server)
                        {
                                conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf contains no viable nameserver entries! Defaulting to nameserver '127.0.0.1'!");
-                               strlcpy(x,"127.0.0.1",MAXBUF);
+                               data.Set("127.0.0.1");
                        }
                }
                else
                {
                        conf->GetInstance()->Log(DEFAULT,"/etc/resolv.conf can't be opened! Defaulting to nameserver '127.0.0.1'!");
-                       strlcpy(x,"127.0.0.1",MAXBUF);
+                       data.Set("127.0.0.1");
                }
        }
        return true;
 }
 
-bool ValidateModPath(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateModPath(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       char* x = (char*)data;  
-       if (!*x)
-               strlcpy(x,MOD_PATH,MAXBUF);
+       if (!*(data.GetString()))
+               data.Set(MOD_PATH);
        return true;
 }
 
 
-bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateServerName(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       char* x = (char*)data;
-       if (!strchr(x,'.'))
+       if (!strchr(data.GetString(),'.'))
        {
-               conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",x,x,'.');
-               charlcat(x,'.',MAXBUF);
+               conf->GetInstance()->Log(DEFAULT,"WARNING: <server:name> '%s' is not a fully-qualified domain name. Changed to '%s%c'",data.GetString(),data.GetString(),'.');
+               std::string moo = std::string(data.GetString()).append(".");
+               data.Set(moo.c_str());
        }
-       //strlower(x);
        return true;
 }
 
-bool ValidateNetBufferSize(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateNetBufferSize(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       if ((!conf->NetBufferSize) || (conf->NetBufferSize > 65535) || (conf->NetBufferSize < 1024))
+       if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1024))
        {
                conf->GetInstance()->Log(DEFAULT,"No NetBufferSize specified or size out of range, setting to default of 10240.");
-               conf->NetBufferSize = 10240;
+               data.Set(10240);
        }
        return true;
 }
 
-bool ValidateMaxWho(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateMaxWho(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       if ((!conf->MaxWhoResults) || (conf->MaxWhoResults > 65535) || (conf->MaxWhoResults < 1))
+       if ((!data.GetInteger()) || (data.GetInteger() > 65535) || (data.GetInteger() < 1))
        {
                conf->GetInstance()->Log(DEFAULT,"No MaxWhoResults specified or size out of range, setting to default of 128.");
-               conf->MaxWhoResults = 128;
+               data.Set(128);
        }
        return true;
 }
 
-bool ValidateLogLevel(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateLogLevel(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       const char* dbg = (const char*)data;
+       std::string dbg = data.GetString();
        conf->LogLevel = DEFAULT;
-       if (!strcmp(dbg,"debug"))
-       {
+
+       if (dbg == "debug")
                conf->LogLevel = DEBUG;
-               conf->debugging = 1;
-       }
-       else if (!strcmp(dbg,"verbose"))
+       else if (dbg  == "verbose")
                conf->LogLevel = VERBOSE;
-       else if (!strcmp(dbg,"default"))
+       else if (dbg == "default")
                conf->LogLevel = DEFAULT;
-       else if (!strcmp(dbg,"sparse"))
+       else if (dbg == "sparse")
                conf->LogLevel = SPARSE;
-       else if (!strcmp(dbg,"none"))
+       else if (dbg == "none")
                conf->LogLevel = NONE;
+
+       conf->debugging = (conf->LogLevel == DEBUG);
+
        return true;
 }
 
-bool ValidateMotd(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateMotd(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       conf->ReadFile(conf->MOTD,conf->motd);
+       conf->ReadFile(conf->MOTD, data.GetString());
        return true;
 }
 
-bool ValidateRules(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateRules(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       conf->ReadFile(conf->RULES,conf->rules);
+       conf->ReadFile(conf->RULES, data.GetString());
        return true;
 }
 
-bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, void* data)
+bool ValidateWhoWas(ServerConfig* conf, const char* tag, const char* value, ValueItem &data)
 {
-       char* max = (char*)data;
-       conf->WhoWasMaxKeep = conf->GetInstance()->Duration(max);
+       conf->WhoWasMaxKeep = conf->GetInstance()->Duration(data.GetString());
 
        if (conf->WhoWasGroupSize < 0)
                conf->WhoWasGroupSize = 0;
@@ -543,51 +559,50 @@ void ServerConfig::Read(bool bail, userrec* user)
        static char* Once[] = { "server", "admin", "files", "power", "options", NULL };
 
        /* These tags can occur ONCE or not at all */
-       static InitialConfig Values[] = {
-               {"options",             "softlimit",                    &this->SoftLimit,               DT_INTEGER, ValidateSoftLimit},
-               {"options",             "somaxconn",                    &this->MaxConn,                 DT_INTEGER, ValidateMaxConn},
-               {"server",              "name",                         &this->ServerName,              DT_CHARPTR, ValidateServerName},
-               {"server",              "description",                  &this->ServerDesc,              DT_CHARPTR, NoValidation},
-               {"server",              "network",                      &this->Network,                 DT_CHARPTR, NoValidation},
-               {"admin",               "name",                         &this->AdminName,               DT_CHARPTR, NoValidation},
-               {"admin",               "email",                        &this->AdminEmail,              DT_CHARPTR, NoValidation},
-               {"admin",               "nick",                         &this->AdminNick,               DT_CHARPTR, NoValidation},
-               {"files",               "motd",                         &this->motd,                    DT_CHARPTR, ValidateMotd},
-               {"files",               "rules",                        &this->rules,                   DT_CHARPTR, ValidateRules},
-               {"power",               "diepass",                      &this->diepass,                 DT_CHARPTR, NoValidation},      
-               {"power",               "pause",                        &this->DieDelay,                DT_INTEGER, NoValidation},
-               {"power",               "restartpass",                  &this->restartpass,             DT_CHARPTR, NoValidation},
-               {"options",             "prefixquit",                   &this->PrefixQuit,              DT_CHARPTR, NoValidation},
-               {"die",                 "value",                        &this->DieValue,                DT_CHARPTR, NoValidation},
-               {"options",             "loglevel",                     &debug,                         DT_CHARPTR, ValidateLogLevel},
-               {"options",             "netbuffersize",                &this->NetBufferSize,           DT_INTEGER, ValidateNetBufferSize},
-               {"options",             "maxwho",                       &this->MaxWhoResults,           DT_INTEGER, ValidateMaxWho},
-               {"options",             "allowhalfop",                  &this->AllowHalfop,             DT_BOOLEAN, NoValidation},
-               {"dns",                 "server",                       &this->DNSServer,               DT_CHARPTR, ValidateDnsServer},
-               {"dns",                 "timeout",                      &this->dns_timeout,             DT_INTEGER, ValidateDnsTimeout},
-               {"options",             "moduledir",                    &this->ModPath,                 DT_CHARPTR, ValidateModPath},
-               {"disabled",            "commands",                     &this->DisabledCommands,        DT_CHARPTR, NoValidation},
-               {"options",             "userstats",                    &this->UserStats,               DT_CHARPTR, NoValidation},
-               {"options",             "customversion",                &this->CustomVersion,           DT_CHARPTR, NoValidation},
-               {"options",             "hidesplits",                   &this->HideSplits,              DT_BOOLEAN, NoValidation},
-               {"options",             "hidebans",                     &this->HideBans,                DT_BOOLEAN, NoValidation},
-               {"options",             "hidewhois",                    &this->HideWhoisServer,         DT_CHARPTR, NoValidation},
-               {"options",             "operspywhois",                 &this->OperSpyWhois,            DT_BOOLEAN, NoValidation},
-               {"options",             "tempdir",                      &this->TempDir,                 DT_CHARPTR, ValidateTempDir},
-               {"options",             "nouserdns",                    &this->NoUserDns,               DT_BOOLEAN, NoValidation},
-               {"options",             "syntaxhints",                  &this->SyntaxHints,             DT_BOOLEAN, NoValidation},
-               {"options",             "cyclehosts",                   &this->CycleHosts,              DT_BOOLEAN, NoValidation},
-               {"pid",                 "file",                         &this->PID,                     DT_CHARPTR, NoValidation},
-               {"whowas",              "groupsize",                    &this->WhoWasGroupSize,         DT_INTEGER, NoValidation},
-               {"whowas",              "maxgroups",                    &this->WhoWasMaxGroups,         DT_INTEGER, NoValidation},
-               {"whowas",              "maxkeep",                      &maxkeep,                       DT_CHARPTR, ValidateWhoWas},
+       InitialConfig Values[] = {
+               {"options",             "softlimit",                    new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER, ValidateSoftLimit},
+               {"options",             "somaxconn",                    new ValueContainerInt  (&this->MaxConn),                DT_INTEGER, ValidateMaxConn},
+               {"server",              "name",                         new ValueContainerChar (this->ServerName),              DT_CHARPTR, ValidateServerName},
+               {"server",              "description",                  new ValueContainerChar (this->ServerDesc),              DT_CHARPTR, NoValidation},
+               {"server",              "network",                      new ValueContainerChar (this->Network),                 DT_CHARPTR, NoValidation},
+               {"admin",               "name",                         new ValueContainerChar (this->AdminName),               DT_CHARPTR, NoValidation},
+               {"admin",               "email",                        new ValueContainerChar (this->AdminEmail),              DT_CHARPTR, NoValidation},
+               {"admin",               "nick",                         new ValueContainerChar (this->AdminNick),               DT_CHARPTR, NoValidation},
+               {"files",               "motd",                         new ValueContainerChar (this->motd),                    DT_CHARPTR, ValidateMotd},
+               {"files",               "rules",                        new ValueContainerChar (this->rules),                   DT_CHARPTR, ValidateRules},
+               {"power",               "diepass",                      new ValueContainerChar (this->diepass),                 DT_CHARPTR, NoValidation},      
+               {"power",               "pause",                        new ValueContainerInt  (&this->DieDelay),               DT_INTEGER, NoValidation},
+               {"power",               "restartpass",                  new ValueContainerChar (this->restartpass),             DT_CHARPTR, NoValidation},
+               {"options",             "prefixquit",                   new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR, NoValidation},
+               {"options",             "loglevel",                     new ValueContainerChar (debug),                         DT_CHARPTR, ValidateLogLevel},
+               {"options",             "netbuffersize",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER, ValidateNetBufferSize},
+               {"options",             "maxwho",                       new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER, ValidateMaxWho},
+               {"options",             "allowhalfop",                  new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN, NoValidation},
+               {"dns",                 "server",                       new ValueContainerChar (this->DNSServer),               DT_CHARPTR, ValidateDnsServer},
+               {"dns",                 "timeout",                      new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER, ValidateDnsTimeout},
+               {"options",             "moduledir",                    new ValueContainerChar (this->ModPath),                 DT_CHARPTR, ValidateModPath},
+               {"disabled",            "commands",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR, NoValidation},
+               {"options",             "userstats",                    new ValueContainerChar (this->UserStats),               DT_CHARPTR, NoValidation},
+               {"options",             "customversion",                new ValueContainerChar (this->CustomVersion),           DT_CHARPTR, NoValidation},
+               {"options",             "hidesplits",                   new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN, NoValidation},
+               {"options",             "hidebans",                     new ValueContainerBool (&this->HideBans),               DT_BOOLEAN, NoValidation},
+               {"options",             "hidewhois",                    new ValueContainerChar (this->HideWhoisServer),         DT_CHARPTR, NoValidation},
+               {"options",             "operspywhois",                 new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN, NoValidation},
+               {"options",             "nouserdns",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN, NoValidation},
+               {"options",             "syntaxhints",                  new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN, NoValidation},
+               {"options",             "cyclehosts",                   new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN, NoValidation},
+               {"pid",                 "file",                         new ValueContainerChar (this->PID),                     DT_CHARPTR, NoValidation},
+               {"whowas",              "groupsize",                    new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER, NoValidation},
+               {"whowas",              "maxgroups",                    new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER, NoValidation},
+               {"whowas",              "maxkeep",                      new ValueContainerChar (maxkeep),                       DT_CHARPTR, ValidateWhoWas},
+               {"die",                 "value",                        new ValueContainerChar (this->DieValue),                DT_CHARPTR, NoValidation},
                {NULL}
        };
 
        /* These tags can occur multiple times, and therefore they have special code to read them
         * which is different to the code for reading the singular tags listed above.
         */
-       static MultiConfig MultiValues[] = {
+       MultiConfig MultiValues[] = {
 
                {"connect",
                                {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
@@ -704,44 +719,54 @@ void ServerConfig::Read(bool bail, userrec* user)
        /* Check we dont have more than one of singular tags, or any of them missing
         */
        for (int Index = 0; Once[Index]; Index++)
-               if (!CheckOnce(Once[Index],bail,user))
+               if (!CheckOnce(Once[Index], bail, user))
                        return;
 
        /* Read the values of all the tags which occur once or not at all, and call their callbacks.
         */
        for (int Index = 0; Values[Index].tag; Index++)
        {
+               char item[MAXBUF];
+               ConfValue(this->config_data, Values[Index].tag, Values[Index].value, 0, item, MAXBUF);
+               ValueItem vi(item);
+
+               Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi);
+
                switch (Values[Index].datatype)
                {
                        case DT_CHARPTR:
-                               /* Assuming MAXBUF here, potentially unsafe */
-                               ConfValue(this->config_data, Values[Index].tag, Values[Index].value, 0, ((char*)Values[Index].val), MAXBUF);
-                               ServerInstance->Log(DEBUG,"Data type DT_CHARPTR item <%s:%s> = '%s'", Values[Index].tag, Values[Index].value, ((char*)Values[Index].val));
+                               {
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()));
+                               }
                        break;
-
                        case DT_INTEGER:
-                               ConfValueInteger(this->config_data, Values[Index].tag, Values[Index].value, 0, *((int*)Values[Index].val));
-                               ServerInstance->Log(DEBUG,"Data type DT_INTEGER item <%s:%s> = '%d'", Values[Index].tag, Values[Index].value, *((int*)Values[Index].val));
+                               {
+                                       int val = vi.GetInteger();
+                                       ValueContainerInt* vci = (ValueContainerInt*)Values[Index].val;
+                                       vci->Set(&val, sizeof(int));
+                               }
                        break;
-
                        case DT_BOOLEAN:
-                               *((bool*)(Values[Index].val)) = (ConfValueBool(this->config_data, Values[Index].tag, Values[Index].value, 0));
-                               ServerInstance->Log(DEBUG,"Data type DT_BOOLEAN item <%s:%s> = '%d'", Values[Index].tag, Values[Index].value, *((bool*)(Values[Index].val)));
+                               {
+                                       bool val = vi.GetBool();
+                                       ValueContainerBool* vcb = (ValueContainerBool*)Values[Index].val;
+                                       vcb->Set(&val, sizeof(bool));
+                               }
                        break;
-
-                       case DT_NOTHING:
+                       default:
+                               /* You don't want to know what happens if someones bad code sends us here. */
                        break;
                }
 
-               Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, Values[Index].val);
+               /* We're done with this now */
+               delete Values[Index].val;
        }
 
        /* Read the multiple-tag items (class tags, connect tags, etc)
         * and call the callbacks associated with them. We have three
         * callbacks for these, a 'start', 'item' and 'end' callback.
         */
-       
-       /* XXX - Make this use ConfValueInteger and so on */
        for (int Index = 0; MultiValues[Index].tag; Index++)
        {
                MultiValues[Index].init_function(this, MultiValues[Index].tag);
@@ -759,7 +784,6 @@ void ServerConfig::Read(bool bail, userrec* user)
                                                {
                                                        char item[MAXBUF];
                                                        ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item, MAXBUF);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_CHARPTR multi-item <%s:%s>[%d] = '%s'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
                                                        vl.push_back(ValueItem(item));
                                                }
                                        break;
@@ -767,22 +791,21 @@ void ServerConfig::Read(bool bail, userrec* user)
                                                {
                                                        int item;
                                                        ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum, item);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_INTEGER multi-item <%s:%s>[%d] = '%d'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
                                                        vl.push_back(ValueItem(item));
                                                }
                                        break;
                                        case DT_BOOLEAN:
                                                {
                                                        bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], tagnum);
-                                                       ServerInstance->Log(DEBUG,"Data type DT_BOOLEAN multi-item <%s:%s>[%d] = '%d'", MultiValues[Index].tag, MultiValues[Index].items[valuenum],tagnum, item);
                                                        vl.push_back(ValueItem(item));
                                                }
                                        break;
                                        default:
+                                               /* Someone was smoking craq if we got here, and we're all gonna die. */
                                        break;
                                }
                        }
-                       ServerInstance->Log(DEBUG,"Call validation function for multi-value <%s>", MultiValues[Index].tag);
+
                        MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                }
 
@@ -814,6 +837,7 @@ void ServerConfig::Read(bool bail, userrec* user)
                }
 
                if (!removed_modules.empty())
+               {
                        for (std::vector<std::string>::iterator removing = removed_modules.begin(); removing != removed_modules.end(); removing++)
                        {
                                if (ServerInstance->UnloadModule(removing->c_str()))
@@ -831,23 +855,26 @@ void ServerConfig::Read(bool bail, userrec* user)
                                                user->WriteServ("972 %s %s :Failed to unload module %s: %s",user->nick, removing->c_str(), removing->c_str(), ServerInstance->ModuleError());
                                }
                        }
+               }
 
                if (!added_modules.empty())
-               for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                {
-                       if (ServerInstance->LoadModule(adding->c_str()))
+                       for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
-
-                               if (user)
-                                       user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
-
-                               add++;
-                       }
-                       else
-                       {
-                               if (user)
-                                       user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->ModuleError());
+                               if (ServerInstance->LoadModule(adding->c_str()))
+                               {
+                                       ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
+       
+                                       if (user)
+                                               user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
+       
+                                       add++;
+                               }
+                               else
+                               {
+                                       if (user)
+                                               user->WriteServ("974 %s %s :Failed to load module %s: %s",user->nick, adding->c_str(), adding->c_str(), ServerInstance->ModuleError());
+                               }
                        }
                }
 
@@ -1307,7 +1334,7 @@ int ServerConfig::ConfVarEnum(ConfigDataHash &target, const std::string &tag, in
  */
 bool ServerConfig::ReadFile(file_cache &F, const char* fname)
 {
-       FILE* file;
+       FILE* file = NULL;
        char linebuf[MAXBUF];
 
        F.clear();
@@ -1331,8 +1358,10 @@ bool ServerConfig::ReadFile(file_cache &F, const char* fname)
        {
                while (!feof(file))
                {
-                       fgets(linebuf, sizeof(linebuf), file);
-                       linebuf[strlen(linebuf)-1] = 0;
+                       if (fgets(linebuf, sizeof(linebuf), file))
+                               linebuf[strlen(linebuf)-1] = 0;
+                       else
+                               *linebuf = 0;
 
                        if (!feof(file))
                        {
@@ -1396,12 +1425,14 @@ bool ServerConfig::DirValid(const char* dirandfile)
        if (getcwd(buffer, MAXBUF ) == NULL )
                return false;
 
-       chdir(work);
+       if (chdir(work) == -1)
+               return false;
 
        if (getcwd(otherdir, MAXBUF ) == NULL )
                return false;
 
-       chdir(buffer);
+       if (chdir(buffer) == -1)
+               return false;
 
        size_t t = strlen(work);
 
@@ -1448,12 +1479,15 @@ std::string ServerConfig::GetFullProgDir(char** argv, int argc)
        if (getcwd(buffer, MAXBUF) == NULL)
                return "";
 
-       chdir(work);
+       if (chdir(work) == -1)
+               return "";
 
        if (getcwd(otherdir, MAXBUF) == NULL)
                return "";
 
-       chdir(buffer);
+       if (chdir(buffer) == -1)
+               return "";
+
        return otherdir;
 }
 
@@ -1462,3 +1496,55 @@ InspIRCd* ServerConfig::GetInstance()
        return ServerInstance;
 }
 
+
+ValueItem::ValueItem(int value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+ValueItem::ValueItem(bool value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+ValueItem::ValueItem(char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(const char* value)
+{
+       v = value;
+}
+
+void ValueItem::Set(int value)
+{
+       std::stringstream n;
+       n << value;
+       v = n.str();
+}
+
+int ValueItem::GetInteger()
+{
+       return atoi(v.c_str());
+}
+
+char* ValueItem::GetString()
+{
+       return (char*)v.c_str();
+}
+
+bool ValueItem::GetBool()
+{
+       return (GetInteger() || v == "yes" || v == "true");
+}
+