]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Commit patch from danieldg that makes a ton of stuff const-safe for latest warn-happy...
[user/henk/code/inspircd.git] / src / configreader.cpp
index d9afb99dd3ef63e9665e6dc4bd7fade55f80b9e6..fe02bc2bd462a33f29d1a22e3a72026fe75e5122 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -160,7 +160,7 @@ void ServerConfig::Send005(User* user)
                user->WriteServ("005 %s %s", user->nick, line->c_str());
 }
 
-bool ServerConfig::CheckOnce(char* tag)
+bool ServerConfig::CheckOnce(const char* tag)
 {
        int count = ConfValueEnum(this->config_data, tag);
 
@@ -335,7 +335,7 @@ bool ValidateDnsServer(ServerConfig* conf, const char*, const char*, ValueItem &
                std::string nameserver;
                // attempt to look up their nameserver from /etc/resolv.conf
                conf->GetInstance()->Log(DEFAULT,"WARNING: <dns:server> not defined, attempting to find working server in /etc/resolv.conf...");
-               ifstream resolv("/etc/resolv.conf");
+               std::ifstream resolv("/etc/resolv.conf");
                bool found_server = false;
 
                if (resolv.is_open())
@@ -478,13 +478,13 @@ bool ValidateInvite(ServerConfig* conf, const char*, const char*, ValueItem &dat
 
 bool ValidateSID(ServerConfig* conf, const char*, const char*, ValueItem &data)
 {
-       int sid = data.GetInteger();
-       if ((sid > 999) || (sid < 0))
+       const char *sid = data.GetString();
+
+       if (*sid && !conf->GetInstance()->IsSID(sid))
        {
-               sid = sid % 1000;
-               data.Set(sid);
-               conf->GetInstance()->Log(DEFAULT,"WARNING: Server ID is less than 0 or greater than 999. Set to %d", sid);
+               throw CoreException(std::string(sid) + " is not a valid server ID. A server ID must be 3 characters long, with the first character a digit and the next two characters a digit or letter.");
        }
+
        return true;
 }
 
@@ -527,20 +527,28 @@ bool InitConnect(ServerConfig* conf, const char*)
                conf->GetInstance()->Log(DEBUG, "Address of class is %p", c);
        }
 
-       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end(); i++)
+       for (ClassVector::iterator i = conf->Classes.begin(); i != conf->Classes.end() ; )
        {
-               ConnectClass *c = *i;
+               ConnectClassc = *i;
 
                /* only delete a class with refcount 0 */
                if (c->RefCount == 0)
                {
                        conf->GetInstance()->Log(DEFAULT, "Removing connect class, refcount is 0!");
+                       
+                       /* This was causing a crash, because we'd set i to .begin() just here, but then the for loop's increment would
+                        * set it to .begin() + 1. Which if it was already the last thing in the list, wasn't good.
+                        * Now the increment is in the else { } below.
+                        */
                        conf->Classes.erase(i);
                        i = conf->Classes.begin(); // start over so we don't trample on a bad iterator
                }
-
-               /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
-               c->SetDisabled(true);
+               else
+               {
+                       /* also mark all existing classes disabled, if they still exist in the conf, they will be reenabled. */
+                       c->SetDisabled(true);
+                       i++;
+               }
        }
 
        return true;
@@ -567,6 +575,7 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        const char* parent = values[13].GetString();
        int maxchans = values[14].GetInteger();
        unsigned long limit = values[15].GetInteger();
+       const char* hashtype = values[16].GetString();
 
        /*
         * duplicates check: Now we don't delete all connect classes on rehash, we need to ensure we don't add dupes.
@@ -574,11 +583,11 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
         */
        for (ClassVector::iterator item = conf->Classes.begin(); item != conf->Classes.end(); ++item)
        {
-               ConnectClass* c = *item;
-               if ((*name && (c->GetName() == name)) || (*allow && (c->GetHost() == allow)) || (*deny && (c->GetHost() == deny)))
+               ConnectClass* cc = *item;
+               if ((*name && (cc->GetName() == name)) || (*allow && (cc->GetHost() == allow)) || (*deny && (cc->GetHost() == deny)))
                {
                        /* reenable class so users can be shoved into it :P */
-                       c->SetDisabled(false);
+                       cc->SetDisabled(false);
                        conf->GetInstance()->Log(DEFAULT, "Not adding class, it already exists!");
                        return true;
                } 
@@ -594,11 +603,11 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
                ClassVector::iterator item = conf->Classes.begin();
                for (; item != conf->Classes.end(); ++item)
                {
-                       ConnectClass* c = *item;
-                       conf->GetInstance()->Log(DEBUG,"Class: %s", c->GetName().c_str());
-                       if (c->GetName() == parent)
+                       ConnectClass* cc = *item;
+                       conf->GetInstance()->Log(DEBUG,"Class: %s", cc->GetName().c_str());
+                       if (cc->GetName() == parent)
                        {
-                               ConnectClass* newclass = new ConnectClass(name, c);
+                               ConnectClass* newclass = new ConnectClass(name, cc);
                                newclass->Update(timeout, flood, *allow ? allow : deny, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans, port, limit);
                                conf->Classes.push_back(newclass);
                                break;
@@ -611,16 +620,16 @@ bool DoConnect(ServerConfig* conf, const char*, char**, ValueList &values, int*)
        {
                if (*allow)
                {
-                       ConnectClass* c = new ConnectClass(name, timeout, flood, allow, pingfreq, password, threshold, sendq, recvq, localmax, globalmax, maxchans);
-                       c->limit = limit;
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, timeout, flood, allow, pingfreq, password, hashtype, threshold, sendq, recvq, localmax, globalmax, maxchans);
+                       cc->limit = limit;
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
                else
                {
-                       ConnectClass* c = new ConnectClass(name, deny);
-                       c->SetPort(port);
-                       conf->Classes.push_back(c);
+                       ConnectClass* cc = new ConnectClass(name, deny);
+                       cc->SetPort(port);
+                       conf->Classes.push_back(cc);
                }
        }
 
@@ -768,10 +777,10 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
                }
                else
                {
-                       ServerInstance->WriteOpers("There were errors in the configuration file:");
+                       ServerInstance->SNO->WriteToSnoMask('A', "There were errors in the configuration file:");
                        while (start < errors.length())
                        {
-                               ServerInstance->WriteOpers(errors.substr(start, 360).c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', errors.substr(start, 360).c_str());
                                start += 360;
                        }
                }
@@ -779,397 +788,399 @@ void ServerConfig::ReportConfigError(const std::string &errormessage, bool bail,
        }
 }
 
-void ServerConfig::Read(bool bail, User* user)
+void ServerConfig::Read(bool bail, User* user, int pass)
 {
        int rem = 0, add = 0;           /* Number of modules added, number of modules removed */
 
-       for (int pass = 0; pass < 2; pass++)
-       {
-       
-               ServerInstance->Log(DEBUG,"Start config pass %d", pass);
-
-               static char debug[MAXBUF];      /* Temporary buffer for debugging value */
-               static char maxkeep[MAXBUF];    /* Temporary buffer for WhoWasMaxKeep value */
-               static char hidemodes[MAXBUF];  /* Modes to not allow listing from users below halfop */
-               static char exemptchanops[MAXBUF];      /* Exempt channel ops from these modes */
-               static char announceinvites[MAXBUF];    /* options:announceinvites setting */
-               std::ostringstream errstr;      /* String stream containing the error output */
-
-               /* These tags MUST occur and must ONLY occur once in the config file */
-               static char* Once[] = { "server", "admin", "files", "power", "options", NULL };
-
-               /* These tags can occur ONCE or not at all */
-               InitialConfig Values[] = {
-                       {"options",     "softlimit",    MAXCLIENTS_S,           new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER,  ValidateSoftLimit},
-                       {"options",     "somaxconn",    SOMAXCONN_S,            new ValueContainerInt  (&this->MaxConn),                DT_INTEGER,  ValidateMaxConn},
-                       {"options",     "moronbanner",  "Youre banned!",        new ValueContainerChar (this->MoronBanner),             DT_CHARPTR,  NoValidation},
-                       {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME, ValidateServerName},
-                       {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR,  NoValidation},
-                       {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_NOSPACES, NoValidation},
-                       {"server",      "id",           "0",                    new ValueContainerInt  (&this->sid),                    DT_NOSPACES, ValidateSID},
-                       {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR,  NoValidation},
-                       {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR,  NoValidation},
-                       {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR,  NoValidation},
-                       {"files",       "motd",         "",                     new ValueContainerChar (this->motd),                    DT_CHARPTR,  ValidateMotd},
-                       {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR,  ValidateRules},
-                       {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR,  ValidateNotEmpty},
-                       {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER,  NoValidation},
-                       {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR,  ValidateNotEmpty},
-                       {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR,  NoValidation},
-                       {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR,  NoValidation},
-                       {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR,  NoValidation},
-                       {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR,  ValidateLogLevel},
-                       {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
-                       {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
-                       {"options",     "allowhalfop",  "0",                    new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN,  NoValidation},
-                       {"dns",         "server",       "",                     new ValueContainerChar (this->DNSServer),               DT_IPADDRESS,DNSServerValidator},
-                       {"dns",         "timeout",      "5",                    new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER,  NoValidation},
-                       {"options",     "moduledir",    MOD_PATH,               new ValueContainerChar (this->ModPath),                 DT_CHARPTR,  NoValidation},
-                       {"disabled",    "commands",     "",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR,  NoValidation},
-                       {"options",     "userstats",    "",                     new ValueContainerChar (this->UserStats),               DT_CHARPTR,  NoValidation},
-                       {"options",     "customversion","",                     new ValueContainerChar (this->CustomVersion),           DT_CHARPTR,  NoValidation},
-                       {"options",     "hidesplits",   "0",                    new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN,  NoValidation},
-                       {"options",     "hidebans",     "0",                    new ValueContainerBool (&this->HideBans),               DT_BOOLEAN,  NoValidation},
-                       {"options",     "hidewhois",    "",                     new ValueContainerChar (this->HideWhoisServer),         DT_NOSPACES, NoValidation},
-                       {"options",     "hidekills",    "",                     new ValueContainerChar (this->HideKillsServer),         DT_NOSPACES,  NoValidation},
-                       {"options",     "operspywhois", "0",                    new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN,  NoValidation},
-                       {"options",     "nouserdns",    "0",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN,  NoValidation},
-                       {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN,  NoValidation},
-                       {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN,  NoValidation},
-                       {"options",     "ircumsgprefix","0",                    new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN,  NoValidation},
-                       {"options",     "announceinvites", "1",                 new ValueContainerChar (announceinvites),               DT_CHARPTR,  ValidateInvite},
-                       {"options",     "hostintopic",  "1",                    new ValueContainerBool (&this->FullHostInTopic),        DT_BOOLEAN,  NoValidation},
-                       {"options",     "hidemodes",    "",                     new ValueContainerChar (hidemodes),                     DT_CHARPTR,  ValidateModeLists},
-                       {"options",     "exemptchanops","",                     new ValueContainerChar (exemptchanops),                 DT_CHARPTR,  ValidateExemptChanOps},
-                       {"options",     "maxtargets",   "20",                   new ValueContainerUInt (&this->MaxTargets),             DT_INTEGER,  ValidateMaxTargets},
-                       {"options",     "defaultmodes", "nt",                   new ValueContainerChar (this->DefaultModes),            DT_CHARPTR,  NoValidation},
-                       {"pid",         "file",         "",                     new ValueContainerChar (this->PID),                     DT_CHARPTR,  NoValidation},
-                       {"whowas",      "groupsize",    "10",                   new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER,  NoValidation},
-                       {"whowas",      "maxgroups",    "10240",                new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER,  NoValidation},
-                       {"whowas",      "maxkeep",      "3600",                 new ValueContainerChar (maxkeep),                       DT_CHARPTR,  ValidateWhoWas},
-                       {"die",         "value",        "",                     new ValueContainerChar (this->DieValue),                DT_CHARPTR,  NoValidation},
-                       {"channels",    "users",        "20",                   new ValueContainerUInt (&this->MaxChans),               DT_INTEGER,  NoValidation},
-                       {"channels",    "opers",        "60",                   new ValueContainerUInt (&this->OperMaxChans),           DT_INTEGER,  NoValidation},
-                       {NULL,          NULL,           NULL,                   NULL,                                                   DT_NOTHING,  NoValidation}
-               };
-
-               /* These tags can occur multiple times, and therefore they have special code to read them
-                * which is different to the code for reading the singular tags listed above.
-                */
-               MultiConfig MultiValues[] = {
-
-                       {"connect",
-                                       {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
-                                       "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
-                                       "name",         "parent",       "maxchans",     "limit",
-                                       NULL},
-                                       {"",            "",             "",             "",             "120",          "",
-                                        "",            "",             "",             "3",            "3",            "0",
-                                        "",            "",             "0",        "0",
-                                        NULL},
-                                       {DT_IPADDRESS|DT_ALLOW_WILD,
-                                                       DT_IPADDRESS|DT_ALLOW_WILD,
-                                                                       DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                                       DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
-                                       DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER},
-                                       InitConnect, DoConnect, DoneConnect},
-
-                       {"uline",
-                                       {"server",      "silent",       NULL},
-                                       {"",            "0",            NULL},
-                                       {DT_HOSTNAME,   DT_BOOLEAN},
-                                       InitULine,DoULine,DoneULine},
-
-                       {"banlist",
-                                       {"chan",        "limit",        NULL},
-                                       {"",            "",             NULL},
-                                       {DT_CHARPTR,    DT_INTEGER},
-                                       InitMaxBans, DoMaxBans, DoneMaxBans},
-
-                       {"module",
-                                       {"name",        NULL},
-                                       {"",            NULL},
-                                       {DT_CHARPTR},
-                                       InitModule, DoModule, DoneModule},
-
-                       {"badip",
-                                       {"reason",      "ipmask",       NULL},
-                                       {"No reason",   "",             NULL},
-                                       {DT_CHARPTR,    DT_IPADDRESS|DT_ALLOW_WILD},
-                                       InitXLine, DoZLine, DoneConfItem},
-
-                       {"badnick",
-                                       {"reason",      "nick",         NULL},
-                                       {"No reason",   "",             NULL},
-                                       {DT_CHARPTR,    DT_CHARPTR},
-                                       InitXLine, DoQLine, DoneConfItem},
-       
-                       {"badhost",
-                                       {"reason",      "host",         NULL},
-                                       {"No reason",   "",             NULL},
-                                       {DT_CHARPTR,    DT_CHARPTR},
-                                       InitXLine, DoKLine, DoneConfItem},
-
-                       {"exception",
-                                       {"reason",      "host",         NULL},
-                                       {"No reason",   "",             NULL},
-                                       {DT_CHARPTR,    DT_CHARPTR},
-                                       InitXLine, DoELine, DoneELine},
+       static char debug[MAXBUF];      /* Temporary buffer for debugging value */
+       static char maxkeep[MAXBUF];    /* Temporary buffer for WhoWasMaxKeep value */
+       static char hidemodes[MAXBUF];  /* Modes to not allow listing from users below halfop */
+       static char exemptchanops[MAXBUF];      /* Exempt channel ops from these modes */
+       static char announceinvites[MAXBUF];    /* options:announceinvites setting */
+       errstr.clear();
+
+       /* These tags MUST occur and must ONLY occur once in the config file */
+       static const char* Once[] = { "server", "admin", "files", "power", "options", NULL };
+
+       /* These tags can occur ONCE or not at all */
+       InitialConfig Values[] = {
+               {"options",     "softlimit",    MAXCLIENTS_S,           new ValueContainerUInt (&this->SoftLimit),              DT_INTEGER,  ValidateSoftLimit},
+               {"options",     "somaxconn",    SOMAXCONN_S,            new ValueContainerInt  (&this->MaxConn),                DT_INTEGER,  ValidateMaxConn},
+               {"options",     "moronbanner",  "Youre banned!",        new ValueContainerChar (this->MoronBanner),             DT_CHARPTR,  NoValidation},
+               {"server",      "name",         "",                     new ValueContainerChar (this->ServerName),              DT_HOSTNAME, ValidateServerName},
+               {"server",      "description",  "Configure Me",         new ValueContainerChar (this->ServerDesc),              DT_CHARPTR,  NoValidation},
+               {"server",      "network",      "Network",              new ValueContainerChar (this->Network),                 DT_NOSPACES, NoValidation},
+               {"server",      "id",           "",                     new ValueContainerChar (this->sid),                     DT_CHARPTR,  ValidateSID},
+               {"admin",       "name",         "",                     new ValueContainerChar (this->AdminName),               DT_CHARPTR,  NoValidation},
+               {"admin",       "email",        "Mis@configu.red",      new ValueContainerChar (this->AdminEmail),              DT_CHARPTR,  NoValidation},
+               {"admin",       "nick",         "Misconfigured",        new ValueContainerChar (this->AdminNick),               DT_CHARPTR,  NoValidation},
+               {"files",       "motd",         "",                     new ValueContainerChar (this->motd),                    DT_CHARPTR,  ValidateMotd},
+               {"files",       "rules",        "",                     new ValueContainerChar (this->rules),                   DT_CHARPTR,  ValidateRules},
+               {"power",       "diepass",      "",                     new ValueContainerChar (this->diepass),                 DT_CHARPTR,  ValidateNotEmpty},
+               {"power",       "pause",        "",                     new ValueContainerInt  (&this->DieDelay),               DT_INTEGER,  NoValidation},
+               {"power",       "hash",         "",                     new ValueContainerChar (this->powerhash),               DT_CHARPTR,  NoValidation},
+               {"power",       "restartpass",  "",                     new ValueContainerChar (this->restartpass),             DT_CHARPTR,  ValidateNotEmpty},
+               {"options",     "prefixquit",   "",                     new ValueContainerChar (this->PrefixQuit),              DT_CHARPTR,  NoValidation},
+               {"options",     "suffixquit",   "",                     new ValueContainerChar (this->SuffixQuit),              DT_CHARPTR,  NoValidation},
+               {"options",     "fixedquit",    "",                     new ValueContainerChar (this->FixedQuit),               DT_CHARPTR,  NoValidation},
+               {"options",     "prefixpart",   "",                     new ValueContainerChar (this->PrefixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "suffixpart",   "",                     new ValueContainerChar (this->SuffixPart),              DT_CHARPTR,  NoValidation},
+               {"options",     "fixedpart",    "",                     new ValueContainerChar (this->FixedPart),               DT_CHARPTR,  NoValidation},
+               {"options",     "loglevel",     "default",              new ValueContainerChar (debug),                         DT_CHARPTR,  ValidateLogLevel},
+               {"options",     "netbuffersize","10240",                new ValueContainerInt  (&this->NetBufferSize),          DT_INTEGER,  ValidateNetBufferSize},
+               {"options",     "maxwho",       "128",                  new ValueContainerInt  (&this->MaxWhoResults),          DT_INTEGER,  ValidateMaxWho},
+               {"options",     "allowhalfop",  "0",                    new ValueContainerBool (&this->AllowHalfop),            DT_BOOLEAN,  NoValidation},
+               {"dns",         "server",       "",                     new ValueContainerChar (this->DNSServer),               DT_IPADDRESS,DNSServerValidator},
+               {"dns",         "timeout",      "5",                    new ValueContainerInt  (&this->dns_timeout),            DT_INTEGER,  NoValidation},
+               {"options",     "moduledir",    MOD_PATH,               new ValueContainerChar (this->ModPath),                 DT_CHARPTR,  NoValidation},
+               {"disabled",    "commands",     "",                     new ValueContainerChar (this->DisabledCommands),        DT_CHARPTR,  NoValidation},
+               {"options",     "userstats",    "",                     new ValueContainerChar (this->UserStats),               DT_CHARPTR,  NoValidation},
+               {"options",     "customversion","",                     new ValueContainerChar (this->CustomVersion),           DT_CHARPTR,  NoValidation},
+               {"options",     "hidesplits",   "0",                    new ValueContainerBool (&this->HideSplits),             DT_BOOLEAN,  NoValidation},
+               {"options",     "hidebans",     "0",                    new ValueContainerBool (&this->HideBans),               DT_BOOLEAN,  NoValidation},
+               {"options",     "hidewhois",    "",                     new ValueContainerChar (this->HideWhoisServer),         DT_NOSPACES, NoValidation},
+               {"options",     "hidekills",    "",                     new ValueContainerChar (this->HideKillsServer),         DT_NOSPACES,  NoValidation},
+               {"options",     "operspywhois", "0",                    new ValueContainerBool (&this->OperSpyWhois),           DT_BOOLEAN,  NoValidation},
+               {"options",     "nouserdns",    "0",                    new ValueContainerBool (&this->NoUserDns),              DT_BOOLEAN,  NoValidation},
+               {"options",     "syntaxhints",  "0",                    new ValueContainerBool (&this->SyntaxHints),            DT_BOOLEAN,  NoValidation},
+               {"options",     "cyclehosts",   "0",                    new ValueContainerBool (&this->CycleHosts),             DT_BOOLEAN,  NoValidation},
+               {"options",     "ircumsgprefix","0",                    new ValueContainerBool (&this->UndernetMsgPrefix),      DT_BOOLEAN,  NoValidation},
+               {"options",     "announceinvites", "1",                 new ValueContainerChar (announceinvites),               DT_CHARPTR,  ValidateInvite},
+               {"options",     "hostintopic",  "1",                    new ValueContainerBool (&this->FullHostInTopic),        DT_BOOLEAN,  NoValidation},
+               {"options",     "hidemodes",    "",                     new ValueContainerChar (hidemodes),                     DT_CHARPTR,  ValidateModeLists},
+               {"options",     "exemptchanops","",                     new ValueContainerChar (exemptchanops),                 DT_CHARPTR,  ValidateExemptChanOps},
+               {"options",     "maxtargets",   "20",                   new ValueContainerUInt (&this->MaxTargets),             DT_INTEGER,  ValidateMaxTargets},
+               {"options",     "defaultmodes", "nt",                   new ValueContainerChar (this->DefaultModes),            DT_CHARPTR,  NoValidation},
+               {"pid",         "file",         "",                     new ValueContainerChar (this->PID),                     DT_CHARPTR,  NoValidation},
+               {"whowas",      "groupsize",    "10",                   new ValueContainerInt  (&this->WhoWasGroupSize),        DT_INTEGER,  NoValidation},
+               {"whowas",      "maxgroups",    "10240",                new ValueContainerInt  (&this->WhoWasMaxGroups),        DT_INTEGER,  NoValidation},
+               {"whowas",      "maxkeep",      "3600",                 new ValueContainerChar (maxkeep),                       DT_CHARPTR,  ValidateWhoWas},
+               {"die",         "value",        "",                     new ValueContainerChar (this->DieValue),                DT_CHARPTR,  NoValidation},
+               {"channels",    "users",        "20",                   new ValueContainerUInt (&this->MaxChans),               DT_INTEGER,  NoValidation},
+               {"channels",    "opers",        "60",                   new ValueContainerUInt (&this->OperMaxChans),           DT_INTEGER,  NoValidation},
+               {NULL,          NULL,           NULL,                   NULL,                                                   DT_NOTHING,  NoValidation}
+       };
+
+       /* These tags can occur multiple times, and therefore they have special code to read them
+        * which is different to the code for reading the singular tags listed above.
+        */
+       MultiConfig MultiValues[] = {
+
+               {"connect",
+                               {"allow",       "deny",         "password",     "timeout",      "pingfreq",     "flood",
+                               "threshold",    "sendq",        "recvq",        "localmax",     "globalmax",    "port",
+                               "name",         "parent",       "maxchans",     "limit",        "hash",
+                               NULL},
+                               {"",            "",             "",             "",             "120",          "",
+                                "",            "",             "",             "3",            "3",            "0",
+                                "",            "",             "0",        "0",        "",
+                                NULL},
+                               {DT_IPADDRESS|DT_ALLOW_WILD,
+                                               DT_IPADDRESS|DT_ALLOW_WILD,
+                                                               DT_CHARPTR,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
+                               DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,     DT_INTEGER,
+                               DT_NOSPACES,    DT_NOSPACES,    DT_INTEGER,     DT_INTEGER,     DT_CHARPTR},
+                               InitConnect, DoConnect, DoneConnect},
+
+               {"uline",
+                               {"server",      "silent",       NULL},
+                               {"",            "0",            NULL},
+                               {DT_HOSTNAME,   DT_BOOLEAN},
+                               InitULine,DoULine,DoneULine},
+
+               {"banlist",
+                               {"chan",        "limit",        NULL},
+                               {"",            "",             NULL},
+                               {DT_CHARPTR,    DT_INTEGER},
+                               InitMaxBans, DoMaxBans, DoneMaxBans},
+
+               {"module",
+                               {"name",        NULL},
+                               {"",            NULL},
+                               {DT_CHARPTR},
+                               InitModule, DoModule, DoneModule},
+
+               {"badip",
+                               {"reason",      "ipmask",       NULL},
+                               {"No reason",   "",             NULL},
+                               {DT_CHARPTR,    DT_IPADDRESS|DT_ALLOW_WILD},
+                               InitXLine, DoZLine, DoneConfItem},
+
+               {"badnick",
+                               {"reason",      "nick",         NULL},
+                               {"No reason",   "",             NULL},
+                               {DT_CHARPTR,    DT_CHARPTR},
+                               InitXLine, DoQLine, DoneConfItem},
        
-                       {"type",
-                                       {"name",        "classes",      NULL},
-                                       {"",            "",             NULL},
-                                       {DT_NOSPACES,   DT_CHARPTR},
-                                       InitTypes, DoType, DoneClassesAndTypes},
+               {"badhost",
+                               {"reason",      "host",         NULL},
+                               {"No reason",   "",             NULL},
+                               {DT_CHARPTR,    DT_CHARPTR},
+                               InitXLine, DoKLine, DoneConfItem},
+
+               {"exception",
+                               {"reason",      "host",         NULL},
+                               {"No reason",   "",             NULL},
+                               {DT_CHARPTR,    DT_CHARPTR},
+                               InitXLine, DoELine, DoneELine},
        
-                       {"class",
-                                       {"name",        "commands",     NULL},
-                                       {"",            "",             NULL},
-                                       {DT_NOSPACES,   DT_CHARPTR},
-                                       InitClasses, DoClass, DoneClassesAndTypes},
+               {"type",
+                               {"name",        "classes",      NULL},
+                               {"",            "",             NULL},
+                               {DT_NOSPACES,   DT_CHARPTR},
+                               InitTypes, DoType, DoneClassesAndTypes},
+
+               {"class",
+                               {"name",        "commands",     NULL},
+                               {"",            "",             NULL},
+                               {DT_NOSPACES,   DT_CHARPTR},
+                               InitClasses, DoClass, DoneClassesAndTypes},
        
-                       {NULL,
-                                       {NULL},
-                                       {NULL},
-                                       {0},
-                                       NULL, NULL, NULL}
-               };
-
-               include_stack.clear();
+               {NULL,
+                               {NULL},
+                               {NULL},
+                               {0},
+                               NULL, NULL, NULL}
+       };
 
-               /* Load and parse the config file, if there are any errors then explode */
+       /* Load and parse the config file, if there are any errors then explode */
 
-               /* Make a copy here so if it fails then we can carry on running with an unaffected config */
-               ConfigDataHash newconfig;
+       /* Make a copy here so if it fails then we can carry on running with an unaffected config */
+       newconfig.clear();
 
-               if (this->LoadConf(newconfig, ServerInstance->ConfigFileName, errstr, pass))
-               {
-                       /* If we succeeded, set the ircd config to the new one */
-                       this->config_data = newconfig;
-               }
-               else
-               {
-                       ReportConfigError(errstr.str(), bail, user);
-                       return;
-               }
+       if (this->LoadConf(newconfig, ServerInstance->ConfigFileName, errstr, pass))
+       {
+               /* If we succeeded, set the ircd config to the new one */
+               this->config_data = newconfig;
+       }
+       else
+       {
+               ReportConfigError(errstr.str(), bail, user);
+               return;
+       }
 
-               /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
-               try
+       /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
+       try
+       {
+               /* Read the values of all the tags which occur once or not at all, and call their callbacks.
+                */
+               for (int Index = 0; Values[Index].tag; Index++)
                {
-                       /* Read the values of all the tags which occur once or not at all, and call their callbacks.
-                        */
-                       for (int Index = 0; Values[Index].tag; Index++)
-                       {
-                               char item[MAXBUF];
-                               int dt = Values[Index].datatype;
-                               bool allow_newlines = ((dt & DT_ALLOW_NEWLINE) > 0);
-                               bool allow_wild = ((dt & DT_ALLOW_WILD) > 0);
-                               dt &= ~DT_ALLOW_NEWLINE;
-                               dt &= ~DT_ALLOW_WILD;
-
-                               ConfValue(this->config_data, Values[Index].tag, Values[Index].value, Values[Index].default_value, 0, item, MAXBUF, allow_newlines);
-                               ValueItem vi(item);
-
-                               if (!Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi))
-                                       throw CoreException("One or more values in your configuration file failed to validate. Please see your ircd.log for more information.");
+                       char item[MAXBUF];
+                       int dt = Values[Index].datatype;
+                       bool allow_newlines = ((dt & DT_ALLOW_NEWLINE) > 0);
+                       bool allow_wild = ((dt & DT_ALLOW_WILD) > 0);
+                       dt &= ~DT_ALLOW_NEWLINE;
+                       dt &= ~DT_ALLOW_WILD;
+
+                       ConfValue(this->config_data, Values[Index].tag, Values[Index].value, Values[Index].default_value, 0, item, MAXBUF, allow_newlines);
+                       ValueItem vi(item);
+                       
+                       if (!Values[Index].validation_function(this, Values[Index].tag, Values[Index].value, vi))
+                               throw CoreException("One or more values in your configuration file failed to validate. Please see your ircd.log for more information.");
        
-                               switch (Values[Index].datatype)
+                       switch (Values[Index].datatype)
+                       {
+                               case DT_NOSPACES:
                                {
-                                       case DT_NOSPACES:
-                                       {
-                                               ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                               this->ValidateNoSpaces(vi.GetString(), Values[Index].tag, Values[Index].value);
-                                               vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
-                                       }
-                                       break;
-                                       case DT_HOSTNAME:
-                                       {
-                                               ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                               this->ValidateHostname(vi.GetString(), Values[Index].tag, Values[Index].value);
-                                               vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
-                                       }
-                                       break;
-                                       case DT_IPADDRESS:
-                                       {
-                                               ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                               this->ValidateIP(vi.GetString(), Values[Index].tag, Values[Index].value, allow_wild);
-                                               vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
-                                       }
-                                       break;
-                                       case DT_CHANNEL:
-                                       {
-                                               ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                               if (*(vi.GetString()) && !ServerInstance->IsChannel(vi.GetString()))
-                                                       throw CoreException("The value of <"+std::string(Values[Index].tag)+":"+Values[Index].value+"> is not a valid channel name");
-                                               vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
-                                       }
-                                       break;
-                                       case DT_CHARPTR:
-                                       {
-                                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
-                                               /* Make sure we also copy the null terminator */
-                                               vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
-                                       }
-                                       break;
-                                       case DT_INTEGER:
-                                       {
-                                               int val = vi.GetInteger();
-                                               ValueContainerInt* vci = (ValueContainerInt*)Values[Index].val;
-                                               vci->Set(&val, sizeof(int));
-                                       }
-                                       break;
-                                       case DT_BOOLEAN:
-                                       {
-                                               bool val = vi.GetBool();
-                                               ValueContainerBool* vcb = (ValueContainerBool*)Values[Index].val;
-                                               vcb->Set(&val, sizeof(bool));
-                                       }
-                                       break;
-                                       default:
-                                               /* You don't want to know what happens if someones bad code sends us here. */
-                                       break;
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       this->ValidateNoSpaces(vi.GetString(), Values[Index].tag, Values[Index].value);
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
                                }
-       
-                               /* We're done with this now */
-                               delete Values[Index].val;
+                               break;
+                               case DT_HOSTNAME:
+                               {
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       this->ValidateHostname(vi.GetString(), Values[Index].tag, Values[Index].value);
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
+                               }
+                               break;
+                               case DT_IPADDRESS:
+                               {
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       this->ValidateIP(vi.GetString(), Values[Index].tag, Values[Index].value, allow_wild);
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
+                               }
+                               break;
+                               case DT_CHANNEL:
+                               {
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       if (*(vi.GetString()) && !ServerInstance->IsChannel(vi.GetString()))
+                                               throw CoreException("The value of <"+std::string(Values[Index].tag)+":"+Values[Index].value+"> is not a valid channel name");
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
+                               }
+                               break;
+                               case DT_CHARPTR:
+                               {
+                                       ValueContainerChar* vcc = (ValueContainerChar*)Values[Index].val;
+                                       /* Make sure we also copy the null terminator */
+                                       vcc->Set(vi.GetString(), strlen(vi.GetString()) + 1);
+                               }
+                               break;
+                               case DT_INTEGER:
+                               {
+                                       int val = vi.GetInteger();
+                                       ValueContainerInt* vci = (ValueContainerInt*)Values[Index].val;
+                                       vci->Set(&val, sizeof(int));
+                               }
+                               break;
+                               case DT_BOOLEAN:
+                               {
+                                       bool val = vi.GetBool();
+                                       ValueContainerBool* vcb = (ValueContainerBool*)Values[Index].val;
+                                       vcb->Set(&val, sizeof(bool));
+                               }
+                               break;
+                               default:
+                                       /* You don't want to know what happens if someones bad code sends us here. */
+                               break;
                        }
+                       /* We're done with this now */
+                       delete Values[Index].val;
+               }
 
-                       /* Read the multiple-tag items (class tags, connect tags, etc)
-                        * and call the callbacks associated with them. We have three
-                        * callbacks for these, a 'start', 'item' and 'end' callback.
-                        */
-                       for (int Index = 0; MultiValues[Index].tag; Index++)
+               /* Read the multiple-tag items (class tags, connect tags, etc)
+                * and call the callbacks associated with them. We have three
+                * callbacks for these, a 'start', 'item' and 'end' callback.
+                */
+               for (int Index = 0; MultiValues[Index].tag; Index++)
+               {
+                       MultiValues[Index].init_function(this, MultiValues[Index].tag);
+
+                       int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
+
+                       for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
                        {
-                               MultiValues[Index].init_function(this, MultiValues[Index].tag);
-       
-                               int number_of_tags = ConfValueEnum(this->config_data, MultiValues[Index].tag);
-       
-                               for (int tagnum = 0; tagnum < number_of_tags; tagnum++)
+                               ValueList vl;
+                               for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
                                {
-                                       ValueList vl;
-                                       for (int valuenum = 0; MultiValues[Index].items[valuenum]; valuenum++)
-                                       {
-                                               int dt = MultiValues[Index].datatype[valuenum];
-                                               bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
-                                               bool allow_wild = ((dt & DT_ALLOW_WILD) > 0);
-                                               dt &= ~DT_ALLOW_NEWLINE;
-                                               dt &= ~DT_ALLOW_WILD;
+                                       int dt = MultiValues[Index].datatype[valuenum];
+                                       bool allow_newlines =  ((dt & DT_ALLOW_NEWLINE) > 0);
+                                       bool allow_wild = ((dt & DT_ALLOW_WILD) > 0);
+                                       dt &= ~DT_ALLOW_NEWLINE;
+                                       dt &= ~DT_ALLOW_WILD;
 
-                                               switch (dt)
+                                       switch (dt)
+                                       {
+                                               case DT_NOSPACES:
+                                               {
+                                                       char item[MAXBUF];
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
+                                                       this->ValidateNoSpaces(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
+                                               }
+                                               break;
+                                               case DT_HOSTNAME:
                                                {
-                                                       case DT_NOSPACES:
-                                                       {
-                                                               char item[MAXBUF];
-                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(""));
-                                                               this->ValidateNoSpaces(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
-                                                       }
-                                                       break;
-                                                       case DT_HOSTNAME:
-                                                       {
-                                                               char item[MAXBUF];
-                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(""));
-                                                               this->ValidateHostname(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
-                                                       }
-                                                       break;
-                                                       case DT_IPADDRESS:
-                                                       {
-                                                               char item[MAXBUF];
-                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(""));
-                                                               this->ValidateIP(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum], allow_wild);
-                                                       }
-                                                       break;
-                                                       case DT_CHANNEL:
-                                                       {
-                                                               char item[MAXBUF];
-                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(""));
-                                                               if (!ServerInstance->IsChannel(vl[vl.size()-1].GetString()))
-                                                                       throw CoreException("The value of <"+std::string(MultiValues[Index].tag)+":"+MultiValues[Index].items[valuenum]+"> number "+ConvToStr(tagnum + 1)+" is not a valid channel name");
-                                                       }
-                                                       break;
-                                                       case DT_CHARPTR:
-                                                       {
-                                                               char item[MAXBUF];
-                                                               if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(""));
-                                                       }
-                                                       break;
-                                                       case DT_INTEGER:
-                                                       {
-                                                               int item = 0;
-                                                               if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item))
-                                                                       vl.push_back(ValueItem(item));
-                                                               else
-                                                                       vl.push_back(ValueItem(0));
-                                                       }
-                                                       break;
-                                                       case DT_BOOLEAN:
-                                                       {
-                                                               bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum);
+                                                       char item[MAXBUF];
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
                                                                vl.push_back(ValueItem(item));
-                                                       }
-                                                       break;
-                                                       default:
-                                                               /* Someone was smoking craq if we got here, and we're all gonna die. */
-                                                       break;
+                                                       else
+                                                               vl.push_back(ValueItem(""));
+                                                       this->ValidateHostname(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum]);
                                                }
+                                               break;
+                                               case DT_IPADDRESS:
+                                               {
+                                                       char item[MAXBUF];
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
+                                                       this->ValidateIP(vl[vl.size()-1].GetString(), MultiValues[Index].tag, MultiValues[Index].items[valuenum], allow_wild);
+                                               }
+                                               break;
+                                               case DT_CHANNEL:
+                                               {
+                                                       char item[MAXBUF];
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
+                                                       if (!ServerInstance->IsChannel(vl[vl.size()-1].GetString()))
+                                                               throw CoreException("The value of <"+std::string(MultiValues[Index].tag)+":"+MultiValues[Index].items[valuenum]+"> number "+ConvToStr(tagnum + 1)+" is not a valid channel name");
+                                               }
+                                               break;
+                                               case DT_CHARPTR:
+                                               {
+                                                       char item[MAXBUF];
+                                                       if (ConfValue(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item, MAXBUF, allow_newlines))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(""));
+                                               }
+                                               break;
+                                               case DT_INTEGER:
+                                               {
+                                                       int item = 0;
+                                                       if (ConfValueInteger(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum, item))
+                                                               vl.push_back(ValueItem(item));
+                                                       else
+                                                               vl.push_back(ValueItem(0));
+                                               }
+                                               break;
+                                               case DT_BOOLEAN:
+                                               {
+                                                       bool item = ConfValueBool(this->config_data, MultiValues[Index].tag, MultiValues[Index].items[valuenum], MultiValues[Index].items_default[valuenum], tagnum);
+                                                       vl.push_back(ValueItem(item));
+                                               }
+                                               break;
+                                               default:
+                                                       /* Someone was smoking craq if we got here, and we're all gonna die. */
+                                               break;
                                        }
-
-                                       MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                                }
-
-                               MultiValues[Index].finish_function(this, MultiValues[Index].tag);
+                                       MultiValues[Index].validation_function(this, MultiValues[Index].tag, (char**)MultiValues[Index].items, vl, MultiValues[Index].datatype);
                        }
-       
+                               MultiValues[Index].finish_function(this, MultiValues[Index].tag);
                }
 
-               catch (CoreException &ce)
-               {
-                       ReportConfigError(ce.GetReason(), bail, user);
-                       return;
-               }
+       }
 
-               /** XXX END PASS **/
-               ServerInstance->Log(DEBUG,"End config pass %d", pass);
+       catch (CoreException &ce)
+       {
+               ReportConfigError(ce.GetReason(), bail, user);
+               return;
+       }
+
+       /** XXX END PASS **/
+       ServerInstance->Log(DEBUG,"End config pass %d", pass);
+
+       if (pass == 0)
+       {
+               /* FIRST PASS: Set up commands, load modules.
+                * We cannot gaurantee that all config is correct
+                * at this point
+                */
 
                if (pass == 0)
                {
-                       /* FIRST PASS: Set up commands, load modules.
-                        * We cannot gaurantee that all config is correct
-                        * at this point
-                        */
-       
-                       /** Note: This is safe, the method checks for user == NULL */
-                       ServerInstance->Parser->SetupCommandTable(user);
-                       ServerInstance->Modules->LoadAll();
-               }
-               else
-               {
-                       /* SECOND PASS: Call modules to read configs, finalize
-                        * stuff. Check that we have at least the required number
-                        * of whichever items. This is no longer done first.
-                        */
-                       ConfigReader* n = new ConfigReader(ServerInstance);
-                       FOREACH_MOD(I_OnReadConfig,OnReadConfig(this, n));
+                       ServerInstance->Log(DEBUG, "Downloading configuration");
 
-                       for (int Index = 0; Once[Index]; Index++)
-                               if (!CheckOnce(Once[Index]))
-                                       return;
+                       TotalDownloaded = 0;
+                       FileErrors = 0;
                }
 
+               if (!ServerInstance->Res)
+                       ServerInstance->Res = new DNS(ServerInstance);
+               /** Note: This is safe, the method checks for user == NULL */
+               ServerInstance->Parser->SetupCommandTable(user);
+               ServerInstance->Modules->LoadAll();
+       }
+       else
+       {
+               /* SECOND PASS: Call modules to read configs, finalize
+                * stuff. Check that we have at least the required number
+                * of whichever items. This is no longer done first.
+                */
+               ConfigReader* n = new ConfigReader(ServerInstance);
+               FOREACH_MOD(I_OnReadConfig,OnReadConfig(this, n));
+
+               for (int Index = 0; Once[Index]; Index++)
+                       if (!CheckOnce(Once[Index]))
+                               return;
        }
 
        // write once here, to try it out and make sure its ok
@@ -1203,7 +1214,7 @@ void ServerConfig::Read(bool bail, User* user)
                {
                        if (ServerInstance->Modules->Unload(removing->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH UNLOADED MODULE: %s",removing->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "REHASH UNLOADED MODULE: %s",removing->c_str());
                                if (user)
                                        user->WriteServ("973 %s %s :Module %s successfully unloaded.",user->nick, removing->c_str(), removing->c_str());
                                rem++;
@@ -1220,9 +1231,16 @@ void ServerConfig::Read(bool bail, User* user)
        {
                for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
                {
+                       /* Skip over modules that are aleready loaded for some reason */
+                       if (ServerInstance->Modules->Find(*adding))
+                               continue;
+
+                       if (bail)
+                               printf_c("[\033[1;32m*\033[0m] Loading module:\t\033[1;32m%s\033[0m\n", adding->c_str());
+
                        if (ServerInstance->Modules->Load(adding->c_str()))
                        {
-                               ServerInstance->WriteOpers("*** REHASH LOADED MODULE: %s",adding->c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "REHASH LOADED MODULE: %s",adding->c_str());
                                if (user)
                                        user->WriteServ("975 %s %s :Module %s successfully loaded.",user->nick, adding->c_str(), adding->c_str());
 
@@ -1232,25 +1250,89 @@ void ServerConfig::Read(bool bail, User* user)
                        {
                                if (user)
                                        user->WriteServ("974 %s %s :%s",user->nick, adding->c_str(), ServerInstance->Modules->LastError().c_str());
+
+                               if (bail)
+                               {
+                                       printf_c("\n[\033[1;31m*\033[0m] %s\n\n", ServerInstance->Modules->LastError().c_str());
+                                       ServerInstance->Exit(EXIT_STATUS_MODULE);
+                               }
                        }
                }
        }
 
-       ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules in pass 2.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
-
-       /** Note: This is safe, the method checks for user == NULL */
-       /*ServerInstance->Parser->SetupCommandTable(user);*/
+       ServerInstance->Log(DEFAULT,"Successfully unloaded %lu of %lu modules and loaded %lu of %lu modules.",(unsigned long)rem,(unsigned long)removed_modules.size(),(unsigned long)add,(unsigned long)added_modules.size());
 
        if (user)
                user->WriteServ("NOTICE %s :*** Successfully rehashed server.", user->nick);
        else
-               ServerInstance->WriteOpers("*** Successfully rehashed server.");
+               ServerInstance->SNO->WriteToSnoMask('A', "Successfully rehashed server.");
 }
 
-bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::ostringstream &errorstream, int pass)
+/* XXX: This can and will block! */
+void ServerConfig::DoDownloads()
+{
+       ServerInstance->Log(DEBUG,"In DoDownloads()");
+
+       /* Reads all local files into the IncludedFiles map, then initiates sockets for the remote ones */
+       for (std::map<std::string, std::istream*>::iterator x = IncludedFiles.begin(); x != IncludedFiles.end(); ++x)
+       {
+               if (CompletedFiles.find(x->first) != CompletedFiles.end())
+                       continue;
+
+               ServerInstance->Log(DEBUG,"StartDownloads File: %s", x->first.c_str());
+
+               std::string file = x->first;
+               if ((file[0] == '/') || (file.substr(0, 7) == "file://"))
+               {
+                       /* For file:// schema files, we use std::ifstream which is a derivative of std::istream.
+                        * For all other file schemas, we use a std::stringstream.
+                        */
+
+                       /* Add our own ifstream */
+                       std::ifstream* conf = new std::ifstream(file.c_str());
+                       if (!conf->fail())
+                       {
+                               ServerInstance->Log(DEBUG,"file:// schema file %s loaded OK", file.c_str());
+                               delete x->second;
+                               x->second = conf;
+                       }
+                       else
+                       {
+                               delete x->second;
+                               x->second = NULL;
+                               FileErrors++;
+                       }
+                       TotalDownloaded++;
+               }
+               else
+               {
+                       /* Modules handle these */
+                       ServerInstance->Log(DEBUG,"Module-handled schema for %s", x->first.c_str());
+
+                       /* For now, error it */
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT(I_OnDownloadFile, OnDownloadFile(file, x->second));
+                       if (MOD_RESULT == 0)
+                       {
+                               /* No module claimed this file */
+                               TotalDownloaded++;
+                               FileErrors++;
+                               delete x->second;
+                               x->second = NULL;
+                       }
+                       else
+                       {
+                               /* Search new file here for more includes to parse */
+                       }
+               }
+               CompletedFiles[x->first] = true;
+       }
+}
+
+bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::ostringstream &errorstream, int pass, std::istream *scan_for_includes_only)
 {
-       std::ifstream conf(filename);
        std::string line;
+       std::istream* conf = NULL;
        char ch;
        long linenumber;
        bool in_tag;
@@ -1263,41 +1345,63 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
        in_quote = false;
        in_comment = false;
 
-       /* Check if the file open failed first */
-       if (!conf && (pass == 1))
+       if (scan_for_includes_only)
        {
-               int MOD_RESULT = 0;
-               std::stringstream filedata;
-               /** XXX: THIS SHOULD BE NONBLOCKING WITH A CALLBACK, RETURN A VALUE LIKE
-                * LOADCONF_TRYAGAIN, LOADCONF_DONE_WITH_ERROR, LOADCONF_DONE_COMPLETE
-                */
-               FOREACH_RESULT(I_OnDownloadFile, OnDownloadFile(filename, filedata));
-               if (MOD_RESULT == 0)
+               ServerInstance->Log(DEBUG,"scan_for_includes_only set");
+               conf = scan_for_includes_only;
+       }
+
+       if (std::string(filename) == CONFIG_FILE)
+       {
+               if (!scan_for_includes_only)
                {
-                       errorstream << "LoadConf: Couldn't open config file: " << filename << std::endl;
-                       return false;
+                       conf = new std::ifstream(filename);
+                       if (conf->fail())
+                       {
+                               errorstream << "File " << filename << " could not be opened." << std::endl;
+                               return false;
+                       }
                }
        }
-       else if (!conf && (pass == 0))
-               return true;
-
-       /* Fix the chmod of the file to restrict it to the current user and group */
-       chmod(filename,0600);
-
-       for (unsigned int t = 0; t < include_stack.size(); t++)
+       else
        {
-               if (std::string(filename) == include_stack[t])
+               std::map<std::string, std::istream*>::iterator x = IncludedFiles.find(filename);
+               if (x == IncludedFiles.end())
                {
-                       errorstream << "File " << filename << " is included recursively (looped inclusion)." << std::endl;
-                       return false;
+                       if (pass == 0)
+                       {
+                               ServerInstance->Log(DEBUG,"Push include file %s onto map", filename);
+                               /* First pass, we insert the file into a map, and just return true */
+                               IncludedFiles.insert(std::make_pair(filename,new std::stringstream));
+                               return true;
+                       }
+                       else
+                       {
+                               /* Second pass, look for the file in the map */
+                               ServerInstance->Log(DEBUG,"We are in the second pass, and %s is not in the map!", filename);
+                               errorstream << "File " << filename << " could not be opened." << std::endl;
+                               return false;
+                       }
+               }
+               else
+               {
+                       if (!scan_for_includes_only)
+                       {
+                               if (x->second)
+                                       conf = IncludedFiles.find(filename)->second;
+                               else
+                               {
+                                       errorstream << "File " << filename << " could not be opened." << std::endl;
+                                       return false;
+                               }
+                       }
                }
        }
 
-       /* It's not already included, add it to the list of files we've loaded */
-       include_stack.push_back(filename);
+       ServerInstance->Log(DEBUG,"Start to read conf %s %08lx", filename, conf);
 
        /* Start reading characters... */
-       while (conf.get(ch))
+       while (conf->get(ch))
        {
 
                /*
@@ -1311,6 +1415,8 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                if ((character_count++ < 2) && (ch == '\xFF' || ch == '\xFE'))
                {
                        errorstream << "File " << filename << " cannot be read, as it is encoded in braindead UTF-16. Save your file as plain ASCII!" << std::endl;
+                       if (!scan_for_includes_only)
+                               delete conf;
                        return false;
                }
 
@@ -1356,7 +1462,7 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                {
                        line += ch;
                        char real_character;
-                       if (conf.get(real_character))
+                       if (conf->get(real_character))
                        {
                                if (real_character == 'n')
                                        real_character = '\n';
@@ -1366,6 +1472,8 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        else
                        {
                                errorstream << "End of file after a \\, what did you want to escape?: " << filename << ":" << linenumber << std::endl;
+                               if (!scan_for_includes_only)
+                                       delete conf;
                                return false;
                        }
                }
@@ -1380,6 +1488,8 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                if (!in_quote)
                                {
                                        errorstream << "Got another opening < when the first one wasn't closed: " << filename << ":" << linenumber << std::endl;
+                                       if (!scan_for_includes_only)
+                                               delete conf;
                                        return false;
                                }
                        }
@@ -1388,6 +1498,8 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                if (in_quote)
                                {
                                        errorstream << "We're in a quote but outside a tag, interesting. " << filename << ":" << linenumber << std::endl;
+                                       if (!scan_for_includes_only)
+                                               delete conf;
                                        return false;
                                }
                                else
@@ -1438,14 +1550,20 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                                         * LoadConf() and load the included config into the same ConfigDataHash
                                         */
 
-                                       if (!this->ParseLine(target, line, linenumber, errorstream, pass))
+                                       if (!this->ParseLine(target, line, linenumber, errorstream, pass, scan_for_includes_only))
+                                       {
+                                               if (!scan_for_includes_only)
+                                                       delete conf;
                                                return false;
+                                       }
 
                                        line.clear();
                                }
                                else
                                {
                                        errorstream << "Got a closing > when we weren't inside a tag: " << filename << ":" << linenumber << std::endl;
+                                       if (!scan_for_includes_only)
+                                               delete conf;
                                        return false;
                                }
                        }
@@ -1459,15 +1577,17 @@ bool ServerConfig::LoadConf(ConfigDataHash &target, const char* filename, std::o
                        is a newline missing from the end of the file: " << filename << ":" << linenumber << std::endl;
        }
 
+       if (!scan_for_includes_only)
+               delete conf;
        return true;
 }
 
-bool ServerConfig::LoadConf(ConfigDataHash &target, const std::string &filename, std::ostringstream &errorstream, int pass)
+bool ServerConfig::LoadConf(ConfigDataHash &target, const std::string &filename, std::ostringstream &errorstream, int pass, std::istream* scan_for_includs_only)
 {
-       return this->LoadConf(target, filename.c_str(), errorstream, pass);
+       return this->LoadConf(target, filename.c_str(), errorstream, pass, scan_for_includs_only);
 }
 
-bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &linenumber, std::ostringstream &errorstream, int pass)
+bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &linenumber, std::ostringstream &errorstream, int pass, std::istream* scan_for_includes_only)
 {
        std::string tagname;
        std::string current_key;
@@ -1557,7 +1677,8 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
                                        else
                                        {
                                                /* Leaving quotes, we have the value */
-                                               results.push_back(KeyVal(current_key, current_value));
+                                               if (!scan_for_includes_only)
+                                                       results.push_back(KeyVal(current_key, current_value));
 
                                                // std::cout << "<" << tagname << ":" << current_key << "> " << current_value << std::endl;
 
@@ -1565,8 +1686,8 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
                                                got_key = false;
 
                                                if ((tagname == "include") && (current_key == "file"))
-                                               {
-                                                       if (!this->DoInclude(target, current_value, errorstream, pass))
+                                               {       
+                                                       if (!this->DoInclude(target, current_value, errorstream, pass, scan_for_includes_only))
                                                                return false;
                                                }
 
@@ -1586,12 +1707,13 @@ bool ServerConfig::ParseLine(ConfigDataHash &target, std::string &line, long &li
        }
 
        /* Finished parsing the tag, add it to the config hash */
-       target.insert(std::pair<std::string, KeyValList > (tagname, results));
+       if (!scan_for_includes_only)
+               target.insert(std::pair<std::string, KeyValList > (tagname, results));
 
        return true;
 }
 
-bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, std::ostringstream &errorstream, int pass)
+bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, std::ostringstream &errorstream, int pass, std::istream* scan_for_includes_only)
 {
        std::string confpath;
        std::string newfile;
@@ -1603,7 +1725,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
        std::replace(newfile.begin(),newfile.end(),'\\','/');
        std::replace(confpath.begin(),confpath.end(),'\\','/');
 
-       if (newfile[0] != '/')
+       if ((newfile[0] != '/') && (newfile.find("://") == std::string::npos))
        {
                if((pos = confpath.rfind("/")) != std::string::npos)
                {
@@ -1617,7 +1739,7 @@ bool ServerConfig::DoInclude(ConfigDataHash &target, const std::string &file, st
                }
        }
 
-       return LoadConf(target, newfile, errorstream, pass);
+       return LoadConf(target, newfile, errorstream, pass, scan_for_includes_only);
 }
 
 bool ServerConfig::ConfValue(ConfigDataHash &target, const char* tag, const char* var, int index, char* result, int length, bool allow_linefeeds)
@@ -1985,11 +2107,7 @@ InspIRCd* ServerConfig::GetInstance()
 
 std::string ServerConfig::GetSID()
 {
-       std::string OurSID;
-       OurSID += (char)((sid / 100) + 48);
-       OurSID += (char)((sid / 10) % 10 + 48);
-       OurSID += (char)(sid % 10 + 48);
-       return OurSID;
+       return sid;
 }
 
 ValueItem::ValueItem(int value)
@@ -2006,12 +2124,7 @@ ValueItem::ValueItem(bool value)
        v = n.str();
 }
 
-ValueItem::ValueItem(char* value)
-{
-       v = value;
-}
-
-void ValueItem::Set(char* value)
+ValueItem::ValueItem(const char* value)
 {
        v = value;
 }
@@ -2180,7 +2293,7 @@ bool DoELine(ServerConfig* conf, const char* tag, char** entries, ValueList &val
 // this should probably be moved to configreader, but atm it relies on CheckELines above.
 bool DoneELine(ServerConfig* conf, const char* tag)
 {
-       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->local_users.begin(); u2 != conf->GetInstance()->local_users.end(); u2++)
+       for (std::vector<User*>::const_iterator u2 = conf->GetInstance()->Users->local_users.begin(); u2 != conf->GetInstance()->Users->local_users.end(); u2++)
        {
                User* u = (User*)(*u2);
                u->exempt = false;
@@ -2189,4 +2302,3 @@ bool DoneELine(ServerConfig* conf, const char* tag)
        conf->GetInstance()->XLines->CheckELines();
        return true;
 }
-