]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/configreader.cpp
Extract RFC modes from the core to core_channel and core_user.
[user/henk/code/inspircd.git] / src / configreader.cpp
index d198a1d84c83cfb78e0a4807382d1df2c23a8204..ff9d5bd141dafa02a3d9cf0085b0fc00104fda21 100644 (file)
@@ -62,17 +62,9 @@ ServerConfig::ServerConfig()
        : EmptyTag(CreateEmptyTag())
        , Limits(EmptyTag)
        , Paths(EmptyTag)
+       , RawLog(false)
        , NoSnoticeStack(false)
 {
-       RawLog = HideBans = HideSplits = false;
-       WildcardIPv6 = true;
-       MaxTargets = 20;
-       NetBufferSize = 10240;
-       MaxConn = SOMAXCONN;
-       MaxChans = 20;
-       OperMaxChans = 30;
-       c_ipv4_range = 32;
-       c_ipv6_range = 128;
 }
 
 ServerConfig::~ServerConfig()
@@ -100,22 +92,27 @@ static void ValidHost(const std::string& p, const std::string& msg)
                throw CoreException("The value of "+msg+" is not a valid hostname");
 }
 
-bool ServerConfig::ApplyDisabledCommands(const std::string& data)
+bool ServerConfig::ApplyDisabledCommands()
 {
-       std::stringstream dcmds(data);
-       std::string thiscmd;
-
-       /* Enable everything first */
+       // Enable everything first.
        const CommandParser::CommandMap& commands = ServerInstance->Parser.GetCommands();
        for (CommandParser::CommandMap::const_iterator x = commands.begin(); x != commands.end(); ++x)
                x->second->Disable(false);
 
-       /* Now disable all the ones which the user wants disabled */
-       while (dcmds >> thiscmd)
+       // Now disable the commands specified in the config.
+       std::string command;
+       irc::spacesepstream commandlist(ConfValue("disabled")->getString("commands"));
+       while (commandlist.GetToken(command))
        {
-               Command* handler = ServerInstance->Parser.GetHandler(thiscmd);
-               if (handler)
-                       handler->Disable(true);
+               Command* handler = ServerInstance->Parser.GetHandler(command);
+               if (!handler)
+               {
+                       ServerInstance->Logs->Log("CONFIG", LOG_DEBUG, "Unable to disable the %s command as it does not exist!", command.c_str());
+                       continue;
+               }
+
+               ServerInstance->Logs->Log("CONFIG", LOG_DEBUG, "The %s command has been disabled", command.c_str());
+               handler->Disable(true);
        }
        return true;
 }
@@ -161,9 +158,8 @@ void ServerConfig::CrossCheckOperClassType()
                if (OperTypes.find(name) != OperTypes.end())
                        throw CoreException("Duplicate type block with name " + name + " at " + tag->getTagLocation());
 
-               OperInfo* ifo = new OperInfo;
+               OperInfo* ifo = new OperInfo(name);
                OperTypes[name] = ifo;
-               ifo->name = name;
                ifo->type_block = tag;
 
                std::string classname;
@@ -193,8 +189,7 @@ void ServerConfig::CrossCheckOperClassType()
                if (oper_blocks.find(name) != oper_blocks.end())
                        throw CoreException("Duplicate oper block with name " + name + " at " + tag->getTagLocation());
 
-               OperInfo* ifo = new OperInfo;
-               ifo->name = type;
+               OperInfo* ifo = new OperInfo(type);
                ifo->oper_block = tag;
                ifo->type_block = tblk->second->type_block;
                ifo->class_blocks.assign(tblk->second->class_blocks.begin(), tblk->second->class_blocks.end());
@@ -224,7 +219,7 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                }
        }
 
-       int blk_count = config_data.count("connect");
+       size_t blk_count = config_data.count("connect");
        if (blk_count == 0)
        {
                // No connect blocks found; make a trivial default block
@@ -236,14 +231,14 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
        }
 
        Classes.resize(blk_count);
-       std::map<std::string, int> names;
+       std::map<std::string, size_t> names;
 
        bool try_again = true;
-       for(int tries=0; try_again; tries++)
+       for(size_t tries = 0; try_again; tries++)
        {
                try_again = false;
                ConfigTagList tags = ConfTags("connect");
-               int i=0;
+               size_t i = 0;
                for(ConfigIter it = tags.first; it != tags.second; ++it, ++i)
                {
                        ConfigTag* tag = it->second;
@@ -254,7 +249,7 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                        std::string parentName = tag->getString("parent");
                        if (!parentName.empty())
                        {
-                               std::map<std::string,int>::iterator parentIter = names.find(parentName);
+                               std::map<std::string, size_t>::const_iterator parentIter = names.find(parentName);
                                if (parentIter == names.end())
                                {
                                        try_again = true;
@@ -316,7 +311,7 @@ void ServerConfig::CrossCheckConnectBlocks(ServerConfig* current)
                        if (tag->readString("sendq", sendq))
                        {
                                // attempt to guess a good hard/soft sendq from a single value
-                               long value = atol(sendq.c_str());
+                               unsigned long value = strtoul(sendq.c_str(), NULL, 10);
                                if (value > 16384)
                                        me->softsendqmax = value / 16;
                                else
@@ -431,7 +426,6 @@ void ServerConfig::Fill()
        ServerDesc = server->getString("description", "Configure Me");
        Network = server->getString("network", "Network");
        NetBufferSize = ConfValue("performance")->getInt("netbuffersize", 10240, 1024, 65534);
-       DisabledCommands = ConfValue("disabled")->getString("commands", "");
        DisabledDontExist = ConfValue("disabled")->getBool("fakenonexistant");
        UserStats = security->getString("userstats");
        CustomVersion = security->getString("customversion");
@@ -450,15 +444,12 @@ void ServerConfig::Fill()
        PID = ConfValue("pid")->getString("file");
        MaxChans = ConfValue("channels")->getInt("users", 20);
        OperMaxChans = ConfValue("channels")->getInt("opers");
-       c_ipv4_range = ConfValue("cidr")->getInt("ipv4clone", 32);
-       c_ipv6_range = ConfValue("cidr")->getInt("ipv6clone", 128);
+       c_ipv4_range = ConfValue("cidr")->getInt("ipv4clone", 32, 1, 32);
+       c_ipv6_range = ConfValue("cidr")->getInt("ipv6clone", 128, 1, 128);
        Limits = ServerLimits(ConfValue("limits"));
        Paths = ServerPaths(ConfValue("path"));
        NoSnoticeStack = options->getBool("nosnoticestack", false);
 
-       if (Network.find(' ') != std::string::npos)
-               throw CoreException(Network + " is not a valid network name. A network name must not contain spaces.");
-
        std::string defbind = options->getString("defaultbind");
        if (stdalgo::string::equalsci(defbind, "ipv4"))
        {
@@ -557,7 +548,7 @@ void ServerConfig::Apply(ServerConfig* old, const std::string &useruid)
        /* The stuff in here may throw CoreException, be sure we're in a position to catch it. */
        try
        {
-               for (int index = 0; index * sizeof(DeprecatedConfig) < sizeof(ChangedConfig); index++)
+               for (unsigned long index = 0; index * sizeof(DeprecatedConfig) < sizeof(ChangedConfig); index++)
                {
                        std::string value;
                        ConfigTagList tags = ConfTags(ChangedConfig[index].tag);
@@ -730,6 +721,10 @@ void ServerConfig::ApplyModules(User* user)
 
        for (std::vector<std::string>::iterator adding = added_modules.begin(); adding != added_modules.end(); adding++)
        {
+               // Skip modules which are already loaded.
+               if (ServerInstance->Modules->Find(*adding))
+                       continue;
+
                if (ServerInstance->Modules->Load(*adding))
                {
                        ServerInstance->SNO->WriteGlobalSno('a', "*** REHASH LOADED MODULE: %s",adding->c_str());
@@ -814,15 +809,23 @@ void ConfigReaderThread::Finish()
                ServerInstance->Users.RehashCloneCounts();
                ServerInstance->XLines->CheckELines();
                ServerInstance->XLines->ApplyLines();
-               ChanModeReference ban(NULL, "ban");
-               static_cast<ListModeBase*>(*ban)->DoRehash();
-               Config->ApplyDisabledCommands(Config->DisabledCommands);
+               Config->ApplyDisabledCommands();
                User* user = ServerInstance->FindNick(TheUserUID);
 
                ConfigStatus status(user);
                const ModuleManager::ModuleMap& mods = ServerInstance->Modules->GetModules();
                for (ModuleManager::ModuleMap::const_iterator i = mods.begin(); i != mods.end(); ++i)
-                       i->second->ReadConfig(status);
+               {
+                       try
+                       {
+                               ServerInstance->Logs->Log("MODULE", LOG_DEBUG, "Rehashing " + i->first);
+                               i->second->ReadConfig(status);
+                       }
+                       catch (CoreException& modex)
+                       {
+                               ServerInstance->Logs->Log("MODULE", LOG_DEFAULT, "Exception caught: " + modex.GetReason());
+                       }
+               }
 
                // The description of this server may have changed - update it for WHOIS etc.
                ServerInstance->FakeClient->server->description = Config->ServerDesc;