Finally gave up fixing all this.

[user/henk/code/inspircd.git] / src / connection.cpp

diff --git a/src/connection.cpp b/src/connection.cpp
index 7393d7d77f2208149a8cc20eefb3409bdb0e67e4..9ee559725611f7b6fe30c5ad7066f64c6b21d329 100644 (file)
--- a/src/connection.cpp
+++ b/src/connection.cpp
@@ -4,8 +4,6 @@
 #include <sys/errno.h>
 #include <sys/ioctl.h>
 #include <sys/utsname.h>
-#include <errno.h>
-#include <vector>
 #include "inspircd.h"
 #include "modules.h"
 
@@ -14,9 +12,6 @@ extern std::vector<ircd_module*> factory;
 
 extern int MODCOUNT;
 
-#define STATE_CLEAR 1
-#define STATE_WAIT_FOR_ACK 2
-
 packet::packet()
 {
        srand(time(NULL));
@@ -31,8 +26,6 @@ connection::connection()
 {
        key = GenKey();
        fd = 0;
-       state = STATE_CLEAR;
-       buffer.clear();
 }
 
 
@@ -77,16 +70,15 @@ bool connection::CreateListener(char* host, int p)
 
        this->port = p;
 
-       setsockopt(fd,SOL_SOCKET,SO_REUSEADDR,(const char*)&on,sizeof(on));
-       linger.l_onoff = 1;
-       linger.l_linger = 0;
-       setsockopt(fd,SOL_SOCKET,SO_LINGER,(const char*)&linger,sizeof(linger));
+    setsockopt(fd,SOL_SOCKET,SO_REUSEADDR,(const char*)&on,sizeof(on));
+    linger.l_onoff = 1;
+    linger.l_linger = 0;
+    setsockopt(fd,SOL_SOCKET,SO_LINGER,(const char*)&linger,sizeof(linger));
 
-       buffer.clear();
-       
        return true;
 }
 
+
 bool connection::BeginLink(char* targethost, int port, char* password)
 {
        char connect[MAXBUF];
@@ -133,13 +125,10 @@ bool connection::SendPacket(char *message, char* host, int port, long ourkey)
        // returns false if the packet could not be sent (e.g. target host down)
        if (sendto(this->fd,&p,sizeof(p),0,(sockaddr*)&host_address,sizeof(host_address))<0)
        {
-               log(DEBUG,"sendto() failed for Connection::SendPacket() with a packet of size %d: %s",sizeof(p),strerror(errno));
+               log(DEBUG,"sendto() failed for Connection::SendPacket() with a packet of size %d",sizeof(p));
                return false;
        }
-
-       this->state = STATE_CLEAR;
        return true;
-       break;
 
 }
 
@@ -192,6 +181,7 @@ bool connection::SendACK(char* host, int port, int reply_id)
        {
                return false;
        }
+       return true;
 
 }
 
@@ -238,13 +228,12 @@ bool connection::RecvPacket(char *message, char* host, int &prt, long &theirkey)
        host_address.sin_family=AF_INET;
        host_address_size=sizeof(host_address);
 
-       //int recvfrom(int s, void *buf, size_t len, int flags, struct sockaddr *from, socklen_t *fromlen);
        if (recvfrom(fd,&p,sizeof(p),0,(sockaddr*)&host_address,&host_address_size)<0)
        {
                return false;
        }
 
-       log(DEBUG,"connection::RecvPacket(): received packet type %d '%s' from '%s'",p.type,p.data,inet_ntoa(host_address.sin_addr));
+       log(DEBUG,"connection::RecvPacket(): received packet type %d '%s'",p.type,p.data);
 
        if (p.type == PT_SYN_ONLY)
        {
@@ -260,7 +249,6 @@ bool connection::RecvPacket(char *message, char* host, int &prt, long &theirkey)
                strcpy(message,p.data);
                strcpy(host,inet_ntoa(host_address.sin_addr));
                prt = ntohs(host_address.sin_port);
-               this->state = STATE_CLEAR;
                return false;
        }
 
@@ -269,8 +257,8 @@ bool connection::RecvPacket(char *message, char* host, int &prt, long &theirkey)
                strcpy(message,p.data);
                strcpy(host,inet_ntoa(host_address.sin_addr));
                theirkey = p.key;
-               prt = ntohs(host_address.sin_port); // the port we received it on
-               SendACK(host,prt,p.id);
+               prt = ntohs(host_address.sin_port);
+               SendACK(host,this->port,p.id);
                return true;
        }